@abaplint/transpiler-cli 2.13.89 → 2.13.91

package/build/bundle.js

@@ -324,6 +324,7 @@ const abaplint = __importStar(__webpack_require__(/*! @abaplint/core */ "./node_
 const config_1 = __webpack_require__(/*! ./config */ "./build/config.js");
 const file_operations_1 = __webpack_require__(/*! ./file_operations */ "./build/file_operations.js");
 const git_clone_1 = __webpack_require__(/*! ./git_clone */ "./build/git_clone.js");
+const lib_folder_1 = __webpack_require__(/*! ./lib_folder */ "./build/lib_folder.js");
 class Progress {
     bar;
     set(total, _text) {
@@ -339,13 +340,17 @@ async function loadLib(config) {
     for (const lib of config.libs || []) {
         let dir = "";
         let cleanupFolder = false;
-        if (lib.folder !== undefined && lib.folder !== "" && fs.existsSync(process.cwd() + lib.folder)) {
-            console.log("From folder: " + lib.folder);
-            dir = process.cwd() + lib.folder;
+        const folder = (0, lib_folder_1.resolveLibFolder)(lib.folder, process.cwd());
+        if (folder !== undefined && fs.existsSync(folder)) {
+            console.log("From folder: " + folder);
+            dir = folder;
         }
         else {
             if (lib.url === undefined || lib.url === "") {
-                throw new Error("Library must define a non-empty url or an existing folder");
+                if (folder === undefined) {
+                    throw new Error("Library must define a non-empty url or an existing folder");
+                }
+                throw new Error("Library folder not found: " + folder);
             }
             console.log("Clone: " + lib.url);
             dir = fs.mkdtempSync(path.join(os.tmpdir(), "abap_transpile-"));
@@ -489,6 +494,65 @@ run().then(() => {
 
 /***/ },
 
+/***/ "./build/lib_folder.js"
+/*!*****************************!*\
+  !*** ./build/lib_folder.js ***!
+  \*****************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.resolveLibFolder = resolveLibFolder;
+const path = __importStar(__webpack_require__(/*! path */ "path"));
+// A lib "folder" is relative to the current working directory. It used to be
+// concatenated onto cwd, so it only worked when it started with a separator;
+// "deps" silently became "/path/to/cwddeps" and the lib was cloned instead.
+// join() keeps the leading separator working, so existing configuration is
+// unaffected, and accepts "deps" and "./deps" as well.
+function resolveLibFolder(folder, cwd) {
+    if (folder === undefined || folder === "") {
+        return undefined;
+    }
+    return path.join(cwd, folder);
+}
+//# sourceMappingURL=lib_folder.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/abap/1_lexer/lexer.js"
 /*!*********************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/abap/1_lexer/lexer.js ***!
@@ -6972,7 +7036,8 @@ const Expressions = __importStar(__webpack_require__(/*! . */ "./node_modules/@a
 const tokens_1 = __webpack_require__(/*! ../../1_lexer/tokens */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/index.js");
 class MethodDefReturning extends combi_1.Expression {
     getRunnable() {
-        const value = (0, combi_1.seq)("VALUE", (0, combi_1.tok)(tokens_1.ParenLeft), Expressions.MethodParamName, (0, combi_1.tok)(tokens_1.ParenRightW));
+        // see MethodParam: the lexer gives "!VALUE" as one Identifier
+        const value = (0, combi_1.seq)((0, combi_1.altPrio)("VALUE", "!VALUE"), (0, combi_1.tok)(tokens_1.ParenLeft), Expressions.MethodParamName, (0, combi_1.tok)(tokens_1.ParenRightW));
         return (0, combi_1.seq)("RETURNING", value, Expressions.TypeParam);
     }
 }
@@ -7050,8 +7115,11 @@ const Expressions = __importStar(__webpack_require__(/*! . */ "./node_modules/@a
 const tokens_1 = __webpack_require__(/*! ../../1_lexer/tokens */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/index.js");
 class MethodParam extends combi_1.Expression {
     getRunnable() {
-        const ref = (0, combi_1.seq)("REFERENCE", (0, combi_1.tok)(tokens_1.ParenLeft), Expressions.MethodParamName, (0, combi_1.tok)(tokens_1.ParenRightW));
-        const value = (0, combi_1.seq)("VALUE", (0, combi_1.tok)(tokens_1.ParenLeft), Expressions.MethodParamName, (0, combi_1.tok)(tokens_1.ParenRightW));
+        // The escape is part of the token: the lexer gives "!VALUE" as a single
+        // Identifier, so a literal "VALUE" cannot match it and the whole METHODS
+        // statement falls back to Unknown.
+        const ref = (0, combi_1.seq)((0, combi_1.altPrio)("REFERENCE", "!REFERENCE"), (0, combi_1.tok)(tokens_1.ParenLeft), Expressions.MethodParamName, (0, combi_1.tok)(tokens_1.ParenRightW));
+        const value = (0, combi_1.seq)((0, combi_1.altPrio)("VALUE", "!VALUE"), (0, combi_1.tok)(tokens_1.ParenLeft), Expressions.MethodParamName, (0, combi_1.tok)(tokens_1.ParenRightW));
         const fieldsOrValue = (0, combi_1.seq)((0, combi_1.altPrio)(value, ref, Expressions.MethodParamName), Expressions.TypeParam);
         return fieldsOrValue;
     }
@@ -12035,6 +12103,10 @@ class StatementParser {
         let add = [];
         let pre = [];
         let colon = undefined;
+        // inside EXEC SQL and an AMDP body a colon reads a host variable, ":lv_a",
+        // and is not the chaining marker; recognized here because nativeSQL() runs
+        // afterwards and can only re-wrap what this has already cut
+        let native = false;
         for (const token of wa.tokens) {
             if (token instanceof Tokens.Comment) {
                 wa.statements.push(new nodes_1.StatementNode(new _statement_1.Comment()).setChildren(this.tokensToNodes([token])));
@@ -12044,6 +12116,7 @@ class StatementParser {
             const str = token.getStr();
             if (str.length === 1) {
                 if (str === ".") {
+                    native = this.nativeAfter(native, add, colon);
                     wa.addUnknown(pre, add, colon);
                     add = [];
                     pre = [];
@@ -12053,13 +12126,13 @@ class StatementParser {
                     wa.addUnknown(pre, add, colon);
                     add = [];
                 }
-                else if (str === ":" && colon === undefined) {
+                else if (str === ":" && colon === undefined && native === false) {
                     colon = token;
                     add.pop(); // do not add colon token to statement
                     pre.push(...add);
                     add = [];
                 }
-                else if (str === ":") {
+                else if (str === ":" && native === false) {
                     add.pop(); // do not add colon token to statement
                 }
             }
@@ -12068,6 +12141,36 @@ class StatementParser {
             wa.addUnknown(pre, add, colon);
         }
     }
+    /** whether the statement that just ended opens or closes a region where a
+     * colon belongs to the statement rather than chaining it */
+    nativeAfter(native, tokens, colon) {
+        // a pragma sits between the closing keyword and the period, so it is left
+        // out before the last word is read: "ENDEXEC ##NEEDED." closes the region
+        const words = tokens.filter(t => !(t instanceof Tokens.Pragma)).map(t => t.getStr().toUpperCase());
+        // a native body usually arrives as one blob terminated by its own closing
+        // keyword, so the terminator is the word before the period
+        if (words[words.length - 2] === "ENDEXEC" || words[words.length - 2] === "ENDMETHOD") {
+            return false;
+        }
+        if (colon !== undefined) {
+            // a fragment of a chain cannot OPEN a region: it is only part of a
+            // statement, and taking "DATA: lv_a TYPE i, exec sql." for one would
+            // turn chaining off for the rest of the file
+            return native;
+        }
+        if (words[0] === "EXEC" && words[1] === "SQL") {
+            return true;
+        }
+        // "BY DATABASE" as well as LANGUAGE, and not LANGUAGE alone: a method
+        // may be NAMED language
+        if (words[0] === "METHOD"
+            && words.includes("BY")
+            && words.includes("DATABASE")
+            && words.includes("LANGUAGE")) {
+            return true;
+        }
+        return native;
+    }
 }
 exports.StatementParser = StatementParser;
 //# sourceMappingURL=statement_parser.js.map
@@ -54444,7 +54547,9 @@ class MethodParameters {
     }
     isPassByValue(param) {
         var _a;
-        return param.getFirstToken().getStr().toUpperCase() === "VALUE"
+        // "!" is the identifier escape, generated code has eg. "IMPORTING !VALUE(iv_foo)"
+        const first = param.getFirstToken().getStr().toUpperCase();
+        return (first === "VALUE" || first === "!VALUE")
             && ((_a = param.getChildren()[1]) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr()) === "(";
     }
 }
@@ -71132,7 +71237,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.55";
+        return "2.120.58";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -85527,7 +85632,10 @@ __exportStar(__webpack_require__(/*! ./prefer_inline */ "./node_modules/@abaplin
 __exportStar(__webpack_require__(/*! ./prefer_insert_into_table */ "./node_modules/@abaplint/core/build/src/rules/prefer_insert_into_table.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_is_not */ "./node_modules/@abaplint/core/build/src/rules/prefer_is_not.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_pragmas */ "./node_modules/@abaplint/core/build/src/rules/prefer_pragmas.js"), exports);
+__exportStar(__webpack_require__(/*! ./prefer_abap_bool */ "./node_modules/@abaplint/core/build/src/rules/prefer_abap_bool.js"), exports);
+__exportStar(__webpack_require__(/*! ./prefer_abap_bool_values */ "./node_modules/@abaplint/core/build/src/rules/prefer_abap_bool_values.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_raise_exception_new */ "./node_modules/@abaplint/core/build/src/rules/prefer_raise_exception_new.js"), exports);
+__exportStar(__webpack_require__(/*! ./prefer_string_template */ "./node_modules/@abaplint/core/build/src/rules/prefer_string_template.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_returning_to_exporting */ "./node_modules/@abaplint/core/build/src/rules/prefer_returning_to_exporting.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_xsdbool */ "./node_modules/@abaplint/core/build/src/rules/prefer_xsdbool.js"), exports);
 __exportStar(__webpack_require__(/*! ./preferred_compare_operator */ "./node_modules/@abaplint/core/build/src/rules/preferred_compare_operator.js"), exports);
@@ -92820,6 +92928,382 @@ exports.PragmaStyle = PragmaStyle;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/prefer_abap_bool.js"
+/*!*************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/prefer_abap_bool.js ***!
+  \*************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.PreferAbapBool = exports.PreferAbapBoolConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js"));
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+const FORBIDDEN_TYPES = new Set(["XFELD", "SAP_BOOL", "BOOLE_D", "FLAG"]);
+class PreferAbapBoolConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferAbapBoolConf = PreferAbapBoolConf;
+class PreferAbapBool extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferAbapBoolConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_abap_bool",
+            title: "Prefer abap_bool",
+            shortDescription: `Use abap_bool instead of XFELD, SAP_BOOL, BOOLE_D, FLAG for boolean variables`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-abap_bool-for-booleans`,
+            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+            badExample: `DATA foo TYPE xfeld.`,
+            goodExample: `DATA foo TYPE abap_bool.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const structure = file.getStructure();
+        if (structure === undefined) {
+            return [];
+        }
+        const statements = [
+            ...structure.findAllStatements(Statements.Data),
+            ...structure.findAllStatements(Statements.ClassData),
+            ...structure.findAllStatements(Statements.Constant),
+            ...structure.findAllStatements(Statements.Type),
+            ...structure.findAllStatements(Statements.FieldSymbol),
+        ];
+        for (const stat of statements) {
+            const typeNameExpr = stat.findFirstExpression(Expressions.TypeName);
+            if (typeNameExpr === undefined) {
+                continue;
+            }
+            const typeName = typeNameExpr.concatTokens().toUpperCase();
+            if (FORBIDDEN_TYPES.has(typeName) === false) {
+                continue;
+            }
+            const token = typeNameExpr.getFirstToken();
+            const fix = edit_helper_1.EditHelper.replaceToken(file, token, "abap_bool");
+            issues.push(issue_1.Issue.atToken(file, token, `Use abap_bool instead of ${typeName}`, this.getMetadata().key, this.conf.severity, fix));
+        }
+        return issues;
+    }
+}
+exports.PreferAbapBool = PreferAbapBool;
+//# sourceMappingURL=prefer_abap_bool.js.map
+
+/***/ },
+
+/***/ "./node_modules/@abaplint/core/build/src/rules/prefer_abap_bool_values.js"
+/*!********************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/prefer_abap_bool_values.js ***!
+  \********************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.PreferAbapBoolValues = exports.PreferAbapBoolValuesConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js"));
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+const nodes_1 = __webpack_require__(/*! ../abap/nodes */ "./node_modules/@abaplint/core/build/src/abap/nodes/index.js");
+const ABAP_BOOL = "ABAP_BOOL";
+const ABAP_TRUE = "abap_true";
+const ABAP_FALSE = "abap_false";
+const VALID_VALUES = new Set(["ABAP_TRUE", "ABAP_FALSE", "ABAP_UNDEFINED"]);
+class PreferAbapBoolValuesConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferAbapBoolValuesConf = PreferAbapBoolValuesConf;
+class PreferAbapBoolValues extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferAbapBoolValuesConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_abap_bool_values",
+            title: "Prefer abap_true and abap_false",
+            shortDescription: `Use abap_true and abap_false instead of 'X' and ' ' for abap_bool variables`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-abap_true-abap_false-and-abap_undefined-for-abap_bool-variables`,
+            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+            badExample: `DATA lv_flag TYPE abap_bool.\nlv_flag = 'X'.`,
+            goodExample: `DATA lv_flag TYPE abap_bool.\nlv_flag = abap_true.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const structure = file.getStructure();
+        if (structure === undefined) {
+            return [];
+        }
+        const boolVars = this.collectBoolVars(file);
+        // Check Move statements: target = source
+        for (const stat of structure.findAllStatements(Statements.Move)) {
+            const target = stat.findFirstExpression(Expressions.Target);
+            const source = stat.findFirstExpression(Expressions.Source);
+            if (target === undefined || source === undefined) {
+                continue;
+            }
+            const targetName = target.concatTokens().toUpperCase();
+            if (!boolVars.has(targetName)) {
+                continue;
+            }
+            this.checkSourceNode(source, file, issues);
+        }
+        // Check comparisons: IF/ELSEIF conditions
+        const compareStatements = [
+            ...structure.findAllStatements(Statements.If),
+            ...structure.findAllStatements(Statements.ElseIf),
+        ];
+        for (const stat of compareStatements) {
+            const cond = stat.findFirstExpression(Expressions.Cond);
+            if (cond === undefined) {
+                continue;
+            }
+            for (const compare of cond.findAllExpressions(Expressions.Compare)) {
+                this.checkCompareBoolLiteral(compare, boolVars, file, issues);
+            }
+        }
+        return issues;
+    }
+    collectBoolVars(file) {
+        var _a;
+        const boolVars = new Set();
+        const structure = file.getStructure();
+        if (structure === undefined) {
+            return boolVars;
+        }
+        const statements = [
+            ...structure.findAllStatements(Statements.Data),
+            ...structure.findAllStatements(Statements.ClassData),
+            ...structure.findAllStatements(Statements.FieldSymbol),
+        ];
+        for (const stat of statements) {
+            const typeNameExpr = stat.findFirstExpression(Expressions.TypeName);
+            if (typeNameExpr === undefined) {
+                continue;
+            }
+            if (typeNameExpr.concatTokens().toUpperCase() !== ABAP_BOOL) {
+                continue;
+            }
+            const nameExpr = (_a = stat.findFirstExpression(Expressions.DefinitionName)) !== null && _a !== void 0 ? _a : stat.findFirstExpression(Expressions.FieldSymbol);
+            if (nameExpr === undefined) {
+                continue;
+            }
+            boolVars.add(nameExpr.concatTokens().toUpperCase());
+        }
+        return boolVars;
+    }
+    checkSourceNode(source, file, issues) {
+        const firstToken = source.getFirstToken().getStr().toUpperCase();
+        if (firstToken === "COND") {
+            const condBody = source.findDirectExpression(Expressions.CondBody);
+            if (condBody) {
+                this.checkCondBodyBranches(condBody, file, issues);
+            }
+            return;
+        }
+        if (firstToken === "SWITCH") {
+            const switchBody = source.findDirectExpression(Expressions.SwitchBody);
+            if (switchBody) {
+                this.checkSwitchBodyBranches(switchBody, file, issues);
+            }
+            return;
+        }
+        // Plain literal assignment
+        const issue = this.checkLiteralSource(source, file);
+        if (issue) {
+            issues.push(issue);
+        }
+    }
+    checkLiteralSource(source, file) {
+        const constantStr = source.findFirstExpression(Expressions.ConstantString);
+        if (constantStr === undefined) {
+            return undefined;
+        }
+        const token = constantStr.getFirstToken();
+        const val = token.getStr();
+        if (val === "'X'") {
+            const fix = edit_helper_1.EditHelper.replaceToken(file, token, ABAP_TRUE);
+            return issue_1.Issue.atToken(file, token, `Use ${ABAP_TRUE} instead of 'X'`, this.getMetadata().key, this.conf.severity, fix);
+        }
+        if (val === "' '") {
+            const fix = edit_helper_1.EditHelper.replaceToken(file, token, ABAP_FALSE);
+            return issue_1.Issue.atToken(file, token, `Use ${ABAP_FALSE} instead of ' '`, this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
+    checkCondBodyBranches(condBody, file, issues) {
+        // CondBody: WHEN <cond> THEN <source> [WHEN <cond> THEN <source>]* [ELSE <source>]
+        // Walk children; Source nodes after THEN/ELSE are the result values
+        let afterThenOrElse = false;
+        for (const child of condBody.getChildren()) {
+            const tokenStr = child.getFirstToken().getStr().toUpperCase();
+            if (tokenStr === "THEN" || tokenStr === "ELSE") {
+                afterThenOrElse = true;
+                continue;
+            }
+            if (tokenStr === "WHEN") {
+                afterThenOrElse = false;
+                continue;
+            }
+            if (afterThenOrElse && child instanceof nodes_1.ExpressionNode && child.get() instanceof Expressions.Source) {
+                const issue = this.checkLiteralSource(child, file);
+                if (issue) {
+                    issues.push(issue);
+                }
+                afterThenOrElse = false;
+            }
+        }
+    }
+    checkSwitchBodyBranches(switchBody, file, issues) {
+        // SwitchBody: <source> WHEN <val> [OR <val>]* THEN <source> [ELSE <source>]
+        // First Source is the operand; Source after THEN/ELSE are result values
+        let firstSourceSeen = false;
+        let afterThenOrElse = false;
+        for (const child of switchBody.getChildren()) {
+            const tokenStr = child.getFirstToken().getStr().toUpperCase();
+            if (tokenStr === "THEN" || tokenStr === "ELSE") {
+                afterThenOrElse = true;
+                continue;
+            }
+            if (tokenStr === "WHEN" || tokenStr === "OR") {
+                afterThenOrElse = false;
+                continue;
+            }
+            if (child instanceof nodes_1.ExpressionNode && child.get() instanceof Expressions.Source) {
+                if (!firstSourceSeen) {
+                    firstSourceSeen = true;
+                    continue;
+                }
+                if (afterThenOrElse) {
+                    const issue = this.checkLiteralSource(child, file);
+                    if (issue) {
+                        issues.push(issue);
+                    }
+                    afterThenOrElse = false;
+                }
+            }
+        }
+    }
+    checkCompareBoolLiteral(compare, boolVars, file, issues) {
+        // Compare: Source CompareOperator Source  (or other forms)
+        const sources = compare.findDirectExpressions(Expressions.Source);
+        if (sources.length < 2) {
+            return;
+        }
+        const [left, right] = sources;
+        const leftStr = left.concatTokens().toUpperCase();
+        const rightStr = right.concatTokens().toUpperCase();
+        let literalSource;
+        if (boolVars.has(leftStr) && !VALID_VALUES.has(rightStr)) {
+            literalSource = right;
+        }
+        else if (boolVars.has(rightStr) && !VALID_VALUES.has(leftStr)) {
+            literalSource = left;
+        }
+        if (literalSource) {
+            const issue = this.checkLiteralSource(literalSource, file);
+            if (issue) {
+                issues.push(issue);
+            }
+        }
+    }
+}
+exports.PreferAbapBoolValues = PreferAbapBoolValues;
+//# sourceMappingURL=prefer_abap_bool_values.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/prefer_corresponding.js"
 /*!*****************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/prefer_corresponding.js ***!
@@ -93809,6 +94293,151 @@ exports.PreferReturningToExporting = PreferReturningToExporting;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/prefer_string_template.js"
+/*!*******************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/prefer_string_template.js ***!
+  \*******************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.PreferStringTemplate = exports.PreferStringTemplateConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const nodes_1 = __webpack_require__(/*! ../abap/nodes */ "./node_modules/@abaplint/core/build/src/abap/nodes/index.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+class PreferStringTemplateConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferStringTemplateConf = PreferStringTemplateConf;
+class PreferStringTemplate extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferStringTemplateConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_string_template",
+            title: "Prefer string template over &&",
+            shortDescription: `Use string templates instead of && to assemble text`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use--to-assemble-text`,
+            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+            badExample: `DATA(msg) = \`Hello \` && name && \`!\`.`,
+            goodExample: `DATA(msg) = |Hello { name }!|.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const structure = file.getStructure();
+        if (structure === undefined) {
+            return [];
+        }
+        const allSources = structure.findAllExpressions(Expressions.Source);
+        // collect all Source nodes that appear as the RHS (children[2]) of a && expression
+        const rhsChildren = new Set();
+        for (const source of allSources) {
+            const children = source.getChildren();
+            if (children.length === 3 && children[1].getFirstToken().getStr() === "&&") {
+                rhsChildren.add(children[2]);
+            }
+        }
+        for (const source of allSources) {
+            const children = source.getChildren();
+            if (children.length !== 3) {
+                continue;
+            }
+            if (children[1].getFirstToken().getStr() !== "&&") {
+                continue;
+            }
+            // only process top-level && roots (not nested RHS children)
+            if (rhsChildren.has(source)) {
+                continue;
+            }
+            const operands = this.flattenChain(source);
+            if (!operands.some(op => { const c = op.getFirstToken().getStr()[0]; return c === "'" || c === "`"; })) {
+                continue;
+            }
+            const template = this.buildTemplate(operands);
+            const start = source.getFirstToken().getStart();
+            const end = source.getLastToken().getEnd();
+            const fix = edit_helper_1.EditHelper.replaceRange(file, start, end, template);
+            const token = children[1].getFirstToken();
+            issues.push(issue_1.Issue.atToken(file, token, "Use string template instead of &&", this.getMetadata().key, this.conf.severity, fix));
+        }
+        return issues;
+    }
+    flattenChain(node) {
+        const children = node.getChildren();
+        if (children.length === 3 && children[1].getFirstToken().getStr() === "&&") {
+            return [...this.flattenChain(children[0]), ...this.flattenChain(children[2])];
+        }
+        if (children.length === 1 && children[0] instanceof nodes_1.ExpressionNode) {
+            return this.flattenChain(children[0]);
+        }
+        return [node];
+    }
+    buildTemplate(operands) {
+        let inner = "";
+        for (const op of operands) {
+            const raw = op.getFirstToken().getStr();
+            const firstChar = raw[0];
+            if (firstChar === "'" || firstChar === "`") {
+                inner += raw.slice(1, -1);
+            }
+            else {
+                inner += `{ ${op.concatTokens()} }`;
+            }
+        }
+        return `|${inner}|`;
+    }
+}
+exports.PreferStringTemplate = PreferStringTemplate;
+//# sourceMappingURL=prefer_string_template.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/prefer_xsdbool.js"
 /*!***********************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/prefer_xsdbool.js ***!
@@ -103441,7 +104070,14 @@ class DatabaseSetup {
         return {
             schemas: {
                 sqlite: this.driver(new sqlite_database_schema_1.SQLiteDatabaseSchema(this.reg)),
-                hdb: ["todo"],
+                // HANA takes the PG schema unchanged -- measured against HANA Express
+                // on a tree of 77 tables. The one thing it needs is that identifiers
+                // reach it quoted in UPPER case, and that is not a dialect of DDL: the
+                // same rule applies to every statement, so @abaplint/database-hdb
+                // folds them on the way out rather than a second generator doing it
+                // here. (Unquoted would nearly work and then meet a column called
+                // `cross`, which is one of HANA's reserved words.)
+                hdb: this.driver(new pg_database_schema_1.PGDatabaseSchema(this.reg)),
                 pg: this.driver(new pg_database_schema_1.PGDatabaseSchema(this.reg)),
                 snowflake: this.driver(new snowflake_database_schema_1.SnowflakeDatabaseSchema(this.reg)),
             },
@@ -103596,7 +104232,7 @@ class PopulateTables {
         if (raw === undefined) {
             return "";
         }
-        return `INSERT INTO reposrc ('PROGNAME', 'DATA') VALUES ('${name.padEnd(40, " ")}', '${this.escape(raw)}');`;
+        return `INSERT INTO reposrc (progname, data) VALUES ('${name.padEnd(40, " ")}', '${this.escape(raw)}');`;
     }
     insertT100(msag) {
         // ignore if T100 is unknown
@@ -113775,6 +114411,27 @@ exports.ContinueTranspiler = ContinueTranspiler;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/transpiler/build/src/statements/controls.js"
+/*!****************************************************************************!*\
+  !*** ./node_modules/@abaplint/transpiler/build/src/statements/controls.js ***!
+  \****************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.ControlsTranspiler = void 0;
+const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
+class ControlsTranspiler {
+    transpile(_node, _traversal) {
+        return new chunk_1.Chunk(`throw new Error("Controls, not supported, transpiler");`);
+    }
+}
+exports.ControlsTranspiler = ControlsTranspiler;
+//# sourceMappingURL=controls.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/transpiler/build/src/statements/convert.js"
 /*!***************************************************************************!*\
   !*** ./node_modules/@abaplint/transpiler/build/src/statements/convert.js ***!
@@ -116440,6 +117097,7 @@ __exportStar(__webpack_require__(/*! ./concatenate */ "./node_modules/@abaplint/
 __exportStar(__webpack_require__(/*! ./end_of_selection */ "./node_modules/@abaplint/transpiler/build/src/statements/end_of_selection.js"), exports);
 __exportStar(__webpack_require__(/*! ./condense */ "./node_modules/@abaplint/transpiler/build/src/statements/condense.js"), exports);
 __exportStar(__webpack_require__(/*! ./constant */ "./node_modules/@abaplint/transpiler/build/src/statements/constant.js"), exports);
+__exportStar(__webpack_require__(/*! ./controls */ "./node_modules/@abaplint/transpiler/build/src/statements/controls.js"), exports);
 __exportStar(__webpack_require__(/*! ./continue */ "./node_modules/@abaplint/transpiler/build/src/statements/continue.js"), exports);
 __exportStar(__webpack_require__(/*! ./convert */ "./node_modules/@abaplint/transpiler/build/src/statements/convert.js"), exports);
 __exportStar(__webpack_require__(/*! ./create_data */ "./node_modules/@abaplint/transpiler/build/src/statements/create_data.js"), exports);

package/build/types.d.ts

@@ -10,9 +10,11 @@ export interface ITranspilerConfig {
      * @uniqueItems true
      */
     exclude_filter?: string[];
+    /** @minLength 1 */
     output_folder: string;
     libs?: {
         url?: string;
+        /** relative to the current working directory */
         folder?: string;
         files?: string | string[];
         /** list of regex, case insensitive

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.13.89",
+  "version": "2.13.91",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,17 +27,17 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.55",
-    "@abaplint/transpiler": "^2.13.89",
+    "@abaplint/core": "^2.120.58",
+    "@abaplint/transpiler": "^2.13.91",
     "@types/glob": "^9.0.0",
-    "@types/node": "^26.4.1",
+    "@types/node": "^26.6.2",
     "@types/progress": "^2.0.7",
     "glob": "^13.0.6",
     "p-limit": "^7.3.2",
     "progress": "^2.0.3",
     "ts-json-schema-generator": "^2.9.0",
     "typescript": "^6.0.3",
-    "webpack": "^5.110.3",
+    "webpack": "^5.111.1",
     "webpack-cli": "^7.2.3"
   }
 }

package/schema.json

@@ -61,6 +61,7 @@
                 ]
               },
               "folder": {
+                "description": "relative to the current working directory",
                 "type": "string"
               },
               "url": {
@@ -75,6 +76,7 @@
           "$ref": "#/definitions/ITranspilerOptions"
         },
         "output_folder": {
+          "minLength": 1,
           "type": "string"
         },
         "write_source_map": {