@abaplint/transpiler-cli 2.13.87 → 2.13.89

package/build/bundle.js

@@ -177,15 +177,32 @@ class FileOperations {
         }
         return (0, p_limit_1.default)(concurrency);
     }
+    // abapGit stores the content of a Web Repository or MIME object beside its
+    // XML, in a file whose name says .w3mi.data. or .smim.data. That content is
+    // bytes, and reading it as UTF-8 destroys it: every byte above 0x7F fails to
+    // decode and comes back as the replacement character, so a PNG arrives
+    // starting ef bf bd rather than 89 50 4e 47 and is served, with a plausible
+    // size and the right content type, as a broken image.
+    //
+    // latin1 rather than a Buffer because the whole pipeline carries a file as a
+    // string; latin1 maps every byte to the code point of the same value, so a
+    // read and a write of it are exact. Node's "binary" is the same encoding
+    // under its old name, so there is nothing more faithful to switch to: the
+    // only stronger answer is to carry a Buffer end to end and never make it a
+    // string at all, which is a change to every file the transpiler touches.
+    // Measured on an 11770 byte PNG: latin1 and binary both return it
+    // unchanged, utf8 returns 20175 bytes and no longer a PNG.
+    static isBinaryFilename(filename) {
+        return /\.(w3mi|smim)\.data\./i.test(filename);
+    }
     static async readAllFiles(filesToRead, outputFolder) {
         const limit = this.setupPLimit();
         const promises = filesToRead.map((filename) => {
             return limit(async () => {
-                //        const isBinary = filename.includes(".w3mi.data.");
                 return {
                     filename: path.basename(filename),
                     relative: path.relative(outputFolder, path.dirname(filename)),
-                    contents: await fsPromises.readFile(filename, "utf8"),
+                    contents: await fsPromises.readFile(filename, this.isBinaryFilename(filename) ? "latin1" : "utf8"),
                 };
             });
         });
@@ -221,7 +238,9 @@ class FileOperations {
         const limit = this.setupPLimit();
         const promises = files.map((file) => {
             return limit(async () => {
-                await fsPromises.writeFile(file.path, file.contents);
+                // read as latin1, written as latin1: anything else re-encodes the
+                // bytes on the way out and undoes the careful read
+                await fsPromises.writeFile(file.path, file.contents, this.isBinaryFilename(file.path) ? { encoding: "latin1" } : undefined);
             });
         });
         await Promise.all(promises);
@@ -380,7 +399,7 @@ async function writeObjects(outputFiles, config, outputFolder, files) {
             && (type === "PROG" || type === "FUGR" || type === "CLAS")) {
             const name = output.filename + ".map";
             // SourceMappingUrl needs to be percent-encoded, ref https://github.com/microsoft/TypeScript/issues/40951
-            contents = contents + `\n//# sourceMappingURL=` + name.replace(/#/g, "%23");
+            contents = contents + `\n//# sourceMappingURL=` + name.replace(/%/g, "%25").replace(/#/g, "%23");
             // map the bare abap filename each mapping carries to its path on disk;
             // source map "sources" are URLs, so always forward slashes, also on Windows
             const sourcePaths = {};
@@ -12856,7 +12875,7 @@ class CallTransaction {
     getMatcher() {
         const options = (0, combi_1.seq)("OPTIONS FROM", expressions_1.Source);
         const messages = (0, combi_1.seq)("MESSAGES INTO", expressions_1.Target);
-        const auth = (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK");
+        const auth = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK"), { also: combi_1.AlsoIn.OpenABAP });
         const perm = (0, combi_1.per)((0, combi_1.seq)("UPDATE", expressions_1.Source), "AND SKIP FIRST SCREEN", options, messages, (0, combi_1.seq)("MODE", expressions_1.Source));
         const ret = (0, combi_1.seq)("CALL TRANSACTION", expressions_1.Source, (0, combi_1.optPrio)(auth), (0, combi_1.optPrio)((0, combi_1.seq)("USING", expressions_1.Source)), (0, combi_1.opt)(perm));
         return (0, combi_1.verNotLang)(version_1.LanguageVersion.Cloud, ret);
@@ -25134,12 +25153,15 @@ class ABAPFileInformationParser {
                 continue;
             }
             const parameters = this.parseMethodParameters(def);
+            const concatenated = def.concatTokens().toUpperCase();
             methods.push({
                 name: methodName.getStr(),
                 identifier: new _identifier_1.Identifier(methodName, this.filename),
                 isRedefinition: def.findDirectExpression(Expressions.Redefinition) !== undefined,
-                isForTesting: def.concatTokens().toUpperCase().includes(" FOR TESTING"),
-                isFinal: def.concatTokens().toUpperCase().includes(" FINAL"),
+                isForTesting: concatenated.includes(" FOR TESTING"),
+                isFinal: concatenated.includes(" FINAL"),
+                isDefaultIgnore: concatenated.includes(" DEFAULT IGNORE"),
+                isDefaultFail: concatenated.includes(" DEFAULT FAIL"),
                 isAbstract: def.findDirectExpression(Expressions.Abstract) !== undefined,
                 isEventHandler: def.findDirectExpression(Expressions.EventHandler) !== undefined,
                 visibility,
@@ -35305,11 +35327,15 @@ class Source {
         }
         let hexExpected = false;
         let hexNext = false;
+        // an arithmetic operator has been seen, so the operands that follow
+        // determine a calculation type rather than simply replacing the context
+        let arithmetic = false;
         while (children.length >= 0) {
             if (first instanceof nodes_1.ExpressionNode) {
                 const get = first.get();
                 if (get instanceof Expressions.MethodCallChain) {
-                    context = method_call_chain_1.MethodCallChain.runSyntax(first, input, targetType);
+                    const found = method_call_chain_1.MethodCallChain.runSyntax(first, input, targetType);
+                    context = arithmetic === true ? this.infer(context, found, true) : found;
                     if (context === undefined) {
                         const message = "Method has no RETURNING value";
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
@@ -35317,18 +35343,19 @@ class Source {
                     }
                 }
                 else if (get instanceof Expressions.FieldChain) {
-                    context = field_chain_1.FieldChain.runSyntax(first, input, type, allowGenericDeference);
+                    const found = field_chain_1.FieldChain.runSyntax(first, input, type, allowGenericDeference);
+                    context = arithmetic === true ? this.infer(context, found, true) : found;
                 }
                 else if (get instanceof Expressions.StringTemplate) {
                     context = string_template_1.StringTemplate.runSyntax(first, input);
                 }
                 else if (get instanceof Expressions.Source) {
                     const found = Source.runSyntax(first, input);
-                    context = this.infer(context, found);
+                    context = this.infer(context, found, arithmetic);
                 }
                 else if (get instanceof Expressions.Constant) {
                     const found = constant_1.Constant.runSyntax(first);
-                    context = this.infer(context, found);
+                    context = this.infer(context, found, arithmetic);
                 }
                 else if (get instanceof Expressions.Dereference) {
                     context = dereference_1.Dereference.runSyntax(first, context, input);
@@ -35337,6 +35364,7 @@ class Source {
                     context = component_chain_1.ComponentChain.runSyntax(context, first, input);
                 }
                 else if (get instanceof Expressions.ArithOperator) {
+                    arithmetic = true;
                     if (first.concatTokens() === "**") {
                         context = new basic_1.FloatType();
                     }
@@ -35383,7 +35411,13 @@ class Source {
             Source.runSyntax(last, input);
         }
     }
-    static infer(context, found) {
+    static infer(context, found, arithmetic = false) {
+        if (arithmetic === true) {
+            const calculation = this.calculationType(context, found);
+            if (calculation !== undefined) {
+                return calculation;
+            }
+        }
         if (context instanceof basic_1.FloatType && found instanceof basic_1.IntegerType) {
             return context;
         }
@@ -35397,6 +35431,56 @@ class Source {
             return found;
         }
     }
+    /** The calculation type of an arithmetic expression is the most general of the
+     * operand types. An operand of type c, n, d, t or string is converted into it and
+     * never becomes the result: "lv_f * '0.25'" is a float, not a character field of
+     * length four. Returns undefined when neither operand is numeric, leaving the
+     * decision to the caller. */
+    static calculationType(left, right) {
+        if (left === undefined || right === undefined) {
+            return undefined;
+        }
+        else if (left instanceof basic_1.VoidType || left instanceof unknown_type_1.UnknownType) {
+            // not knowing an operand means not knowing the result
+            return left;
+        }
+        else if (right instanceof basic_1.VoidType || right instanceof unknown_type_1.UnknownType) {
+            return right;
+        }
+        const leftRank = this.numericRank(left);
+        const rightRank = this.numericRank(right);
+        if (leftRank === undefined && rightRank === undefined) {
+            return undefined;
+        }
+        else if (rightRank === undefined) {
+            return left;
+        }
+        else if (leftRank === undefined) {
+            return right;
+        }
+        return leftRank >= rightRank ? left : right;
+    }
+    static numericRank(type) {
+        if (type instanceof basic_1.DecFloat34Type) {
+            return 6;
+        }
+        else if (type instanceof basic_1.DecFloat16Type) {
+            return 5;
+        }
+        else if (type instanceof basic_1.FloatType) {
+            return 4;
+        }
+        else if (type instanceof basic_1.PackedType) {
+            return 3;
+        }
+        else if (type instanceof basic_1.Integer8Type) {
+            return 2;
+        }
+        else if (type instanceof basic_1.IntegerType) {
+            return 1;
+        }
+        return undefined;
+    }
     static addIfInferred(node, input, inferredType) {
         const basic = new basic_types_1.BasicTypes(input);
         const typeExpression = node.findDirectExpression(Expressions.TypeNameOrInfer);
@@ -71048,7 +71132,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.52";
+        return "2.120.55";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -71987,7 +72071,7 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
 * CREATE OBJECT statements
 * RAISE EVENT statements
 
-https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#align-parameters
 
 Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
 
@@ -76821,7 +76905,7 @@ class ConstantClasses {
             key: "constant_classes",
             title: "Validate constant classes",
             shortDescription: `Checks that a class contains exactly the constants corresponding to a domain's fixed values.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enumeration-classes-to-constants-interfaces`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enum-to-constants-interfaces`,
             tags: [_irule_1.RuleTag.Styleguide],
         };
     }
@@ -78508,7 +78592,11 @@ Make sure to test the downported code, it might not always be completely correct
           return found;
         }
         */
-        let found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
+        let found = this.stripCallTransactionAuthorityCheck(high, lowFile);
+        if (found) {
+            return found;
+        }
+        found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
         if (found) {
             return found;
         }
@@ -81002,6 +81090,31 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return false;
     }
+    /** WITH/WITHOUT AUTHORITY-CHECK on CALL TRANSACTION requires v740sp02, so the statement is
+     * Unknown in the low version, note that only WITHOUT is handled here */
+    stripCallTransactionAuthorityCheck(high, lowFile) {
+        if (!(high.get() instanceof Statements.CallTransaction)) {
+            return undefined;
+        }
+        else if (this.lowReg.getConfig().isOpenABAP()) {
+            // open-abap supports the addition
+            return undefined;
+        }
+        const tokens = high.getTokens();
+        // the lexer splits "AUTHORITY-CHECK" into three tokens: AUTHORITY, -, CHECK
+        for (let i = 1; i < tokens.length - 3; i++) {
+            if (tokens[i].getStr().toUpperCase() === "WITHOUT"
+                && tokens[i + 1].getStr().toUpperCase() === "AUTHORITY"
+                && tokens[i + 2].getStr() === "-"
+                && tokens[i + 3].getStr().toUpperCase() === "CHECK") {
+                // also remove the preceding space so no double space is left behind
+                const fix = edit_helper_1.EditHelper.deleteRange(lowFile, tokens[i - 1].getEnd(), tokens[i + 3].getEnd());
+                const message = "Remove WITHOUT AUTHORITY-CHECK from CALL TRANSACTION";
+                return issue_1.Issue.atToken(lowFile, tokens[i], message, this.getMetadata().key, this.conf.severity, fix);
+            }
+        }
+        return undefined;
+    }
     replaceXsdBool(node, lowFile, highSyntax) {
         if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
@@ -84655,6 +84768,11 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
                 return [idef];
             }
             for (const m of this.findInterfaceMethods(idef)) {
+                if (m.method.isDefaultIgnore === true || m.method.isDefaultFail === true) {
+                    // the interface says an implementation is optional, so asking for one
+                    // reports an error where ABAP reports none
+                    continue;
+                }
                 if (this.isAbstract(m, interfaceInfo, def)) {
                     if (def.isAbstract) {
                         continue;
@@ -85406,6 +85524,7 @@ __exportStar(__webpack_require__(/*! ./parser_missing_space */ "./node_modules/@
 __exportStar(__webpack_require__(/*! ./pragma_style */ "./node_modules/@abaplint/core/build/src/rules/pragma_style.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_corresponding */ "./node_modules/@abaplint/core/build/src/rules/prefer_corresponding.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_inline */ "./node_modules/@abaplint/core/build/src/rules/prefer_inline.js"), exports);
+__exportStar(__webpack_require__(/*! ./prefer_insert_into_table */ "./node_modules/@abaplint/core/build/src/rules/prefer_insert_into_table.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_is_not */ "./node_modules/@abaplint/core/build/src/rules/prefer_is_not.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_pragmas */ "./node_modules/@abaplint/core/build/src/rules/prefer_pragmas.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_raise_exception_new */ "./node_modules/@abaplint/core/build/src/rules/prefer_raise_exception_new.js"), exports);
@@ -86221,7 +86340,7 @@ class KeywordCase extends _abap_rule_1.ABAPRule {
             key: "keyword_case",
             title: "Keyword case",
             shortDescription: `Checks that keywords have the same case. Non-keywords must be lower case.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-your-pretty-printer-team-settings`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-your-teams-abap-formatter-settings`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `write 'hello world'.`,
             goodExample: `WRITE 'hello world'.`,
@@ -93085,6 +93204,126 @@ exports.PreferInline = PreferInline;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/prefer_insert_into_table.js"
+/*!*********************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/prefer_insert_into_table.js ***!
+  \*********************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.PreferInsertIntoTable = exports.PreferInsertIntoTableConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js"));
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+class PreferInsertIntoTableConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferInsertIntoTableConf = PreferInsertIntoTableConf;
+class PreferInsertIntoTable extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferInsertIntoTableConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_insert_into_table",
+            title: "Prefer INSERT INTO TABLE over APPEND",
+            shortDescription: `Prefer INSERT INTO TABLE over APPEND`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `INSERT INTO TABLE respects the table type, while APPEND always tries to add to the end. This will dump if the sort order of a sorted table would change.\n\nhttps://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-insert-into-table-to-append-to`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
+            badExample: `APPEND row TO itab.`,
+            goodExample: `INSERT row INTO TABLE itab.`,
+        };
+    }
+    getConfig() { return this.conf; }
+    setConfig(conf) { this.conf = conf; }
+    runParsed(file) {
+        const issues = [];
+        for (const stat of file.getStatements()) {
+            if (!(stat.get() instanceof Statements.Append)) {
+                continue;
+            }
+            if (stat.concatTokens().toUpperCase().includes(" SORTED BY ")) {
+                continue;
+            }
+            const fix = this.buildFix(file, stat);
+            const message = "Prefer INSERT INTO TABLE over APPEND";
+            issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity, fix));
+        }
+        return issues;
+    }
+    buildFix(file, stat) {
+        const tokens = stat.getTokens();
+        // Find the APPEND token (first token)
+        const appendToken = tokens[0];
+        if (appendToken.getStr().toUpperCase() !== "APPEND") {
+            return undefined;
+        }
+        // Find the last "TO" token that precedes the table target.
+        // In all fixable forms the table target follows the last standalone "TO":
+        //   APPEND row TO itab
+        //   APPEND LINES OF itab2 TO itab
+        //   APPEND LINES OF itab2 FROM 1 TO 3 TO itab   <- last TO is the table
+        //   APPEND INITIAL LINE TO itab
+        let lastToIndex = -1;
+        for (let i = tokens.length - 1; i >= 0; i--) {
+            if (tokens[i].getStr().toUpperCase() === "TO") {
+                lastToIndex = i;
+                break;
+            }
+        }
+        if (lastToIndex < 0) {
+            return undefined;
+        }
+        const toToken = tokens[lastToIndex];
+        const fix1 = edit_helper_1.EditHelper.replaceToken(file, appendToken, "INSERT");
+        const fix2 = edit_helper_1.EditHelper.replaceToken(file, toToken, "INTO TABLE");
+        return edit_helper_1.EditHelper.merge(fix1, fix2);
+    }
+}
+exports.PreferInsertIntoTable = PreferInsertIntoTable;
+//# sourceMappingURL=prefer_insert_into_table.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/prefer_is_not.js"
 /*!**********************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/prefer_is_not.js ***!
@@ -95722,6 +95961,8 @@ class SequentialBlank extends _abap_rule_1.ABAPRule {
             key: "sequential_blank",
             title: "Sequential blank lines",
             shortDescription: `Checks that code does not contain more than the configured number of blank lines in a row.`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#add-a-single-blank-line-to-separate-things-but-not-more`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };
     }
@@ -103285,12 +103526,48 @@ exports.DatabaseSetup = DatabaseSetup;
 /*!***************************************************************************!*\
   !*** ./node_modules/@abaplint/transpiler/build/src/db/populate_tables.js ***!
   \***************************************************************************/
-(__unused_webpack_module, exports) {
+(__unused_webpack_module, exports, __webpack_require__) {
 
 "use strict";
 
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.PopulateTables = void 0;
+/* eslint-disable max-len */
+const abaplint = __importStar(__webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js"));
+const w3mi_name_1 = __webpack_require__(/*! ../w3mi_name */ "./node_modules/@abaplint/transpiler/build/src/w3mi_name.js");
 class PopulateTables {
     hasREPOSRC;
     hasSEOSUBCO;
@@ -103426,7 +103703,9 @@ class PopulateTables {
             return "";
         }
         const type = obj.getType().toUpperCase();
-        const name = obj.getName().toUpperCase();
+        const name = obj instanceof abaplint.Objects.WebMIME
+            ? (0, w3mi_name_1.w3miObjectName)(obj)
+            : obj.getName().toUpperCase();
         return `INSERT INTO "tadir" ("pgmid", "object", "obj_name", "devclass", "korrnum", "srcsystem", "delflag", "genflag", "edtflag", "masterlang")
       VALUES ('R3TR', '${type}', '${this.escape(name)}', '$TMP', '', 'ABC', '', '', '', 'E');`;
     }
@@ -103435,7 +103714,7 @@ class PopulateTables {
             return [];
         }
         const ret = [];
-        const name = obj.getName().toUpperCase();
+        const name = (0, w3mi_name_1.w3miObjectName)(obj);
         for (const [key, value] of Object.entries(obj.getParameters())) {
             ret.push(`INSERT INTO "wwwparams" ("relid", "objid", "name", "value") VALUES ('MI', '${name}', '${this.escape(key)}', '${this.escape(value)}');`);
         }
@@ -109920,6 +110199,7 @@ const traversal_1 = __webpack_require__(/*! ../traversal */ "./node_modules/@aba
 const requires_1 = __webpack_require__(/*! ../requires */ "./node_modules/@abaplint/transpiler/build/src/requires.js");
 const rearranger_1 = __webpack_require__(/*! ../rearranger */ "./node_modules/@abaplint/transpiler/build/src/rearranger.js");
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
+const initialization_1 = __webpack_require__(/*! ../initialization */ "./node_modules/@abaplint/transpiler/build/src/initialization.js");
 class HandleABAP {
     options;
     constructor(options) {
@@ -110024,10 +110304,10 @@ class HandleABAP {
                 continue;
             }
             if (name) {
-                contents.appendString("const {" + traversal_1.Traversal.escapeNamespace(name) + "} = await import(\"./" + filename.replace(/#/g, "%23") + "\");\n");
+                contents.appendString("const {" + traversal_1.Traversal.escapeNamespace(name) + "} = await import(\"./" + (0, initialization_1.escapeFilenameForImport)(filename) + "\");\n");
             }
             else {
-                contents.appendString("await import(\"./" + filename.replace(/#/g, "%23") + "\");\n");
+                contents.appendString("await import(\"./" + (0, initialization_1.escapeFilenameForImport)(filename) + "\");\n");
             }
         }
         contents.appendChunk(output.chunk);
@@ -110638,6 +110918,7 @@ exports.HandleView = HandleView;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.HandleW3MI = void 0;
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
+const w3mi_name_1 = __webpack_require__(/*! ../w3mi_name */ "./node_modules/@abaplint/transpiler/build/src/w3mi_name.js");
 class HandleW3MI {
     runObject(obj, _reg) {
         const filename = obj.getXMLFile()?.getFilename().replace(".xml", ".mjs").toLowerCase();
@@ -110646,7 +110927,7 @@ class HandleW3MI {
         }
         obj.parse();
         const dataFile = obj.getDataFile();
-        const chunk = new chunk_1.Chunk().appendString(`abap.W3MI["${obj.getName().toUpperCase()}"] = {
+        const chunk = new chunk_1.Chunk().appendString(`abap.W3MI["${(0, w3mi_name_1.w3miObjectName)(obj)}"] = {
   "objectType": "W3MI",
   "filename": ${JSON.stringify(dataFile?.getFilename())},
 };`);
@@ -110896,12 +111177,24 @@ var __importStar = (this && this.__importStar) || (function () {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.Initialization = void 0;
 exports.escapeNamespaceFilename = escapeNamespaceFilename;
+exports.escapeFilenameForImport = escapeFilenameForImport;
 const abaplint = __importStar(__webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js"));
 const handle_fugr_1 = __webpack_require__(/*! ./handlers/handle_fugr */ "./node_modules/@abaplint/transpiler/build/src/handlers/handle_fugr.js");
 function escapeNamespaceFilename(filename) {
     // ES modules are resolved and cached as URLs. This means that special characters must be
     // percent-encoded, such as # with %23 and ? with %3F.
-    return filename.replace(/\//g, "%23");
+    //
+    // The percent sign goes first, and the order is the whole point. A URL is
+    // percent-decoded before it is resolved, so a file whose *name* contains a
+    // percent has to carry it escaped or the decoding eats it: abapGit stores
+    // ZO4D_06_PLASMA.PNG as zo4d_06_plasma%2epng, and "./zo4d_06_plasma%2epng.w3mi.mjs"
+    // resolves to zo4d_06_plasma.png.w3mi.mjs, which is not there. Escaping the
+    // percent after the slash would corrupt the %23 this function just wrote.
+    return filename.replace(/%/g, "%25").replace(/\//g, "%23");
+}
+// The same rule for a name that already carries abapGit's # rather than a slash
+function escapeFilenameForImport(filename) {
+    return filename.replace(/%/g, "%25").replace(/#/g, "%23");
 }
 class Initialization {
     script(reg, dbSetup, options, useImport, pluginOutputs) {
@@ -113780,11 +114073,39 @@ class CreateObjectTranspiler {
             ret += `  ${id} = abap.Classes[${internalName}.get().trimEnd()];\n`;
             ret += `}\n`;
             ret += `if (${id} === undefined) { throw new ${cx}; }\n`;
+            // ...and it has to be compatible with the STATIC type of the target.
+            // A system raises CX_SY_CREATE_OBJECT_ERROR for a class that is not,
+            // before the constructor runs; without this the class was assigned to
+            // the reference whatever it was, and the mismatch surfaced later as a
+            // javascript TypeError on the first member access - which no CATCH
+            // takes, so a caller that guards its dynamic CREATE OBJECT the way the
+            // documentation asks for was not guarded at all
+            const staticName = this.findTargetTypeName(node, traversal);
+            if (staticName !== undefined) {
+                const staticType = traversal.lookupClassOrInterface(staticName, node.getFirstToken());
+                ret += `abap.statements.checkCreateObjectType(${id}, ${staticType}, "${staticName.toUpperCase()}");\n`;
+            }
             clas = id;
         }
         ret += target + ".set(await (new " + clas + "()).constructor_(" + para + "));";
         return new chunk_1.Chunk(ret);
     }
+    /** The name of the target reference's STATIC type, or undefined when there
+     * is nothing to check against - a generic `REF TO object`, or a target this
+     * cannot resolve (which is reported by findClassName on the static path and
+     * must not turn a working dynamic CREATE OBJECT into a transpile error
+     * here). */
+    findTargetTypeName(node, traversal) {
+        const scope = traversal.findCurrentScopeByToken(node.getFirstToken());
+        if (scope === undefined) {
+            return undefined;
+        }
+        const type = traversal.determineType(node, scope);
+        if (type instanceof abaplint.BasicTypes.ObjectReferenceType) {
+            return type.getIdentifierName();
+        }
+        return undefined;
+    }
     findClassName(node, traversal) {
         const c = node.findDirectExpression(abaplint.Expressions.ClassName);
         if (c) {
@@ -124987,6 +125308,58 @@ exports.Validation = Validation;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/transpiler/build/src/w3mi_name.js"
+/*!******************************************************************!*\
+  !*** ./node_modules/@abaplint/transpiler/build/src/w3mi_name.js ***!
+  \******************************************************************/
+(__unused_webpack_module, exports) {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.w3miObjectName = w3miObjectName;
+/**
+ * The name a system knows a Web Repository object by: `wwwdata-objid`.
+ *
+ * It is not the file name. abapGit percent-escapes the characters a file name
+ * cannot hold, so `ZOISEE-EAR-02.MP3` is stored as `zoisee-ear-02%2emp3`, and
+ * abaplint derives an object's name from the file it was read from. Keying
+ * anything a caller sees on that spelling turns an abapGit storage detail into
+ * an API: ABAP that asks `SELECT ... FROM wwwparams WHERE objid = 'X.MP3'`,
+ * which is how the object is addressed on a system, then finds nothing.
+ *
+ * The real name is in the object's own XML, and abapGit puts it there from the
+ * key itself — `io_xml->add( iv_name = 'NAME' ig_data = ms_key-objid )` in
+ * `zcl_abapgit_object_w3xx_super`, in both serializer versions.
+ */
+function w3miObjectName(obj) {
+    const raw = obj.getXMLFile()?.getRaw();
+    if (raw !== undefined) {
+        // every entry of <PARAMS> carries a <NAME> of its own, so only the part
+        // before the parameter list can be searched for the object's
+        const head = raw.split(/<PARAMS[\s/>]/)[0];
+        const found = /<NAME>([^<]*)<\/NAME>/.exec(head);
+        const name = found === null ? "" : unescapeXML(found[1]).trim();
+        if (name.length > 0) {
+            return name.toUpperCase();
+        }
+    }
+    // an object with no XML, or an XML from something that is not abapGit: the
+    // file name is the only name there is, and a wrong key beats no key
+    return obj.getName().toUpperCase();
+}
+function unescapeXML(value) {
+    // a W3MI name may hold < and > and &, which reach the file escaped
+    return value.replace(/&lt;/g, "<")
+        .replace(/&gt;/g, ">")
+        .replace(/&quot;/g, "\"")
+        .replace(/&apos;/g, "'")
+        .replace(/&amp;/g, "&");
+}
+//# sourceMappingURL=w3mi_name.js.map
+
+/***/ },
+
 /***/ "./node_modules/progress/index.js"
 /*!****************************************!*\
   !*** ./node_modules/progress/index.js ***!

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.13.87",
+  "version": "2.13.89",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,8 +27,8 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.52",
-    "@abaplint/transpiler": "^2.13.87",
+    "@abaplint/core": "^2.120.55",
+    "@abaplint/transpiler": "^2.13.89",
     "@types/glob": "^9.0.0",
     "@types/node": "^26.4.1",
     "@types/progress": "^2.0.7",