@abaplint/transpiler-cli 2.13.85 → 2.13.86

package/build/bundle.js

@@ -63578,6 +63578,9 @@ const ddic_1 = __webpack_require__(/*! ../ddic */ "./node_modules/@abaplint/core
 const Types = __importStar(__webpack_require__(/*! ../abap/types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js"));
 const xml_utils_1 = __webpack_require__(/*! ../xml_utils */ "./node_modules/@abaplint/core/build/src/xml_utils.js");
 const domain_1 = __webpack_require__(/*! ./domain */ "./node_modules/@abaplint/core/build/src/objects/domain.js");
+const _identifier_1 = __webpack_require__(/*! ../abap/4_file_information/_identifier */ "./node_modules/@abaplint/core/build/src/abap/4_file_information/_identifier.js");
+const identifier_1 = __webpack_require__(/*! ../abap/1_lexer/tokens/identifier */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/identifier.js");
+const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
 class DataElement extends _abstract_object_1.AbstractObject {
     constructor() {
         super(...arguments);
@@ -63598,6 +63601,17 @@ class DataElement extends _abstract_object_1.AbstractObject {
             allowNamespace: true,
         };
     }
+    getIdentifier() {
+        const xmlIdentifier = super.getIdentifier();
+        if (xmlIdentifier) {
+            return xmlIdentifier;
+        }
+        const file = this.getAFFFile();
+        if (file === undefined) {
+            return undefined;
+        }
+        return new _identifier_1.Identifier(new identifier_1.Identifier(new position_1.Position(1, 1), this.getName()), file.getFilename());
+    }
     setDirty() {
         this.parsedXML = undefined;
         this.parsedType = undefined;
@@ -63645,7 +63659,6 @@ class DataElement extends _abstract_object_1.AbstractObject {
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.dtelmaster;
     }
     parseType(reg) {
-        var _a;
         const references = [];
         let lookup = undefined;
         this.parse();
@@ -63657,7 +63670,53 @@ class DataElement extends _abstract_object_1.AbstractObject {
                 return this.parsedType;
             }
             const ddic = new ddic_1.DDIC(reg);
-            if (this.parsedXML.refkind === "D") {
+            const lookupPredefinedType = () => {
+                var _a, _b;
+                if (((_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.datatype) === undefined || this.parsedXML.datatype === "") {
+                    return { type: new Types.UnknownType("DATATYPE unexpectely empty in " + this.getName()) };
+                }
+                return { type: ddic.textToType({
+                        text: this.parsedXML.datatype,
+                        length: this.parsedXML.leng,
+                        decimals: this.parsedXML.decimals,
+                        infoText: this.getName(),
+                        qualifiedName: this.getName(),
+                        conversionExit: undefined,
+                        ddicName: this.getName(),
+                        description: (_b = this.parsedXML.texts) === null || _b === void 0 ? void 0 : _b.heading,
+                    }) };
+            };
+            if (this.parsedXML.affCategory === "referenceToPredefinedType") {
+                const predefined = lookupPredefinedType();
+                lookup = predefined.type instanceof Types.UnknownType
+                    ? predefined
+                    : { type: new Types.DataReference(predefined.type, this.getName()) };
+            }
+            else if (this.parsedXML.affCategory === "referenceDictionaryType") {
+                if (this.parsedXML.domname === undefined || this.parsedXML.domname === "") {
+                    lookup = { type: new Types.UnknownType("Type name unexpectely empty in " + this.getName()) };
+                }
+                else {
+                    const referenced = ddic.lookup(this.parsedXML.domname);
+                    lookup = referenced.type instanceof Types.UnknownType
+                        ? referenced
+                        : Object.assign(Object.assign({}, referenced), { type: new Types.DataReference(referenced.type, this.getName()) });
+                }
+            }
+            else if (this.parsedXML.affCategory === "referenceClasIntType") {
+                if (this.parsedXML.domname === undefined || this.parsedXML.domname === "") {
+                    lookup = { type: new Types.UnknownType("Type name unexpectely empty in " + this.getName()) };
+                }
+                else {
+                    lookup = ddic.lookupObject(this.parsedXML.domname);
+                }
+            }
+            else if (this.parsedXML.affCategory !== undefined
+                && this.parsedXML.affCategory !== "domain"
+                && this.parsedXML.affCategory !== "predefinedType") {
+                lookup = { type: new Types.UnknownType("Unknown AFF data type category " + this.parsedXML.affCategory + " in " + this.getName()) };
+            }
+            else if (this.parsedXML.refkind === "D") {
                 if (this.parsedXML.domname === undefined || this.parsedXML.domname === "") {
                     lookup = { type: new Types.UnknownType("DOMNAME unexpectely empty in " + this.getName()) };
                 }
@@ -63674,21 +63733,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
                 }
             }
             else {
-                if (this.parsedXML.datatype === undefined || this.parsedXML.datatype === "") {
-                    lookup = { type: new Types.UnknownType("DATATYPE unexpectely empty in " + this.getName()) };
-                }
-                else {
-                    lookup = { type: ddic.textToType({
-                            text: this.parsedXML.datatype,
-                            length: this.parsedXML.leng,
-                            decimals: this.parsedXML.decimals,
-                            infoText: this.getName(),
-                            qualifiedName: this.getName(),
-                            conversionExit: undefined,
-                            ddicName: this.getName(),
-                            description: (_a = this.parsedXML.texts) === null || _a === void 0 ? void 0 : _a.heading,
-                        }) };
-                }
+                lookup = lookupPredefinedType();
             }
         }
         if (lookup.object) {
@@ -63703,17 +63748,52 @@ class DataElement extends _abstract_object_1.AbstractObject {
         return lookup.type;
     }
     parse() {
-        var _a, _b, _c, _d, _e, _f, _g;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p;
         if (this.parsedXML !== undefined) {
             return { updated: false, runtime: 0 };
         }
         const start = Date.now();
         this.parsedXML = {};
+        const jsonFile = this.getAFFFile();
+        if (jsonFile) {
+            try {
+                const parsed = JSON.parse(jsonFile.getRaw());
+                const typeInformation = parsed.dataTypeInformation;
+                const predefinedType = typeInformation === null || typeInformation === void 0 ? void 0 : typeInformation.predefinedType;
+                const fieldLabels = parsed.fieldLabels;
+                this.parsedXML = {
+                    description: (_a = parsed.header) === null || _a === void 0 ? void 0 : _a.description,
+                    affCategory: typeInformation === null || typeInformation === void 0 ? void 0 : typeInformation.category,
+                    refkind: (typeInformation === null || typeInformation === void 0 ? void 0 : typeInformation.category) === "domain" ? "D" : undefined,
+                    domname: typeInformation === null || typeInformation === void 0 ? void 0 : typeInformation.typeName,
+                    datatype: predefinedType === null || predefinedType === void 0 ? void 0 : predefinedType.dataType,
+                    leng: (_b = predefinedType === null || predefinedType === void 0 ? void 0 : predefinedType.length) === null || _b === void 0 ? void 0 : _b.toString(),
+                    decimals: (_c = predefinedType === null || predefinedType === void 0 ? void 0 : predefinedType.decimals) === null || _c === void 0 ? void 0 : _c.toString(),
+                    texts: {
+                        short: fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.short,
+                        medium: fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.medium,
+                        long: fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.long,
+                        heading: fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.heading,
+                    },
+                    textMaxLengths: {
+                        short: (_d = fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.shortLength) === null || _d === void 0 ? void 0 : _d.toString(),
+                        medium: (_e = fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.mediumLength) === null || _e === void 0 ? void 0 : _e.toString(),
+                        long: (_f = fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.longLength) === null || _f === void 0 ? void 0 : _f.toString(),
+                        heading: (_g = fieldLabels === null || fieldLabels === void 0 ? void 0 : fieldLabels.headingLength) === null || _g === void 0 ? void 0 : _g.toString(),
+                    },
+                };
+            }
+            catch (_q) {
+                // handled by parseType()
+            }
+            const end = Date.now();
+            return { updated: true, runtime: end - start };
+        }
         const parsed = super.parseRaw2();
         if (parsed === undefined) {
             return { updated: false, runtime: 0 };
         }
-        const dd04v = (_c = (_b = (_a = parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.DD04V;
+        const dd04v = (_k = (_j = (_h = parsed.abapGit) === null || _h === void 0 ? void 0 : _h["asx:abap"]) === null || _j === void 0 ? void 0 : _j["asx:values"]) === null || _k === void 0 ? void 0 : _k.DD04V;
         this.parsedXML = {
             description: dd04v === null || dd04v === void 0 ? void 0 : dd04v.DDTEXT,
             refkind: dd04v === null || dd04v === void 0 ? void 0 : dd04v.REFKIND,
@@ -63736,7 +63816,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
             },
         };
         this.parsedXML.textsTranslations = [];
-        for (const item of (0, xml_utils_1.xmlToArray)((_g = (_f = (_e = (_d = parsed.abapGit) === null || _d === void 0 ? void 0 : _d["asx:abap"]) === null || _e === void 0 ? void 0 : _e["asx:values"]) === null || _f === void 0 ? void 0 : _f.DD04_TEXTS) === null || _g === void 0 ? void 0 : _g.item)) {
+        for (const item of (0, xml_utils_1.xmlToArray)((_p = (_o = (_m = (_l = parsed.abapGit) === null || _l === void 0 ? void 0 : _l["asx:abap"]) === null || _m === void 0 ? void 0 : _m["asx:values"]) === null || _o === void 0 ? void 0 : _o.DD04_TEXTS) === null || _p === void 0 ? void 0 : _p.item)) {
             this.parsedXML.textsTranslations.push({
                 language: item.DDLANGUAGE,
                 description: item.DDTEXT,
@@ -63749,6 +63829,9 @@ class DataElement extends _abstract_object_1.AbstractObject {
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }
+    getAFFFile() {
+        return this.getFiles().find(file => file.getFilename().toLowerCase().endsWith(".dtel.json"));
+    }
 }
 exports.DataElement = DataElement;
 //# sourceMappingURL=data_element.js.map
@@ -63895,16 +63978,21 @@ const _abstract_object_1 = __webpack_require__(/*! ./_abstract_object */ "./node
 const Types = __importStar(__webpack_require__(/*! ../abap/types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js"));
 const ddic_1 = __webpack_require__(/*! ../ddic */ "./node_modules/@abaplint/core/build/src/ddic.js");
 const xml_utils_1 = __webpack_require__(/*! ../xml_utils */ "./node_modules/@abaplint/core/build/src/xml_utils.js");
+const _identifier_1 = __webpack_require__(/*! ../abap/4_file_information/_identifier */ "./node_modules/@abaplint/core/build/src/abap/4_file_information/_identifier.js");
+const identifier_1 = __webpack_require__(/*! ../abap/1_lexer/tokens/identifier */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/identifier.js");
+const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
 class Domain extends _abstract_object_1.AbstractObject {
     getType() {
         return "DOMA";
     }
     getDescription() {
         var _a;
+        this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.description;
     }
     getConversionExit() {
         var _a;
+        this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.conversionExit;
     }
     getDataType() {
@@ -63918,6 +64006,17 @@ class Domain extends _abstract_object_1.AbstractObject {
             allowNamespace: true,
         };
     }
+    getIdentifier() {
+        const xmlIdentifier = super.getIdentifier();
+        if (xmlIdentifier) {
+            return xmlIdentifier;
+        }
+        const file = this.getAFFFile();
+        if (file === undefined) {
+            return undefined;
+        }
+        return new _identifier_1.Identifier(new identifier_1.Identifier(new position_1.Position(1, 1), this.getName()), file.getFilename());
+    }
     setDirty() {
         this.parsedXML = undefined;
         super.setDirty();
@@ -63944,18 +64043,57 @@ class Domain extends _abstract_object_1.AbstractObject {
         });
     }
     parse() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u;
+        var _v, _w;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
         const start = Date.now();
         this.parsedXML = {};
+        const jsonFile = this.getAFFFile();
+        if (jsonFile) {
+            try {
+                const parsed = JSON.parse(jsonFile.getRaw());
+                const language = (_a = parsed.header) === null || _a === void 0 ? void 0 : _a.originalLanguage;
+                const values = [];
+                for (const fixedValue of (_v = parsed.fixedValues) !== null && _v !== void 0 ? _v : []) {
+                    values.push({
+                        low: fixedValue === null || fixedValue === void 0 ? void 0 : fixedValue.fixedValue,
+                        high: "",
+                        description: fixedValue === null || fixedValue === void 0 ? void 0 : fixedValue.description,
+                        language: language,
+                    });
+                }
+                for (const interval of (_w = parsed.fixedValueIntervals) !== null && _w !== void 0 ? _w : []) {
+                    values.push({
+                        low: interval === null || interval === void 0 ? void 0 : interval.lowLimit,
+                        high: interval === null || interval === void 0 ? void 0 : interval.highLimit,
+                        description: interval === null || interval === void 0 ? void 0 : interval.description,
+                        language: language,
+                    });
+                }
+                this.parsedXML = {
+                    description: (_b = parsed.header) === null || _b === void 0 ? void 0 : _b.description,
+                    datatype: (_c = parsed.format) === null || _c === void 0 ? void 0 : _c.dataType,
+                    length: (_e = (_d = parsed.format) === null || _d === void 0 ? void 0 : _d.length) === null || _e === void 0 ? void 0 : _e.toString(),
+                    decimals: (_g = (_f = parsed.format) === null || _f === void 0 ? void 0 : _f.decimals) === null || _g === void 0 ? void 0 : _g.toString(),
+                    conversionExit: (_h = parsed.outputCharacteristics) === null || _h === void 0 ? void 0 : _h.conversionRoutine,
+                    values: values,
+                    valuesTranslations: [],
+                };
+            }
+            catch (_x) {
+                // handled by parseType()
+            }
+            const end = Date.now();
+            return { updated: true, runtime: end - start };
+        }
         const parsed = super.parseRaw2();
         if (parsed === undefined) {
             return { updated: false, runtime: 0 };
         }
-        const dd01v = (_c = (_b = (_a = parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.DD01V;
-        const dd07v_tab = (0, xml_utils_1.xmlToArray)((_g = (_f = (_e = (_d = parsed.abapGit) === null || _d === void 0 ? void 0 : _d["asx:abap"]) === null || _e === void 0 ? void 0 : _e["asx:values"]) === null || _f === void 0 ? void 0 : _f.DD07V_TAB) === null || _g === void 0 ? void 0 : _g.DD07V);
+        const dd01v = (_l = (_k = (_j = parsed.abapGit) === null || _j === void 0 ? void 0 : _j["asx:abap"]) === null || _k === void 0 ? void 0 : _k["asx:values"]) === null || _l === void 0 ? void 0 : _l.DD01V;
+        const dd07v_tab = (0, xml_utils_1.xmlToArray)((_q = (_p = (_o = (_m = parsed.abapGit) === null || _m === void 0 ? void 0 : _m["asx:abap"]) === null || _o === void 0 ? void 0 : _o["asx:values"]) === null || _p === void 0 ? void 0 : _p.DD07V_TAB) === null || _q === void 0 ? void 0 : _q.DD07V);
         const values = [];
         for (const ddo7v of dd07v_tab) {
             const value = {
@@ -63966,7 +64104,7 @@ class Domain extends _abstract_object_1.AbstractObject {
             };
             values.push(value);
         }
-        const dd07v_texts = (0, xml_utils_1.xmlToArray)((_l = (_k = (_j = (_h = parsed.abapGit) === null || _h === void 0 ? void 0 : _h["asx:abap"]) === null || _j === void 0 ? void 0 : _j["asx:values"]) === null || _k === void 0 ? void 0 : _k.DD07_TEXTS) === null || _l === void 0 ? void 0 : _l.item);
+        const dd07v_texts = (0, xml_utils_1.xmlToArray)((_u = (_t = (_s = (_r = parsed.abapGit) === null || _r === void 0 ? void 0 : _r["asx:abap"]) === null || _s === void 0 ? void 0 : _s["asx:values"]) === null || _t === void 0 ? void 0 : _t.DD07_TEXTS) === null || _u === void 0 ? void 0 : _u.item);
         const translationValues = [];
         for (const dd07v of dd07v_texts) {
             const value = {
@@ -63997,6 +64135,9 @@ class Domain extends _abstract_object_1.AbstractObject {
         var _b;
         return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.valuesTranslations) !== null && _b !== void 0 ? _b : [];
     }
+    getAFFFile() {
+        return this.getFiles().find(file => file.getFilename().toLowerCase().endsWith(".doma.json"));
+    }
 }
 exports.Domain = Domain;
 //# sourceMappingURL=domain.js.map
@@ -70877,7 +71018,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.48";
+        return "2.120.50";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -104661,8 +104802,10 @@ class ConstantTranspiler {
         return new chunk_1.Chunk(`todo, Constant`);
     }
     handleCharacter(res) {
-        const foo = res.replace(/''/g, "'");
-        let length = foo.length - 2;
+        // length of the value: strip the enclosing quotes first, an escaped
+        // quote ('') inside counts as one character and must not merge with them
+        const inner = res.substring(1, res.length - 1).replace(/''/g, "'");
+        let length = inner.length;
         if (length <= 0) {
             // note: Characters cannot have length = zero, 1 is minimum
             length = 1;
@@ -110585,7 +110728,8 @@ globalThis.abap = new runtime.ABAP();\n`;
                 || obj instanceof abaplint.Objects.Oauth2Profile
                 || obj instanceof abaplint.Objects.WebMIME
                 || obj instanceof abaplint.Objects.TypePool
-                || obj instanceof abaplint.Objects.TableType) {
+                || obj instanceof abaplint.Objects.TableType
+                || obj instanceof abaplint.Objects.View) {
                 list.push(imp(`${escapeNamespaceFilename(obj.getName().toLowerCase())}.${obj.getType().toLowerCase()}`));
             }
         }
@@ -118788,9 +118932,11 @@ class SelectTranspiler {
                 where = sqlCond;
             }
         }
+        let whereClause = "";
         if (where) {
-            select += "WHERE " + new expressions_1.SQLCondTranspiler().transpile(where, traversal, table).getCode() + " ";
+            whereClause = "WHERE " + new expressions_1.SQLCondTranspiler().transpile(where, traversal, table).getCode() + " ";
         }
+        select += whereClause;
         const groupBy = node.findFirstExpression(abaplint.Expressions.SQLGroupBy);
         if (groupBy) {
             select += new sql_group_by_1.SQLGroupByTranspiler().transpile(groupBy, traversal).getCode() + " ";
@@ -118831,6 +118977,7 @@ class SelectTranspiler {
                 else {
                     const code = new expressions_1.FieldChainTranspiler(true).transpile(chain, traversal).getCode();
                     select = select.replace(search, `" + ${code} + "`);
+                    whereClause = whereClause.replace(search, `" + ${code} + "`);
                 }
             }
         }
@@ -118858,14 +119005,17 @@ class SelectTranspiler {
             const unique2 = unique_identifier_1.UniqueIdentifier.get();
             const fn = node.findFirstExpression(abaplint.Expressions.SQLForAllEntries)?.findDirectExpression(abaplint.Expressions.SQLSource);
             const faeTranspiled = new expressions_1.SQLSourceTranspiler().transpile(fn, traversal).getCode();
+            // ABAP semantics: with an empty driving table the whole WHERE condition is ignored
+            const selectEmpty = select.replace(whereClause, "");
             select = select.replace(new RegExp(" " + escapeRegExp(faeTranspiled), "g"), " " + unique);
             select = select.replace(unique + ".get().table_line.get()", unique + ".get()"); // there can be only one?
-            let by = `Object.keys(${target}.getRowType().get())`;
-            if (keys.length > 0) {
-                by = JSON.stringify(keys);
-            }
+            // FOR ALL ENTRIES removes duplicate rows from the result: duplicates of
+            // the selected columns, so de-duplicate by the target's components. The
+            // DB key alone is wrong for projections (INTO CORRESPONDING FIELDS
+            // without the key fields crashed on the missing component names)
+            const by = `Object.keys(${target}.getRowType().get())`;
             const code = `if (${faeTranspiled}.array().length === 0) {
-  throw new Error("FAE, todo, empty table");
+  await abap.statements.select(${target}, {select: "${selectEmpty.trim()}"${extra}});
 } else {
   const ${unique2} = ${faeTranspiled}.array();
   ${target}.clear();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.13.85",
+  "version": "2.13.86",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,8 +27,8 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.48",
-    "@abaplint/transpiler": "^2.13.85",
+    "@abaplint/core": "^2.120.50",
+    "@abaplint/transpiler": "^2.13.86",
     "@types/glob": "^9.0.0",
     "@types/node": "^26.4.1",
     "@types/progress": "^2.0.7",