@abaplint/transpiler-cli 2.13.82 → 2.13.84

package/build/bundle.js

@@ -27940,6 +27940,13 @@ class TypeUtils {
             || type instanceof basic_1.UnknownType
             || type instanceof basic_1.VoidType;
     }
+    isCharLikeForCompare(type) {
+        return type === undefined
+            || type instanceof basic_1.StringType
+            || type instanceof basic_1.CLikeType
+            || type instanceof basic_1.CSequenceType
+            || this.isCharLikeField(type);
+    }
     isCharLike(type) {
         if (type === undefined) {
             return false;
@@ -30281,6 +30288,7 @@ const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@ab
 const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_type_utils.js");
 class Compare {
     static runSyntax(node, input) {
+        var _a;
         const sourceTypes = [];
         const sources = node.findDirectExpressions(Expressions.Source);
         for (const t of sources) {
@@ -30292,8 +30300,16 @@ class Compare {
         for (const t of node.findDirectExpressions(Expressions.MethodCallChain)) {
             method_call_chain_1.MethodCallChain.runSyntax(t, input);
         }
-        if (node.findDirectExpression(Expressions.CompareOperator)
-            && new _type_utils_1.TypeUtils(input.scope).isCompareable(sourceTypes[0], sourceTypes[1], sources[0], sources[1]) === false
+        const typeUtils = new _type_utils_1.TypeUtils(input.scope);
+        const compareOperator = (_a = node.findDirectExpression(Expressions.CompareOperator)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+        if (compareOperator === "CS"
+            && sourceTypes.length === 2
+            && sourceTypes.some((type) => typeUtils.isCharLikeForCompare(type) === false)) {
+            const message = "CS operands must be character-like (data type C, N, D, T, or STRING)";
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+        }
+        else if (node.findDirectExpression(Expressions.CompareOperator)
+            && typeUtils.isCompareable(sourceTypes[0], sourceTypes[1], sources[0], sources[1]) === false
             && sourceTypes.length === 2) {
             let message = "Incompatible types for comparison";
             if ((sourceTypes[0] instanceof basic_1.DateType
@@ -32303,6 +32319,17 @@ var __importStar = (this && this.__importStar) || (function () {
         return result;
     };
 })();
+var __rest = (this && this.__rest) || function (s, e) {
+    var t = {};
+    for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
+        t[p] = s[p];
+    if (s != null && typeof Object.getOwnPropertySymbols === "function")
+        for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) {
+            if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable.call(s, p[i]))
+                t[p[i]] = s[p[i]];
+        }
+    return t;
+};
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.InlineData = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
@@ -32335,7 +32362,7 @@ class InlineData {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 type = basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
             }
-            const identifier = new _typed_identifier_1.TypedIdentifier(token, input.filename, type, ["inline" /* IdentifierMeta.InlineDefinition */]);
+            const identifier = new _typed_identifier_1.TypedIdentifier(token, input.filename, this.stripDerivedFromConstant(type), ["inline" /* IdentifierMeta.InlineDefinition */]);
             input.scope.addIdentifier(identifier);
             input.scope.addReference(token, identifier, _reference_1.ReferenceType.DataWriteReference, input.filename);
         }
@@ -32346,6 +32373,26 @@ class InlineData {
             input.scope.addReference(token, identifier, _reference_1.ReferenceType.DataWriteReference, input.filename);
         }
     }
+    // The inferred type is taken from the source expression, which might be a literal.
+    // The variable itself is not a constant, so the relaxations that apply to literals
+    // must not be inherited, eg. a "c" variable is not assignable to a "string" parameter
+    static stripDerivedFromConstant(type) {
+        const data = type.getAbstractTypeData();
+        if ((data === null || data === void 0 ? void 0 : data.derivedFromConstant) !== true) {
+            return type;
+        }
+        const { derivedFromConstant } = data, rest = __rest(data, ["derivedFromConstant"]);
+        if (type instanceof basic_1.CharacterType) {
+            return new basic_1.CharacterType(type.getLength(), rest);
+        }
+        else if (type instanceof basic_1.IntegerType) {
+            return basic_1.IntegerType.get(rest);
+        }
+        else if (type instanceof basic_1.StringType) {
+            return basic_1.StringType.get(rest);
+        }
+        return type;
+    }
 }
 exports.InlineData = InlineData;
 //# sourceMappingURL=inline_data.js.map
@@ -42034,17 +42081,35 @@ const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expr
 const inline_data_1 = __webpack_require__(/*! ../expressions/inline_data */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/inline_data.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 const target_1 = __webpack_require__(/*! ../expressions/target */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/target.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 class GetTime {
     runSyntax(node, input) {
         const target = node.findDirectExpression(Expressions.Target);
+        const stamp = node.findDirectTokenByText("STAMP") !== undefined;
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
         if (inline) {
             inline_data_1.InlineData.runSyntax(inline, input, new basic_1.PackedType(8, 0));
         }
         else if (target) {
-            target_1.Target.runSyntax(target, input);
+            const type = target_1.Target.runSyntax(target, input);
+            if (stamp === true && this.compatibleTimeStamp(type) === false) {
+                const message = "GET TIME STAMP FIELD, target type not compatible";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
         }
     }
+    // the target must be a timestamp, ie. packed(timestamp and timestampl) or utclong
+    compatibleTimeStamp(type) {
+        return type === undefined
+            || type instanceof basic_1.PackedType
+            || type instanceof basic_1.UTCLongType
+            || type instanceof basic_1.VoidType
+            || type instanceof basic_1.AnyType
+            || type instanceof basic_1.DataType
+            || type instanceof basic_1.UnknownType
+            || type.isGeneric();
+    }
 }
 exports.GetTime = GetTime;
 //# sourceMappingURL=get_time.js.map
@@ -70812,7 +70877,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.45";
+        return "2.120.48";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -72443,7 +72508,7 @@ class AllowedObjectNaming {
             key: "allowed_object_naming",
             title: "Allowed object naming",
             shortDescription: `Enforces basic name length and namespace restrictions, see note SAP 104010`,
-            tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
         };
     }
     initialize(_reg) {
@@ -78300,6 +78365,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.outlineTableExpressionKeyBuiltin(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.assignWithTable(low, high, lowFile);
         if (found) {
             return found;
@@ -78997,6 +79066,69 @@ ${indentation}`);
         }
         return condition;
     }
+    /** A built-in function is only recognized as one in an operand position that admits an
+     * expression, and "WITH KEY comp = ..." does not become such a position until v740. The
+     * table expression rewrites carry the key operand over verbatim, so
+     * "tab[ comp = to_upper( x ) ]" downports to a READ TABLE that a 702 or 731 compiler can
+     * only read as a functional method call - "method TO_UPPER is unknown", reported as a
+     * SYNTAX_ERROR of the whole class pool. Hoist the call into a variable first, an
+     * assignment IS an expression position at 702.
+     *
+     * Built-ins that predate 702 (lines, strlen, numofchar, ...) carry no release in
+     * BuiltIn.methods; they are accepted in the operand as they are and stay untouched. So do
+     * functional method calls, which are exactly the reading that makes the built-in fail, and
+     * the INDEX operand of "tab[ 1 ]", which is not a key operand. */
+    outlineTableExpressionKeyBuiltin(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const tableExpression of high.findAllExpressionsRecursive(Expressions.TableExpression)) {
+            let afterComponent = false;
+            for (const child of tableExpression.getChildren()) {
+                if (child.get() instanceof Expressions.ComponentChainSimple) {
+                    afterComponent = true;
+                    continue;
+                }
+                else if (afterComponent === false
+                    || !(child.get() instanceof Expressions.Source)
+                    || !(child instanceof nodes_1.ExpressionNode)) {
+                    continue;
+                }
+                const type = this.builtinReturnType(child, lowFile, highSyntax);
+                if (type === undefined) {
+                    continue;
+                }
+                const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+                const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+                const code = `DATA ${uniqueName} TYPE ${type}.\n` +
+                    indentation + `${uniqueName} = ${child.concatTokens()}.\n` +
+                    indentation;
+                const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
+                const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, child.getFirstToken().getStart(), child.getLastToken().getEnd(), uniqueName);
+                const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+                return issue_1.Issue.atToken(lowFile, child.getFirstToken(), "Outline built-in function in table expression key", this.getMetadata().key, this.conf.severity, fix);
+            }
+        }
+        return undefined;
+    }
+    /** the ABAP type returned by the built-in function this Source starts with, or undefined
+     * if it does not start with one, or with one that predates 702 */
+    builtinReturnType(source, lowFile, highSyntax) {
+        var _a, _b, _c;
+        const spag = highSyntax.spaghetti.lookupPosition(source.getFirstToken().getStart(), lowFile.getFilename());
+        for (const r of (spag === null || spag === void 0 ? void 0 : spag.getData().references) || []) {
+            if (r.referenceType !== _reference_1.ReferenceType.BuiltinMethodReference
+                || r.position.getStart().equals(source.getFirstToken().getStart()) === false) {
+                continue;
+            }
+            const name = r.position.getName().toUpperCase();
+            if (((_a = _builtin_1.BuiltIn.methods[name]) === null || _a === void 0 ? void 0 : _a.release) === undefined) {
+                return undefined;
+            }
+            return (_c = (_b = _builtin_1.BuiltIn.searchBuiltin(name)) === null || _b === void 0 ? void 0 : _b.getParameters().getReturning()) === null || _c === void 0 ? void 0 : _c.getType().toABAP();
+        }
+        return undefined;
+    }
     outlineCatchSimple(node, lowFile) {
         // outlines "CATCH cx_bcs INTO DATA(lx_bcs_excep).", note that this does not need to look at types
         var _a, _b;
@@ -80607,9 +80739,13 @@ ${indentation}    output = ${uniqueName}.\n`;
                 continue;
             }
             const uniqueName = this.uniqueName(i.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
-            const type = this.findType(i, lowFile, highSyntax);
             const indent = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
-            const abap = `DATA ${uniqueName} TYPE ${type}.\n` +
+            // the CONV type might just be a component of the row type, so prefer the row type
+            const rowOf = this.findRowTypeOf(high, i);
+            const declaration = rowOf === undefined
+                ? `DATA ${uniqueName} TYPE ${this.findType(i, lowFile, highSyntax)}.`
+                : `DATA ${uniqueName} LIKE LINE OF ${rowOf}.`;
+            const abap = declaration + "\n" +
                 indent + `${uniqueName} = ${body}.\n` +
                 indent;
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
@@ -80619,6 +80755,19 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** if the source expression is the complete source of an INSERT or APPEND statement, then the
+     * outlined variable must be typed via the row type of the table, returns the table name */
+    findRowTypeOf(high, source) {
+        var _a;
+        if (!(high.get() instanceof Statements.InsertInternal)
+            && !(high.get() instanceof Statements.Append)) {
+            return undefined;
+        }
+        else if (high.getChildren()[1] !== source) {
+            return undefined;
+        }
+        return (_a = high.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+    }
     // "CAST" to "?="
     outlineCast(low, high, lowFile, highSyntax) {
         var _a;
@@ -112612,12 +112761,56 @@ exports.CollectTranspiler = CollectTranspiler;
 
 "use strict";
 
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.CommitTranspiler = void 0;
+const abaplint = __importStar(__webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js"));
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
+const insert_database_1 = __webpack_require__(/*! ./insert_database */ "./node_modules/@abaplint/transpiler/build/src/statements/insert_database.js");
 class CommitTranspiler {
     transpile(node, traversal) {
-        return new chunk_1.Chunk().append("abap.statements.commit();", node, traversal);
+        const options = [];
+        const connection = node.findDirectExpression(abaplint.Expressions.DatabaseConnection);
+        if (connection) {
+            options.push(`"connection": ${(0, insert_database_1.findConnection)(connection, traversal)}`);
+        }
+        else if (node.findTokenSequencePosition("AND", "WAIT")) {
+            options.push(`"wait": true`);
+        }
+        const opt = options.length === 0 ? "" : `{${options.join(", ")}}`;
+        return new chunk_1.Chunk().append(`await abap.statements.commit(${opt});`, node, traversal);
     }
 }
 exports.CommitTranspiler = CommitTranspiler;
@@ -115752,20 +115945,32 @@ class InsertDatabaseTranspiler {
         }
         const connection = node.findDirectExpression(abaplint.Expressions.DatabaseConnection);
         if (connection) {
-            const con = findConnection(connection);
-            options.push(`"connection": "${con}"`);
+            const con = findConnection(connection, traversal);
+            options.push(`"connection": ${con}`);
         }
         return new chunk_1.Chunk(`await abap.statements.insertDatabase(${table.getCode()}, {${options.join(", ")}});`);
     }
 }
 exports.InsertDatabaseTranspiler = InsertDatabaseTranspiler;
-function findConnection(connection) {
+function findConnection(connection, traversal) {
+    const dynamic = connection.findDirectExpression(abaplint.Expressions.Dynamic);
+    if (dynamic) {
+        const field = dynamic.findFirstExpression(abaplint.Expressions.FieldChain);
+        if (field === undefined) {
+            throw new Error("findConnection: dynamic connection name not found");
+        }
+        const value = traversal.traverse(field).getCode();
+        return `${value}.get().trimEnd().toUpperCase()`;
+    }
     let con = connection.getLastToken().getStr().toUpperCase();
+    if (con.startsWith("'") && con.endsWith("'")) {
+        con = con.substring(1, con.length - 1).replace(/''/g, "'");
+    }
     if (con === "DEFAULT_") {
         // todo, workaround for replacing of keywords,
         con = "DEFAULT";
     }
-    return con;
+    return JSON.stringify(con);
 }
 //# sourceMappingURL=insert_database.js.map
 
@@ -117170,8 +117375,8 @@ class OpenCursorTranspiler {
         const options = [];
         const connection = node.findDirectExpression(abaplint.Expressions.DatabaseConnection);
         if (connection) {
-            const con = (0, insert_database_1.findConnection)(connection);
-            options.push(`"connection": "${con}"`);
+            const con = (0, insert_database_1.findConnection)(connection, traversal);
+            options.push(`"connection": ${con}`);
         }
         return new chunk_1.Chunk().append(`await abap.statements.openCursor(${target}, "${select}", {${options.join(", ")}});`, node, traversal);
     }
@@ -118331,12 +118536,53 @@ exports.ReturnTranspiler = ReturnTranspiler;
 
 "use strict";
 
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.RollbackTranspiler = void 0;
+const abaplint = __importStar(__webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js"));
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
+const insert_database_1 = __webpack_require__(/*! ./insert_database */ "./node_modules/@abaplint/transpiler/build/src/statements/insert_database.js");
 class RollbackTranspiler {
     transpile(node, traversal) {
-        return new chunk_1.Chunk().append("abap.statements.rollback();", node, traversal);
+        const options = [];
+        const connection = node.findDirectExpression(abaplint.Expressions.DatabaseConnection);
+        if (connection) {
+            options.push(`"connection": ${(0, insert_database_1.findConnection)(connection, traversal)}`);
+        }
+        const opt = options.length === 0 ? "" : `{${options.join(", ")}}`;
+        return new chunk_1.Chunk().append(`await abap.statements.rollback(${opt});`, node, traversal);
     }
 }
 exports.RollbackTranspiler = RollbackTranspiler;
@@ -121171,11 +121417,13 @@ class ClassImplementationTranspiler {
             ret += traversal.setValues(attr.identifier, name);
         }
         for (const alias of cdef.getAliases()) {
-            const isStatic = staticAttributes.some(s => s.prefix.replace("$", "~") + s.identifier.getName() === alias.getComponent());
+            // note: the component is the raw source casing, so compare case insensitive
+            const component = alias.getComponent().toLowerCase();
+            const isStatic = staticAttributes.some(s => (s.prefix.replace("$", "~") + s.identifier.getName()).toLowerCase() === component);
             if (isStatic === false) {
                 continue;
             }
-            ret += traversal_1.Traversal.escapeNamespace(clasName) + "." + alias.getName().toLowerCase() + " = " + traversal_1.Traversal.escapeNamespace(clasName) + "." + traversal_1.Traversal.escapeNamespace(alias.getComponent().replace("~", "$")) + ";\n";
+            ret += traversal_1.Traversal.escapeNamespace(clasName) + "." + alias.getName().toLowerCase() + " = " + traversal_1.Traversal.escapeNamespace(clasName) + "." + traversal_1.Traversal.escapeNamespace(component.replace("~", "$")) + ";\n";
         }
         for (const e of cdef.getEvents()) {
             if (e.isStatic() === false) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.13.82",
+  "version": "2.13.84",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,8 +27,8 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.45",
-    "@abaplint/transpiler": "^2.13.82",
+    "@abaplint/core": "^2.120.48",
+    "@abaplint/transpiler": "^2.13.84",
     "@types/glob": "^9.0.0",
     "@types/node": "^26.4.1",
     "@types/progress": "^2.0.7",