@abaplint/transpiler-cli 2.13.80 → 2.13.81

package/build/bundle.js

@@ -36816,6 +36816,19 @@ class ValueBody {
                     const message = "VALUE, source type CharacterType not compatible with StringType";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
                 }
+                else if (this.insertsUsingTableKey(targetType)) {
+                    // only STANDARD tables append the rows, and thus allow padding of shorter c and x values
+                    const row = this.characterOrHexLength(rowType);
+                    const source = this.characterOrHexLength(sourceType);
+                    if (row !== undefined
+                        && source !== undefined
+                        && row.abap === source.abap
+                        && row.length !== source.length) {
+                        const message = `VALUE, source type ${source.abap} LENGTH ${source.length} not compatible ` +
+                            `with row type ${row.abap} LENGTH ${row.length}`;
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
+                    }
+                }
             }
         }
         if (letScoped === true) {
@@ -36829,6 +36842,25 @@ class ValueBody {
         }
         return targetType ? targetType : type;
     }
+    /** SORTED and HASHED tables insert the constructed rows using the table key, which
+     * requires the rows to be compatible with the row type. STANDARD tables only append
+     * the rows, so shorter c and x values are padded on the right instead. */
+    static insertsUsingTableKey(targetType) {
+        if (!(targetType instanceof basic_1.TableType)) {
+            return false;
+        }
+        const accessType = targetType.getAccessType();
+        return accessType === basic_1.TableAccessType.sorted || accessType === basic_1.TableAccessType.hashed;
+    }
+    static characterOrHexLength(type) {
+        if (type instanceof basic_1.CharacterType) {
+            return { abap: "c", length: type.getLength() };
+        }
+        else if (type instanceof basic_1.HexType) {
+            return { abap: "x", length: type.getLength() };
+        }
+        return undefined;
+    }
 }
 exports.ValueBody = ValueBody;
 //# sourceMappingURL=value_body.js.map
@@ -69148,6 +69180,20 @@ class Table extends _abstract_object_1.AbstractObject {
         }
         return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.tableCategory;
     }
+    getDeliveryClass() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.deliveryClass;
+    }
+    getSizeCategory() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.sizeCategory;
+    }
     getEnhancementCategory() {
         var _a;
         if (this.parsedData === undefined) {
@@ -69175,7 +69221,7 @@ class Table extends _abstract_object_1.AbstractObject {
         return false;
     }
     parseXML() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x, _y, _z, _0, _1, _2, _3, _4;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x, _y, _z, _0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _11, _12;
         const parsed = super.parseRaw2();
         if (parsed === undefined) {
             return;
@@ -69195,8 +69241,10 @@ class Table extends _abstract_object_1.AbstractObject {
         this.parsedData.tableCategory = (_m = (_l = (_k = (_j = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _j === void 0 ? void 0 : _j["asx:abap"]) === null || _k === void 0 ? void 0 : _k["asx:values"]) === null || _l === void 0 ? void 0 : _l.DD02V) === null || _m === void 0 ? void 0 : _m.TABCLASS;
         this.parsedData.description = (_r = (_q = (_p = (_o = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _o === void 0 ? void 0 : _o["asx:abap"]) === null || _p === void 0 ? void 0 : _p["asx:values"]) === null || _q === void 0 ? void 0 : _q.DD02V) === null || _r === void 0 ? void 0 : _r.DDTEXT;
         this.parsedData.dataClass = (_v = (_u = (_t = (_s = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _s === void 0 ? void 0 : _s["asx:abap"]) === null || _t === void 0 ? void 0 : _t["asx:values"]) === null || _u === void 0 ? void 0 : _u.DD09L) === null || _v === void 0 ? void 0 : _v.TABART;
+        this.parsedData.deliveryClass = (_z = (_y = (_x = (_w = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _w === void 0 ? void 0 : _w["asx:abap"]) === null || _x === void 0 ? void 0 : _x["asx:values"]) === null || _y === void 0 ? void 0 : _y.DD02V) === null || _z === void 0 ? void 0 : _z.CONTFLAG;
+        this.parsedData.sizeCategory = (_3 = (_2 = (_1 = (_0 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _0 === void 0 ? void 0 : _0["asx:abap"]) === null || _1 === void 0 ? void 0 : _1["asx:values"]) === null || _2 === void 0 ? void 0 : _2.DD09L) === null || _3 === void 0 ? void 0 : _3.TABKAT;
         // fields
-        const fields = (_y = (_x = (_w = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _w === void 0 ? void 0 : _w["asx:abap"]) === null || _x === void 0 ? void 0 : _x["asx:values"]) === null || _y === void 0 ? void 0 : _y.DD03P_TABLE;
+        const fields = (_6 = (_5 = (_4 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _4 === void 0 ? void 0 : _4["asx:abap"]) === null || _5 === void 0 ? void 0 : _5["asx:values"]) === null || _6 === void 0 ? void 0 : _6.DD03P_TABLE;
         for (const field of (0, xml_utils_1.xmlToArray)(fields === null || fields === void 0 ? void 0 : fields.DD03P)) {
             if (typeof (field === null || field === void 0 ? void 0 : field.FIELDNAME) !== "string") {
                 continue;
@@ -69220,13 +69268,13 @@ class Table extends _abstract_object_1.AbstractObject {
             });
         }
         // secondary indexes
-        const indexes = (_1 = (_0 = (_z = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _z === void 0 ? void 0 : _z["asx:abap"]) === null || _0 === void 0 ? void 0 : _0["asx:values"]) === null || _1 === void 0 ? void 0 : _1.DD12V;
+        const indexes = (_9 = (_8 = (_7 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _7 === void 0 ? void 0 : _7["asx:abap"]) === null || _8 === void 0 ? void 0 : _8["asx:values"]) === null || _9 === void 0 ? void 0 : _9.DD12V;
         ;
         this.parsedData.secondaryIndexes = [];
         for (const index of (0, xml_utils_1.xmlToArray)(indexes === null || indexes === void 0 ? void 0 : indexes.DD12V)) {
             const indexName = index.INDEXNAME;
             const indexFields = [];
-            const indexFieldsXml = (_4 = (_3 = (_2 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _2 === void 0 ? void 0 : _2["asx:abap"]) === null || _3 === void 0 ? void 0 : _3["asx:values"]) === null || _4 === void 0 ? void 0 : _4.DD17V;
+            const indexFieldsXml = (_12 = (_11 = (_10 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _10 === void 0 ? void 0 : _10["asx:abap"]) === null || _11 === void 0 ? void 0 : _11["asx:values"]) === null || _12 === void 0 ? void 0 : _12.DD17V;
             for (const indexField of (0, xml_utils_1.xmlToArray)(indexFieldsXml === null || indexFieldsXml === void 0 ? void 0 : indexFieldsXml.DD17V)) {
                 if (indexField.INDEXNAME === indexName) {
                     // assumption: fields are listed by POSITION in the xml
@@ -70764,7 +70812,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.44";
+        return "2.120.45";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -86137,6 +86185,7 @@ exports.LineBreakStyle = exports.LineBreakStyleConf = void 0;
 const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const objects_1 = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
 class LineBreakStyleConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.LineBreakStyleConf = LineBreakStyleConf;
@@ -86147,10 +86196,11 @@ class LineBreakStyle {
     getMetadata() {
         return {
             key: "line_break_style",
-            title: "Makes sure line breaks are consistent in the ABAP code",
-            shortDescription: `Enforces LF as newlines in ABAP files
+            title: "Makes sure line breaks are consistent",
+            shortDescription: `Enforces LF as newlines in ABAP and XML files
 
 abapGit does not work with CRLF`,
+            extendedInformation: `SMIM and W3MI files are not checked.`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
         };
     }
@@ -86165,8 +86215,15 @@ abapGit does not work with CRLF`,
     }
     run(obj) {
         const output = [];
+        if (obj instanceof objects_1.MIMEObject || obj instanceof objects_1.WebMIME) {
+            return output;
+        }
         for (const file of obj.getFiles()) {
-            if (file.getFilename().endsWith(".abap")) {
+            const filename = file.getFilename();
+            if (filename.endsWith(".abap") || filename.endsWith(".xml")) {
+                if (filename.endsWith(".xslt.source.xml")) {
+                    continue;
+                }
                 const rows = file.getRawRows();
                 for (let i = 0; i < rows.length; i++) {
                     if (rows[i].endsWith("\r") === true) {
@@ -100692,6 +100749,7 @@ class XMLConsistency {
 * XML is well-formed and parseable
 * Naming for CLAS and INTF objects
 * QUAN fields in TABL objects have reference table and field values
+* Transparent TABL objects have delivery class and size category set
 * Lock parameter names in ENQU objects are max 16 characters
 * Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
@@ -100950,15 +101008,25 @@ class XMLConsistency {
         return issues;
     }
     runTable(obj, file) {
-        var _a, _b;
-        var _c;
+        var _a, _b, _c, _d;
+        var _e;
         const issues = [];
-        for (const field of (_c = obj.getFields()) !== null && _c !== void 0 ? _c : []) {
+        for (const field of (_e = obj.getFields()) !== null && _e !== void 0 ? _e : []) {
             if (field.DATATYPE === "QUAN" && (!((_a = field.REFTABLE) === null || _a === void 0 ? void 0 : _a.trim()) || !((_b = field.REFFIELD) === null || _b === void 0 ? void 0 : _b.trim()))) {
                 const message = `QUAN field ${field.FIELDNAME} must have REFTABLE and REFFIELD set`;
                 issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
             }
         }
+        if (obj.getTableCategory() === Objects.TableCategory.Transparent) {
+            if (!((_c = obj.getDeliveryClass()) === null || _c === void 0 ? void 0 : _c.trim())) {
+                const message = `Transparent table must have delivery class(CONTFLAG in DD02V) set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+            if (!((_d = obj.getSizeCategory()) === null || _d === void 0 ? void 0 : _d.trim())) {
+                const message = `Transparent table must have size category(TABKAT in DD09L) set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
         return issues;
     }
 }
@@ -105467,11 +105535,14 @@ const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/tr
 class MethodCallTranspiler {
     postName;
     method;
-    /** @param postName inserted between the method name and the parameters, eg. ".bind(this)"
-     *  @param method   the already resolved method reference, saves looking it up again */
-    constructor(postName = "", method) {
+    discardResult;
+    /** @param postName      inserted between the method name and the parameters, eg. ".bind(this)"
+     *  @param method        the already resolved method reference, saves looking it up again
+     *  @param discardResult the RETURNING value of this call is not consumed */
+    constructor(postName = "", method, discardResult = false) {
         this.postName = postName;
         this.method = method;
+        this.discardResult = discardResult;
     }
     transpile(node, traversal) {
         let post = "";
@@ -105482,7 +105553,8 @@ class MethodCallTranspiler {
         const scope = traversal.findCurrentScopeByToken(nameToken);
         const m = this.method ?? traversal.findMethodReference(nameToken, scope);
         let name = nameToken.getStr().toLowerCase();
-        if (traversal.isBuiltinMethod(nameToken)) {
+        const isBuiltin = traversal.isBuiltinMethod(nameToken);
+        if (isBuiltin) {
             // todo: this is not correct, the method name might be shadowed
             name = "abap.builtin." + name + "(";
             if (name === "abap.builtin.line_exists(" || name === "abap.builtin.line_index(") {
@@ -105516,9 +105588,14 @@ class MethodCallTranspiler {
         if (step === undefined) {
             throw new Error("MethodCallTranspiler, unexpected node");
         }
+        // "IS SUPPLIED" on a RETURNING parameter is true when the call is functional,
+        // the flag is only passed along when the value of this very call is consumed
+        const returning = isBuiltin === true || this.discardResult === true
+            ? undefined
+            : m?.def.getParameters().getReturning()?.getName().toLowerCase();
         const ret = new chunk_1.Chunk();
         ret.append(name, nameToken, traversal);
-        ret.appendChunk(new method_call_param_1.MethodCallParamTranspiler(m?.def).transpile(step, traversal));
+        ret.appendChunk(new method_call_param_1.MethodCallParamTranspiler(m?.def, returning).transpile(step, traversal));
         ret.appendString(post + ")");
         return ret;
     }
@@ -105631,9 +105708,17 @@ const traversal_1 = __webpack_require__(/*! ../traversal */ "./node_modules/@aba
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
 const method_call_1 = __webpack_require__(/*! ./method_call */ "./node_modules/@abaplint/transpiler/build/src/expressions/method_call.js");
 class MethodCallChainTranspiler {
+    discardResult;
+    /** @param discardResult the value of the last call in the chain is not consumed,
+     *                       ie. the chain is a standalone CALL statement */
+    constructor(discardResult = false) {
+        this.discardResult = discardResult;
+    }
     transpile(node, traversal) {
         let ret = new chunk_1.Chunk();
         const children = node.getChildren();
+        const calls = node.findDirectExpressions(core_1.Expressions.MethodCall);
+        const lastCall = calls[calls.length - 1];
         for (const c of children) {
             if (c instanceof core_1.Nodes.ExpressionNode && c.get() instanceof core_1.Expressions.MethodCall) {
                 const isFirst = c === node.getFirstChild();
@@ -105651,9 +105736,10 @@ class MethodCallChainTranspiler {
                     method = traversal.findMethodReference(nameToken, traversal.findCurrentScopeByToken(nameToken));
                     prefix = traversal.constructorPrototypePrefix(nameToken, method?.def, enclosingClass);
                 }
+                const discard = this.discardResult === true && c === lastCall;
                 const sub = prefix === undefined
-                    ? traversal.traverse(c)
-                    : new method_call_1.MethodCallTranspiler(".bind(this)", method).transpile(c, traversal);
+                    ? new method_call_1.MethodCallTranspiler("", undefined, discard).transpile(c, traversal)
+                    : new method_call_1.MethodCallTranspiler(".bind(this)", method, discard).transpile(c, traversal);
                 if (sub.getCode().startsWith("abap.builtin.")
                     || sub.getCode().startsWith("await abap.builtin.")) {
                     ret.appendChunk(sub);
@@ -105736,32 +105822,43 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.MethodCallParamTranspiler = void 0;
 const core_1 = __webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js");
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
+const parameter_list_s_1 = __webpack_require__(/*! ./parameter_list_s */ "./node_modules/@abaplint/transpiler/build/src/expressions/parameter_list_s.js");
 class MethodCallParamTranspiler {
     m;
-    constructor(m) {
+    suppliedReturning;
+    /** On a real system "RETURNING IS SUPPLIED" is true exactly when the method is called
+     * functionally, so the caller has to say so.
+     * @param m                 the resolved method definition
+     * @param suppliedReturning name of the RETURNING parameter to flag as supplied,
+     *                          ie. the call is functional and the value is consumed */
+    constructor(m, suppliedReturning) {
         this.m = m;
+        this.suppliedReturning = suppliedReturning;
     }
     transpile(node, traversal) {
         let name = "";
         if (!(node.get() instanceof core_1.Expressions.MethodCallParam)) {
             throw new Error("MethodCallParam, unexpected node, " + node?.get().constructor.name);
         }
+        // the RETURNING parameter is passed along when the call is functional, see the constructor
+        const extra = this.suppliedReturning === undefined ? "" : this.suppliedReturning + ": 1";
         const source = node.findDirectExpression(core_1.Expressions.Source);
         if (source) {
             const def = this.m?.getParameters().getDefaultImporting()?.toLowerCase();
             if (this.m === undefined || def === undefined) {
+                // the input is not an object, so there is nowhere to put the RETURNING flag
                 return traversal.traverse(source);
             }
             else {
                 return new chunk_1.Chunk()
                     .appendString("{" + def + ": ")
                     .appendChunk(traversal.traverse(source))
-                    .appendString("}");
+                    .appendString(extra === "" ? "}" : ", " + extra + "}");
             }
         }
         const parameters = node.findDirectExpression(core_1.Expressions.ParameterListS);
         if (parameters) {
-            return traversal.traverse(parameters);
+            return new parameter_list_s_1.ParameterListSTranspiler(extra).transpile(parameters, traversal);
         }
         else {
             const params = node.findDirectExpression(core_1.Expressions.MethodParameters);
@@ -105776,7 +105873,13 @@ class MethodCallParamTranspiler {
             }
         }
         name = name.replace(/}{/g, ", ");
-        return new chunk_1.Chunk(name);
+        if (extra === "") {
+            return new chunk_1.Chunk(name);
+        }
+        else if (name === "") {
+            return new chunk_1.Chunk("{" + extra + "}");
+        }
+        return new chunk_1.Chunk(name.replace(/}$/, ", " + extra + "}"));
     }
 }
 exports.MethodCallParamTranspiler = MethodCallParamTranspiler;
@@ -106143,6 +106246,11 @@ exports.ParameterListSTranspiler = void 0;
 const core_1 = __webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js");
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
 class ParameterListSTranspiler {
+    extra;
+    /** @param extra appended as an additional field of the emitted object, eg. "result: 1" */
+    constructor(extra = "") {
+        this.extra = extra;
+    }
     transpile(node, traversal) {
         const parameters = [];
         for (const c of node.getChildren()) {
@@ -106150,7 +106258,8 @@ class ParameterListSTranspiler {
                 parameters.push(traversal.traverse(c));
             }
         }
-        return new chunk_1.Chunk().appendString("{").join(parameters).appendString("}");
+        const post = this.extra === "" ? "}" : ", " + this.extra + "}";
+        return new chunk_1.Chunk().appendString("{").join(parameters).appendString(post);
     }
 }
 exports.ParameterListSTranspiler = ParameterListSTranspiler;
@@ -111552,7 +111661,8 @@ class CallTranspiler {
                 pre = build.pre + pre;
                 post += build.post;
             }
-            const chainChunk = traversal.traverse(chain);
+            // without RECEIVING the value of the last call in the chain is thrown away
+            const chainChunk = new expressions_1.MethodCallChainTranspiler(receiving === undefined).transpile(chain, traversal);
             let chainCode = chainChunk.getCode();
             if (chainCode.startsWith("await super.constructor(")) {
                 // semantics of constructors in JS vs ABAP is different, so the "constructor_" has been introduced,
@@ -116349,6 +116459,11 @@ class MethodImplementationTranspiler {
                 }
             }
             else if (identifier.getMeta().includes("returning" /* abaplint.IdentifierMeta.MethodReturning */)) {
+                // the caller flags a consumed RETURNING value in INPUT, see MethodCallParamTranspiler,
+                // so "result IS SUPPLIED" needs the parameter even if the method has nothing else
+                if (unique === "") {
+                    unique = "INPUT";
+                }
                 after = after + transpile_types_1.TranspileTypes.declare(identifier) + "\n";
             }
         }
@@ -118383,6 +118498,7 @@ class SelectTranspiler {
             throw new Error("SelectTranspiler, UNION DISTINCT todo");
         }
         let target = "undefined";
+        let intoCorrespondingStructure = false;
         if (targetOverride) {
             // SelectLoop structure uses override
             target = targetOverride;
@@ -118394,7 +118510,9 @@ class SelectTranspiler {
             target = traversal.traverse(node.findFirstExpression(abaplint.Expressions.SQLIntoList)).getCode();
         }
         else if (node.findFirstExpression(abaplint.Expressions.SQLIntoStructure)) {
-            target = traversal.traverse(node.findFirstExpression(abaplint.Expressions.SQLIntoStructure)).getCode();
+            const into = node.findFirstExpression(abaplint.Expressions.SQLIntoStructure);
+            target = traversal.traverse(into).getCode();
+            intoCorrespondingStructure = into.findDirectTokenByText("CORRESPONDING") !== undefined;
         }
         const tokens = node.getTokens();
         const isDistinct = tokens[0]?.getStr().toUpperCase() === "SELECT"
@@ -118472,6 +118590,9 @@ class SelectTranspiler {
         if (concat.includes(" APPENDING TABLE ") || concat.includes(" APPENDING CORRESPONDING FIELDS OF TABLE ")) {
             runtimeOptionsList.push(`appending: true`);
         }
+        if (intoCorrespondingStructure) {
+            runtimeOptionsList.push(`corresponding: true`);
+        }
         if (runtimeOptionsList.length > 0) {
             runtimeOptions = `, {` + runtimeOptionsList.join(", ") + `}`;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.13.80",
+  "version": "2.13.81",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,8 +27,8 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.44",
-    "@abaplint/transpiler": "^2.13.79",
+    "@abaplint/core": "^2.120.45",
+    "@abaplint/transpiler": "^2.13.81",
     "@types/glob": "^9.0.0",
     "@types/node": "^26.4.1",
     "@types/progress": "^2.0.7",