@abaplint/transpiler-cli 2.13.60 → 2.13.61

package/build/bundle.js

@@ -4229,10 +4229,10 @@ exports.ClassName = ClassName;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.Color = void 0;
 const combi_1 = __webpack_require__(/*! ../combi */ "./node_modules/@abaplint/core/build/src/abap/2_statements/combi.js");
-const source_1 = __webpack_require__(/*! ./source */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/source.js");
+const simple_source3_1 = __webpack_require__(/*! ./simple_source3 */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/simple_source3.js");
 class Color extends combi_1.Expression {
     getRunnable() {
-        const eq = (0, combi_1.seq)("=", source_1.Source);
+        const eq = (0, combi_1.seq)("=", simple_source3_1.SimpleSource3);
         const integers = (0, combi_1.altPrio)("1", "2", "3", "4", "5", "6", "7");
         const texts = (0, combi_1.altPrio)("COL_BACKGROUND", "COL_HEADING", "COL_NORMAL", "COL_TOTAL", "COL_KEY", "COL_POSITIVE", "COL_NEGATIVE", "COL_GROUP");
         const value = (0, combi_1.alt)(eq, (0, combi_1.altPrio)("ON", "OFF", "COLOR OFF", (0, combi_1.altPrio)(integers, texts)));
@@ -27124,6 +27124,31 @@ class ObjectOriented {
         }
         return ret;
     }
+    // does the supplied class have friendship with "friendName"?
+    // note that interfaces of the friend, and subclasses of the friend also have friendship
+    hasFriendship(cd, friendName) {
+        var _a;
+        const friends = cd.getFriends().map(f => f.toUpperCase());
+        const isFriend = (name) => friends.includes(name.toUpperCase()) || this.scope.isLocalFriend(cd.getName(), name);
+        if (isFriend(friendName)) {
+            return true;
+        }
+        const friendDefinition = this.scope.findClassDefinition(friendName);
+        if (friendDefinition === undefined) {
+            return false;
+        }
+        if (this.findInterfaces(friendDefinition).some(i => friends.includes(i.name.toUpperCase()))) {
+            return true;
+        }
+        let sup = friendDefinition.getSuperClass();
+        while (sup !== undefined) {
+            if (isFriend(sup)) {
+                return true;
+            }
+            sup = (_a = this.scope.findClassDefinition(sup)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
+        }
+        return false;
+    }
     searchEvent(def, name) {
         if (def === undefined || name === undefined) {
             return undefined;
@@ -27132,6 +27157,11 @@ class ObjectOriented {
         if (found) {
             return found;
         }
+        if (name.includes("~")) {
+            // event of an implemented interface, ie. "if_name~event_name"
+            const [interfaceName, eventName] = name.split("~");
+            return this.searchEvent(this.scope.findInterfaceDefinition(interfaceName), eventName);
+        }
         for (const a of def.getAliases() || []) {
             if (a.getName().toUpperCase() === name.toUpperCase()) {
                 const comp = a.getComponent();
@@ -28123,7 +28153,10 @@ class TypeUtils {
                 || source instanceof basic_1.DataType
                 || source instanceof basic_1.UnknownType;
         }
-        if (source instanceof basic_1.CharacterType) {
+        if (source instanceof cgeneric_type_1.CGenericType && target instanceof basic_1.StringType) {
+            return false;
+        }
+        else if (source instanceof basic_1.CharacterType) {
             if (target instanceof basic_1.CharacterType) {
                 if (((_b = source.getAbstractTypeData()) === null || _b === void 0 ? void 0 : _b.derivedFromConstant) === true) {
                     return source.getLength() <= target.getLength();
@@ -28166,6 +28199,11 @@ class TypeUtils {
                 return false;
             }
         }
+        else if (source instanceof basic_1.DateType || source instanceof basic_1.TimeType) {
+            if (target instanceof basic_1.CharacterType || target instanceof basic_1.StringType) {
+                return false;
+            }
+        }
         else if (source instanceof basic_1.StringType) {
             if (target instanceof basic_1.StructureType && this.structureContainsString(target)) {
                 return false;
@@ -28192,6 +28230,11 @@ class TypeUtils {
                 }
                 return false;
             }
+            else if (target instanceof basic_1.TableType
+                || target instanceof basic_1.DataReference
+                || target instanceof basic_1.ObjectReferenceType) {
+                return false;
+            }
             return true;
         }
         else if (source instanceof basic_1.StructureType) {
@@ -28216,7 +28259,8 @@ class TypeUtils {
             }
             else if (target instanceof basic_1.VoidType
                 || target instanceof basic_1.AnyType
-                || target instanceof basic_1.DataType) {
+                || target instanceof basic_1.DataType
+                || target instanceof basic_1.UnknownType) {
                 return true;
             }
             return false;
@@ -28227,7 +28271,9 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.IntegerType) {
-            if (target instanceof basic_1.StringType || target instanceof basic_1.DateType) {
+            if (target instanceof basic_1.StringType
+                || target instanceof basic_1.DateType
+                || target instanceof basic_1.CharacterType) {
                 return false;
             }
             else if (target instanceof basic_1.Integer8Type || target instanceof basic_1.PackedType) {
@@ -28305,6 +28351,29 @@ class TypeUtils {
         }
         return this.isAssignable(source, target);
     }
+    // Typing with the classic STRUCTURE addition, ie. "FORM foo USING bar STRUCTURE zkey",
+    // is not a compatibility check: ABAP only checks the fragment view up to the end of the
+    // formal structure, so the actual parameter is allowed to be longer. For TABLES parameters
+    // the table key is not part of the check at all.
+    isAssignableStructureTyping(source, target, node) {
+        if (source instanceof basic_1.StructureType && target instanceof basic_1.StructureType) {
+            const sourceComponents = source.getComponents();
+            const targetComponents = target.getComponents();
+            if (sourceComponents.length < targetComponents.length) {
+                return false;
+            }
+            for (let i = 0; i < targetComponents.length; i++) {
+                if (this.isAssignableStrict(sourceComponents[i].type, targetComponents[i].type) === false) {
+                    return false;
+                }
+            }
+            return true;
+        }
+        else if (source instanceof basic_1.TableType && target instanceof basic_1.TableType) {
+            return this.isAssignableStructureTyping(source.getRowType(), target.getRowType());
+        }
+        return this.isAssignableStrict(source, target, node);
+    }
     isAssignable(source, target) {
         if (source === undefined || target === undefined) {
             return true;
@@ -28313,6 +28382,9 @@ class TypeUtils {
             console.dir(source);
             console.dir(target);
         */
+        if (source instanceof basic_1.UTCLongType || target instanceof basic_1.UTCLongType) {
+            return this.isUTCLongAssignable(source, target);
+        }
         if (target instanceof basic_1.TableType) {
             if (target.isWithHeader()) {
                 return this.isAssignable(source, target.getRowType());
@@ -28464,6 +28536,33 @@ class TypeUtils {
         }
         return true;
     }
+    // utclong can only be converted to and from character like types
+    isUTCLongAssignable(source, target) {
+        if (this.isGenericOrVoid(source) || this.isGenericOrVoid(target)) {
+            return true;
+        }
+        else if (source instanceof basic_1.UTCLongType && target instanceof basic_1.UTCLongType) {
+            return true;
+        }
+        else if (source instanceof basic_1.UTCLongType) {
+            return this.isTextLike(target);
+        }
+        return this.isTextLike(source);
+    }
+    isGenericOrVoid(type) {
+        return type instanceof basic_1.VoidType
+            || type instanceof basic_1.AnyType
+            || type instanceof basic_1.DataType
+            || type instanceof basic_1.UnknownType;
+    }
+    isTextLike(type) {
+        return type instanceof basic_1.CharacterType
+            || type instanceof basic_1.StringType
+            || type instanceof basic_1.CLikeType
+            || type instanceof basic_1.CSequenceType
+            || type instanceof cgeneric_type_1.CGenericType
+            || type instanceof basic_1.SimpleType;
+    }
 }
 exports.TypeUtils = TypeUtils;
 //# sourceMappingURL=_type_utils.js.map
@@ -28546,6 +28645,7 @@ const types_1 = __webpack_require__(/*! ../types */ "./node_modules/@abaplint/co
 const expressions_1 = __webpack_require__(/*! ../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
 const _builtin_1 = __webpack_require__(/*! ./_builtin */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_builtin.js");
 const position_1 = __webpack_require__(/*! ../../position */ "./node_modules/@abaplint/core/build/src/position.js");
+const _syntax_input_1 = __webpack_require__(/*! ./_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 class BasicTypes {
     constructor(input) {
         this.input = input;
@@ -29028,7 +29128,7 @@ class BasicTypes {
             return Types.VoidType.get((_f = node.findFirstExpression(Expressions.TypeStructure)) === null || _f === void 0 ? void 0 : _f.concatTokens());
         }
         else if (text.startsWith("LIKE LINE OF ")) {
-            const name = (_g = node.findFirstExpression(Expressions.FieldChain)) === null || _g === void 0 ? void 0 : _g.concatTokens();
+            let name = (_g = node.findFirstExpression(Expressions.FieldChain)) === null || _g === void 0 ? void 0 : _g.concatTokens();
             let e = node.findFirstExpression(Expressions.Type);
             if (e === undefined) {
                 e = node.findFirstExpression(Expressions.FormParamType);
@@ -29036,19 +29136,32 @@ class BasicTypes {
             if (e === undefined) {
                 e = node.findFirstExpression(Expressions.FieldChain);
             }
+            if (e === undefined) {
+                // old style, eg "LIKE LINE OF tab OCCURS 0 WITH HEADER LINE", it is parsed as TypeName
+                e = typeName;
+                name = typeName === null || typeName === void 0 ? void 0 : typeName.concatTokens();
+            }
             const type = this.resolveLikeName(e, false);
+            let row = undefined;
             if (type === undefined) {
                 return new Types.UnknownType("Type error, could not resolve \"" + name + "\", parseType");
             }
             else if (type instanceof Types.TableType) {
-                return type.getRowType();
+                row = type.getRowType();
             }
             else if (type instanceof Types.VoidType) {
-                return type;
+                row = type;
             }
             else {
                 return new Types.UnknownType("Type error, not a table type " + name);
             }
+            if (this.isOccurs(node)) {
+                return new Types.TableType(row, {
+                    withHeader: text.includes(" WITH HEADER LINE"),
+                    keyType: Types.TableKeyType.default
+                }, qualifiedName);
+            }
+            return row;
         }
         else if (text.startsWith("LIKE REF TO ")) {
             const name = (_h = node.findFirstExpression(Expressions.FieldChain)) === null || _h === void 0 ? void 0 : _h.concatTokens();
@@ -29486,6 +29599,13 @@ class BasicTypes {
         }
         const chain = val.findFirstExpression(Expressions.SimpleFieldChain);
         if (chain) {
+            // todo, hardcoded for now, should be a generic check that the chain is a constant
+            const concat = chain.concatTokens().toUpperCase();
+            if (concat === "SY-DATUM" || concat === "SY-UZEIT") {
+                const message = "VALUE, " + concat.toLowerCase() + " is not a constant";
+                this.input.issues.push((0, _syntax_input_1.syntaxIssue)(this.input, chain.getFirstToken(), message));
+                return undefined;
+            }
             return this.resolveConstantValue(chain);
         }
         throw new Error("findValue, unexpected");
@@ -31856,18 +31976,27 @@ class FormParam {
             else {
                 type = new basic_1.UnknownType("todo, FORM STRUCTURES typing");
             }
-            return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, type, ["form_parameter" /* IdentifierMeta.FormParameter */]);
+            return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, type, ["form_parameter" /* IdentifierMeta.FormParameter */, "form_parameter_structure" /* IdentifierMeta.FormParameterStructure */]);
         }
         if (node.getChildren().length === 1 && nameToken) {
             // untyped FORM parameter
             return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, basic_1.AnyType.get(), ["form_parameter" /* IdentifierMeta.FormParameter */]);
         }
         let bfound = new basic_types_1.BasicTypes(input).parseType(node);
-        const isTypeC = ((_c = node.findFirstExpression(expressions_1.TypeName)) === null || _c === void 0 ? void 0 : _c.concatTokens().toUpperCase()) === "C";
+        const typeName = (_c = node.findFirstExpression(expressions_1.TypeName)) === null || _c === void 0 ? void 0 : _c.concatTokens().toUpperCase();
         const hasExplicitLength = node.findFirstExpression(expressions_1.Length) !== undefined
             || node.findFirstExpression(expressions_1.ConstantFieldLength) !== undefined;
-        if (isTypeC && hasExplicitLength === false && bfound instanceof basic_1.CharacterType) {
-            bfound = basic_1.CGenericType.get();
+        // the length cannot be specified for FORM parameters, so these types are generic
+        if (hasExplicitLength === false) {
+            if (typeName === "C" && bfound instanceof basic_1.CharacterType) {
+                bfound = basic_1.CGenericType.get();
+            }
+            else if (typeName === "X" && bfound instanceof basic_1.HexType) {
+                bfound = basic_1.XGenericType.get();
+            }
+            else if (typeName === "P" && bfound instanceof basic_1.PackedType) {
+                bfound = basic_1.PGenericType.get();
+            }
         }
         if (nameToken && bfound) {
             return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound, ["form_parameter" /* IdentifierMeta.FormParameter */]);
@@ -32759,6 +32888,8 @@ const _reference_1 = __webpack_require__(/*! ../_reference */ "./node_modules/@a
 const component_name_1 = __webpack_require__(/*! ./component_name */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/component_name.js");
 const attribute_name_1 = __webpack_require__(/*! ./attribute_name */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/attribute_name.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
+const visibility_1 = __webpack_require__(/*! ../../4_file_information/visibility */ "./node_modules/@abaplint/core/build/src/abap/4_file_information/visibility.js");
+const class_definition_1 = __webpack_require__(/*! ../../types/class_definition */ "./node_modules/@abaplint/core/build/src/abap/types/class_definition.js");
 class MethodCallChain {
     static runSyntax(node, input, targetType) {
         var _a, _b;
@@ -32807,6 +32938,12 @@ class MethodCallChain {
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
+                    const notVisible = method ? this.checkVisibility(method, def, foundDef, input) : undefined;
+                    if (notVisible !== undefined) {
+                        const message = `Method "${methodName}" is ${notVisible} and cannot be accessed`;
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const voidedName = context instanceof basic_1.VoidType ? context.getVoided() : undefined;
                     const extra = helper.methodReferenceExtras(foundDef, className || voidedName);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
@@ -32849,6 +32986,47 @@ class MethodCallChain {
         return context;
     }
     //////////////////////////////////////
+    // returns the visibility as text if the method cannot be accessed from the current scope
+    static checkVisibility(method, def, foundDef, input) {
+        var _a, _b, _c;
+        const visibility = method.getVisibility();
+        if (visibility === visibility_1.Visibility.Public || foundDef === undefined) {
+            return undefined;
+        }
+        else if (!(foundDef instanceof class_definition_1.ClassDefinition)) {
+            // interface members are always public
+            return undefined;
+        }
+        const name = foundDef.getName().toUpperCase();
+        const enclosing = (_a = input.scope.getEnclosingClassName()) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+        if (enclosing === undefined || enclosing === name) {
+            return undefined;
+        }
+        // friendship with the class used at the call site also gives access to inherited members
+        const helper = new _object_oriented_1.ObjectOriented(input.scope);
+        const visited = [];
+        let current = def instanceof class_definition_1.ClassDefinition ? def : foundDef;
+        while (current !== undefined && visited.includes(current.getName().toUpperCase()) === false) {
+            visited.push(current.getName().toUpperCase());
+            if (helper.hasFriendship(current, enclosing)) {
+                return undefined;
+            }
+            const sup = current.getSuperClass();
+            current = sup === undefined ? undefined : input.scope.findClassDefinition(sup);
+        }
+        if (visibility === visibility_1.Visibility.Protected) {
+            // subclasses can access protected members
+            let sup = (_b = input.scope.findClassDefinition(enclosing)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
+            while (sup !== undefined) {
+                if (sup.toUpperCase() === name) {
+                    return undefined;
+                }
+                sup = (_c = input.scope.findClassDefinition(sup)) === null || _c === void 0 ? void 0 : _c.getSuperClass();
+            }
+            return "protected";
+        }
+        return "private";
+    }
     static findTop(first, input, targetType) {
         var _a;
         if (first.get() instanceof Expressions.ClassName) {
@@ -35517,6 +35695,7 @@ const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@ab
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 const sql_set_op_group_1 = __webpack_require__(/*! ./sql_set_op_group */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_set_op_group.js");
 const sql_source_1 = __webpack_require__(/*! ./sql_source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_source.js");
+const RANGE_COMPONENTS = ["SIGN", "OPTION", "LOW", "HIGH"];
 class SQLIn {
     static runSyntax(node, input) {
         const setop = node.findDirectExpression(Expressions.SQLSetOpGroup);
@@ -35536,6 +35715,12 @@ class SQLIn {
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
+                if (intype instanceof basic_1.TableType && this.isRangeRow(intype.getRowType()) === false) {
+                    const name = insource.concatTokens().replace(/^@/, "").replace(/\[\]$/, "");
+                    const message = `row structure of ${name} is not correct`;
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    return;
+                }
             }
             return;
         }
@@ -35546,6 +35731,16 @@ class SQLIn {
             sql_source_1.SQLSource.runSyntax(s, input);
         }
     }
+    // "IN itab" expects a ranges table, ie. the row must have SIGN, OPTION, LOW and HIGH
+    static isRangeRow(rowType) {
+        if (rowType instanceof basic_1.VoidType || rowType instanceof basic_1.UnknownType || rowType instanceof basic_1.AnyType) {
+            return true;
+        }
+        else if (!(rowType instanceof basic_1.StructureType)) {
+            return false;
+        }
+        return RANGE_COMPONENTS.every(c => rowType.getComponentByName(c) !== undefined);
+    }
 }
 exports.SQLIn = SQLIn;
 //# sourceMappingURL=sql_in.js.map
@@ -39624,7 +39819,7 @@ class CreateObject {
         this.validateParameters(cdef, node, input);
     }
     static checkInstantiationAllowed(cdef, input) {
-        var _a, _b, _c;
+        var _a, _b;
         const createVis = cdef.getCreateVisibility();
         if (createVis === visibility_1.Visibility.Public) {
             return undefined;
@@ -39637,34 +39832,17 @@ class CreateObject {
         if (enclosingClass.toUpperCase() === cdef.getName().toUpperCase()) {
             return undefined;
         }
-        if (cdef.getFriends().some(f => f.toUpperCase() === enclosingClass.toUpperCase()) ||
-            input.scope.isLocalFriend(cdef.getName(), enclosingClass)) {
+        if (new _object_oriented_1.ObjectOriented(input.scope).hasFriendship(cdef, enclosingClass)) {
             return undefined;
         }
-        const enclosingDefinition = input.scope.findClassDefinition(enclosingClass);
-        if (enclosingDefinition !== undefined) {
-            const implementedInterfaces = new _object_oriented_1.ObjectOriented(input.scope).findInterfaces(enclosingDefinition);
-            if (cdef.getFriends().some(friend => implementedInterfaces.some(implemented => implemented.name.toUpperCase() === friend.toUpperCase()))) {
-                return undefined;
-            }
-        }
-        // subclasses of friends also have friendship
-        let enclosingSup = enclosingDefinition === null || enclosingDefinition === void 0 ? void 0 : enclosingDefinition.getSuperClass();
-        while (enclosingSup !== undefined) {
-            if (cdef.getFriends().some(f => f.toUpperCase() === enclosingSup.toUpperCase()) ||
-                input.scope.isLocalFriend(cdef.getName(), enclosingSup)) {
-                return undefined;
-            }
-            enclosingSup = (_a = input.scope.findClassDefinition(enclosingSup)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
-        }
         if (createVis === visibility_1.Visibility.Protected) {
             // subclasses are also allowed
-            let sup = (_b = input.scope.findClassDefinition(enclosingClass)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
+            let sup = (_a = input.scope.findClassDefinition(enclosingClass)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
             while (sup !== undefined) {
                 if (sup.toUpperCase() === cdef.getName().toUpperCase()) {
                     return undefined;
                 }
-                sup = (_c = input.scope.findClassDefinition(sup)) === null || _c === void 0 ? void 0 : _c.getSuperClass();
+                sup = (_b = input.scope.findClassDefinition(sup)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
             }
         }
         return cdef.getName() + " cannot be instantiated, class is defined as " +
@@ -39928,6 +40106,7 @@ const source_1 = __webpack_require__(/*! ../expressions/source */ "./node_module
 const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/dynamic.js");
 const database_table_1 = __webpack_require__(/*! ../expressions/database_table */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/database_table.js");
 const _check_database_fields_1 = __webpack_require__(/*! ../expressions/_check_database_fields */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/_check_database_fields.js");
+const sql_in_1 = __webpack_require__(/*! ../expressions/sql_in */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_in.js");
 class DeleteDatabase {
     runSyntax(node, input) {
         for (const s of node.findAllExpressions(Expressions.Source)) {
@@ -39939,6 +40118,12 @@ class DeleteDatabase {
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
+        for (const compare of node.findAllExpressions(Expressions.SQLCompare)) {
+            const sqlin = compare.findDirectExpression(Expressions.SQLIn);
+            if (sqlin !== undefined) {
+                sql_in_1.SQLIn.runSyntax(sqlin, input);
+            }
+        }
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
             const dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
@@ -40943,13 +41128,17 @@ const expressions_1 = __webpack_require__(/*! ../../2_statements/expressions */
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 class Form {
     runSyntax(node, input) {
-        var _a;
-        const name = (_a = node.findDirectExpression(expressions_1.FormName)) === null || _a === void 0 ? void 0 : _a.concatTokens();
-        if (name === undefined) {
+        const nameExpression = node.findDirectExpression(expressions_1.FormName);
+        const name = nameExpression === null || nameExpression === void 0 ? void 0 : nameExpression.concatTokens();
+        if (nameExpression === undefined || name === undefined) {
             const message = "Form, could not find name";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
+        if (name.length > 30) {
+            const message = "FORM name longer than 30 characters";
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, nameExpression.getFirstToken(), message));
+        }
         input.scope.push(_scope_type_1.ScopeType.Form, name, node.getFirstToken().getStart(), input.filename);
         const form = new form_definition_1.FormDefinition(node, input);
         input.scope.addList(form.getUsingParameters());
@@ -41009,7 +41198,7 @@ const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expr
 const source_1 = __webpack_require__(/*! ../expressions/source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/source.js");
 class Format {
     runSyntax(node, input) {
-        for (const s of node.findAllExpressions(Expressions.Source)) {
+        for (const s of node.findAllExpressionsMulti([Expressions.Source, Expressions.SimpleSource3])) {
             source_1.Source.runSyntax(s, input);
         }
     }
@@ -43834,6 +44023,16 @@ class Parameter {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
+        const radioGroup = node.findFirstExpression(Expressions.RadioGroupName);
+        if (radioGroup && radioGroup.concatTokens().length > 4) {
+            const message = "Radio button group name too long, " + radioGroup.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, radioGroup.getFirstToken(), message));
+        }
+        if (this.hasUserCommand(node) && this.hasLength(node)) {
+            const message = "USER-COMMAND and LENGTH not possible together";
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+            return;
+        }
         const bfound = new basic_types_1.BasicTypes(input).parseType(node);
         if (bfound) {
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound));
@@ -43845,6 +44044,30 @@ class Parameter {
         const magicToken = new tokens_1.Identifier(nameToken.getStart(), magicName);
         input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(magicToken, input.filename, basic_1.VoidType.get("PARAMETER-MAGIC")));
     }
+    // "USER-COMMAND" is lexed as three tokens
+    hasUserCommand(node) {
+        const tokens = node.getTokens();
+        for (let i = 0; i < tokens.length - 2; i++) {
+            if (tokens[i].getStr().toUpperCase() === "USER"
+                && tokens[i + 1].getStr() === "-"
+                && tokens[i + 2].getStr().toUpperCase() === "COMMAND") {
+                return true;
+            }
+        }
+        return false;
+    }
+    // "VISIBLE LENGTH" is not the same as "LENGTH"
+    hasLength(node) {
+        var _a;
+        const tokens = node.getTokens();
+        for (let i = 0; i < tokens.length; i++) {
+            if (tokens[i].getStr().toUpperCase() === "LENGTH"
+                && ((_a = tokens[i - 1]) === null || _a === void 0 ? void 0 : _a.getStr().toUpperCase()) !== "VISIBLE") {
+                return true;
+            }
+        }
+        return false;
+    }
 }
 exports.Parameter = Parameter;
 //# sourceMappingURL=parameter.js.map
@@ -43902,6 +44125,7 @@ const target_1 = __webpack_require__(/*! ../expressions/target */ "./node_module
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 const assert_error_1 = __webpack_require__(/*! ../assert_error */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/assert_error.js");
 const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/dynamic.js");
+const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_type_utils.js");
 class Perform {
     runSyntax(node, input) {
         if (!(node.get() instanceof Statements.Perform)) {
@@ -43909,19 +44133,22 @@ class Perform {
         }
         ////////////////////////////
         // check parameters are defined
+        const changing = [];
         for (const c of node.findDirectExpressions(Expressions.PerformChanging)) {
             for (const s of c.findDirectExpressions(Expressions.Target)) {
-                target_1.Target.runSyntax(s, input);
+                changing.push({ node: s, type: target_1.Target.runSyntax(s, input) });
             }
         }
+        const tables = [];
         for (const t of node.findDirectExpressions(Expressions.PerformTables)) {
             for (const s of t.findDirectExpressions(Expressions.Source)) {
-                source_1.Source.runSyntax(s, input);
+                tables.push({ node: s, type: source_1.Source.runSyntax(s, input) });
             }
         }
+        const using = [];
         for (const u of node.findDirectExpressions(Expressions.PerformUsing)) {
             for (const s of u.findDirectExpressions(Expressions.SimpleSource3)) {
-                source_1.Source.runSyntax(s, input);
+                using.push({ node: s, type: source_1.Source.runSyntax(s, input) });
             }
         }
         ////////////////////////////
@@ -43946,7 +44173,40 @@ class Perform {
             return;
         }
         input.scope.addReference(expr.getFirstToken(), found, _reference_1.ReferenceType.FormReference, input.filename);
-        // todo, also check parameters match
+        ////////////////////////////
+        // check parameters match
+        // USING and CHANGING are interchangeable, the actual parameters form a single positional list
+        if (this.checkParameters(node, tables, found.getTablesParameters(), "TABLES", input) === false) {
+            return;
+        }
+        const formal = found.getUsingParameters().concat(found.getChangingParameters());
+        this.checkParameters(node, using.concat(changing), formal, "USING/CHANGING", input);
+    }
+    // returns false if an issue was reported
+    checkParameters(node, actual, formal, kind, input) {
+        if (actual.length !== formal.length) {
+            const message = `PERFORM, expected ${formal.length} ${kind} parameters, found ${actual.length}`;
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+            return false;
+        }
+        const typeUtils = new _type_utils_1.TypeUtils(input.scope);
+        for (let i = 0; i < actual.length; i++) {
+            const { node: source, type } = actual[i];
+            if (type === undefined) {
+                continue;
+            }
+            const parameter = formal[i];
+            const structureTyping = parameter.getMeta().includes("form_parameter_structure" /* IdentifierMeta.FormParameterStructure */);
+            const assignable = structureTyping
+                ? typeUtils.isAssignableStructureTyping(type, parameter.getType(), source)
+                : typeUtils.isAssignableStrict(type, parameter.getType(), source);
+            if (assignable === false) {
+                const message = `PERFORM parameter type not compatible, ${parameter.getName()}`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, source.getFirstToken(), message));
+                return false;
+            }
+        }
+        return true;
     }
 }
 exports.Perform = Perform;
@@ -51927,6 +52187,7 @@ const constants_1 = __webpack_require__(/*! ../5_syntax/structures/constants */
 const type_definitions_1 = __webpack_require__(/*! ./type_definitions */ "./node_modules/@abaplint/core/build/src/abap/types/type_definitions.js");
 const types_1 = __webpack_require__(/*! ../5_syntax/structures/types */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/structures/types.js");
 const type_1 = __webpack_require__(/*! ../5_syntax/statements/type */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/type.js");
+const _syntax_input_1 = __webpack_require__(/*! ../5_syntax/_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 const _reference_1 = __webpack_require__(/*! ../5_syntax/_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
 const alias_1 = __webpack_require__(/*! ./alias */ "./node_modules/@abaplint/core/build/src/abap/types/alias.js");
 class Attributes {
@@ -52148,6 +52409,13 @@ class Attributes {
                 if (foundAttribute) {
                     input.scope.addNamedIdentifier(aliasName.getStr(), foundAttribute);
                 }
+                const component = compName.split("~")[1];
+                if (foundType === undefined
+                    && foundAttribute === undefined
+                    && this.existsInInterface(idef, component, input, []) === false) {
+                    const message = "Component " + component + " not found in interface " + idef.getName();
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, compToken, message));
+                }
             }
             else if (this.declaredInterfaces.includes(name.toUpperCase()) || input.scope.getDDIC().inErrorNamespace(name) === false) {
                 input.scope.addReference(compToken, undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, input.filename);
@@ -52157,6 +52425,33 @@ class Attributes {
             }
         }
     }
+    /** does the component exist in the interface, or in one of its aliases or included interfaces? */
+    existsInInterface(idef, component, input, visited) {
+        const upperName = idef.getName().toUpperCase();
+        if (visited.includes(upperName)) {
+            return false;
+        }
+        visited.push(upperName);
+        const upper = component.toUpperCase();
+        if (idef.getTypeDefinitions().getByName(component) !== undefined
+            || idef.getAttributes().findByName(component) !== undefined
+            || idef.getMethodDefinitions().getByName(component) !== undefined
+            || idef.getEvents().some(e => e.getName().toUpperCase() === upper)
+            || idef.getAliases().some(a => a.getName().toUpperCase() === upper)) {
+            return true;
+        }
+        for (const i of idef.getImplementing()) {
+            const sub = input.scope.findInterfaceDefinition(i.name);
+            if (sub === undefined) {
+                // voided or not found, assume the component exists
+                return true;
+            }
+            else if (this.existsInInterface(sub, component, input, visited)) {
+                return true;
+            }
+        }
+        return false;
+    }
     parseAttribute(node, visibility, input) {
         let found = undefined;
         const s = node.get();
@@ -52788,7 +53083,8 @@ class FormDefinition extends _identifier_1.Identifier {
                 else if (!(type instanceof basic_1.UnknownType) && !(type instanceof basic_1.VoidType)) {
                     type = new basic_1.UnknownType("FORM TABLES type must be table type");
                 }
-                ret.push(new _typed_identifier_1.TypedIdentifier(p.getToken(), input.filename, type, ["form_parameter" /* IdentifierMeta.FormParameter */]));
+                // keep the meta from FormParam, so STRUCTURE typing can be recognized later
+                ret.push(new _typed_identifier_1.TypedIdentifier(p.getToken(), input.filename, type, p.getMeta()));
             }
         }
         return ret;
@@ -70299,7 +70595,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.28";
+        return "2.120.37";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -72986,6 +73282,11 @@ class CDSCheckSyntaxConf extends _basic_rule_config_1.BasicRuleConfig {
 exports.CDSCheckSyntaxConf = CDSCheckSyntaxConf;
 const KNOWN_QUAN_DATA_ELEMENTS = ["MENGE_D"];
 const KNOWN_CURR_DATA_ELEMENTS = ["BWERT", "DZWERT"];
+// Reserved names, cannot be used as element names, see DDIC table TRESE
+const RESERVED_ELEMENT_NAMES = ["BEGIN", "NUMBER", "POSITION"];
+const MAX_LABEL_LENGTH = 40;
+// Annotations which are not supported in CDS view entities
+const VIEW_ENTITY_FORBIDDEN_ANNOTATIONS = ["Semantics.unitOfMeasure"];
 class CDSCheckSyntax {
     constructor() {
         this.conf = new CDSCheckSyntaxConf();
@@ -73027,6 +73328,9 @@ Missing objects are only reported when their names match the configured errorNam
         this.checkTypes(tree, ddic, issues, file);
         this.checkRootProjection(tree, ddic, issues, file);
         this.checkFieldAnnotations(tree, ddic, issues, file);
+        this.checkLabels(tree, issues, file);
+        this.checkViewEntityAnnotations(tree, issues, file);
+        this.checkReservedNames(tree, issues, file);
         this.checkFields(tree, sources, object, issues, file);
         return issues;
     }
@@ -73211,6 +73515,62 @@ Missing objects are only reported when their names match the configured errorNam
                 || a.toUpperCase().includes("@SEMANTICS:{CURRENCYCODE:TRUE"));
         }
     }
+    checkLabels(tree, issues, file) {
+        for (const annotation of tree.findAllExpressionsRecursive(expressions_1.CDSAnnotation)) {
+            const concatenated = annotation.concatTokens();
+            if (/@\s*<?\s*EndUserText/i.test(concatenated) === false) {
+                continue;
+            }
+            const expression = /label\s*:\s*'((?:[^']|'')*)'/gi;
+            let match = expression.exec(concatenated);
+            while (match !== null) {
+                const label = match[1].replace(/''/g, "'");
+                if (label.length > MAX_LABEL_LENGTH) {
+                    const message = `CDS label is ${label.length} characters, maximum is ${MAX_LABEL_LENGTH}`;
+                    issues.push(issue_1.Issue.atToken(file, annotation.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
+                }
+                match = expression.exec(concatenated);
+            }
+        }
+    }
+    checkViewEntityAnnotations(tree, issues, file) {
+        const view = tree.findFirstExpression(expressions_1.CDSDefineView);
+        if (view === undefined || view.findDirectTokenByText("ENTITY") === undefined) {
+            return;
+        }
+        for (const annotation of tree.findAllExpressionsRecursive(expressions_1.CDSAnnotation)) {
+            const normalized = annotation.concatTokens().replace(/\s/g, "").toUpperCase().replace(/^@</, "@");
+            for (const forbidden of VIEW_ENTITY_FORBIDDEN_ANNOTATIONS) {
+                const upper = forbidden.toUpperCase();
+                if (normalized.startsWith("@" + upper) === false
+                    && normalized.startsWith("@" + upper.replace(".", ":{")) === false) {
+                    continue;
+                }
+                const message = `Annotation ${forbidden} is not allowed in view entities`;
+                issues.push(issue_1.Issue.atToken(file, annotation.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+    }
+    checkReservedNames(tree, issues, file) {
+        var _a, _b;
+        for (const element of tree.findAllExpressionsRecursive(expressions_1.CDSElement)) {
+            if (element.findDirectTokenByText("INCLUDE") !== undefined) {
+                continue;
+            }
+            let nameNode = (_a = element.findDirectExpression(expressions_1.CDSAs)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(expressions_1.CDSName);
+            if (nameNode === undefined) {
+                const names = ((_b = element.findDirectExpression(expressions_1.CDSPrefixedName)) === null || _b === void 0 ? void 0 : _b.findDirectExpressions(expressions_1.CDSName)) || [];
+                nameNode = names[names.length - 1];
+            }
+            if (nameNode === undefined) {
+                continue;
+            }
+            const name = this.name(nameNode);
+            if (RESERVED_ELEMENT_NAMES.includes(name.toUpperCase())) {
+                issues.push(issue_1.Issue.atToken(file, nameNode.getFirstToken(), `CDS element name "${name}" is reserved`, this.getMetadata().key, this.conf.severity));
+            }
+        }
+    }
     checkFields(tree, sources, object, issues, file) {
         var _a;
         const associationNames = new Set();
@@ -73439,7 +73799,8 @@ class CDSFieldOrder {
     }
     getAssociationNames(tree) {
         const names = new Set();
-        for (const assoc of tree.findAllExpressions(expressions_1.CDSAssociation)) {
+        const found = [...tree.findAllExpressions(expressions_1.CDSAssociation), ...tree.findAllExpressions(expressions_1.CDSComposition)];
+        for (const assoc of found) {
             const relation = assoc.findDirectExpression(expressions_1.CDSRelation);
             if (relation === undefined) {
                 continue;
@@ -73557,7 +73918,6 @@ const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/c
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const objects_1 = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
 const expressions_1 = __webpack_require__(/*! ../cds/expressions */ "./node_modules/@abaplint/core/build/src/cds/expressions/index.js");
-const cds_name_1 = __webpack_require__(/*! ../cds/expressions/cds_name */ "./node_modules/@abaplint/core/build/src/cds/expressions/cds_name.js");
 class CDSNamingConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -73629,7 +73989,7 @@ https://help.sap.com/docs/SAP_S4HANA_ON-PREMISE/ee6ff9b281d8448f96b4fe6c89f2bdc8
         if (file === undefined) {
             return [];
         }
-        const name = this.getCDSName(tree);
+        const name = o.getDefinitionName();
         if (name === undefined) {
             return [];
         }
@@ -73646,13 +74006,6 @@ https://help.sap.com/docs/SAP_S4HANA_ON-PREMISE/ee6ff9b281d8448f96b4fe6c89f2bdc8
         }
         return [];
     }
-    getCDSName(tree) {
-        const nameNodes = tree.findDirectExpressions(cds_name_1.CDSName);
-        if (nameNodes.length > 0) {
-            return nameNodes[0].getFirstToken().getStr();
-        }
-        return undefined;
-    }
     getAllowedPrefixes(tree) {
         const root = tree.get();
         if (root instanceof expressions_1.CDSExtendView) {
@@ -75674,6 +76027,7 @@ class CloudTypes {
             || obj instanceof Objects.BehaviorDefinition
             || obj instanceof Objects.BusinessCatalog
             || obj instanceof Objects.BusinessCatalogAppAssignment
+            || obj instanceof Objects.BusinessConfigurationMaintenanceObject
             || obj instanceof Objects.CDSMetadataExtension
             || obj instanceof Objects.Class
             || obj instanceof Objects.CDSType
@@ -75690,11 +76044,13 @@ class CloudTypes {
             || obj instanceof Objects.EventBinding
             || obj instanceof Objects.EventConsumer
             || obj instanceof Objects.FunctionGroup
+            || obj instanceof Objects.GatewayODataGroupAndAssignment
             || obj instanceof Objects.HttpService
             || obj instanceof Objects.IAMApp
             || obj instanceof Objects.InboundService
             || obj instanceof Objects.Interface
             || obj instanceof Objects.LockObject
+            || obj instanceof Objects.MaintenanceAndTransportObject
             || obj instanceof Objects.MessageClass
             || obj instanceof Objects.NumberRange
             || obj instanceof Objects.OutboundService
@@ -84460,6 +84816,7 @@ __exportStar(__webpack_require__(/*! ./newline_between_methods */ "./node_module
 __exportStar(__webpack_require__(/*! ./no_aliases */ "./node_modules/@abaplint/core/build/src/rules/no_aliases.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_chained_assignment */ "./node_modules/@abaplint/core/build/src/rules/no_chained_assignment.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_comments_between_methods */ "./node_modules/@abaplint/core/build/src/rules/no_comments_between_methods.js"), exports);
+__exportStar(__webpack_require__(/*! ./no_dynamic_stuff */ "./node_modules/@abaplint/core/build/src/rules/no_dynamic_stuff.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_external_form_calls */ "./node_modules/@abaplint/core/build/src/rules/no_external_form_calls.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_inline_in_optional_branches */ "./node_modules/@abaplint/core/build/src/rules/no_inline_in_optional_branches.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_macros */ "./node_modules/@abaplint/core/build/src/rules/no_macros.js"), exports);
@@ -84539,6 +84896,7 @@ __exportStar(__webpack_require__(/*! ./when_others_last */ "./node_modules/@abap
 __exportStar(__webpack_require__(/*! ./whitespace_end */ "./node_modules/@abaplint/core/build/src/rules/whitespace_end.js"), exports);
 __exportStar(__webpack_require__(/*! ./xml_consistency */ "./node_modules/@abaplint/core/build/src/rules/xml_consistency.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_exclamation_escape */ "./node_modules/@abaplint/core/build/src/rules/no_exclamation_escape.js"), exports);
+__exportStar(__webpack_require__(/*! ./xml_bom */ "./node_modules/@abaplint/core/build/src/rules/xml_bom.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_exclamation_escape */ "./node_modules/@abaplint/core/build/src/rules/no_exclamation_escape.js"), exports);
 //# sourceMappingURL=index.js.map
 
@@ -88572,6 +88930,250 @@ exports.NoCommentsBetweenMethods = NoCommentsBetweenMethods;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/no_dynamic_stuff.js"
+/*!*************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/no_dynamic_stuff.js ***!
+  \*************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.NoDynamicStuff = exports.NoDynamicStuffConf = void 0;
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js"));
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+class NoDynamicStuffConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Detects dynamic method calls, ie. CALL METHOD (name), SET HANDLER and CALL BADI */
+        this.callMethod = true;
+        /** Detects dynamic CALL FUNCTION, ie. the function module name is not a literal */
+        this.callFunction = true;
+        /** Detects CALL DATABASE PROCEDURE, the procedure name is always dynamic */
+        this.callDatabaseProcedure = true;
+        /** Detects dynamic CALL TRANSFORMATION */
+        this.callTransformation = true;
+        /** Detects dynamic CALL TRANSACTION, ie. the transaction code is not a literal */
+        this.callTransaction = true;
+        /** Detects dynamic PERFORM */
+        this.perform = true;
+        /** Detects dynamic SUBMIT */
+        this.submit = true;
+        /** Detects dynamic CREATE OBJECT */
+        this.createObject = true;
+        /** Detects dynamic CREATE DATA */
+        this.createData = true;
+        /** Detects dynamic GET BADI */
+        this.getBadi = true;
+        /** Detects dynamic ASSIGN, including ASSIGN COMPONENT */
+        this.assign = true;
+        /** Detects dynamic internal table access, ie. dynamic WHERE, keys, SORT BY and TRANSPORTING */
+        this.internalTable = true;
+        /** Detects dynamic EXPORT and IMPORT */
+        this.exportImport = true;
+    }
+}
+exports.NoDynamicStuffConf = NoDynamicStuffConf;
+class NoDynamicStuff extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoDynamicStuffConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_dynamic_stuff",
+            title: "No dynamic stuff",
+            shortDescription: `Detects dynamic calls and other dynamic language constructs`,
+            extendedInformation: `Dynamic constructs cannot be checked statically, they are not found by
+where-used lists and refactorings, and they can introduce injection vulnerabilities.
+
+Dynamic tokens are also reported when containing a literal, eg. CALL METHOD go_calendar->('RESET_DAY_INFO'),
+the syntax check does not resolve these either, so they behave like any other dynamic token.
+
+Dynamic SQL is reported by rule dangerous_statement.`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
+            badExample: `CALL METHOD (lv_class)=>(lv_method).
+CALL METHOD go_calendar->('RESET_DAY_INFO').
+CALL FUNCTION lv_function_module.
+CREATE OBJECT ref TYPE (lv_class).
+ASSIGN (lv_name) TO <fs>.
+SORT tab BY (lv_field).`,
+            goodExample: `cl_class=>method( ).
+go_calendar->reset_day_info( ).
+CALL FUNCTION 'ZFOO'.
+CREATE OBJECT ref TYPE cl_class.
+ASSIGN foo TO <fs>.
+SORT tab BY field.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const statementNode of file.getStatements()) {
+            const found = this.check(statementNode);
+            if (found !== undefined) {
+                issues.push(issue_1.Issue.atStatement(file, statementNode, "Dynamic " + found, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+    check(node) {
+        const statement = node.get();
+        // note that MethodSource is also used by SET HANDLER and CALL BADI
+        if (this.conf.callMethod === true && this.dynamicMethodSource(node) === true) {
+            return "method call";
+        }
+        if (statement instanceof Statements.CallFunction) {
+            if (this.conf.callFunction === true
+                && this.notLiteral(node.findDirectExpression(Expressions.FunctionName))) {
+                return "CALL FUNCTION";
+            }
+        }
+        else if (statement instanceof Statements.CallDatabase) {
+            if (this.conf.callDatabaseProcedure === true) {
+                return "CALL DATABASE PROCEDURE";
+            }
+        }
+        else if (statement instanceof Statements.CallTransformation) {
+            if (this.conf.callTransformation === true && this.hasDynamic(node)) {
+                return "CALL TRANSFORMATION";
+            }
+        }
+        else if (statement instanceof Statements.CallTransaction) {
+            // the transaction code is a Source, ie. there is no parenthesized dynamic variant
+            if (this.conf.callTransaction === true
+                && this.notLiteral(node.findDirectExpression(Expressions.Source))) {
+                return "CALL TRANSACTION";
+            }
+        }
+        else if (statement instanceof Statements.Perform) {
+            if (this.conf.perform === true && this.hasDynamic(node)) {
+                return "PERFORM";
+            }
+        }
+        else if (statement instanceof Statements.Submit) {
+            if (this.conf.submit === true && this.hasDynamic(node)) {
+                return "SUBMIT";
+            }
+        }
+        else if (statement instanceof Statements.CreateObject) {
+            if (this.conf.createObject === true && this.hasDynamic(node)) {
+                return "CREATE OBJECT";
+            }
+        }
+        else if (statement instanceof Statements.CreateData) {
+            if (this.conf.createData === true && this.hasDynamic(node)) {
+                return "CREATE DATA";
+            }
+        }
+        else if (statement instanceof Statements.GetBadi) {
+            if (this.conf.getBadi === true && this.hasDynamic(node)) {
+                return "GET BADI";
+            }
+        }
+        else if (statement instanceof Statements.Assign
+            || statement instanceof Statements.AssignLocalCopy) {
+            if (this.conf.assign === true
+                && (this.hasDynamic(node) || this.dynamicAssignComponent(node))) {
+                return "ASSIGN";
+            }
+        }
+        else if (statement instanceof Statements.Export) {
+            if (this.conf.exportImport === true && this.hasDynamic(node)) {
+                return "EXPORT";
+            }
+        }
+        else if (statement instanceof Statements.Import) {
+            if (this.conf.exportImport === true && this.hasDynamic(node)) {
+                return "IMPORT";
+            }
+        }
+        else if (statement instanceof Statements.At
+            || statement instanceof Statements.DeleteInternal
+            || statement instanceof Statements.InsertInternal
+            || statement instanceof Statements.Loop
+            || statement instanceof Statements.ModifyInternal
+            || statement instanceof Statements.ReadTable
+            || statement instanceof Statements.Sort
+            || statement instanceof Statements.SortDataset) {
+            if (this.conf.internalTable === true && this.hasDynamic(node)) {
+                return "internal table access";
+            }
+        }
+        return undefined;
+    }
+    dynamicMethodSource(node) {
+        for (const source of node.findAllExpressions(Expressions.MethodSource)) {
+            // Dynamic is always a direct child of MethodSource, dynamics further down
+            // are parameters of the method call and not part of the method name
+            if (source.findDirectExpression(Expressions.Dynamic) !== undefined) {
+                return true;
+            }
+        }
+        return false;
+    }
+    dynamicAssignComponent(node) {
+        var _a;
+        const component = (_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findExpressionAfterToken("COMPONENT");
+        return component !== undefined && this.isLiteral(component) === false;
+    }
+    hasDynamic(node) {
+        return node.findFirstExpression(Expressions.Dynamic) !== undefined;
+    }
+    notLiteral(node) {
+        return node !== undefined && this.isLiteral(node) === false;
+    }
+    isLiteral(node) {
+        return node.findDirectExpression(Expressions.Constant) !== undefined;
+    }
+}
+exports.NoDynamicStuff = NoDynamicStuff;
+//# sourceMappingURL=no_dynamic_stuff.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/no_exclamation_escape.js"
 /*!******************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/no_exclamation_escape.js ***!
@@ -99765,6 +100367,64 @@ exports.WhitespaceEnd = WhitespaceEnd;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/xml_bom.js"
+/*!****************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/xml_bom.js ***!
+  \****************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.XMLBOM = exports.XMLBOMConf = void 0;
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+class XMLBOMConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.XMLBOMConf = XMLBOMConf;
+class XMLBOM {
+    constructor() {
+        this.conf = new XMLBOMConf();
+    }
+    getMetadata() {
+        return {
+            key: "xml_bom",
+            title: "XML UTF-8 byte order mark",
+            shortDescription: "Checks that XML files start with a UTF-8 byte order mark",
+            extendedInformation: "Checks that each XML file has a UTF-8 byte order mark (BOM) at its beginning.",
+            tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(_reg) {
+        return this;
+    }
+    run(obj) {
+        const file = obj.getXMLFile();
+        if (file === undefined || file.getRaw().startsWith("\uFEFF")) {
+            return [];
+        }
+        return [this.createIssue(file)];
+    }
+    createIssue(file) {
+        const start = new position_1.Position(1, 1);
+        const fix = edit_helper_1.EditHelper.insertAt(file, start, "\uFEFF");
+        return issue_1.Issue.atRange(file, start, start, "XML file must start with a UTF-8 byte order mark", this.getMetadata().key, this.conf.severity, fix);
+    }
+}
+exports.XMLBOM = XMLBOM;
+//# sourceMappingURL=xml_bom.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/xml_consistency.js"
 /*!************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/xml_consistency.js ***!
@@ -100497,6 +101157,10 @@ exports.DECLARATION_STUFF = [
     Statements.DataBegin,
     Statements.Constant,
     Statements.ConstantBegin,
+    Statements.Static,
+    Statements.StaticBegin,
+    Statements.FieldSymbol,
+    Statements.Ranges,
     Statements.Tables,
     Statements.Include, // this is not super correct, but anyhow
     Statements.Parameter,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.13.60",
+  "version": "2.13.61",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,7 +27,7 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.28",
+    "@abaplint/core": "^2.120.37",
     "@abaplint/transpiler": "^2.13.60",
     "@types/glob": "^8.1.0",
     "@types/node": "^24.13.3",