@abaplint/transpiler-cli 2.13.45 → 2.13.47

package/build/bundle.js

@@ -31845,6 +31845,10 @@ class InlineData {
     static runSyntax(node, input, type) {
         var _a;
         const token = (_a = node.findFirstExpression(Expressions.TargetField)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        if (token && token.getStr().length > 30) {
+            const message = "DATA name too long, " + token.getStr();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, message));
+        }
         if (token && type) {
             if (type instanceof basic_1.CSequenceType || type instanceof basic_1.CLikeType) {
                 type = basic_1.StringType.get();
@@ -32016,10 +32020,16 @@ const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expr
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "./node_modules/@abaplint/core/build/src/abap/types/_typed_identifier.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 const _reference_1 = __webpack_require__(/*! ../_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 class InlineFS {
     static runSyntax(node, input, type) {
         var _a;
         const token = (_a = node.findFirstExpression(Expressions.TargetFieldSymbol)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        const fs = node.findFirstExpression(Expressions.FieldSymbol);
+        if (fs && fs.concatTokens().length > 30) {
+            const message = "FIELD-SYMBOLS name too long, " + fs.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fs.getFirstToken(), message));
+        }
         if (token && type) {
             const identifier = new _typed_identifier_1.TypedIdentifier(token, input.filename, type, ["inline" /* IdentifierMeta.InlineDefinition */]);
             input.scope.addIdentifier(identifier);
@@ -37154,6 +37164,75 @@ exports.Assign = Assign;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/at_selection_screen.js"
+/*!***********************************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/at_selection_screen.js ***!
+  \***********************************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.AtSelectionScreen = void 0;
+const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const _reference_1 = __webpack_require__(/*! ../_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
+const source_field_1 = __webpack_require__(/*! ../expressions/source_field */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/source_field.js");
+class AtSelectionScreen {
+    runSyntax(node, input) {
+        // "AT SELECTION-SCREEN ON <field>", "ON VALUE-REQUEST FOR <field>",
+        // "ON HELP-REQUEST FOR <field>" and "ON END OF <field>" all reference
+        // a parameter or select-option, register these as read references so
+        // they are not reported as unused.
+        const fields = [
+            ...node.findDirectExpressions(Expressions.FieldSub),
+            ...node.findDirectExpressions(Expressions.Field),
+        ];
+        for (const field of fields) {
+            const token = field.getFirstToken();
+            if (input.scope.findVariable(token.getStr()) !== undefined) {
+                source_field_1.SourceField.runSyntax(field, input, _reference_1.ReferenceType.DataReadReference, false);
+            }
+        }
+    }
+}
+exports.AtSelectionScreen = AtSelectionScreen;
+//# sourceMappingURL=at_selection_screen.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/authority_check.js"
 /*!*******************************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/authority_check.js ***!
@@ -40341,14 +40420,19 @@ const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expr
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "./node_modules/@abaplint/core/build/src/abap/types/_typed_identifier.js");
 const basic_types_1 = __webpack_require__(/*! ../basic_types */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/basic_types.js");
 const unknown_type_1 = __webpack_require__(/*! ../../types/basic/unknown_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/unknown_type.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 class FieldSymbol {
     runSyntax(node, input) {
-        var _a;
-        const fsname = (_a = node.findFirstExpression(Expressions.FieldSymbol)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
-        if (fsname === undefined) {
+        const fs = node.findFirstExpression(Expressions.FieldSymbol);
+        const fsname = fs === null || fs === void 0 ? void 0 : fs.getFirstToken();
+        if (fs === undefined || fsname === undefined) {
             return;
         }
+        if (fs.concatTokens().length > 30) {
+            const message = "FIELD-SYMBOLS name too long, " + fs.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fsname, message));
+        }
         if (node.getChildren().length === 5) {
             // no type specified
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(fsname, input.filename, basic_1.VoidType.get("FS-SIMPLE")));
@@ -47751,6 +47835,7 @@ const if_1 = __webpack_require__(/*! ./statements/if */ "./node_modules/@abaplin
 const else_if_1 = __webpack_require__(/*! ./statements/else_if */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/else_if.js");
 const append_1 = __webpack_require__(/*! ./statements/append */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/append.js");
 const selection_screen_1 = __webpack_require__(/*! ./statements/selection_screen */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/selection_screen.js");
+const at_selection_screen_1 = __webpack_require__(/*! ./statements/at_selection_screen */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/at_selection_screen.js");
 const ranges_1 = __webpack_require__(/*! ./statements/ranges */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/ranges.js");
 const write_1 = __webpack_require__(/*! ./statements/write */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/write.js");
 const case_1 = __webpack_require__(/*! ./statements/case */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/case.js");
@@ -47958,6 +48043,7 @@ if (Object.keys(map).length === 0) {
     addToMap(new authority_check_1.AuthorityCheck());
     addToMap(new insert_report_1.InsertReport());
     addToMap(new selection_screen_1.SelectionScreen());
+    addToMap(new at_selection_screen_1.AtSelectionScreen());
     addToMap(new ranges_1.Ranges());
     addToMap(new add_1.Add());
     addToMap(new raise_event_1.RaiseEvent());
@@ -51657,6 +51743,7 @@ class ClassDefinition extends _identifier_1.Identifier {
             this.createVisibilityValue = visibility_1.Visibility.Public;
         }
         // perform checks after everything has been initialized
+        this.checkInterfaceVisibility(input, node);
         this.checkMethodsFromSuperClasses(input);
         this.checkMethodNameLength(input);
         this.checkClassConstructorStatic(input);
@@ -51730,6 +51817,17 @@ class ClassDefinition extends _identifier_1.Identifier {
             }
         }
     }
+    checkInterfaceVisibility(input, node) {
+        const sections = [
+            node.findDirectStructure(Structures.ProtectedSection),
+            node.findDirectStructure(Structures.PrivateSection),
+        ];
+        for (const section of sections) {
+            for (const statement of (section === null || section === void 0 ? void 0 : section.findAllStatements(Statements.InterfaceDef)) || []) {
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, statement.getFirstToken(), "INTERFACES can only be declared in public sections"));
+            }
+        }
+    }
     checkMethodsFromSuperClasses(input) {
         var _a;
         const scope = input.scope;
@@ -69492,7 +69590,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.5";
+        return "2.120.6";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -102092,7 +102190,7 @@ class ConstantTranspiler {
             str = node.findDirectExpression(core_1.Expressions.TextElementString);
         }
         if (str) {
-            let res = str.getFirstToken().getStr();
+            const res = str.getFirstToken().getStr();
             if (res.startsWith("'") && this.addGet === false) {
                 const code = this.handleCharacter(res);
                 return new chunk_1.Chunk().append(code, node, traversal);
@@ -102102,10 +102200,7 @@ class ConstantTranspiler {
                 return new chunk_1.Chunk().append(code, node, traversal);
             }
             else {
-                if (res.startsWith("'")) {
-                    res = "'" + res.substring(1, res.length - 1).trimEnd() + "'";
-                }
-                const code = ConstantTranspiler.escape(res);
+                const code = ConstantTranspiler.escape(ConstantTranspiler.trimTextFieldLiteral(res));
                 return new chunk_1.Chunk().append(code, node, traversal);
             }
         }
@@ -102146,6 +102241,13 @@ class ConstantTranspiler {
         //    const code = "new abap.types.Character(" + length + ").set(" + ConstantTranspiler.escape(res) + ")";
         return code;
     }
+    // text field literals are of type c, trailing blanks are not part of the value
+    static trimTextFieldLiteral(str) {
+        if (str.startsWith("'") && str.endsWith("'") && str.length >= 2) {
+            return "'" + str.substring(1, str.length - 1).trimEnd() + "'";
+        }
+        return str;
+    }
     static escape(str) {
         str = str.replace(/\\/g, "\\\\");
         if (str.startsWith("'")) {
@@ -110297,6 +110399,30 @@ const constant_1 = __webpack_require__(/*! ../expressions/constant */ "./node_mo
 const expressions_1 = __webpack_require__(/*! ../expressions */ "./node_modules/@abaplint/transpiler/build/src/expressions/index.js");
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
 class DataTranspiler {
+    skipLoopScoping;
+    variableName = "";
+    loopScoped = false;
+    constructor(options) {
+        this.skipLoopScoping = options?.skipLoopScoping === true;
+    }
+    /** name of the declared javascript variable, set by transpile() */
+    getVariableName() {
+        return this.variableName;
+    }
+    /** set by transpile(), true if the declaration is inside a loop */
+    isLoopScoped() {
+        return this.loopScoped;
+    }
+    /** DATA is scoped to the enclosing method/form/program, but when the statement is inside a
+     * loop the generated declaration ends up inside the javascript block of the loop. Declaring
+     * with "var" hoists it out of the block, and the guard makes sure its constructed only on the
+     * first pass, ie. contents are kept across iterations, matching ABAP */
+    static wrapLoopScoped(name, chunk) {
+        return new chunk_1.Chunk()
+            .appendString(`if (${name} === undefined) {\n`)
+            .appendChunk(chunk)
+            .appendString("\n}");
+    }
     transpile(node, traversal) {
         const token = node.findFirstExpression(abaplint.Expressions.DefinitionName)?.getFirstToken();
         if (token === undefined) {
@@ -110324,12 +110450,17 @@ class DataTranspiler {
                 value = "\n" + traversal_1.Traversal.prefixVariable(found.getName().toLowerCase()) + ".set(\"" + enumDefault + "\");";
             }
         }
+        this.variableName = traversal_1.Traversal.prefixVariable(traversal_1.Traversal.escapeNamespace(found.getName().toLowerCase()));
+        this.loopScoped = traversal.isInsideLoop(node);
         const ret = new chunk_1.Chunk()
-            .appendString("let ")
-            .appendString(traversal_1.Traversal.prefixVariable(traversal_1.Traversal.escapeNamespace(found.getName().toLowerCase())))
+            .appendString(this.loopScoped === true ? "var " : "let ")
+            .appendString(this.variableName)
             .appendString(" = " + transpile_types_1.TranspileTypes.toType(found.getType()))
             .appendString(";")
             .appendString(value);
+        if (this.loopScoped === true && this.skipLoopScoping === false) {
+            return DataTranspiler.wrapLoopScoped(this.variableName, ret);
+        }
         return ret;
     }
     static findEnumDefault(scope, _enumType) {
@@ -110361,7 +110492,7 @@ class DataTranspiler {
                 int = val.findFirstExpression(abaplint.Expressions.ConstantString);
             }
             if (int) {
-                const escaped = constant_1.ConstantTranspiler.escape(int.concatTokens());
+                const escaped = constant_1.ConstantTranspiler.escape(constant_1.ConstantTranspiler.trimTextFieldLiteral(int.concatTokens()));
                 value = "\n" + name + ".set(" + escaped + ");";
             }
             else if (val.getChildren()[1].get() instanceof abaplint.Expressions.SimpleFieldChain) {
@@ -117919,13 +118050,18 @@ class DataTranspiler {
             return new chunk_1.Chunk("");
         }
         const topName = begin.findDirectExpression(abaplint.Expressions.DefinitionName)?.concatTokens().toLowerCase();
-        const chunk = new statements_1.DataTranspiler().transpile(begin, traversal).ensureStartMapping(begin, traversal);
+        // the component values are part of the declaration, so they must stay inside the loop guard
+        const statement = new statements_1.DataTranspiler({ skipLoopScoping: true });
+        let chunk = statement.transpile(begin, traversal).ensureStartMapping(begin, traversal);
         for (const d of node.findDirectStatements(abaplint.Statements.Data)) {
             const subName = d.findFirstExpression(abaplint.Expressions.DefinitionName)?.concatTokens().toLowerCase();
             if (subName && topName) {
                 chunk.appendString(statements_1.DataTranspiler.buildValue(d, topName + ".get()." + subName, traversal));
             }
         }
+        if (statement.isLoopScoped() === true) {
+            chunk = statements_1.DataTranspiler.wrapLoopScoped(statement.getVariableName(), chunk);
+        }
         chunk.appendString("\n");
         return chunk;
     }
@@ -119789,10 +119925,15 @@ class Traversal {
     }
     buildThisAttributes(def, cName) {
         let ret = "";
+        const constants = def.getAttributes()?.getConstants() || [];
         for (const a of def.getAttributes()?.getAll() || []) {
             let escaped = Traversal.escapeNamespace(a.getName().toLowerCase());
             if (a.getMeta().includes("static" /* abaplint.IdentifierMeta.Static */) === true) {
                 ret += "this." + escaped + " = " + cName + "." + escaped + ";\n";
+                const isConstant = constants.some(c => c.getName().toUpperCase() === a.getName().toUpperCase());
+                if (a.getVisibility() === abaplint.Visibility.Private && isConstant === false) {
+                    ret += `this.FRIENDS_ACCESS_INSTANCE["${escaped}"] = this.${escaped};\n`;
+                }
             }
             else {
                 if (a.getVisibility() === abaplint.Visibility.Private) {
@@ -120144,7 +120285,7 @@ this.INTERNAL_ID = abap.internalIdCounter++;\n`;
         }
         const handle = (val, name) => {
             if (typeof val === "string") {
-                const e = expressions_1.ConstantTranspiler.escape(val);
+                const e = expressions_1.ConstantTranspiler.escape(expressions_1.ConstantTranspiler.trimTextFieldLiteral(val));
                 ret += name + ".set(" + e + ");\n";
             }
             else if (typeof val === "object") {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.13.45",
+  "version": "2.13.47",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,8 +27,8 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.5",
-    "@abaplint/transpiler": "^2.13.45",
+    "@abaplint/core": "^2.120.6",
+    "@abaplint/transpiler": "^2.13.47",
     "@types/glob": "^8.1.0",
     "@types/node": "^24.12.2",
     "@types/progress": "^2.0.7",