@abaplint/runtime 2.8.7 → 2.8.9

package/build/src/operators/_parse.js

@@ -15,6 +15,10 @@ function parse(val) {
             return parseInt(val, 10);
         }
     }
+    else if (val instanceof types_1.Integer) {
+        // optimize, as this is the most common case
+        return val.get();
+    }
     else if (val instanceof types_1.Float) {
         return val.getRaw();
     }

package/build/src/statements/set_bit.js

@@ -2,6 +2,9 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.setBit = void 0;
 function setBit(number, hex, val) {
+    if (number.get() <= 0) {
+        throw new Error("BIT_OFFSET_NOT_POSITIVE");
+    }
     let hexFull = hex.get();
     if (hexFull === "") {
         hexFull = "00";

package/build/src/types/field_symbol.d.ts

@@ -17,7 +17,7 @@ export declare class FieldSymbol {
     unassign(): void;
     isAssigned(): boolean;
     getPointer(): any;
-    dereference(): INumeric | ICharacter | Float | import("./integer8").Integer8 | ABAPObject | Table | Structure | undefined;
+    dereference(): INumeric | ICharacter | Float | import("packages/runtime/src/types").Integer8 | ABAPObject | Table | Structure | undefined;
     clear(): void | Structure | undefined;
     get(): any;
     appendInitial(): import("./table").TableRowType | undefined;

package/build/src/types/hex.js

@@ -94,6 +94,10 @@ class Hex {
             else {
                 offset = (0, _parse_1.parse)(offset);
             }
+            if (offset * 2 > this.value.length
+                || offset < 0) {
+                (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+            }
         }
         let length = input?.length;
         if (length) {
@@ -103,24 +107,27 @@ class Hex {
             else {
                 length = (0, _parse_1.parse)(length);
             }
+            if (length * 2 > this.value.length
+                || length < 0) {
+                (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+            }
+        }
+        // NOTE: this only copies the minimal length of the string,
+        if (offset !== undefined && length !== undefined) {
+            if (offset * 2 + length * 2 > this.value.length) {
+                (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+            }
+            return new xstring_1.XString().set(this.value.substr(offset * 2, length * 2));
         }
-        if ((offset && offset * 2 > this.value.length)
-            || (length && length * 2 > this.value.length)
-            || (offset && length && offset * 2 + length * 2 > this.value.length)
-            || (offset && offset < 0)
-            || (length && length < 0)) {
-            (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+        else if (offset !== undefined) {
+            return new xstring_1.XString().set(this.value.substr(offset * 2));
         }
-        let ret = this.value;
-        if (offset) {
-            ret = ret.substr(offset * 2);
+        else if (length !== undefined) {
+            return new xstring_1.XString().set(this.value.substr(0, length * 2));
         }
-        if (length !== undefined) {
-            ret = ret.substr(0, length * 2);
+        else {
+            throw new Error("hex: getOffset, unexpected");
         }
-        const r = new xstring_1.XString();
-        r.set(ret);
-        return r;
     }
 }
 exports.Hex = Hex;

package/build/src/types/xstring.js

@@ -61,6 +61,10 @@ class XString {
             else {
                 offset = (0, _parse_1.parse)(offset);
             }
+            if (offset * 2 > this.value.length
+                || offset < 0) {
+                (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+            }
         }
         let length = input?.length;
         if (length) {
@@ -70,26 +74,27 @@ class XString {
             else {
                 length = (0, _parse_1.parse)(length);
             }
+            if (length * 2 > this.value.length
+                || length < 0) {
+                (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+            }
+        }
+        // NOTE: this only copies the minimal length of the string,
+        if (offset !== undefined && length !== undefined) {
+            if (offset * 2 + length * 2 > this.value.length) {
+                (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+            }
+            return new XString().set(this.value.substr(offset * 2, length * 2));
         }
-        if ((offset && offset * 2 > this.value.length)
-            || (length && length * 2 > this.value.length)
-            || (offset && length && offset * 2 + length * 2 > this.value.length)
-            || (offset && offset < 0)
-            || (length && length < 0)) {
-            (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+        else if (offset !== undefined) {
+            return new XString().set(this.value.substr(offset * 2));
         }
-        let ret = this.value;
-        if (offset) {
-            // @ts-ignore
-            ret = ret.substr(offset * 2);
+        else if (length !== undefined) {
+            return new XString().set(this.value.substr(0, length * 2));
         }
-        if (length !== undefined) {
-            // @ts-ignore
-            ret = ret.substr(0, length * 2);
+        else {
+            throw new Error("xstring: getOffset, unexpected");
         }
-        const r = new XString();
-        r.set(ret);
-        return r;
     }
 }
 exports.XString = XString;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/runtime",
-  "version": "2.8.7",
+  "version": "2.8.9",
   "description": "Transpiler - Runtime",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
@@ -34,7 +34,7 @@
     "chai": "^4.4.1",
     "mocha": "^10.3.0",
     "source-map-support": "^0.5.21",
-    "typescript": "^5.3.3"
+    "typescript": "^5.4.2"
   },
   "dependencies": {
     "temporal-polyfill": "^0.2.3"