@abaplint/runtime 2.8.15 → 2.8.17

package/build/src/compare/eq.js

@@ -4,6 +4,7 @@ exports.eq = void 0;
 /* eslint-disable max-len */
 const types_1 = require("../types");
 const _parse_1 = require("../operators/_parse");
+const initial_1 = require("./initial");
 function compareTables(left, right) {
     const leftArray = left.array();
     const rightArray = right.array();
@@ -106,10 +107,37 @@ function eq(left, right) {
             return false;
         }
     }
-    else if (right instanceof types_1.Hex || right instanceof types_1.HexUInt8 || right instanceof types_1.XString) {
-        if (left instanceof types_1.Hex || left instanceof types_1.XString || left instanceof types_1.HexUInt8) {
+    else if (right instanceof types_1.Hex || right instanceof types_1.XString || right instanceof types_1.HexUInt8) {
+        if (left instanceof types_1.Hex || left instanceof types_1.HexUInt8) {
+            // @ts-ignore
+            if (right.getLength && right.getLength() !== left.getLength()) {
+                return (0, initial_1.initial)(left) && (0, initial_1.initial)(right);
+            }
+            return right.get() === left.get();
+        }
+        else if (left instanceof types_1.XString) {
             return right.get() === left.get();
         }
+        /*
+      } else if (right instanceof HexUInt8) {
+        if (left instanceof XString) {
+          return right.get() === left.get();
+        } else if (left instanceof HexUInt8) {
+    // https://stackoverflow.com/questions/21553528/how-to-test-for-equality-in-arraybuffer-dataview-and-typedarray
+          const llen = left.getLength();
+          if (llen === right.getLength()) {
+    // todo: this can be optimized by creating multi byte views?
+    //       new DataView(this.value.buffer).setInt32(0, 0, true);
+            for (let i = 0; i < llen; i++) {
+              if (right.getOffsetRaw(i) !== left.getOffsetRaw(i)) {
+                return false;
+              }
+            }
+          } else {
+            return initial(left) && initial(right);
+          }
+        }
+        */
     }
     else if (right instanceof types_1.ABAPObject) {
         if (left instanceof types_1.ABAPObject) {

package/build/src/statements/concatenate.js

@@ -50,7 +50,7 @@ function concatenate(input) {
             }
             result += val + sep;
         }
-        if (result.length > 0) {
+        if (sep.length > 0 && result.length > 0) {
             result = result.slice(0, result.length - sep.length);
         }
         input.target.set(result);

package/build/src/types/hex.js

@@ -53,6 +53,9 @@ class Hex {
             }
             return this.set(hex);
         }
+        else if (value instanceof Hex || value instanceof xstring_1.XString) {
+            this.value = value.get();
+        }
         else {
             const v = value.get();
             if (value instanceof float_1.Float) {

package/build/src/types/hex_uint8.js

@@ -1,12 +1,18 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.HexUInt8 = void 0;
+/* eslint-disable no-bitwise */
 const _parse_1 = require("../operators/_parse");
 const float_1 = require("./float");
 const xstring_1 = require("./xstring");
 const throw_error_1 = require("../throw_error");
 const integer8_1 = require("./integer8");
 const REGEXP = /^(?![A-F0-9])/;
+const LUT_HEX_4b = ["0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "A", "B", "C", "D", "E", "F"];
+const LUT_HEX_8b = new Array(0x100);
+for (let n = 0; n < 0x100; n++) {
+    LUT_HEX_8b[n] = `${LUT_HEX_4b[(n >>> 4) & 0xF]}${LUT_HEX_4b[n & 0xF]}`;
+}
 class HexUInt8 {
     constructor(input) {
         this.length = input?.length ? input?.length : 1;
@@ -65,6 +71,12 @@ class HexUInt8 {
                 hexString = hexString.padStart(this.length * 2, "0");
             }
         }
+        else if (value instanceof HexUInt8 || value instanceof xstring_1.XString) {
+            hexString = value.get();
+            if (hexString.length < this.length * 2) {
+                hexString = hexString.padEnd(this.length * 2, "0");
+            }
+        }
         else {
             const v = value.get();
             if (value instanceof float_1.Float) {
@@ -99,7 +111,13 @@ class HexUInt8 {
         }
     }
     get() {
-        return Buffer.from(this.value).toString("hex").toUpperCase();
+        //    return Buffer.from(this.value).toString("hex").toUpperCase();
+        let out = "";
+        // eslint-disable-next-line @typescript-eslint/prefer-for-of
+        for (let idx = 0; idx < this.value.length; idx++) {
+            out += LUT_HEX_8b[this.value[idx]];
+        }
+        return out;
     }
     getOffset(input) {
         let offset = input?.offset;
@@ -143,8 +161,13 @@ class HexUInt8 {
             console.dir(this.value.subarray(offset, length ? offset + length : undefined));
             console.dir(Buffer.from(this.value.subarray(offset, length ? offset + length : undefined)));
         */
-        const str = Buffer.from(this.value.subarray(offset, length ? offset + length : undefined)).toString("hex")
-            .toUpperCase();
+        //    const str = Buffer.from(this.value.subarray(offset, length ? offset + length : undefined)).toString("hex").toUpperCase();
+        let str = "";
+        const until = length ? offset + length : this.value.length;
+        // eslint-disable-next-line @typescript-eslint/prefer-for-of
+        for (let idx = offset; idx < until; idx++) {
+            str += LUT_HEX_8b[this.value[idx]];
+        }
         return new xstring_1.XString().set(str);
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/runtime",
-  "version": "2.8.15",
+  "version": "2.8.17",
   "description": "Transpiler - Runtime",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",