@abaplint/runtime 2.13.92 → 2.13.94

package/build/src/template_formatting.js

@@ -3,6 +3,17 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.templateFormatting = templateFormatting;
 const alpha_1 = require("./alpha");
 const types_1 = require("./types");
+/** DECIMALS for a decimal number: its decimal digits are rounded, half away
+ * from zero, the way ABAP rounds commercially - 2.675 gives 2.68, where
+ * toFixed( ) on the nearest binary float gives 2.67 */
+function decimalsOfDecimal(value, decimals) {
+    const shift = (x, places) => {
+        const [mantissa, exponent] = (x + "").split("e");
+        return Number(mantissa + "e" + (Number(exponent || 0) + places));
+    };
+    const rounded = shift(Math.round(shift(Math.abs(value), decimals)), -decimals);
+    return (value < 0 && rounded !== 0 ? "-" : "") + rounded.toFixed(decimals);
+}
 function templateFormatting(source, options) {
     let text = "";
     if (source instanceof types_1.FieldSymbol) {
@@ -22,7 +33,10 @@ function templateFormatting(source, options) {
     }
     else if (source instanceof types_1.DecFloat34) {
         const raw = source.getRaw();
-        if (Number.isInteger(raw)) {
+        if (options?.decimals !== undefined) {
+            text = decimalsOfDecimal(raw, options.decimals);
+        }
+        else if (Number.isInteger(raw)) {
             text = raw.toFixed(0);
         }
         else {
@@ -43,7 +57,7 @@ function templateFormatting(source, options) {
         }
     }
     else if (source instanceof types_1.Packed) {
-        if (options?.decimals) {
+        if (options?.decimals !== undefined) {
             text = source.toFixed(options.decimals);
         }
         else {
@@ -127,10 +141,10 @@ function templateFormatting(source, options) {
         else if (options.width) {
             text = text.trimEnd().padEnd(options.width, " ");
         }
-        else if (options.decimals && source instanceof types_1.Integer) {
+        else if (options.decimals !== undefined && source instanceof types_1.Integer) {
             text = source.get().toFixed(options.decimals);
         }
-        else if (options.decimals && source instanceof types_1.Float) {
+        else if (options.decimals !== undefined && source instanceof types_1.Float) {
             text = source.getRaw().toFixed(options.decimals);
         }
     }

package/build/src/types/date.js

@@ -32,7 +32,13 @@ class Date {
         else if (value instanceof float_1.Float) {
             this.set(Math.round(value.getRaw()));
         }
+        else if (value instanceof string_1.String) {
+            // an empty string is the initial date, a shorter one is filled with blanks
+            const str = value.get();
+            this.value = str === "" ? "00000000" : str;
+        }
         else if (typeof value === "string") {
+            // raw character results, eg. from CONCATENATE, are filled with blanks
             this.value = value;
         }
         else {

package/build/src/types/hex.js

@@ -6,7 +6,7 @@ const float_1 = require("./float");
 const xstring_1 = require("./xstring");
 const throw_error_1 = require("../throw_error");
 const integer8_1 = require("./integer8");
-const REGEXP = /^(?![A-F0-9])/;
+const HEX_PREFIX = /^[A-F0-9]*/;
 class Hex {
     value;
     length;
@@ -73,9 +73,12 @@ class Hex {
                 return this.set(v);
             }
             else {
-                this.value = v;
-                if (this.value.match(REGEXP)) {
-                    this.value = "";
+                // c -> x: the leading hexadecimal digits, upper case only, and a
+                // trailing half byte padded with 0; the first other character ends
+                // the conversion, so "ABG1" is AB, "0a1B" is 00
+                this.value = HEX_PREFIX.exec(v)[0];
+                if (this.value.length % 2 === 1) {
+                    this.value += "0";
                 }
             }
         }

package/build/src/types/integer.js

@@ -93,14 +93,11 @@ class Integer {
             this.set(roundHalfAwayFromZero(value.getRaw()));
         }
         else if (value instanceof hex_1.Hex || value instanceof xstring_1.XString || value instanceof hex_uint8_1.HexUInt8) {
-            const hex = value.get();
-            let num = parseInt(hex, 16);
-            // handle two complement, the first bit is the sign
-            if (hex.length >= 8) {
-                const maxVal = Math.pow(2, hex.length / 2 * 8);
-                if (num > maxVal / 2 - 1) {
-                    num = num - maxVal;
-                }
+            // the last four bytes, 00 on the left, as a signed integer; an empty xstring is 0
+            const hex = value.get().slice(-8);
+            let num = hex === "" ? 0 : parseInt(hex, 16);
+            if (hex.length === 8 && num > 0x7FFFFFFF) {
+                num = num - 0x100000000;
             }
             this.set(num);
         }

package/build/src/types/table.js

@@ -550,8 +550,18 @@ class Table {
             return val;
         }
     }
-    /* appends and returns this */
+    /* appends and returns this - how VALUE #( ) builds a table, row by row.
+     * A sorted table gets each row at its sorted place, as INSERT ... INTO
+     * TABLE puts it: pushed, it was in insertion order until something
+     * assigned it, so a VALUE #( ) handed straight to a method or looped over
+     * was a SORTED table unsorted, and every binary search on it could miss.
+     * A duplicate of a unique key is kept, as before */
     appendThis(item) {
+        const primary = this.getOptions()?.primaryKey;
+        if (primary?.type === TableAccessType.sorted && !(item instanceof data_reference_1.DataReference)) {
+            this.insertSorted(item, (a, b) => (0, sort_1.compareRows)(a, b, primary.keyFields), false);
+            return this;
+        }
         this.append(item);
         return this;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/runtime",
-  "version": "2.13.92",
+  "version": "2.13.94",
   "description": "Transpiler - Runtime",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",