@abaplint/runtime 2.13.91 → 2.13.92

package/build/src/operators/div.js

@@ -16,14 +16,13 @@ function div(left, right) {
                 (0, throw_error_1.throwError)("CX_SY_ZERODIVIDE");
             }
         }
+        // DIV leaves a remainder that is never negative, 0 <= l - r * div < |r|,
+        // so a truncated quotient moves down for a positive divisor and up for
+        // a negative one: 7 DIV -2 = -3, -7 DIV -2 = 4
         const remainder = l % r;
         let div = l / r;
-        if (remainder !== 0n) {
-            const sign1 = l < 0n;
-            const sign2 = r < 0n;
-            if (sign1 !== sign2) {
-                div = div - 1n;
-            }
+        if (remainder < 0n) {
+            div = r > 0n ? div - 1n : div + 1n;
         }
         return new types_1.Integer8().set(div);
     }
@@ -38,7 +37,9 @@ function div(left, right) {
         }
     }
     else {
-        return new types_1.Integer().set(Math.floor(l / r));
+        // floor only for a positive divisor; for a negative one the quotient
+        // rounds up, so that the remainder a - b * ( a DIV b ) is not negative
+        return new types_1.Integer().set(r > 0 ? Math.floor(l / r) : -Math.floor(l / -r));
     }
 }
 //# sourceMappingURL=div.js.map

package/build/src/operators/mod.js

@@ -16,9 +16,12 @@ function mod(left, right) {
                 (0, throw_error_1.throwError)("CX_SY_ZERODIVIDE");
             }
         }
-        let val = ((l % r) + r) % r;
-        if (val < 0) {
-            val = val * -1n;
+        // the remainder is never negative and below |r|, whatever the signs:
+        // 7 MOD -3 = 1, -7 MOD -3 = 2
+        const a = r < 0n ? -r : r;
+        let val = l % a;
+        if (val < 0n) {
+            val = val + a;
         }
         return new types_1.Integer8().set(val);
     }
@@ -32,9 +35,14 @@ function mod(left, right) {
             (0, throw_error_1.throwError)("CX_SY_ZERODIVIDE");
         }
     }
-    let val = ((l % r) + r) % r;
-    if (val < 0) {
-        val = val * -1;
+    // a MOD r = a - r * ( a DIV r ), with the quotient rule of DIV:
+    // 7 MOD -3 = 1, -7 MOD -3 = 2, 7.5 MOD -2 = 1.5. For f this is also what a
+    // system computes in double precision, 0.5 MOD 0.1 = 0 there, where a
+    // remainder by % gives 0.09999999999999998
+    const q = r > 0 ? Math.floor(l / r) : -Math.floor(l / -r);
+    let val = l - r * q;
+    if (val === 0) {
+        val = 0; // not -0
     }
     // the calculation type of the operands decides: with a float operand the
     // remainder is a float, 2.75 MOD 1 is 0.75 and not 1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/runtime",
-  "version": "2.13.91",
+  "version": "2.13.92",
   "description": "Transpiler - Runtime",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",