@abaplint/runtime 2.13.86 → 2.13.88

package/build/src/builtin/_position.d.ts

@@ -0,0 +1,12 @@
+import { ICharacter } from "../types/_character";
+import { INumeric } from "../types/_numeric";
+/** Reads an offset, length or occurrence argument as a number.
+ *
+ * parse() rather than get(): INumeric.get() promises a number, but Float and DecFloat34
+ * hand out their ABAP display form instead, ie. "1,2000000000000000E+01". Reading that
+ * back as a position keeps only the leading digit of the mantissa, so a length of 12
+ * silently becomes 1. nmin( ) and nmax( ) return a Float, and the syntax check lets them
+ * through where it rejects a declared TYPE f, so they are the way a float gets here.
+ *
+ * Rounded because ABAP converts the argument to type i, the same as assigning to one. */
+export declare function position(input: INumeric | ICharacter | string | number | undefined): number | undefined;

package/build/src/builtin/_position.js

@@ -0,0 +1,20 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.position = position;
+const _parse_1 = require("../operators/_parse");
+/** Reads an offset, length or occurrence argument as a number.
+ *
+ * parse() rather than get(): INumeric.get() promises a number, but Float and DecFloat34
+ * hand out their ABAP display form instead, ie. "1,2000000000000000E+01". Reading that
+ * back as a position keeps only the leading digit of the mantissa, so a length of 12
+ * silently becomes 1. nmin( ) and nmax( ) return a Float, and the syntax check lets them
+ * through where it rejects a declared TYPE f, so they are the way a float gets here.
+ *
+ * Rounded because ABAP converts the argument to type i, the same as assigning to one. */
+function position(input) {
+    if (input === undefined) {
+        return undefined;
+    }
+    return Math.round((0, _parse_1.parse)(input));
+}
+//# sourceMappingURL=_position.js.map

package/build/src/builtin/contains_any_not_of.d.ts

@@ -0,0 +1,10 @@
+import { String } from "../types";
+import { ICharacter } from "../types/_character";
+import { INumeric } from "../types/_numeric";
+export interface IContainsAnyNotOfInput {
+    val: ICharacter | string;
+    sub: ICharacter | string;
+    off?: INumeric | number;
+    len?: INumeric | number;
+}
+export declare function contains_any_not_of(input: IContainsAnyNotOfInput): String;

package/build/src/builtin/contains_any_not_of.js

@@ -0,0 +1,28 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.contains_any_not_of = contains_any_not_of;
+const types_1 = require("../types");
+const throw_error_1 = require("../throw_error");
+function contains_any_not_of(input) {
+    const val = typeof input.val === "string" ? input.val : input.val.get();
+    const sub = typeof input.sub === "string" ? input.sub : input.sub.get();
+    const off = typeof input.off === "number" ? input.off : input.off?.get() || 0;
+    const len = typeof input.len === "number" ? input.len : input.len?.get();
+    if (off < 0 || off > val.length) {
+        (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+    }
+    if (len !== undefined && (len < 0 || off + len > val.length)) {
+        (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+    }
+    const end = len === undefined ? val.length : off + len;
+    const characters = new Set(sub.split(""));
+    let found = false;
+    for (let i = off; i < end; i++) {
+        if (!characters.has(val.charAt(i))) {
+            found = true;
+            break;
+        }
+    }
+    return new types_1.String().set(found ? "X" : " ");
+}
+//# sourceMappingURL=contains_any_not_of.js.map

package/build/src/builtin/contains_any_of.d.ts

@@ -0,0 +1,10 @@
+import { String } from "../types";
+import { ICharacter } from "../types/_character";
+import { INumeric } from "../types/_numeric";
+export interface IContainsAnyOfInput {
+    val: ICharacter | string;
+    sub: ICharacter | string;
+    off?: INumeric | number;
+    len?: INumeric | number;
+}
+export declare function contains_any_of(input: IContainsAnyOfInput): String;

package/build/src/builtin/contains_any_of.js

@@ -0,0 +1,28 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.contains_any_of = contains_any_of;
+const types_1 = require("../types");
+const throw_error_1 = require("../throw_error");
+function contains_any_of(input) {
+    const val = typeof input.val === "string" ? input.val : input.val.get();
+    const sub = typeof input.sub === "string" ? input.sub : input.sub.get();
+    const off = typeof input.off === "number" ? input.off : input.off?.get() || 0;
+    const len = typeof input.len === "number" ? input.len : input.len?.get();
+    if (off < 0 || off > val.length) {
+        (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+    }
+    if (len !== undefined && (len < 0 || off + len > val.length)) {
+        (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
+    }
+    const end = len === undefined ? val.length : off + len;
+    const characters = new Set(sub.split(""));
+    let found = false;
+    for (let i = off; i < end; i++) {
+        if (characters.has(val.charAt(i))) {
+            found = true;
+            break;
+        }
+    }
+    return new types_1.String().set(found ? "X" : " ");
+}
+//# sourceMappingURL=contains_any_of.js.map

package/build/src/builtin/count.js

@@ -4,15 +4,16 @@ exports.count = count;
 const abap_regex_1 = require("../abap_regex");
 const compare_1 = require("../compare");
 const types_1 = require("../types");
+const _position_1 = require("./_position");
 function count(input) {
     let found = 0;
     let val = input.val.get();
-    if (input.off) {
-        const off = input.off.get();
+    const off = (0, _position_1.position)(input.off);
+    if (off !== undefined) {
         val = val.substring(off);
     }
-    if (input.len) {
-        const len = input.len.get();
+    const len = (0, _position_1.position)(input.len);
+    if (len !== undefined) {
         val = val.substring(0, len);
     }
     let reg = "";

package/build/src/builtin/escape.js

@@ -2,9 +2,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.escape = escape;
 const types_1 = require("../types");
+const _position_1 = require("./_position");
 function escape(input) {
     let val = typeof input.val === "string" ? input.val : input.val.get();
-    const format = typeof input.format === "number" ? input.format : input.format.get();
+    const format = (0, _position_1.position)(input.format);
     // todo, optimize/cache regexes
     switch (format) {
         case 1: // e_xml_attr

package/build/src/builtin/find.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.find = find;
 const throw_error_1 = require("../throw_error");
 const types_1 = require("../types");
+const _position_1 = require("./_position");
 function find(input) {
     let val = typeof input.val === "string" ? input.val : input.val.get();
     if (input.len !== undefined) {
@@ -32,8 +33,8 @@ function find(input) {
     }
     else {
         const sub = typeof input.sub === "string" ? input.sub : input.sub?.get();
-        let off = typeof input.off === "number" ? input.off : input.off?.get() || 0;
-        let occ = typeof input.occ === "number" ? input.occ : input.occ?.get();
+        let off = (0, _position_1.position)(input.off) || 0;
+        let occ = (0, _position_1.position)(input.occ);
         if (occ === 0) {
             (0, throw_error_1.throwError)("CX_SY_STRG_PAR_VAL");
         }

package/build/src/builtin/find_any_not_of.js

@@ -3,12 +3,13 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.find_any_not_of = find_any_not_of;
 const types_1 = require("../types");
 const throw_error_1 = require("../throw_error");
+const _position_1 = require("./_position");
 function find_any_not_of(input) {
     const val = typeof input.val === "string" ? input.val : input.val.get();
     const sub = typeof input.sub === "string" ? input.sub : input.sub.get();
-    const off = typeof input.off === "number" ? input.off : input.off?.get() || 0;
-    const len = typeof input.len === "number" ? input.len : input.len?.get();
-    let occ = typeof input.occ === "number" ? input.occ : input.occ?.get();
+    const off = (0, _position_1.position)(input.off) || 0;
+    const len = (0, _position_1.position)(input.len);
+    let occ = (0, _position_1.position)(input.occ);
     if (occ === 0) {
         (0, throw_error_1.throwError)("CX_SY_STRG_PAR_VAL");
     }

package/build/src/builtin/find_any_of.js

@@ -3,12 +3,13 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.find_any_of = find_any_of;
 const types_1 = require("../types");
 const throw_error_1 = require("../throw_error");
+const _position_1 = require("./_position");
 function find_any_of(input) {
     const val = typeof input.val === "string" ? input.val : input.val.get();
     const sub = typeof input.sub === "string" ? input.sub : input.sub.get();
-    const off = typeof input.off === "number" ? input.off : input.off?.get() || 0;
-    const len = typeof input.len === "number" ? input.len : input.len?.get();
-    let occ = typeof input.occ === "number" ? input.occ : input.occ?.get();
+    const off = (0, _position_1.position)(input.off) || 0;
+    const len = (0, _position_1.position)(input.len);
+    let occ = (0, _position_1.position)(input.occ);
     if (occ === 0) {
         (0, throw_error_1.throwError)("CX_SY_STRG_PAR_VAL");
     }

package/build/src/builtin/index.d.ts

@@ -8,6 +8,8 @@ export * from "./ceil";
 export * from "./concat_lines_of";
 export * from "./condense";
 export * from "./contains";
+export * from "./contains_any_not_of";
+export * from "./contains_any_of";
 export * from "./cos";
 export * from "./cosh";
 export * from "./count_any_of";

package/build/src/builtin/index.js

@@ -25,6 +25,8 @@ __exportStar(require("./ceil"), exports);
 __exportStar(require("./concat_lines_of"), exports);
 __exportStar(require("./condense"), exports);
 __exportStar(require("./contains"), exports);
+__exportStar(require("./contains_any_not_of"), exports);
+__exportStar(require("./contains_any_of"), exports);
 __exportStar(require("./cos"), exports);
 __exportStar(require("./cosh"), exports);
 __exportStar(require("./count_any_of"), exports);

package/build/src/builtin/insert.js

@@ -2,10 +2,11 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.insert = insert;
 const types_1 = require("../types");
+const _position_1 = require("./_position");
 function insert(input) {
-    let offset = 0;
-    if (input.off) {
-        offset = input.off.get();
+    let offset = (0, _position_1.position)(input.off);
+    if (offset === undefined) {
+        offset = 0;
     }
     const value = input.val.getOffset({ offset: 0, length: offset }).get() +
         input.sub.get() +

package/build/src/builtin/repeat.js

@@ -2,8 +2,9 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.repeat = repeat;
 const string_1 = require("../types/string");
+const _position_1 = require("./_position");
 function repeat(input) {
     const val = typeof input.val === "string" ? input.val : input.val.get();
-    return new string_1.String().set(val.repeat(input.occ.get()));
+    return new string_1.String().set(val.repeat((0, _position_1.position)(input.occ)));
 }
 //# sourceMappingURL=repeat.js.map

package/build/src/builtin/replace.js

@@ -4,6 +4,7 @@ exports.replace = replace;
 const string_1 = require("../types/string");
 const abap_regex_1 = require("../abap_regex");
 const types_1 = require("../types");
+const _position_1 = require("./_position");
 function dereference(input) {
     if (input instanceof types_1.FieldSymbol) {
         const pointer = input.getPointer();
@@ -58,14 +59,12 @@ function replace(input) {
     else if (regexInput) {
         sub = new RegExp(abap_regex_1.ABAPRegExp.convert(regexInput.get()), "g");
     }
-    if (input.off && input.len && typeof source === "string") {
-        const offset = input.off.get();
-        const length = input.len.get();
+    const offset = (0, _position_1.position)(input.off);
+    const length = (0, _position_1.position)(input.len);
+    if (offset !== undefined && length !== undefined && typeof source === "string") {
         val = val.substring(0, offset) + wi + val.substring(offset + length);
     }
-    else if (input.off && input.len && !(typeof source === "string")) {
-        const offset = input.off.get();
-        const length = input.len.get();
+    else if (offset !== undefined && length !== undefined && !(typeof source === "string")) {
         val = source.getOffset({ offset: 0, length: offset }).get() +
             wi +
             source.getOffset({ offset: offset + length }).get();
@@ -76,7 +75,7 @@ function replace(input) {
         }
         val = val.replace(sub, wi);
     }
-    else if (input.occ && input.occ.get() === 0 && sub && wi !== undefined) {
+    else if (input.occ && (0, _position_1.position)(input.occ) === 0 && sub && wi !== undefined) {
         if (typeof sub === "string") {
             sub = new RegExp(sub, "g");
         }

package/build/src/builtin/segment.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.segment = segment;
 const throw_error_1 = require("../throw_error");
 const types_1 = require("../types");
+const _position_1 = require("./_position");
 function segment(input) {
     let val = input.val;
     if (typeof val !== "string") {
@@ -12,10 +13,7 @@ function segment(input) {
     if (typeof sep !== "string") {
         sep = sep.get();
     }
-    let index = input.index;
-    if (typeof index !== "number") {
-        index = index.get();
-    }
+    let index = (0, _position_1.position)(input.index);
     if (index === 0 || sep.length === 0) {
         (0, throw_error_1.throwError)("CX_SY_STRG_PAR_VAL");
     }

package/build/src/builtin/shift_left.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.shift_left = shift_left;
 const string_1 = require("../types/string");
 const throw_error_1 = require("../throw_error");
+const _position_1 = require("./_position");
 function shift_left(input) {
     let val = typeof input.val === "string" ? input.val : input.val.get();
     if (input.sub) {
@@ -12,17 +13,14 @@ function shift_left(input) {
         }
     }
     else if (input.places) {
-        let places = typeof input.places === "string" ? input.places : input.places.get();
-        if (typeof places === "string") {
-            places = parseInt(places, 10);
-        }
+        const places = (0, _position_1.position)(input.places);
         if (places > val.length) {
             (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
         }
         val = val.substring(places);
     }
     else if (input.circular) {
-        const leftShifts = input.circular.get() % val.length;
+        const leftShifts = (0, _position_1.position)(input.circular) % val.length;
         val = val.slice(leftShifts) + val.slice(0, leftShifts);
     }
     else {

package/build/src/builtin/substring.js

@@ -3,15 +3,16 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.substring = substring;
 const string_1 = require("../types/string");
 const throw_error_1 = require("../throw_error");
+const _position_1 = require("./_position");
 function substring(input) {
-    let off = input?.off?.get();
+    let off = (0, _position_1.position)(input?.off);
     if (off === undefined) {
         off = 0;
     }
     else if (off < 0) {
         (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
     }
-    const len = input?.len?.get();
+    const len = (0, _position_1.position)(input?.len);
     if (len && len < 0) {
         (0, throw_error_1.throwError)("CX_SY_RANGE_OUT_OF_BOUNDS");
     }

package/build/src/compare/gt.js

@@ -93,21 +93,14 @@ function gt(left, right) {
     else {
         r = right.get();
     }
+    // a character operand is converted to the type of the numeric one it is
+    // compared with: '0.5' against a float is 0.5, not 0. parse() knows the
+    // rules, and an empty string is 0 there too
     if (typeof l === "string" && typeof r === "number") {
-        if (l === "") {
-            l = 0;
-        }
-        else {
-            l = parseInt(l, 10);
-        }
+        l = (0, _parse_1.parse)(l);
     }
     else if (typeof l === "number" && typeof r === "string") {
-        if (r === "") {
-            r = 0;
-        }
-        else {
-            r = parseInt(r, 10);
-        }
+        r = (0, _parse_1.parse)(r);
     }
     if (l === undefined) {
         return true; // todo, not sure this is correct

package/build/src/operators/add.js

@@ -11,6 +11,14 @@ function add(left, right) {
     if (left instanceof types_1.Integer && right instanceof types_1.Integer) {
         return new types_1.Integer().set(left.get() + right.get());
     }
+    else if (left instanceof types_1.Float && right instanceof types_1.Float) {
+        // Two floats fall through the rest of the chain to exactly this, and
+        // float arithmetic is the most common thing there is: the remaining type
+        // tests all fail, and then parse() is called on each operand, which for a
+        // Float is getRaw(). It sits after the integer branch on purpose, so that
+        // integer arithmetic pays nothing for it.
+        return new types_1.Float().set(left.getRaw() + right.getRaw());
+    }
     else if (typeof left === "number" && typeof right === "number"
         && Number.isInteger(left) && Number.isInteger(right)) {
         return new types_1.Integer().set(left + right);

package/build/src/operators/minus.js

@@ -20,6 +20,14 @@ function minus(left, right) {
     if (left instanceof types_1.Integer && right instanceof types_1.Integer) {
         return new types_1.Integer().set(left.get() - right.get());
     }
+    else if (left instanceof types_1.Float && right instanceof types_1.Float) {
+        // Two floats fall through the rest of the chain to exactly this, and
+        // float arithmetic is the most common thing there is: the remaining type
+        // tests all fail, and then parse() is called on each operand, which for a
+        // Float is getRaw(). It sits after the integer branch on purpose, so that
+        // integer arithmetic pays nothing for it.
+        return new types_1.Float().set(left.getRaw() - right.getRaw());
+    }
     else if (left instanceof types_1.Integer8 || right instanceof types_1.Integer8) {
         const l = left instanceof types_1.Integer8 ? left.get() : BigInt((0, _parse_1.parse)(left));
         const r = right instanceof types_1.Integer8 ? right.get() : BigInt((0, _parse_1.parse)(right));

package/build/src/operators/mod.d.ts

@@ -1,4 +1,4 @@
-import { Integer, Integer8 } from "../types";
+import { Float, Integer, Integer8 } from "../types";
 import { ICharacter } from "../types/_character";
 import { INumeric } from "../types/_numeric";
-export declare function mod(left: INumeric | ICharacter | string | Integer8 | number, right: INumeric | Integer8 | ICharacter | string | number): Integer8 | Integer;
+export declare function mod(left: INumeric | ICharacter | string | Integer8 | number, right: INumeric | Integer8 | ICharacter | string | number): Float | Integer8 | Integer;

package/build/src/operators/mod.js

@@ -36,12 +36,11 @@ function mod(left, right) {
     if (val < 0) {
         val = val * -1;
     }
-    // hmm, to handle field symbols?
-    if (left instanceof types_1.Integer8 || right instanceof types_1.Integer8) {
-        return new types_1.Integer8().set(val);
-    }
-    else {
-        return new types_1.Integer().set(val);
+    // the calculation type of the operands decides: with a float operand the
+    // remainder is a float, 2.75 MOD 1 is 0.75 and not 1
+    if (left instanceof types_1.Float || right instanceof types_1.Float) {
+        return new types_1.Float().set(val);
     }
+    return new types_1.Integer().set(val);
 }
 //# sourceMappingURL=mod.js.map

package/build/src/operators/multiply.js

@@ -14,6 +14,14 @@ function multiply(left, right) {
         const val = left.get() * right.get();
         return new types_1.Integer().set(val);
     }
+    else if (left instanceof types_1.Float && right instanceof types_1.Float) {
+        // Two floats fall through the rest of the chain to exactly this, and
+        // float arithmetic is the most common thing there is: the remaining type
+        // tests all fail, and then parse() is called on each operand, which for a
+        // Float is getRaw(). It sits after the integer branch on purpose, so that
+        // integer arithmetic pays nothing for it.
+        return new types_1.Float().set(left.getRaw() * right.getRaw());
+    }
     else if (typeof left === "number" && typeof right === "number"
         && Number.isInteger(left) && Number.isInteger(right)) {
         const val = left * right;

package/build/src/statements/create_data.js

@@ -4,6 +4,23 @@ exports.createData = createData;
 const throw_error_1 = require("../throw_error");
 const types_1 = require("../types");
 const tableOptions = { withHeader: false, keyType: types_1.TableKeyType.default };
+/** CREATE DATA ... TYPE REF TO <name>, both the static and the dynamic spelling.
+ * "REF TO data" is the generic case: the created data object is itself an
+ * unbound data reference, so the target points at a DataReference. Anything
+ * else names a class or interface. */
+function createDataRefTo(target, name) {
+    if (name.toUpperCase() === "DATA") {
+        // a DataReference pointing at a DataReference, same shape GET REFERENCE OF
+        // a "REF TO data" variable produces - the declared types do not model the
+        // nesting, so this mirrors get_reference's cast
+        target.assign(new types_1.DataReference(undefined));
+        return;
+    }
+    if (abap.Classes[name.toUpperCase()] === undefined) {
+        (0, throw_error_1.throwError)("CX_SY_CREATE_DATA_ERROR");
+    }
+    target.assign(new abap.types.ABAPObject({ qualifiedName: name, RTTIName: name }));
+}
 function createData(target, options) {
     // console.dir(options);
     if (target instanceof types_1.FieldSymbol) {
@@ -70,10 +87,7 @@ function createData(target, options) {
             target.assign(new types_1.Integer8());
         }
         else if (options.refTo === true) {
-            if (abap.Classes[options.name.toUpperCase()] === undefined) {
-                (0, throw_error_1.throwError)("CX_SY_CREATE_DATA_ERROR");
-            }
-            target.assign(new abap.types.ABAPObject({ qualifiedName: options.name, RTTIName: options.name }));
+            createDataRefTo(target, options.name);
         }
         else {
             (0, throw_error_1.throwError)("CX_SY_CREATE_DATA_ERROR");
@@ -170,6 +184,11 @@ function createData(target, options) {
                     }
                     target.assign(abap.Classes[className][typeName.toLowerCase().trimEnd()].clone());
                 }
+                else if (options.refTo === true) {
+                    // statically written "TYPE REF TO ...", the dynamic "TYPE REF TO (name)"
+                    // variant is handled in the options.name branch above
+                    createDataRefTo(target, options.typeName.trimEnd());
+                }
                 else {
                     throw new Error("CREATE DATA, unknown type " + options.typeName);
                 }

package/build/src/statements/create_object.d.ts

@@ -0,0 +1,17 @@
+/**
+ * CREATE OBJECT with a DYNAMIC class name, into a reference that has a static
+ * type: the class the name resolves to has to be compatible with that type.
+ *
+ * A system raises CX_SY_CREATE_OBJECT_ERROR when it is not, and it raises it
+ * BEFORE the constructor runs - so this is checked on the class, not on an
+ * instance. Without the check an unrelated class was simply assigned to the
+ * reference and the mismatch surfaced later as a raw javascript TypeError on
+ * the first member access, which no CATCH takes: a caller that guards its
+ * dynamic CREATE OBJECT the way the ABAP documentation asks for was not
+ * guarded at all.
+ *
+ * `targetType` is the class or interface object of the reference's static
+ * type and `targetName` its upper-case name; a generic `REF TO object` target
+ * passes both as undefined, and then there is nothing to check.
+ */
+export declare function checkCreateObjectType(clas: any, targetType: any, targetName?: string): void;

package/build/src/statements/create_object.js

@@ -0,0 +1,45 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkCreateObjectType = checkCreateObjectType;
+const throw_error_1 = require("../throw_error");
+/**
+ * CREATE OBJECT with a DYNAMIC class name, into a reference that has a static
+ * type: the class the name resolves to has to be compatible with that type.
+ *
+ * A system raises CX_SY_CREATE_OBJECT_ERROR when it is not, and it raises it
+ * BEFORE the constructor runs - so this is checked on the class, not on an
+ * instance. Without the check an unrelated class was simply assigned to the
+ * reference and the mismatch surfaced later as a raw javascript TypeError on
+ * the first member access, which no CATCH takes: a caller that guards its
+ * dynamic CREATE OBJECT the way the ABAP documentation asks for was not
+ * guarded at all.
+ *
+ * `targetType` is the class or interface object of the reference's static
+ * type and `targetName` its upper-case name; a generic `REF TO object` target
+ * passes both as undefined, and then there is nothing to check.
+ */
+function checkCreateObjectType(clas, targetType, targetName) {
+    if (clas === undefined || targetType === undefined) {
+        return;
+    }
+    if (targetType.INTERNAL_TYPE === "CLAS") {
+        // the class itself or anything below it
+        if (clas === targetType || clas.prototype instanceof targetType) {
+            return;
+        }
+    }
+    else if (targetType.INTERNAL_TYPE === "INTF") {
+        // the same list the cast checks, and it carries the interfaces a
+        // superclass or a composed interface brings along
+        const list = clas.IMPLEMENTED_INTERFACES;
+        if (list?.some(i => i === targetName) === true) {
+            return;
+        }
+    }
+    else {
+        // not something this can decide - leave it as it was
+        return;
+    }
+    (0, throw_error_1.throwError)("CX_SY_CREATE_OBJECT_ERROR");
+}
+//# sourceMappingURL=create_object.js.map

package/build/src/statements/index.d.ts

@@ -12,6 +12,7 @@ import { find } from "./find";
 import { collect } from "./collect";
 import { overlay } from "./overlay";
 import { cast } from "./cast";
+import { checkCreateObjectType } from "./create_object";
 import { getBit } from "./get_bit";
 import { readReport } from "./read_report";
 import { getReference } from "./get_reference";
@@ -58,6 +59,7 @@ export declare class Statements {
     assert: typeof assert;
     assign: typeof assign;
     cast: typeof cast;
+    checkCreateObjectType: typeof checkCreateObjectType;
     collect: typeof collect;
     concatenate: typeof concatenate;
     condense: typeof condense;

package/build/src/statements/index.js

@@ -15,6 +15,7 @@ const find_1 = require("./find");
 const collect_1 = require("./collect");
 const overlay_1 = require("./overlay");
 const cast_1 = require("./cast");
+const create_object_1 = require("./create_object");
 const get_bit_1 = require("./get_bit");
 const read_report_1 = require("./read_report");
 const get_reference_1 = require("./get_reference");
@@ -61,6 +62,7 @@ class Statements {
     assert = assert_1.assert;
     assign = assign_1.assign;
     cast = cast_1.cast;
+    checkCreateObjectType = create_object_1.checkCreateObjectType;
     collect = collect_1.collect;
     concatenate = concatenate_1.concatenate;
     condense = condense_1.condense;

package/build/src/statements/loop.js

@@ -110,6 +110,24 @@ async function* loop(table, options) {
     }
     const loopController = table.startLoop(loopFrom, loopTo, array);
     let entered = false;
+    // ABAP hands sy-tabix back the way it found it. A LOOP owns sy-tabix only
+    // for as long as it runs; leaving it, by ENDLOOP or EXIT or RETURN or an
+    // exception, puts back whatever the enclosing loop had. Without that an
+    // inner loop, or a method that happens to contain one, silently rewrites
+    // the row number the outer loop is standing on, and the outer body reads
+    // the inner loop's last index as its own.
+    const outerTabix = abap.builtin.sy.get().tabix.get();
+    // A hashed table has no row number to report, and ABAP says so by leaving
+    // sy-tabix at 0 for the whole loop rather than by inventing a position.
+    // The same goes for a loop that reads an index table through a hash
+    // secondary key. Handing out 1, 2, 3 there looks helpful and is a lie the
+    // caller cannot tell from the truth.
+    const usedKey = options?.usingKey === undefined || options.usingKey === "primary_key"
+        ? undefined
+        : table.getKeyByName(options.usingKey);
+    const hasRowNumber = usedKey !== undefined
+        ? usedKey.type !== types_1.TableAccessType.hashed
+        : !(table instanceof types_1.HashedTable);
     try {
         const isStructured = array[0] instanceof types_1.Structure;
         while (loopController.index < loopController.loopTo) {
@@ -124,7 +142,7 @@ async function* loop(table, options) {
                     continue;
                 }
             }
-            abap.builtin.sy.get().tabix.set(loopController.index + 1);
+            abap.builtin.sy.get().tabix.set(hasRowNumber ? loopController.index + 1 : 0);
             entered = true;
             options?.atLast?.(loopController.index + 1 >= loopController.loopTo);
             yield current;
@@ -138,6 +156,7 @@ async function* loop(table, options) {
     finally {
         table.unregisterLoop(loopController);
         abap.builtin.sy.get().subrc.set(entered ? 0 : 4);
+        abap.builtin.sy.get().tabix.set(outerTabix);
     }
 }
 //# sourceMappingURL=loop.js.map

package/build/src/types/decfloat34.js

@@ -22,7 +22,10 @@ class DecFloat34 {
             this.value = 0;
         }
         else if (typeof value === "string") {
-            this.value = parseFloat(value);
+            // get() writes the decimal separator as a comma, and parseFloat stops
+            // at one: without this, reading back what this type just wrote gives a
+            // truncated number and no error at all
+            this.value = parseFloat(value.replace(",", "."));
         }
         else if (value instanceof DecFloat34) {
             this.value = value.getRaw();

package/build/src/types/float.js

@@ -6,7 +6,12 @@ const hex_1 = require("./hex");
 const xstring_1 = require("./xstring");
 const integer8_1 = require("./integer8");
 const decfloat34_1 = require("./decfloat34");
-const FLOAT_DIGITS = /^\s*[+-]?(\d+\.?\d*|\.\d+)([eE][+-]?\d+)? *$/;
+// A float writes itself out with a comma for the decimal separator, so
+// reading one back has to accept a comma. Both are allowed rather than only
+// the comma: ABAP source literals carry a point, `CONV f( '0.25' )` is
+// everywhere, and a separator that is legal on the way out and illegal on the
+// way in is not a rule, it is a trap.
+const FLOAT_DIGITS = /^\s*[+-]?(\d+[.,]?\d*|[.,]\d+)([eE][+-]?\d+)? *$/;
 /*
 function getNumberParts(x: number) {
   if(isNaN(x)) {
@@ -67,7 +72,7 @@ class Float {
             if (FLOAT_DIGITS.test(value) === false) {
                 (0, throw_error_1.throwError)("CX_SY_CONVERSION_NO_NUMBER");
             }
-            this.value = parseFloat(value);
+            this.value = parseFloat(value.replace(",", "."));
         }
         else if (value instanceof integer8_1.Integer8) {
             this.value = Number(value.get());

package/build/src/types/integer.d.ts

@@ -7,6 +7,7 @@ export declare const DIGITS: RegExp;
 export declare const MAX_INTEGER = 2147483647;
 export declare const MIN_INTEGER = -2147483648;
 export declare function toInteger(value: string, exception?: boolean): number;
+export declare function roundHalfAwayFromZero(value: number): number;
 export declare class Integer implements INumeric {
     private value;
     private constant;

package/build/src/types/integer.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Integer = exports.MIN_INTEGER = exports.MAX_INTEGER = exports.DIGITS = void 0;
 exports.toInteger = toInteger;
+exports.roundHalfAwayFromZero = roundHalfAwayFromZero;
 const throw_error_1 = require("../throw_error");
 const float_1 = require("./float");
 const hex_1 = require("./hex");
@@ -29,7 +30,14 @@ function toInteger(value, exception = true) {
             throw new Error("CONVT_NO_NUMBER");
         }
     }
-    return Math.round(parseFloat(value));
+    return roundHalfAwayFromZero(parseFloat(value));
+}
+// ABAP rounds a half away from zero when a float is moved to an integer,
+// on both sides: 0.5 is 1 and -0.5 is -1. Math.round rounds a half towards
+// positive infinity, so -0.5 was 0 (and -0 at that)
+function roundHalfAwayFromZero(value) {
+    const rounded = value < 0 ? -Math.round(-value) : Math.round(value);
+    return rounded === 0 ? 0 : rounded;
 }
 class Integer {
     value;
@@ -67,7 +75,7 @@ class Integer {
             throw new Error("Changing constant");
         }
         if (typeof value === "number") {
-            this.value = Math.round(value);
+            this.value = roundHalfAwayFromZero(value);
         }
         else if (value instanceof Integer) {
             this.set(value.get());
@@ -82,7 +90,7 @@ class Integer {
             this.set(Number(value.get()));
         }
         else if (value instanceof float_1.Float || value instanceof decfloat34_1.DecFloat34) {
-            this.set(Math.round(value.getRaw()));
+            this.set(roundHalfAwayFromZero(value.getRaw()));
         }
         else if (value instanceof hex_1.Hex || value instanceof xstring_1.XString || value instanceof hex_uint8_1.HexUInt8) {
             const hex = value.get();

package/build/src/types/integer8.js

@@ -47,7 +47,7 @@ class Integer8 {
             this.value = BigInt(value);
         }
         else if (value instanceof float_1.Float || value instanceof decfloat34_1.DecFloat34) {
-            this.set(Math.round(value.getRaw()));
+            this.set((0, integer_1.roundHalfAwayFromZero)(value.getRaw()));
         }
         else if (value instanceof hex_1.Hex || value instanceof xstring_1.XString || value instanceof hex_uint8_1.HexUInt8) {
             if (value.get().length === 16) {

package/build/src/types/table.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Table = exports.HashedTable = exports.TableFactory = exports.LoopController = exports.TableKeyType = exports.TableAccessType = void 0;
 const integer_1 = require("./integer");
+const float_1 = require("./float");
 const abap_object_1 = require("./abap_object");
 const string_1 = require("./string");
 const structure_1 = require("./structure");
@@ -294,8 +295,12 @@ class HashedTable {
     cloneRow(item) {
         // make sure to do conversion if needed
         if (typeof item === "number") {
+            // a raw number is what the numeric built-ins return (sin, cos, sqrt,
+            // abs, floor, ...): a whole one is an integer, anything else is a
+            // float, and wrapping every one as an Integer first rounded a sine
+            // table to zeros before the row ever saw the value
             const tmp = this.getRowType().clone();
-            tmp.set(new integer_1.Integer().set(item));
+            tmp.set(Number.isInteger(item) ? new integer_1.Integer().set(item) : new float_1.Float().set(item));
             return tmp;
         }
         else if (typeof item === "string") {
@@ -564,8 +569,12 @@ class Table {
     cloneRow(item) {
         // make sure to do conversion if needed
         if (typeof item === "number") {
+            // a raw number is what the numeric built-ins return (sin, cos, sqrt,
+            // abs, floor, ...): a whole one is an integer, anything else is a
+            // float, and wrapping every one as an Integer first rounded a sine
+            // table to zeros before the row ever saw the value
             const tmp = this.getRowType().clone();
-            tmp.set(new integer_1.Integer().set(item));
+            tmp.set(Number.isInteger(item) ? new integer_1.Integer().set(item) : new float_1.Float().set(item));
             return tmp;
         }
         else if (typeof item === "string") {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/runtime",
-  "version": "2.13.86",
+  "version": "2.13.88",
   "description": "Transpiler - Runtime",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
@@ -33,7 +33,7 @@
     "@types/mocha": "^10.0.10",
     "@types/node": "^26.4.1",
     "chai": "^6.2.2",
-    "mocha": "^12.0.1",
+    "mocha": "^12.0.2",
     "source-map-support": "^0.5.21",
     "typescript": "^6.0.3"
   },