@abaplint/core 2.99.8 → 2.99.10

package/build/abaplint.d.ts

@@ -4555,7 +4555,7 @@ declare class PrivateSection implements IStructure {
 }
 
 declare class Program extends ABAPObject {
-    private isIncludeValue;
+    private parsedXML;
     getType(): string;
     getSequencedFiles(): readonly ABAPFile[];
     getDescription(): string | undefined;
@@ -4565,6 +4565,8 @@ declare class Program extends ABAPObject {
     };
     setDirty(): void;
     isInclude(): boolean;
+    isModulePool(): boolean;
+    parseXML(): void;
 }
 
 declare class Program_2 implements IStatement {

package/build/src/abap/2_statements/statement_parser.js

@@ -113,6 +113,7 @@ class StatementParser {
                 const concat = statement.concatTokens().toUpperCase();
                 if (concat.startsWith("CALL METHOD ") === false
                     && concat.startsWith("RAISE EXCEPTION TYPE ") === false
+                    && concat.startsWith("READ TABLE ") === false
                     && concat.startsWith("LOOP AT ") === false
                     && concat.startsWith("CALL FUNCTION ") === false) {
                     for (const { first, second } of this.buildSplits(statement.getTokens())) {

package/build/src/abap/5_syntax/statements/tables.js

@@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.Tables = void 0;
 const Expressions = require("../../2_statements/expressions");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
-const basic_1 = require("../../types/basic");
+const unknown_type_1 = require("../../types/basic/unknown_type");
 class Tables {
     runSyntax(node, scope, filename) {
         var _a, _b;
@@ -15,13 +15,15 @@ class Tables {
         if (name.startsWith("*")) {
             name = name.substr(1);
         }
+        // lookupTableOrView will also give Unknown and Void
         const found = (_b = scope.getDDIC()) === null || _b === void 0 ? void 0 : _b.lookupTableOrView(name);
         if (found) {
             scope.getDDICReferences().addUsing(scope.getParentObj(), { object: found.object, filename: filename, token: nameToken });
             scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, filename, found.type));
             return;
         }
-        scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, filename, new basic_1.UnknownType("Tables, fallback")));
+        // this should never happen,
+        scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, filename, new unknown_type_1.UnknownType("Tables, fallback")));
     }
 }
 exports.Tables = Tables;

package/build/src/lsp/_lookup.js

@@ -60,21 +60,27 @@ class LSPLookup {
             const hover = "Method Definition \"" + method.getName() + "\"";
             return { hover, definition: found, definitionId: method, scope: bottomScope };
         }
+        let hoverValue = "";
+        const ddicRefs = reg.getDDICReferences().listByFilename(cursor.identifier.getFilename(), cursor.identifier.getStart().getRow());
+        for (const d of ddicRefs) {
+            if (d.object && d.token && d.token.getStart().equals(cursor.identifier.getStart())) {
+                hoverValue += `DDIC: ${d.object.getType()} ${d.object.getName()}`;
+            }
+        }
         const variable = bottomScope.findVariable(cursor.token.getStr());
         if (variable !== undefined && variable.getStart().equals(cursor.token.getStart())) {
             const hover = "Variable Definition\n\n" + this.dumpType(variable);
+            if (hoverValue !== "") {
+                hoverValue = hover + "\n_________________\n" + hoverValue;
+            }
+            else {
+                hoverValue = hover;
+            }
             let location = undefined;
             if (variable.getMeta().includes("built-in" /* IdentifierMeta.BuiltIn */) === false) {
                 location = _lsp_utils_1.LSPUtils.identiferToLocation(variable);
             }
-            return { hover, definition: location, implementation: location, definitionId: variable, scope: bottomScope };
-        }
-        let hoverValue = "";
-        const ddicRefs = reg.getDDICReferences().listByFilename(cursor.identifier.getFilename(), cursor.identifier.getStart().getRow());
-        for (const d of ddicRefs) {
-            if (d.object && d.token && d.token.getStart().equals(cursor.identifier.getStart())) {
-                hoverValue += `DDIC: ${d.object.getType()} ${d.object.getName()}`;
-            }
+            return { hover: hoverValue, definition: location, implementation: location, definitionId: variable, scope: bottomScope };
         }
         const refs = this.searchReferences(bottomScope, cursor.token);
         if (refs.length > 0) {

package/build/src/objects/program.js

@@ -3,10 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.Program = void 0;
 const _abap_object_1 = require("./_abap_object");
 class Program extends _abap_object_1.ABAPObject {
-    constructor() {
-        super(...arguments);
-        this.isIncludeValue = undefined;
-    }
     getType() {
         return "PROG";
     }
@@ -28,15 +24,25 @@ class Program extends _abap_object_1.ABAPObject {
         };
     }
     setDirty() {
-        this.isIncludeValue = undefined;
+        this.parsedXML = undefined;
         super.setDirty();
     }
     isInclude() {
-        if (this.isIncludeValue === undefined) {
+        this.parseXML();
+        return this.parsedXML.isInclude;
+    }
+    isModulePool() {
+        this.parseXML();
+        return this.parsedXML.isModulePool;
+    }
+    parseXML() {
+        if (this.parsedXML === undefined) {
             const file = this.getXMLFile();
-            this.isIncludeValue = file ? file.getRaw().includes("<SUBC>I</SUBC>") : false;
+            this.parsedXML = {
+                isInclude: file ? file.getRaw().includes("<SUBC>I</SUBC>") : false,
+                isModulePool: file ? file.getRaw().includes("<SUBC>M</SUBC>") : false,
+            };
         }
-        return this.isIncludeValue;
     }
 }
 exports.Program = Program;

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.8";
+        return "2.99.10";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/main_file_contents.js

@@ -55,7 +55,9 @@ class MainFileContents {
         if (stru === undefined) {
             return [];
         }
-        if (obj instanceof Objects.Program && obj.isInclude() === false) {
+        if (obj instanceof Objects.Program
+            && obj.isInclude() === false
+            && obj.isModulePool() === false) {
             let count = 0;
             let first = main.getStatements()[count];
             while (first !== undefined && first.get() instanceof _statement_1.Comment) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.99.8",
+    "version": "2.99.10",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
         "@microsoft/api-extractor": "^7.34.8",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.1.0",
+        "@types/node": "^20.1.2",
         "chai": "^4.3.7",
         "eslint": "^8.40.0",
         "mocha": "^10.2.0",