@abaplint/core 2.99.5 → 2.99.7

package/build/abaplint.d.ts

@@ -2811,6 +2811,8 @@ export declare interface IConfig {
     app?: IAbaplintAppSettings;
     /** Settings for each rule, see https://rules.abaplint.org */
     rules: any;
+    /** see https://abaplint.app */
+    targetRules?: any;
 }
 
 export declare interface IConfiguration {

package/build/src/abap/5_syntax/basic_types.js

@@ -842,7 +842,23 @@ class BasicTypes {
         }
         const constant = val.findFirstExpression(Expressions.Constant);
         if (constant) {
-            return constant.concatTokens();
+            const conc = val.findFirstExpression(Expressions.ConcatenatedConstant);
+            if (conc) {
+                const first = conc.getFirstToken().getStr().substring(0, 1);
+                let result = "";
+                for (const token of conc.getAllTokens()) {
+                    if (token.getStr() === "&") {
+                        continue;
+                    }
+                    else {
+                        result += token.getStr().substring(1, token.getStr().length - 1);
+                    }
+                }
+                return first + result + first;
+            }
+            else {
+                return constant.concatTokens();
+            }
         }
         const chain = val.findFirstExpression(Expressions.SimpleFieldChain);
         if (chain) {

package/build/src/config.js

@@ -50,9 +50,10 @@ class Config {
         return new Config(JSON.stringify(config));
     }
     getEnabledRules() {
+        var _a;
         const rules = [];
         for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {
-            const ruleConfig = this.config["rules"][rule.getMetadata().key];
+            const ruleConfig = (_a = this.config["rules"]) === null || _a === void 0 ? void 0 : _a[rule.getMetadata().key];
             const ruleExists = ruleConfig !== undefined;
             if (ruleExists) {
                 if (ruleConfig === false) { // "rule": false

package/build/src/objects/rename/rename_data_element.js

@@ -18,6 +18,7 @@ class RenameDataElement {
         changes = changes.concat(helper.renameDDICCodeReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTABLReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTTYPReferences(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICAUTHReferences(obj, oldName, newName));
         return {
             documentChanges: changes,
         };

package/build/src/objects/rename/renamer_helper.js

@@ -87,6 +87,21 @@ class RenamerHelper {
         }
         return changes;
     }
+    renameDDICAUTHReferences(obj, oldName, newName) {
+        const changes = [];
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.type !== "AUTH") {
+                continue;
+            }
+            const tabl = this.reg.getObject(u.type, u.name);
+            if (tabl === undefined) {
+                continue;
+            }
+            changes.push(...this.buildXMLFileEdits(tabl, "ROLLNAME", oldName, newName));
+        }
+        return changes;
+    }
     buildXMLFileEdits(object, xmlTag, oldName, newName) {
         const changes = [];
         const xml = object.getXMLFile();

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.5";
+        return "2.99.7";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/check_comments.js

@@ -30,10 +30,12 @@ class CheckComments extends _abap_rule_1.ABAPRule {
             shortDescription: `
 Various checks for comment usage.`,
             extendedInformation: `
-* End of line comments. Comments starting with "#EC" or "##" are ignored
+Detects end of line comments. Comments starting with "#EC" or "##" are ignored
 
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE 2. " descriptive comment`,
+            goodExample: `" descriptive comment\nWRITE 2.`,
         };
     }
     getDescription(issueType) {

package/build/src/rules/strict_sql.js

@@ -29,7 +29,7 @@ https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abenopensql_strict_mo
 Also see separate rule sql_escape_host_variables
 
 Activates from v750 and up`,
-            tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix],
+            tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Quickfix],
         };
     }
     getConfig() {

package/build/src/rules/unnecessary_pragma.js

@@ -118,6 +118,7 @@ ENDIF.`,
             && !(statement.get() instanceof Statements.DataEnd)
             && !(statement.get() instanceof Statements.Type)
             && !(statement.get() instanceof Statements.Form)
+            && !(statement.get() instanceof Statements.Tables)
             && !(statement.get() instanceof Statements.TypeEnd)
             && !(statement.get() instanceof Statements.Constant)
             && !(statement.get() instanceof Statements.ConstantEnd)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.99.5",
+    "version": "2.99.7",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,9 +50,9 @@
         "@microsoft/api-extractor": "^7.34.8",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.16.3",
+        "@types/node": "^20.1.0",
         "chai": "^4.3.7",
-        "eslint": "^8.39.0",
+        "eslint": "^8.40.0",
         "mocha": "^10.2.0",
         "c8": "^7.13.0",
         "source-map-support": "^0.5.21",

package/adhoc/lexer_performance.ts

@@ -1,16 +0,0 @@
-import {MemoryFile} from "../src";
-import {Lexer} from "../src/abap/1_lexer/lexer";
-import * as fs from "fs";
-
-console.log("========================");
-const file = new MemoryFile("abapgit.abap", fs.readFileSync("./lexer_performance.abap", "utf-8"));
-
-let total = 0;
-for (let i = 0; i < 10; i++) {
-  const before = Date.now();
-  const result = new Lexer().run(file);
-  const runtime = Date.now() - before;
-  console.log("Runtime: " + runtime + "ms, Tokens: " + result.tokens.length);
-  total += runtime;
-}
-console.log("Total: " + total + "ms");

package/adhoc/parser_performance.ts

@@ -1,18 +0,0 @@
-import {MemoryFile, Version} from "../src";
-import {Lexer} from "../src/abap/1_lexer/lexer";
-import * as fs from "fs";
-import {StatementParser} from "../src/abap/2_statements/statement_parser";
-
-console.log("========================");
-const file = new MemoryFile("abapgit.abap", fs.readFileSync("./lexer_performance.abap", "utf-8"));
-
-const lexerResult = new Lexer().run(file);
-
-let total = 0;
-for (let i = 0; i < 4; i++) {
-  const before = Date.now();
-  new StatementParser(Version.v702).run([lexerResult], []);
-  const runtime = Date.now() - before;
-  total += runtime;
-}
-console.log("Total: " + total + "ms");