@abaplint/core 2.99.4 → 2.99.6

package/build/abaplint.d.ts

@@ -2811,6 +2811,8 @@ export declare interface IConfig {
     app?: IAbaplintAppSettings;
     /** Settings for each rule, see https://rules.abaplint.org */
     rules: any;
+    /** see https://abaplint.app */
+    targetRules?: any;
 }
 
 export declare interface IConfiguration {

package/build/src/abap/types/basic/character_type.js

@@ -6,7 +6,7 @@ class CharacterType extends _abstract_type_1.AbstractType {
     constructor(length, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Character");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/floating_point_type.js

@@ -7,7 +7,7 @@ class FloatingPointType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Floating Point");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/hex_type.js

@@ -6,7 +6,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTHm, Hex");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/numeric_type.js

@@ -6,7 +6,7 @@ class NumericType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Numeric");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/packed_type.js

@@ -6,10 +6,10 @@ class PackedType extends _abstract_type_1.AbstractType {
     constructor(length, decimals, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Packed");
         }
         else if (decimals < 0) {
-            throw new Error("Bad DECIMALS");
+            throw new Error("Bad DECIMALS, Packed");
         }
         this.length = length;
         this.decimals = decimals;

package/build/src/config.js

@@ -50,9 +50,10 @@ class Config {
         return new Config(JSON.stringify(config));
     }
     getEnabledRules() {
+        var _a;
         const rules = [];
         for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {
-            const ruleConfig = this.config["rules"][rule.getMetadata().key];
+            const ruleConfig = (_a = this.config["rules"]) === null || _a === void 0 ? void 0 : _a[rule.getMetadata().key];
             const ruleExists = ruleConfig !== undefined;
             if (ruleExists) {
                 if (ruleConfig === false) { // "rule": false

package/build/src/objects/rename/rename_data_element.js

@@ -18,6 +18,7 @@ class RenameDataElement {
         changes = changes.concat(helper.renameDDICCodeReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTABLReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTTYPReferences(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICAUTHReferences(obj, oldName, newName));
         return {
             documentChanges: changes,
         };

package/build/src/objects/rename/renamer_helper.js

@@ -87,6 +87,21 @@ class RenamerHelper {
         }
         return changes;
     }
+    renameDDICAUTHReferences(obj, oldName, newName) {
+        const changes = [];
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.type !== "AUTH") {
+                continue;
+            }
+            const tabl = this.reg.getObject(u.type, u.name);
+            if (tabl === undefined) {
+                continue;
+            }
+            changes.push(...this.buildXMLFileEdits(tabl, "ROLLNAME", oldName, newName));
+        }
+        return changes;
+    }
     buildXMLFileEdits(object, xmlTag, oldName, newName) {
         const changes = [];
         const xml = object.getXMLFile();

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.4";
+        return "2.99.6";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/check_comments.js

@@ -30,10 +30,12 @@ class CheckComments extends _abap_rule_1.ABAPRule {
             shortDescription: `
 Various checks for comment usage.`,
             extendedInformation: `
-* End of line comments. Comments starting with "#EC" or "##" are ignored
+Detects end of line comments. Comments starting with "#EC" or "##" are ignored
 
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE 2. " descriptive comment`,
+            goodExample: `" descriptive comment\nWRITE 2.`,
         };
     }
     getDescription(issueType) {

package/build/src/rules/select_single_full_key.js

@@ -6,6 +6,10 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
 const __1 = require("..");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.allowPseudo = true;
+    }
 }
 exports.SelectSingleFullKeyConf = SelectSingleFullKeyConf;
 class SelectSingleFullKey {
@@ -27,6 +31,14 @@ class SelectSingleFullKey {
         return this;
     }
     getConfig() {
+        if (this.conf === undefined) {
+            this.conf = {
+                allowPseudo: true,
+            };
+        }
+        if (this.conf.allowPseudo === undefined) {
+            this.conf.allowPseudo = true;
+        }
         return this.conf;
     }
     setConfig(conf) {
@@ -58,7 +70,11 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const next = statements[i + 1];
-                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment
+                    && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                    if (this.getConfig().allowPseudo !== true) {
+                        issues.push(issue_1.Issue.atStatement(file, s, "Pseudo comment not allowed", this.getMetadata().key, this.getConfig().severity));
+                    }
                     continue;
                 }
                 const tabl = this.findReference(databaseTable.getFirstToken().getStart(), syntax.spaghetti, file);
@@ -67,7 +83,6 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const keys = table.listKeys(this.reg);
-                //        const type = table.parseType(this.reg);
                 const cond = s.findFirstExpression(__1.Expressions.SQLCond);
                 const set = new Set();
                 for (const key of keys) {

package/build/src/rules/unnecessary_pragma.js

@@ -118,6 +118,7 @@ ENDIF.`,
             && !(statement.get() instanceof Statements.DataEnd)
             && !(statement.get() instanceof Statements.Type)
             && !(statement.get() instanceof Statements.Form)
+            && !(statement.get() instanceof Statements.Tables)
             && !(statement.get() instanceof Statements.TypeEnd)
             && !(statement.get() instanceof Statements.Constant)
             && !(statement.get() instanceof Statements.ConstantEnd)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.99.4",
+    "version": "2.99.6",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -47,10 +47,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.34.7",
+        "@microsoft/api-extractor": "^7.34.8",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.16.3",
+        "@types/node": "^20.0.0",
         "chai": "^4.3.7",
         "eslint": "^8.39.0",
         "mocha": "^10.2.0",

package/adhoc/lexer_performance.ts

@@ -1,16 +0,0 @@
-import {MemoryFile} from "../src";
-import {Lexer} from "../src/abap/1_lexer/lexer";
-import * as fs from "fs";
-
-console.log("========================");
-const file = new MemoryFile("abapgit.abap", fs.readFileSync("./lexer_performance.abap", "utf-8"));
-
-let total = 0;
-for (let i = 0; i < 10; i++) {
-  const before = Date.now();
-  const result = new Lexer().run(file);
-  const runtime = Date.now() - before;
-  console.log("Runtime: " + runtime + "ms, Tokens: " + result.tokens.length);
-  total += runtime;
-}
-console.log("Total: " + total + "ms");

package/adhoc/parser_performance.ts

@@ -1,18 +0,0 @@
-import {MemoryFile, Version} from "../src";
-import {Lexer} from "../src/abap/1_lexer/lexer";
-import * as fs from "fs";
-import {StatementParser} from "../src/abap/2_statements/statement_parser";
-
-console.log("========================");
-const file = new MemoryFile("abapgit.abap", fs.readFileSync("./lexer_performance.abap", "utf-8"));
-
-const lexerResult = new Lexer().run(file);
-
-let total = 0;
-for (let i = 0; i < 4; i++) {
-  const before = Date.now();
-  new StatementParser(Version.v702).run([lexerResult], []);
-  const runtime = Date.now() - before;
-  total += runtime;
-}
-console.log("Total: " + total + "ms");