@abaplint/core 2.99.3 → 2.99.5

package/build/src/abap/5_syntax/_current_scope.js

@@ -239,7 +239,7 @@ class CurrentScope {
             return undefined;
         }
         const typePoolName = name.split("_")[0];
-        if (typePoolName.length !== 4) {
+        if (typePoolName.length <= 2 || typePoolName.length > 5) {
             return undefined;
         }
         const typePool = this.reg.getObject("TYPE", typePoolName);
@@ -256,7 +256,10 @@ class CurrentScope {
             return undefined;
         }
         const typePoolName = name.split("_")[0];
-        if (typePoolName.length !== 4 || new ddic_1.DDIC(this.reg).lookupNoVoid(name) !== undefined) {
+        if (typePoolName.length <= 2 || typePoolName.length > 5) {
+            return undefined;
+        }
+        if (new ddic_1.DDIC(this.reg).lookupNoVoid(name) !== undefined) {
             // this is tricky, it should not do recursion when parsing the type pool itself,
             // think about DTEL ABAP_ENCOD vs TYPE ABAP
             return undefined;

package/build/src/abap/types/basic/character_type.js

@@ -6,7 +6,7 @@ class CharacterType extends _abstract_type_1.AbstractType {
     constructor(length, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Character");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/floating_point_type.js

@@ -7,7 +7,7 @@ class FloatingPointType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Floating Point");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/hex_type.js

@@ -6,7 +6,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTHm, Hex");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/numeric_type.js

@@ -6,7 +6,7 @@ class NumericType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Numeric");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/packed_type.js

@@ -6,10 +6,10 @@ class PackedType extends _abstract_type_1.AbstractType {
     constructor(length, decimals, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Packed");
         }
         else if (decimals < 0) {
-            throw new Error("Bad DECIMALS");
+            throw new Error("Bad DECIMALS, Packed");
         }
         this.length = length;
         this.decimals = decimals;

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.3";
+        return "2.99.5";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/select_single_full_key.js

@@ -6,6 +6,10 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
 const __1 = require("..");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.allowPseudo = true;
+    }
 }
 exports.SelectSingleFullKeyConf = SelectSingleFullKeyConf;
 class SelectSingleFullKey {
@@ -27,6 +31,14 @@ class SelectSingleFullKey {
         return this;
     }
     getConfig() {
+        if (this.conf === undefined) {
+            this.conf = {
+                allowPseudo: true,
+            };
+        }
+        if (this.conf.allowPseudo === undefined) {
+            this.conf.allowPseudo = true;
+        }
         return this.conf;
     }
     setConfig(conf) {
@@ -58,7 +70,11 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const next = statements[i + 1];
-                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment
+                    && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                    if (this.getConfig().allowPseudo !== true) {
+                        issues.push(issue_1.Issue.atStatement(file, s, "Pseudo comment not allowed", this.getMetadata().key, this.getConfig().severity));
+                    }
                     continue;
                 }
                 const tabl = this.findReference(databaseTable.getFirstToken().getStart(), syntax.spaghetti, file);
@@ -67,7 +83,6 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const keys = table.listKeys(this.reg);
-                //        const type = table.parseType(this.reg);
                 const cond = s.findFirstExpression(__1.Expressions.SQLCond);
                 const set = new Set();
                 for (const key of keys) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.99.3",
+    "version": "2.99.5",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -47,7 +47,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.34.7",
+        "@microsoft/api-extractor": "^7.34.8",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
         "@types/node": "^18.16.3",