@abaplint/core 2.99.0 → 2.99.2

package/build/abaplint.d.ts

@@ -817,7 +817,11 @@ declare class ChapterOfBookStructure extends AbstractObject {
 declare class CharacterType extends AbstractType {
     private readonly length;
     constructor(length: number, extra?: AbstractTypeData);
-    cloneType(qualifiedName?: string, ddicName?: string): CharacterType;
+    cloneType(input: {
+        qualifiedName?: string;
+        ddicName?: string;
+        derivedFromConstant?: boolean;
+    }): CharacterType;
     getLength(): number;
     toText(): string;
     toABAP(): string;

package/build/src/abap/5_syntax/_type_utils.js

@@ -208,7 +208,7 @@ class TypeUtils {
         return false;
     }
     isAssignableStrict(source, target) {
-        var _a, _b;
+        var _a, _b, _c, _d;
         /*
             console.dir(source);
             console.dir(target);
@@ -227,6 +227,20 @@ class TypeUtils {
                 return false;
             }
         }
+        else if (source instanceof basic_1.HexType) {
+            if (target instanceof basic_1.HexType) {
+                if (((_c = source.getAbstractTypeData()) === null || _c === void 0 ? void 0 : _c.derivedFromConstant) === true) {
+                    return source.getLength() <= target.getLength();
+                }
+                return source.getLength() === target.getLength();
+            }
+            else if (target instanceof basic_1.IntegerType) {
+                if (((_d = source.getAbstractTypeData()) === null || _d === void 0 ? void 0 : _d.derivedFromConstant) === true) {
+                    return true;
+                }
+                return false;
+            }
+        }
         else if (source instanceof basic_1.StringType && target instanceof basic_1.StructureType) {
             if (this.structureContainsString(target)) {
                 return false;

package/build/src/abap/5_syntax/basic_types.js

@@ -190,7 +190,7 @@ class BasicTypes {
         if (type instanceof basic_1.CharacterType
             && qualifiedName
             && qualifiedName.includes("-") === false) {
-            type = type.cloneType(qualifiedName);
+            type = type.cloneType({ qualifiedName });
         }
         return type;
     }

package/build/src/abap/5_syntax/expressions/field_chain.js

@@ -94,10 +94,26 @@ class FieldChain {
                 context = new attribute_name_1.AttributeName().runSyntax(context, current, scope, filename, refType);
             }
             else if (current.get() instanceof Expressions.FieldOffset && current instanceof nodes_1.ExpressionNode) {
-                new field_offset_1.FieldOffset().runSyntax(current, scope, filename);
+                const offset = new field_offset_1.FieldOffset().runSyntax(current, scope, filename);
+                if (offset) {
+                    if (context instanceof basic_1.CharacterType) {
+                        context = new basic_1.CharacterType(context.getLength() - offset);
+                    }
+                    else if (context instanceof basic_1.HexType) {
+                        context = new basic_1.HexType(context.getLength() - offset);
+                    }
+                }
             }
             else if (current.get() instanceof Expressions.FieldLength && current instanceof nodes_1.ExpressionNode) {
-                new field_length_1.FieldLength().runSyntax(current, scope, filename);
+                const length = new field_length_1.FieldLength().runSyntax(current, scope, filename);
+                if (length) {
+                    if (context instanceof basic_1.CharacterType) {
+                        context = new basic_1.CharacterType(length);
+                    }
+                    else if (context instanceof basic_1.HexType) {
+                        context = new basic_1.HexType(length);
+                    }
+                }
             }
         }
         return context;

package/build/src/abap/5_syntax/expressions/field_length.js

@@ -9,6 +9,15 @@ class FieldLength {
         const field = node.findDirectExpression(Expressions.SimpleFieldChain2);
         if (field) {
             new field_chain_1.FieldChain().runSyntax(field, scope, filename, _reference_1.ReferenceType.DataReadReference);
+            return undefined;
+        }
+        else {
+            const children = node.getChildren();
+            const num = children[children.length - 2];
+            if (num.getLastToken().getStr() === "*") {
+                return undefined;
+            }
+            return parseInt(num.getLastToken().getStr(), 10);
         }
     }
 }

package/build/src/abap/5_syntax/expressions/field_offset.js

@@ -9,6 +9,10 @@ class FieldOffset {
         const field = node.findDirectExpression(Expressions.SimpleFieldChain2);
         if (field) {
             new field_chain_1.FieldChain().runSyntax(field, scope, filename, _reference_1.ReferenceType.DataReadReference);
+            return undefined;
+        }
+        else {
+            return parseInt(node.getLastToken().getStr(), 10);
         }
     }
 }

package/build/src/abap/types/basic/character_type.js

@@ -10,13 +10,16 @@ class CharacterType extends _abstract_type_1.AbstractType {
         }
         this.length = length;
     }
-    cloneType(qualifiedName, ddicName) {
+    cloneType(input) {
         const clone = Object.assign({}, this.getAbstractTypeData()) || {};
-        if (qualifiedName) {
-            clone.qualifiedName = qualifiedName;
+        if (input.qualifiedName) {
+            clone.qualifiedName = input.qualifiedName;
         }
-        if (ddicName) {
-            clone.ddicName = ddicName;
+        if (input.ddicName) {
+            clone.ddicName = input.ddicName;
+        }
+        if (input.derivedFromConstant) {
+            clone.derivedFromConstant = input.derivedFromConstant;
         }
         return new CharacterType(this.length, clone);
     }

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.0";
+        return "2.99.2";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/omit_preceding_zeros.js

@@ -7,6 +7,7 @@ const issue_1 = require("../issue");
 const Expressions = require("../abap/2_statements/expressions");
 const _irule_1 = require("./_irule");
 const statements_1 = require("../abap/2_statements/statements");
+const edit_helper_1 = require("../edit_helper");
 class OmitPrecedingZerosConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.OmitPrecedingZerosConf = OmitPrecedingZerosConf;
@@ -20,7 +21,7 @@ class OmitPrecedingZeros extends _abap_rule_1.ABAPRule {
             key: "omit_preceding_zeros",
             title: "Omit preceding zeros",
             shortDescription: `Omit preceding zeros from integer constants`,
-            tags: [_irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `int = -001.`,
             goodExample: `int = -1.`,
         };
@@ -43,7 +44,9 @@ class OmitPrecedingZeros extends _abap_rule_1.ABAPRule {
                     if (s.get() instanceof statements_1.CallScreen || s.get() instanceof statements_1.SetScreen) {
                         continue;
                     }
-                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity);
+                    const replace = str.replace(/^0+/, "");
+                    const fix = edit_helper_1.EditHelper.replaceRange(file, token.getStart(), token.getEnd(), replace);
+                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity, fix);
                     issues.push(issue);
                 }
             }
@@ -51,7 +54,9 @@ class OmitPrecedingZeros extends _abap_rule_1.ABAPRule {
                 const token = (_a = i.findDirectExpression(Expressions.SimpleName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
                 const str = token === null || token === void 0 ? void 0 : token.getStr();
                 if (token && str && str.length > 1 && str.startsWith("0")) {
-                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity);
+                    const replace = str.replace(/^0+/, "");
+                    const fix = edit_helper_1.EditHelper.replaceRange(file, token.getStart(), token.getEnd(), replace);
+                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity, fix);
                     issues.push(issue);
                 }
             }

package/build/src/rules/smim_consistency.js

@@ -37,7 +37,7 @@ class SMIMConsistency {
         }
         const base = this.base(obj.getURL() || "");
         if (base !== "" && this.findFolder(base) === false) {
-            const message = "Parent folder not found";
+            const message = `Parent folder "${base}" not found`;
             const position = new position_1.Position(1, 1);
             const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, message, this.getMetadata().key, this.conf.severity);
             issues.push(issue);
@@ -51,7 +51,8 @@ class SMIMConsistency {
     }
     findFolder(base) {
         for (const smim of this.reg.getObjectsByType("SMIM")) {
-            if (base === smim.getURL()) {
+            const mime = smim;
+            if (base === mime.getURL() && mime.isFolder() === true) {
                 return true;
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.99.0",
+    "version": "2.99.2",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -47,10 +47,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.34.5",
-        "@types/chai": "^4.3.4",
+        "@microsoft/api-extractor": "^7.34.7",
+        "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.16.2",
+        "@types/node": "^18.16.3",
         "chai": "^4.3.7",
         "eslint": "^8.39.0",
         "mocha": "^10.2.0",