@abaplint/core 2.97.17 → 2.98.1

package/build/abaplint.d.ts

@@ -2958,6 +2958,7 @@ declare interface IGlobalConfig {
     /** input files, glob format */
     files: string;
     skipGeneratedBOPFInterfaces?: boolean;
+    /** Skips generated table maintenances, determined via TOBJ object */
     skipGeneratedFunctionGroups?: boolean;
     skipGeneratedGatewayClasses?: boolean;
     skipGeneratedPersistentClasses?: boolean;

package/build/src/abap/2_statements/expressions/select.js

@@ -17,8 +17,12 @@ class Select extends combi_1.Expression {
         const bypass = (0, combi_1.str)("BYPASSING BUFFER");
         const fields = (0, combi_1.seq)("FIELDS", _1.SQLFieldList);
         const perm = (0, combi_1.per)(_1.SQLFrom, into, _1.SQLForAllEntries, where, _1.SQLOrderBy, sql_up_to_1.SQLUpTo, offset, _1.SQLClient, _1.SQLHaving, bypass, sql_group_by_1.SQLGroupBy, fields, _1.DatabaseConnection);
+        const permSingle = (0, combi_1.per)(_1.SQLFrom, sql_into_structure_1.SQLIntoStructure, where, _1.SQLClient, bypass, fields, _1.DatabaseConnection);
         const paren = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), sql_field_name_1.SQLFieldName, (0, combi_1.tok)(tokens_1.WParenRightW));
-        const ret = (0, combi_1.seq)("SELECT", (0, combi_1.altPrio)("DISTINCT", (0, combi_1.optPrio)((0, combi_1.seq)("SINGLE", (0, combi_1.optPrio)("FOR UPDATE")))), (0, combi_1.optPrio)((0, combi_1.altPrio)(_1.SQLFieldList, paren)), perm, (0, combi_1.optPrio)(_1.SQLHints));
+        const fieldList = (0, combi_1.optPrio)((0, combi_1.altPrio)(_1.SQLFieldList, paren));
+        const single = (0, combi_1.seq)("SINGLE", (0, combi_1.optPrio)("FOR UPDATE"), fieldList, permSingle);
+        const other = (0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), fieldList, perm);
+        const ret = (0, combi_1.seq)("SELECT", (0, combi_1.altPrio)(single, other), (0, combi_1.optPrio)(_1.SQLHints));
         return ret;
     }
 }

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.97.17";
+        return "2.98.1";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/abapdoc.js

@@ -44,7 +44,7 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-on
         var _a, _b;
         const issues = [];
         const rows = file.getRawRows();
-        const regexEmptyTags = '^\\"! .*<[^>]*><';
+        const regexEmptyTags = '^\\"! .*<[^/>]*><\\/';
         const regexEmptyAbapdoc = '^\\"!.+$';
         const regexEmptyParameterName = '^\\"! @parameter .+\\|';
         let methods = [];

package/build/src/rules/colon_missing_space.js

@@ -21,6 +21,8 @@ class ColonMissingSpace extends _abap_rule_1.ABAPRule {
             title: "Colon missing space",
             shortDescription: `Checks for missing spaces after colons in chained statements.`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE:hello, world.`,
+            goodExample: `WRITE: hello, world.`,
         };
     }
     getMessage() {

package/build/src/rules/index.js

@@ -132,6 +132,7 @@ __exportStar(require("./remove_descriptions"), exports);
 __exportStar(require("./rfc_error_handling"), exports);
 __exportStar(require("./select_add_order_by"), exports);
 __exportStar(require("./select_performance"), exports);
+__exportStar(require("./select_single_full_key"), exports);
 __exportStar(require("./selection_screen_naming"), exports);
 __exportStar(require("./sequential_blank"), exports);
 __exportStar(require("./short_case"), exports);

package/build/src/rules/select_single_full_key.js

@@ -0,0 +1,99 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const __1 = require("..");
+class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.SelectSingleFullKeyConf = SelectSingleFullKeyConf;
+class SelectSingleFullKey {
+    constructor() {
+        this.conf = new SelectSingleFullKeyConf();
+    }
+    getMetadata() {
+        return {
+            key: "select_single_full_key",
+            title: "Detect SELECT SINGLE which are possibily not unique",
+            shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
+            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
+            pseudoComment: "EC CI_NOORDER",
+            tags: [_irule_1.RuleTag.Experimental],
+        };
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    run(obj) {
+        var _a, _b;
+        if (!(obj instanceof __1.ABAPObject)) {
+            return [];
+        }
+        const syntax = new __1.SyntaxLogic(this.reg, obj).run();
+        if (syntax.issues.length > 0) {
+            return [];
+        }
+        const issues = [];
+        const message = "SELECT SINGLE possibily not unique";
+        for (const file of obj.getABAPFiles()) {
+            const statements = file.getStatements();
+            for (let i = 0; i < statements.length; i++) {
+                const s = statements[i];
+                if (!(s.get() instanceof __1.Statements.Select)) {
+                    continue;
+                }
+                else if (s.findTokenSequencePosition("SELECT", "SINGLE") === undefined) {
+                    continue;
+                }
+                const databaseTable = s.findFirstExpression(__1.Expressions.DatabaseTable);
+                if (databaseTable === undefined) {
+                    continue;
+                }
+                const next = statements[i + 1];
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                    continue;
+                }
+                const tabl = this.findReference(databaseTable.getFirstToken().getStart(), syntax.spaghetti, file);
+                const table = this.reg.getObject("TABL", tabl);
+                const keys = table.listKeys(this.reg);
+                //        const type = table.parseType(this.reg);
+                const cond = s.findFirstExpression(__1.Expressions.SQLCond);
+                const set = new Set();
+                for (const key of keys) {
+                    if (key === "MANDT") {
+                        // todo, it should check for the correct type instead
+                        continue;
+                    }
+                    set.add(key);
+                }
+                for (const compare of (cond === null || cond === void 0 ? void 0 : cond.findAllExpressionsRecursive(__1.Expressions.SQLCompare)) || []) {
+                    if (compare.getChildren().length === 3) {
+                        const fname = (_a = compare.findDirectExpression(__1.Expressions.SQLFieldName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+                        const operator = (_b = compare.findDirectExpression(__1.Expressions.SQLCompareOperator)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
+                        if (fname && (operator === "=" || operator === "EQ")) {
+                            set.delete(fname);
+                        }
+                    }
+                }
+                if (set.size > 0) {
+                    issues.push(issue_1.Issue.atStatement(file, s, message, this.getMetadata().key, this.getConfig().severity));
+                }
+            }
+        }
+        return issues;
+    }
+    findReference(position, spaghetti, file) {
+        const scope = spaghetti.lookupPosition(position, file.getFilename());
+        return scope === null || scope === void 0 ? void 0 : scope.findTableReference(position);
+    }
+}
+exports.SelectSingleFullKey = SelectSingleFullKey;
+//# sourceMappingURL=select_single_full_key.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.97.17",
+    "version": "2.98.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
         "@microsoft/api-extractor": "^7.34.4",
         "@types/chai": "^4.3.4",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.15.13",
+        "@types/node": "^18.16.1",
         "chai": "^4.3.7",
         "eslint": "^8.39.0",
         "mocha": "^10.2.0",