@abaplint/core 2.95.51 → 2.96.0

package/build/src/abap/5_syntax/basic_types.js

@@ -276,13 +276,18 @@ class BasicTypes {
             return undefined;
         }
         let type = undefined;
-        if (text.startsWith("TYPE STANDARD TABLE ") || text.startsWith("LIKE STANDARD TABLE ")) {
+        if (text.startsWith("TYPE STANDARD TABLE ")
+            || text.startsWith("TYPE TABLE ")
+            || text.startsWith("LIKE TABLE ")
+            || text.startsWith("LIKE STANDARD TABLE ")) {
             type = basic_1.TableAccessType.standard;
         }
-        else if (text.startsWith("TYPE SORTED TABLE ") || text.startsWith("LIKE SORTED TABLE ")) {
+        else if (text.startsWith("TYPE SORTED TABLE ")
+            || text.startsWith("LIKE SORTED TABLE ")) {
             type = basic_1.TableAccessType.sorted;
         }
-        else if (text.startsWith("TYPE HASHED TABLE ") || text.startsWith("LIKE HASHED TABLE ")) {
+        else if (text.startsWith("TYPE HASHED TABLE ")
+            || text.startsWith("LIKE HASHED TABLE ")) {
             type = basic_1.TableAccessType.hashed;
         }
         const typeTableKeys = node.findAllExpressions(expressions_1.TypeTableKey);
@@ -299,6 +304,9 @@ class BasicTypes {
             for (const k of (firstKey === null || firstKey === void 0 ? void 0 : firstKey.findDirectExpressions(expressions_1.FieldSub)) || []) {
                 primaryKey.keyFields.push(k.concatTokens().toUpperCase());
             }
+            if (primaryKey.keyFields.length === 0 && text.includes(" DEFAULT KEY")) {
+                primaryKey.keyFields.push("TABLE_LINE");
+            }
         }
         else {
             start = 0;
@@ -373,6 +381,7 @@ class BasicTypes {
                 { name: "low", type: found },
                 { name: "high", type: found },
             ]);
+            options.primaryKey.type = basic_1.TableAccessType.standard;
             return new Types.TableType(structure, options, name);
         }
         else if (text.startsWith("LIKE RANGE OF ")) {
@@ -387,6 +396,7 @@ class BasicTypes {
                 { name: "low", type: found },
                 { name: "high", type: found },
             ], name);
+            options.primaryKey.type = basic_1.TableAccessType.standard;
             return new Types.TableType(structure, options);
         }
         else if (typename && (text.startsWith("TYPE TABLE FOR CREATE ")

package/build/src/abap/5_syntax/statements/data.js

@@ -9,7 +9,12 @@ class Data {
     runSyntax(node, scope, filename) {
         const dd = node.findFirstExpression(Expressions.DataDefinition);
         if (dd) {
-            return new data_definition_1.DataDefinition().runSyntax(dd, scope, filename);
+            const id = new data_definition_1.DataDefinition().runSyntax(dd, scope, filename);
+            if ((id === null || id === void 0 ? void 0 : id.getType().isGeneric()) === true
+                && (id === null || id === void 0 ? void 0 : id.getType().containsVoid()) === false) {
+                throw new Error("DATA definition cannot be generic");
+            }
+            return id;
         }
         const name = node.findFirstExpression(Expressions.DefinitionName);
         if (name) {

package/build/src/abap/types/basic/data_reference_type.js

@@ -21,7 +21,8 @@ class DataReference extends _abstract_type_1.AbstractType {
         return "REF TO " + this.type.toABAP();
     }
     isGeneric() {
-        return this.type.isGeneric();
+        // a DATA definition can be "REF TO data", so its not generic
+        return false;
     }
     containsVoid() {
         return this.type.containsVoid();

package/build/src/abap/types/basic/generic_object_reference_type.js

@@ -7,7 +7,8 @@ class GenericObjectReferenceType extends _abstract_type_1.AbstractType {
         return "```REF TO object```";
     }
     isGeneric() {
-        return true;
+        // a DATA definition can be "REF TO object", so its not generic
+        return false;
     }
     toABAP() {
         return "REF TO object";

package/build/src/abap/types/basic/table_type.js

@@ -47,6 +47,11 @@ class TableType extends _abstract_type_1.AbstractType {
         }
     }
     isGeneric() {
+        var _a, _b;
+        if (((_a = this.options.primaryKey) === null || _a === void 0 ? void 0 : _a.type) !== TableAccessType.standard
+            && ((_b = this.options.primaryKey) === null || _b === void 0 ? void 0 : _b.keyFields.length) === 0) {
+            return true;
+        }
         return this.rowType.isGeneric();
     }
     containsVoid() {

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.95.51";
+        return "2.96.0";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/fully_type_itabs.js

@@ -0,0 +1,59 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.FullyTypeITabs = exports.FullyTypeITabsConf = void 0;
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _abap_rule_1 = require("./_abap_rule");
+const issue_1 = require("../issue");
+const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
+const _irule_1 = require("./_irule");
+class FullyTypeITabsConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.FullyTypeITabsConf = FullyTypeITabsConf;
+class FullyTypeITabs extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new FullyTypeITabsConf();
+    }
+    getMetadata() {
+        return {
+            key: "fully_type_itabs",
+            title: "Fully type internal tables",
+            shortDescription: `No implict table types or table keys`,
+            badExample: `DATA lt_foo TYPE TABLE OF ty.
+DATA lt_bar TYPE STANDARD TABLE OF ty.`,
+            goodExample: `DATA lt_foo TYPE STANDARD TABLE OF ty WITH EMPTY KEY.`,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof Statements.Data)) {
+                continue;
+            }
+            const tt = statement.findFirstExpression(Expressions.TypeTable);
+            if (tt === undefined) {
+                continue;
+            }
+            const concat = tt.concatTokens().toUpperCase();
+            if (concat.includes("TYPE TABLE OF")) {
+                const message = "Specify table type";
+                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+            }
+            else if (concat.includes(" WITH ") === false) {
+                const message = "Specify table key";
+                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.FullyTypeITabs = FullyTypeITabs;
+//# sourceMappingURL=fully_type_itabs.js.map

package/build/src/rules/index.js

@@ -64,6 +64,7 @@ __exportStar(require("./forbidden_pseudo_and_pragma"), exports);
 __exportStar(require("./forbidden_void_type"), exports);
 __exportStar(require("./form_tables_obsolete"), exports);
 __exportStar(require("./fully_type_constants"), exports);
+__exportStar(require("./fully_type_itabs"), exports);
 __exportStar(require("./function_module_recommendations"), exports);
 __exportStar(require("./functional_writing"), exports);
 __exportStar(require("./global_class"), exports);

package/build/src/rules/select_add_order_by.js

@@ -91,7 +91,8 @@ If the target is a sorted/hashed table, no issue is reported`,
                 type = found;
             }
             if (type instanceof basic_1.TableType
-                && ((type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.sorted || (type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.hashed)) {
+                && ((type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.sorted
+                    || (type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.hashed)) {
                 return true;
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.95.51",
+    "version": "2.96.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",