@abaplint/core 2.95.28 → 2.95.30

package/build/src/abap/5_syntax/structures/data.js

@@ -22,7 +22,9 @@ class Data {
                 const found = new data_1.Data().runSyntax(c, scope, filename);
                 if (found) {
                     components.push({ name: found.getName(), type: found.getType() });
-                    values[found.getName()] = found.getValue();
+                    if (found.getValue() !== undefined) {
+                        values[found.getName()] = found.getValue();
+                    }
                 }
             }
             else if (c instanceof nodes_1.StructureNode && ctyp instanceof Structures.Data) {
@@ -77,7 +79,8 @@ class Data {
             return new _typed_identifier_1.TypedIdentifier(name, filename, new Basic.TableType(new Basic.StructureType(components), { withHeader: true }));
         }
         else {
-            return new _typed_identifier_1.TypedIdentifier(name, filename, new Basic.StructureType(components), undefined, values);
+            const val = Object.keys(values).length > 0 ? values : undefined;
+            return new _typed_identifier_1.TypedIdentifier(name, filename, new Basic.StructureType(components), undefined, val);
         }
     }
 }

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.95.28";
+        return "2.95.30";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -406,6 +406,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.outlineGetReferenceSimple(high, lowFile);
+        if (found) {
+            return found;
+        }
         found = this.outlineDataSimple(high, lowFile);
         if (found) {
             return found;
@@ -461,7 +465,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         return undefined;
     }
     //////////////////////////////////////////
-    downportSQLExtras(low, high, lowFile, _highSyntax) {
+    downportSQLExtras(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
         }
@@ -489,7 +493,18 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         for (const c of candidates.reverse()) {
             if (c.getFirstToken() instanceof tokens_1.WAt
                 || c.getFirstToken() instanceof tokens_1.At) {
-                addFix(c.getFirstToken());
+                const tokens = c.getAllTokens();
+                if (tokens[1] instanceof tokens_1.ParenLeftW && tokens[tokens.length - 1] instanceof tokens_1.WParenRightW) {
+                    const source = c.findDirectExpression(Expressions.Source);
+                    const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+                    const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA(${uniqueName}) = ${source === null || source === void 0 ? void 0 : source.concatTokens()}.\n`);
+                    const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, c.getFirstToken().getStart(), c.getLastToken().getEnd(), "@" + uniqueName);
+                    const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+                    return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, outline complex @", this.getMetadata().key, this.conf.severity, fix);
+                }
+                else {
+                    addFix(c.getFirstToken());
+                }
             }
         }
         for (const fieldList of high.findAllExpressionsMulti([Expressions.SQLFieldList, Expressions.SQLFieldListLoop], true)) {
@@ -827,6 +842,28 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), code);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
     }
+    outlineGetReferenceSimple(node, lowFile) {
+        var _a, _b, _c;
+        if (!(node.get() instanceof Statements.GetReference)) {
+            return undefined;
+        }
+        const target = node.findFirstExpression(Expressions.Target);
+        if (!(((_a = target === null || target === void 0 ? void 0 : target.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.InlineData)) {
+            return undefined;
+        }
+        const source = node.findFirstExpression(Expressions.Source);
+        if (!(((_b = source === null || source === void 0 ? void 0 : source.getFirstChild()) === null || _b === void 0 ? void 0 : _b.get()) instanceof Expressions.FieldChain)) {
+            return undefined;
+        }
+        const targetName = ((_c = target.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "errorError";
+        const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+        const firstToken = target.getFirstToken();
+        const lastToken = target.getLastToken();
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getStart(), `DATA ${targetName} LIKE REF TO ${source.concatTokens()}.\n${indentation}`);
+        const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, firstToken.getStart(), lastToken.getEnd(), targetName);
+        const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+        return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
+    }
     outlineDataSimple(node, lowFile) {
         // outlines "DATA(ls_msg) = temp1.", note that this does not need to look at types
         var _a, _b, _c;
@@ -2224,7 +2261,7 @@ ${indentation}    output = ${topTarget}.`;
                 code += indent + "  " + uniqueName + " = " + c.concatTokens() + ".\n";
             }
             else if (c.get() instanceof Expressions.Throw) {
-                code += indent + "  " + c.concatTokens().replace("THROW", "RAISE EXCEPTION NEW") + ".\n";
+                code += indent + "  " + c.concatTokens().replace(/THROW /i, "RAISE EXCEPTION NEW ") + ".\n";
             }
             else {
                 throw "buildCondBody, unexpected expression, " + c.get().constructor.name;

package/build/src/rules/prefer_raise_exception_new.js

@@ -21,8 +21,10 @@ class PreferRaiseExceptionNew extends _abap_rule_1.ABAPRule {
             title: "Prefer RAISE EXCEPTION NEW to RAISE EXCEPTION TYPE",
             shortDescription: `Prefer RAISE EXCEPTION NEW to RAISE EXCEPTION TYPE`,
             extendedInformation: `
-      https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-raise-exception-new-to-raise-exception-type`,
-            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-raise-exception-new-to-raise-exception-type
+
+From 752 and up`,
+            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Upport],
             goodExample: `RAISE EXCEPTION NEW cx_generation_error( previous = exception ).`,
             badExample: `RAISE EXCEPTION TYPE cx_generation_error
   EXPORTING

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.95.28",
+    "version": "2.95.30",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
         "@microsoft/api-extractor": "^7.34.4",
         "@types/chai": "^4.3.4",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.14.5",
+        "@types/node": "^18.14.6",
         "chai": "^4.3.7",
         "eslint": "^8.35.0",
         "mocha": "^10.2.0",