@abaplint/core 2.95.24 → 2.95.26

package/build/src/abap/2_statements/expressions/inlinedata.js

@@ -10,7 +10,8 @@ class InlineData extends combi_1.Expression {
         const right = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenRightW), (0, combi_1.tok)(tokens_1.ParenRight));
         const left = (0, combi_1.tok)(tokens_1.ParenLeft);
         const data = (0, combi_1.seq)("DATA", left, _1.TargetField, right);
-        return (0, combi_1.ver)(version_1.Version.v740sp02, data);
+        const final = (0, combi_1.seq)("FINAL", left, _1.TargetField, right);
+        return (0, combi_1.altPrio)((0, combi_1.ver)(version_1.Version.v740sp02, data), (0, combi_1.ver)(version_1.Version.v757, final));
     }
 }
 exports.InlineData = InlineData;

package/build/src/abap/2_statements/statements/import.js

@@ -4,7 +4,6 @@ exports.Import = void 0;
 const combi_1 = require("../combi");
 const tokens_1 = require("../../1_lexer/tokens");
 const expressions_1 = require("../expressions");
-const version_1 = require("../../../version");
 class Import {
     getMatcher() {
         const dto = (0, combi_1.seq)("TO", expressions_1.Target);
@@ -23,7 +22,7 @@ class Import {
         const target = (0, combi_1.alt)(toeq, to, expressions_1.Dynamic, (0, combi_1.plus)(expressions_1.Target));
         const options = (0, combi_1.per)("ACCEPTING PADDING", "IGNORING CONVERSION ERRORS", "IN CHAR-TO-HEX MODE", "IGNORING STRUCTURE BOUNDARIES", "ACCEPTING TRUNCATION", (0, combi_1.seq)("REPLACEMENT CHARACTER", expressions_1.Source), (0, combi_1.seq)("CODE PAGE INTO", expressions_1.Source), (0, combi_1.seq)("ENDIAN INTO", expressions_1.Source));
         const ret = (0, combi_1.seq)("IMPORT", target, "FROM", source, (0, combi_1.opt)(options));
-        return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
+        return ret;
     }
 }
 exports.Import = Import;

package/build/src/abap/5_syntax/expressions/component_compare.js

@@ -22,7 +22,7 @@ class ComponentCompare {
                     throw new Error("ComponentCompare, source not structured");
                 }
                 if (type.getComponentByName(fieldName) === undefined) {
-                    throw new Error("Component " + fieldName + " not part of structure");
+                    throw new Error("Component \"" + fieldName + "\" not part of structure");
                 }
                 // todo, check type compatibility
             }

package/build/src/abap/5_syntax/statements/submit.js

@@ -4,6 +4,7 @@ exports.Submit = void 0;
 const Expressions = require("../../2_statements/expressions");
 const source_1 = require("../expressions/source");
 const target_1 = require("../expressions/target");
+const dynamic_1 = require("../expressions/dynamic");
 class Submit {
     runSyntax(node, scope, filename) {
         for (const s of node.findDirectExpressions(Expressions.Source)) {
@@ -12,6 +13,9 @@ class Submit {
         for (const t of node.findDirectExpressions(Expressions.Target)) {
             new target_1.Target().runSyntax(t, scope, filename);
         }
+        for (const t of node.findDirectExpressions(Expressions.Dynamic)) {
+            new dynamic_1.Dynamic().runSyntax(t, scope, filename);
+        }
     }
 }
 exports.Submit = Submit;

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.95.24";
+        return "2.95.26";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -2215,6 +2215,9 @@ ${indentation}    output = ${topTarget}.`;
             else if (c.get() instanceof Expressions.Source) {
                 code += indent + "  " + uniqueName + " = " + c.concatTokens() + ".\n";
             }
+            else if (c.get() instanceof Expressions.Throw) {
+                code += indent + "  " + c.concatTokens().replace("THROW", "RAISE EXCEPTION NEW") + ".\n";
+            }
             else {
                 throw "buildCondBody, unexpected expression, " + c.get().constructor.name;
             }

package/build/src/rules/method_overwrites_builtin.js

@@ -21,7 +21,9 @@ class MethodOverwritesBuiltIn extends _abap_rule_1.ABAPRule {
             shortDescription: `Checks Method names that overwrite builtin SAP functions`,
             extendedInformation: `https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abenbuilt_in_functions_overview.htm
 
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obscuring-built-in-functions`,
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obscuring-built-in-functions
+
+Interface method names are ignored`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
         };
     }
@@ -37,9 +39,6 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obscu
         for (const classDef of file.getInfo().listClassDefinitions()) {
             methods = methods.concat(classDef.methods);
         }
-        for (const intfDef of file.getInfo().listInterfaceDefinitions()) {
-            methods = methods.concat(intfDef.methods);
-        }
         const builtIn = new _builtin_1.BuiltIn();
         for (const method of methods) {
             if (builtIn.searchBuiltin(method.name.toUpperCase())) {

package/build/src/rules/uncaught_exception.js

@@ -54,6 +54,7 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         if (stru === undefined) {
             return [];
         }
+        this.findLocalExceptions(obj);
         this.syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (this.syntax.issues.length > 0) {
             return [];
@@ -176,7 +177,6 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         def.getRaising().forEach(r => { var _a; return (_a = this.sinked) === null || _a === void 0 ? void 0 : _a.push(r); });
     }
     isSinked(name) {
-        // todo: ignore dynamic and no_check exceptions
         if (this.sinked === undefined || name === undefined) {
             return true;
         }
@@ -184,9 +184,13 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         if (sup === "CX_DYNAMIC_CHECK" || sup === "CX_NO_CHECK") {
             return true;
         }
-        // todo, check local class hierarchy
+        const lsup = this.localExceptions[name.toUpperCase()];
+        if (lsup === "CX_DYNAMIC_CHECK" || lsup === "CX_NO_CHECK") {
+            return true;
+        }
         return this.sinked.some(a => a.toUpperCase() === name.toUpperCase())
-            || (sup !== undefined && this.isSinked(sup) === true);
+            || (sup !== undefined && this.isSinked(sup) === true)
+            || (lsup !== undefined && this.isSinked(lsup) === true);
     }
     findGlobalExceptions() {
         var _a, _b;
@@ -203,6 +207,17 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
             this.globalExceptions[o.getName().toUpperCase()] = (_b = def.superClassName) === null || _b === void 0 ? void 0 : _b.toUpperCase();
         }
     }
+    findLocalExceptions(obj) {
+        var _a;
+        this.localExceptions = {};
+        for (const file of obj.getABAPFiles()) {
+            for (const def of file.getInfo().listClassDefinitions()) {
+                if (def.isLocal === true && def.superClassName !== undefined) {
+                    this.localExceptions[def.name.toUpperCase()] = (_a = def.superClassName) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+                }
+            }
+        }
+    }
 }
 exports.UncaughtException = UncaughtException;
 //# sourceMappingURL=uncaught_exception.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.95.24",
+    "version": "2.95.26",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -52,7 +52,7 @@
         "@types/mocha": "^10.0.1",
         "@types/node": "^18.14.1",
         "chai": "^4.3.7",
-        "eslint": "^8.34.0",
+        "eslint": "^8.35.0",
         "mocha": "^10.2.0",
         "c8": "^7.13.0",
         "source-map-support": "^0.5.21",