@abaplint/core 2.95.23 → 2.95.24

package/build/abaplint.d.ts

@@ -6365,6 +6365,7 @@ export declare enum Version {
     v754 = "v754",
     v755 = "v755",
     v756 = "v756",
+    v757 = "v757",
     Cloud = "Cloud"
 }
 

package/build/src/abap/2_statements/statements/assign.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.Assign = void 0;
 const combi_1 = require("../combi");
 const expressions_1 = require("../expressions");
+const version_1 = require("../../../version");
 class Assign {
     getMatcher() {
         const type = (0, combi_1.seq)("TYPE", (0, combi_1.altPrio)(expressions_1.Dynamic, expressions_1.TypeName));
@@ -12,7 +13,7 @@ class Assign {
         const decimals = (0, combi_1.seq)("DECIMALS", expressions_1.Source);
         const casting = (0, combi_1.seq)("CASTING", (0, combi_1.opt)((0, combi_1.alt)(like, handle, (0, combi_1.per)(type, decimals))));
         const obsoleteType = (0, combi_1.seq)("TYPE", expressions_1.Source, (0, combi_1.optPrio)(decimals));
-        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), expressions_1.AssignSource, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType)), (0, combi_1.opt)(range));
+        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), expressions_1.AssignSource, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType)), (0, combi_1.opt)(range), (0, combi_1.opt)((0, combi_1.ver)(version_1.Version.v757, "ELSE UNASSIGN")));
         return ret;
     }
 }

package/build/src/abap/5_syntax/expressions/component_compare.js

@@ -2,9 +2,31 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ComponentCompare = void 0;
 const Expressions = require("../../2_statements/expressions");
+const basic_1 = require("../../types/basic");
 const source_1 = require("./source");
 class ComponentCompare {
-    runSyntax(node, scope, filename) {
+    runSyntax(node, scope, filename, type) {
+        const chain = node.findDirectExpression(Expressions.ComponentChainSimple);
+        if (chain === undefined) {
+            throw new Error("ComponentCompare, chain not found");
+        }
+        // todo, handle deep chain
+        if (chain.getChildren().length === 1
+            && type !== undefined
+            && !(type instanceof basic_1.VoidType)
+            && !(type instanceof basic_1.UnknownType)
+            && !(type instanceof basic_1.AnyType)) {
+            const fieldName = chain.concatTokens();
+            if (fieldName.toLowerCase() !== "table_line") {
+                if (!(type instanceof basic_1.StructureType)) {
+                    throw new Error("ComponentCompare, source not structured");
+                }
+                if (type.getComponentByName(fieldName) === undefined) {
+                    throw new Error("Component " + fieldName + " not part of structure");
+                }
+                // todo, check type compatibility
+            }
+        }
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }

package/build/src/abap/5_syntax/expressions/component_cond.js

@@ -4,15 +4,15 @@ exports.ComponentCond = void 0;
 const Expressions = require("../../2_statements/expressions");
 const component_compare_1 = require("./component_compare");
 class ComponentCond {
-    runSyntax(node, scope, filename) {
+    runSyntax(node, scope, filename, type) {
         for (const t of node.findDirectExpressions(Expressions.ComponentCondSub)) {
             const c = t.findDirectExpression(Expressions.ComponentCond);
             if (c) {
-                new ComponentCond().runSyntax(c, scope, filename);
+                new ComponentCond().runSyntax(c, scope, filename, type);
             }
         }
         for (const t of node.findDirectExpressions(Expressions.ComponentCompare)) {
-            new component_compare_1.ComponentCompare().runSyntax(t, scope, filename);
+            new component_compare_1.ComponentCompare().runSyntax(t, scope, filename, type);
         }
     }
 }

package/build/src/abap/5_syntax/statements/loop.js

@@ -8,7 +8,6 @@ const source_1 = require("../expressions/source");
 const inline_data_1 = require("../expressions/inline_data");
 const inline_fs_1 = require("../expressions/inline_fs");
 const fstarget_1 = require("../expressions/fstarget");
-const component_compare_1 = require("../expressions/component_compare");
 const component_cond_1 = require("../expressions/component_cond");
 const dynamic_1 = require("../expressions/dynamic");
 const loop_group_by_1 = require("../expressions/loop_group_by");
@@ -27,6 +26,7 @@ class Loop {
             firstSource = sources[0];
         }
         let sourceType = firstSource ? new source_1.Source().runSyntax(firstSource, scope, filename, targetType) : undefined;
+        let rowType = undefined;
         const concat = node.concatTokens().toUpperCase();
         if (sourceType === undefined) {
             throw new Error("No source type determined");
@@ -48,7 +48,8 @@ class Loop {
         }
         if (sourceType instanceof basic_1.TableType) {
             const targetConcat = (_a = node.findDirectExpression(Expressions.LoopTarget)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
-            sourceType = sourceType.getRowType();
+            rowType = sourceType.getRowType();
+            sourceType = rowType;
             if (targetConcat === null || targetConcat === void 0 ? void 0 : targetConcat.startsWith("REFERENCE INTO ")) {
                 sourceType = new basic_1.DataReference(sourceType);
             }
@@ -73,11 +74,8 @@ class Loop {
                 new fstarget_1.FSTarget().runSyntax(fstarget, scope, filename, sourceType);
             }
         }
-        for (const t of node.findDirectExpressions(Expressions.ComponentCompare)) {
-            new component_compare_1.ComponentCompare().runSyntax(t, scope, filename);
-        }
         for (const t of node.findDirectExpressions(Expressions.ComponentCond)) {
-            new component_cond_1.ComponentCond().runSyntax(t, scope, filename);
+            new component_cond_1.ComponentCond().runSyntax(t, scope, filename, rowType);
         }
         for (const t of node.findDirectExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(t, scope, filename);

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.95.23";
+        return "2.95.24";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/unused_methods.js

@@ -10,6 +10,7 @@ const objects_1 = require("../objects");
 const _reference_1 = require("../abap/5_syntax/_reference");
 const visibility_1 = require("../abap/4_file_information/visibility");
 const edit_helper_1 = require("../edit_helper");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 class UnusedMethodsConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.UnusedMethodsConf = UnusedMethodsConf;
@@ -57,6 +58,8 @@ class UnusedMethods {
             shortDescription: `Checks for unused methods`,
             extendedInformation: `Checks private and protected methods.
 
+Unused methods are not reported if the object contains parser or syntax errors.
+
 Skips:
 * methods FOR TESTING
 * methods SETUP + TEARDOWN + CLASS_SETUP + CLASS_TEARDOWN in testclasses
@@ -89,6 +92,13 @@ Skips:
         else if (obj instanceof objects_1.Program && obj.isInclude() === true) {
             return [];
         }
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                if (statement.get() instanceof _statement_1.Unknown) {
+                    return []; // contains parser errors
+                }
+            }
+        }
         // dont report anything when there are syntax errors
         const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (syntax.issues.length > 0) {

package/build/src/rules/unused_types.js

@@ -9,6 +9,7 @@ const _abap_object_1 = require("../objects/_abap_object");
 const _scope_type_1 = require("../abap/5_syntax/_scope_type");
 const edit_helper_1 = require("../edit_helper");
 const _reference_1 = require("../abap/5_syntax/_reference");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 class WorkArea {
     constructor() {
         this.workarea = [];
@@ -55,6 +56,7 @@ class UnusedTypes {
             key: "unused_types",
             title: "Unused types",
             shortDescription: `Checks for unused TYPE definitions`,
+            extendedInformation: `Unused types are not reported if the object contains parser or syntax errors.`,
             tags: [_irule_1.RuleTag.Quickfix],
             pragma: "##NEEDED",
         };
@@ -76,6 +78,13 @@ class UnusedTypes {
         if (!(obj instanceof _abap_object_1.ABAPObject)) {
             return [];
         }
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                if (statement.get() instanceof _statement_1.Unknown) {
+                    return []; // contains parser errors
+                }
+            }
+        }
         // dont report unused variables when there are syntax errors
         const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (syntax.issues.length > 0) {

package/build/src/rules/unused_variables.js

@@ -68,7 +68,9 @@ class UnusedVariables {
 
 Note that this currently does not work if the source code uses macros.
 
-Unused variables are not reported if the object contains syntax errors. Errors found in INCLUDES are reported for the main program.`,
+Unused variables are not reported if the object contains parser or syntax errors.
+
+Errors found in INCLUDES are reported for the main program.`,
             tags: [_irule_1.RuleTag.Quickfix],
             pragma: "##NEEDED",
             pseudoComment: "EC NEEDED",
@@ -94,10 +96,17 @@ Unused variables are not reported if the object contains syntax errors. Errors f
         else if (obj instanceof objects_1.Interface) { // todo, how to handle interfaces?
             return [];
         }
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                if (statement.get() instanceof _statement_1.Unknown) {
+                    return []; // contains parser errors
+                }
+            }
+        }
         // dont report unused variables when there are syntax errors
         const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (syntax.issues.length > 0) {
-            return [];
+            return []; // contains syntax errors
         }
         this.workarea = new WorkArea();
         const top = syntax.spaghetti.getTop();

package/build/src/version.js

@@ -16,9 +16,10 @@ var Version;
     Version["v754"] = "v754";
     Version["v755"] = "v755";
     Version["v756"] = "v756";
+    Version["v757"] = "v757";
     Version["Cloud"] = "Cloud";
 })(Version = exports.Version || (exports.Version = {}));
-exports.defaultVersion = Version.v756;
+exports.defaultVersion = Version.v757;
 function getPreviousVersion(v) {
     if (v === Version.OpenABAP) {
         return Version.v702;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.95.23",
+    "version": "2.95.24",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
         "@microsoft/api-extractor": "^7.34.4",
         "@types/chai": "^4.3.4",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.14.0",
+        "@types/node": "^18.14.1",
         "chai": "^4.3.7",
         "eslint": "^8.34.0",
         "mocha": "^10.2.0",