@abaplint/core 2.94.9 → 2.94.11

package/build/src/rules/rfc_error_handling.js

@@ -22,16 +22,16 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             tags: [_irule_1.RuleTag.SingleFile],
             shortDescription: `Checks that exceptions 'system_failure' and 'communication_failure' are handled in RFC calls`,
             extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenrfc_exception.htm`,
-            badExample: `
-CALL FUNCTION 'ZRFC'
+            badExample: `
+CALL FUNCTION 'ZRFC'
   DESTINATION lv_rfc.`,
-            goodExample: `
-CALL FUNCTION 'ZRFC'
-  DESTINATION lv_rfc
-  EXCEPTIONS
-    system_failure        = 1 MESSAGE msg
-    communication_failure = 2 MESSAGE msg
-    resource_failure      = 3
+            goodExample: `
+CALL FUNCTION 'ZRFC'
+  DESTINATION lv_rfc
+  EXCEPTIONS
+    system_failure        = 1 MESSAGE msg
+    communication_failure = 2 MESSAGE msg
+    resource_failure      = 3
     OTHERS                = 4.`,
         };
     }

package/build/src/rules/select_add_order_by.js

@@ -21,11 +21,11 @@ class SelectAddOrderBy {
             key: "select_add_order_by",
             title: "SELECT add ORDER BY",
             shortDescription: `SELECTs add ORDER BY clause`,
-            extendedInformation: `
-This will make sure that the SELECT statement returns results in the same sequence on different databases
-
-add ORDER BY PRIMARY KEY if in doubt
-
+            extendedInformation: `
+This will make sure that the SELECT statement returns results in the same sequence on different databases
+
+add ORDER BY PRIMARY KEY if in doubt
+
 If the target is a sorted/hashed table, no issue is reported`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/select_performance.js

@@ -32,14 +32,14 @@ class SelectPerformance {
             key: "select_performance",
             title: "SELECT performance",
             shortDescription: `Various checks regarding SELECT performance.`,
-            extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE
-
+            extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE
+
 SELECT *: not reported if using INTO/APPENDING CORRESPONDING FIELDS OF`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Performance],
-            badExample: `SELECT field1, field2 FROM table
-    INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.
+            badExample: `SELECT field1, field2 FROM table
+    INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.
 ENDSELECT.`,
-            goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS
+            goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS
   INTO TABLE @DATA(table) ORDER BY field3 DESCENDING`,
         };
     }

package/build/src/rules/sicf_consistency.js

@@ -24,8 +24,8 @@ class SICFConsistency {
             key: "sicf_consistency",
             title: "SICF consistency",
             shortDescription: `Checks the validity of ICF services`,
-            extendedInformation: `* Class defined in handler must exist
-* Class must not have any syntax errors
+            extendedInformation: `* Class defined in handler must exist
+* Class must not have any syntax errors
 * Class must implement interface IF_HTTP_EXTENSION`,
         };
     }

package/build/src/rules/space_before_dot.js

@@ -29,8 +29,8 @@ class SpaceBeforeDot extends _abap_rule_1.ABAPRule {
             key: "space_before_dot",
             title: "Space before dot",
             shortDescription: `Checks for extra spaces before dots at the ends of statements`,
-            extendedInformation: `
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#be-consistent
+            extendedInformation: `
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#be-consistent
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#condense-your-code`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
             badExample: `WRITE bar .`,

package/build/src/rules/start_at_tab.js

@@ -20,7 +20,7 @@ class StartAtTab extends _abap_rule_1.ABAPRule {
             key: "start_at_tab",
             title: "Start at tab",
             shortDescription: `Checks that statements start at tabstops.`,
-            extendedInformation: `Reports max 100 issues per file
+            extendedInformation: `Reports max 100 issues per file
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
             badExample: ` WRITE a.`,

package/build/src/rules/sy_modification.js

@@ -19,12 +19,12 @@ class SyModification extends _abap_rule_1.ABAPRule {
             key: "sy_modification",
             title: "Modification of SY fields",
             shortDescription: `Finds modification of sy fields`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm
-
+            extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm
+
 Changes to SY-TVAR* fields are not reported`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `
-sy-uname = 2.
+            badExample: `
+sy-uname = 2.
 sy = sy.`,
         };
     }

package/build/src/rules/tabl_enhancement_category.js

@@ -17,8 +17,8 @@ class TABLEnhancementCategory {
             key: "tabl_enhancement_category",
             title: "TABL enhancement category must be set",
             shortDescription: `Checks that tables do not have the enhancement category 'not classified'.`,
-            extendedInformation: `SAP note 3063227 changes the default to 'Cannot be enhanced'.
-
+            extendedInformation: `SAP note 3063227 changes the default to 'Cannot be enhanced'.
+
 You may use standard report RS_DDIC_CLASSIFICATION_FINAL for adjustment.`,
             tags: [],
         };

package/build/src/rules/unnecessary_pragma.js

@@ -21,31 +21,31 @@ class UnnecessaryPragma extends _abap_rule_1.ABAPRule {
             key: "unnecessary_pragma",
             title: "Unnecessary Pragma",
             shortDescription: `Finds pragmas which can be removed`,
-            extendedInformation: `* NO_HANDLER with handler
-
-* NEEDED without definition
-
-* NO_TEXT without texts
-
+            extendedInformation: `* NO_HANDLER with handler
+
+* NEEDED without definition
+
+* NO_TEXT without texts
+
 * SUBRC_OK where sy-subrc is checked`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception ##NO_HANDLER.
-    RETURN. " it has a handler
-ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.
-SELECT SINGLE * FROM tadir INTO @DATA(sdfs) ##SUBRC_OK.
-IF sy-subrc <> 0.
+            badExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception ##NO_HANDLER.
+    RETURN. " it has a handler
+ENDTRY.
+MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs) ##SUBRC_OK.
+IF sy-subrc <> 0.
 ENDIF.`,
-            goodExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception.
-    RETURN.
-ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message.
-SELECT SINGLE * FROM tadir INTO @DATA(sdfs).
-IF sy-subrc <> 0.
+            goodExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception.
+    RETURN.
+ENDTRY.
+MESSAGE w125(zbar) WITH c_foo INTO message.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs).
+IF sy-subrc <> 0.
 ENDIF.`,
         };
     }

package/build/src/rules/unnecessary_return.js

@@ -22,12 +22,12 @@ class UnnecessaryReturn extends _abap_rule_1.ABAPRule {
             shortDescription: `Finds unnecessary RETURN statements`,
             extendedInformation: `Finds unnecessary RETURN statements`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
-            badExample: `METHOD hello.
-  ...
-  RETURN.
+            badExample: `METHOD hello.
+  ...
+  RETURN.
 ENDMETHOD.`,
-            goodExample: `METHOD hello.
-  ...
+            goodExample: `METHOD hello.
+  ...
 ENDMETHOD.`,
         };
     }

package/build/src/rules/unused_methods.js

@@ -55,15 +55,15 @@ class UnusedMethods {
             key: "unused_methods",
             title: "Unused methods",
             shortDescription: `Checks for unused methods`,
-            extendedInformation: `Checks private and protected methods.
-
-Skips:
-* methods FOR TESTING
-* methods SETUP + TEARDOWN + CLASS_SETUP + CLASS_TEARDOWN in testclasses
-* class_constructor + constructor methods
-* event handlers
-* methods that are redefined
-* INCLUDEs
+            extendedInformation: `Checks private and protected methods.
+
+Skips:
+* methods FOR TESTING
+* methods SETUP + TEARDOWN + CLASS_SETUP + CLASS_TEARDOWN in testclasses
+* class_constructor + constructor methods
+* event handlers
+* methods that are redefined
+* INCLUDEs
 `,
             tags: [],
             pragma: "##CALLED",

package/build/src/rules/unused_variables.js

@@ -64,10 +64,10 @@ class UnusedVariables {
             key: "unused_variables",
             title: "Unused variables",
             shortDescription: `Checks for unused variables and constants`,
-            extendedInformation: `Skips event parameters.
-
-Note that this currently does not work if the source code uses macros.
-
+            extendedInformation: `Skips event parameters.
+
+Note that this currently does not work if the source code uses macros.
+
 Unused variables are not reported if the object contains syntax errors. Errors found in INCLUDES are reported for the main program.`,
             tags: [_irule_1.RuleTag.Quickfix],
             pragma: "##NEEDED",

package/build/src/rules/use_bool_expression.js

@@ -27,15 +27,15 @@ class UseBoolExpression extends _abap_rule_1.ABAPRule {
             shortDescription: `Use boolean expression, xsdbool from 740sp08 and up, boolc from 702 and up`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-xsdbool-to-set-boolean-variables`,
             tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `IF line IS INITIAL.
-  has_entries = abap_false.
-ELSE.
-  has_entries = abap_true.
-ENDIF.
-
+            badExample: `IF line IS INITIAL.
+  has_entries = abap_false.
+ELSE.
+  has_entries = abap_true.
+ENDIF.
+
 DATA(fsdf) = COND #( WHEN foo <> bar THEN abap_true ELSE abap_false ).`,
-            goodExample: `DATA(has_entries) = xsdbool( line IS NOT INITIAL ).
-
+            goodExample: `DATA(has_entries) = xsdbool( line IS NOT INITIAL ).
+
 DATA(fsdf) = xsdbool( foo <> bar ).`,
         };
     }

package/build/src/rules/use_line_exists.js

@@ -22,15 +22,15 @@ class UseLineExists extends _abap_rule_1.ABAPRule {
             key: "use_line_exists",
             title: "Use line_exists",
             shortDescription: `Use line_exists, from 740sp02 and up`,
-            extendedInformation: `
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-line_exists-to-read-table-or-loop-at
-
+            extendedInformation: `
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-line_exists-to-read-table-or-loop-at
+
 Not reported if the READ TABLE statement contains BINARY SEARCH.`,
             tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
-            badExample: `READ TABLE my_table TRANSPORTING NO FIELDS WITH KEY key = 'A'.
-IF sy-subrc = 0.
+            badExample: `READ TABLE my_table TRANSPORTING NO FIELDS WITH KEY key = 'A'.
+IF sy-subrc = 0.
 ENDIF.`,
-            goodExample: `IF line_exists( my_table[ key = 'A' ] ).
+            goodExample: `IF line_exists( my_table[ key = 'A' ] ).
 ENDIF.`,
         };
     }

package/build/src/rules/use_new.js

@@ -23,10 +23,10 @@ class UseNew extends _abap_rule_1.ABAPRule {
             key: "use_new",
             title: "Use NEW",
             shortDescription: `Checks for deprecated CREATE OBJECT statements.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-new-to-create-object
-
-If the target variable is referenced in the CREATE OBJECT statement, no errors are issued
-
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-new-to-create-object
+
+If the target variable is referenced in the CREATE OBJECT statement, no errors are issued
+
 Applicable from v740sp02 and up`,
             badExample: `CREATE OBJECT ref.`,
             goodExample: `ref = NEW #( ).`,

package/build/src/rules/when_others_last.js

@@ -21,13 +21,13 @@ class WhenOthersLast extends _abap_rule_1.ABAPRule {
             title: "WHEN OTHERS last",
             shortDescription: `Checks that WHEN OTHERS is placed the last within a CASE statement.`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `CASE bar.
-  WHEN OTHERS.
-  WHEN 2.
+            badExample: `CASE bar.
+  WHEN OTHERS.
+  WHEN 2.
 ENDCASE.`,
-            goodExample: `CASE bar.
-  WHEN 2.
-  WHEN OTHERS.
+            goodExample: `CASE bar.
+  WHEN 2.
+  WHEN OTHERS.
 ENDCASE.`,
         };
     }

package/package.json

@@ -1,67 +1,67 @@
-{
-    "name": "@abaplint/core",
-    "version": "2.94.9",
-    "description": "abaplint - Core API",
-    "main": "build/src/index.js",
-    "typings": "build/abaplint.d.ts",
-    "scripts": {
-        "lint": "eslint src/**/*.ts test/**/*.ts --format unix",
-        "lint:fix": "eslint src/**/*.ts test/**/*.ts --format unix --fix",
-        "compile": "tsc && sh scripts/version.sh",
-        "test": "npm run compile && mocha --timeout 1000 && npm run lint && npm run schema && api-extractor run",
-        "test:only": "npm run compile && mocha",
-        "test:parallel": "npm run compile && mocha --timeout 1000 --parallel --reporter dot",
-        "coverage": "npm run compile && c8 mocha && c8 report --reporter=html",
-        "lexer_performance": "tsc && curl -o lexer_performance.abap https://raw.githubusercontent.com/abapGit/build/main/zabapgit_standalone.prog.abap && node build/adhoc/lexer_performance.js",
-        "parser_performance": "tsc && curl -o lexer_performance.abap https://raw.githubusercontent.com/abapGit/build/main/zabapgit_standalone.prog.abap && node build/adhoc/parser_performance.js",
-        "schema": "node scripts/schema.js > scripts/schema.ts && ts-json-schema-generator --tsconfig tsconfig_schema.json --jsDoc extended --path scripts/schema.ts > scripts/schema.json && node scripts/schema_post.js",
-        "publish:minor": "npm --no-git-tag-version version minor && rm -rf build && npm install && npm run test && npm publish --access public",
-        "publish:patch": "npm --no-git-tag-version version patch && rm -rf build && npm install && npm run test && npm publish --access public"
-    },
-    "mocha": {
-        "recursive": true,
-        "reporter": "progress",
-        "spec": "build/test/**/*.js",
-        "require": "source-map-support/register"
-    },
-    "c8": {
-        "include": [
-            "build/src/**/*.js"
-        ]
-    },
-    "repository": {
-        "type": "git",
-        "url": "git+https://github.com/abaplint/abaplint.git"
-    },
-    "engines": {
-        "node": ">=12.0.0"
-    },
-    "keywords": [
-        "ABAP",
-        "lint"
-    ],
-    "author": "Lars Hvam Petersen",
-    "license": "MIT",
-    "bugs": {
-        "url": "https://github.com/abaplint/abaplint/issues"
-    },
-    "homepage": "https://abaplint.org",
-    "devDependencies": {
-        "@microsoft/api-extractor": "^7.33.7",
-        "@types/chai": "^4.3.4",
-        "@types/mocha": "^10.0.1",
-        "@types/node": "^18.11.17",
-        "chai": "^4.3.7",
-        "eslint": "^8.30.0",
-        "mocha": "^10.2.0",
-        "c8": "^7.12.0",
-        "source-map-support": "^0.5.21",
-        "ts-json-schema-generator": "^1.2.0",
-        "typescript": "^4.9.4"
-    },
-    "dependencies": {
-        "fast-xml-parser": "^4.0.12",
-        "json5": "^2.2.2",
-        "vscode-languageserver-types": "^3.17.2"
-    }
-}
+{
+    "name": "@abaplint/core",
+    "version": "2.94.11",
+    "description": "abaplint - Core API",
+    "main": "build/src/index.js",
+    "typings": "build/abaplint.d.ts",
+    "scripts": {
+        "lint": "eslint src/**/*.ts test/**/*.ts --format unix",
+        "lint:fix": "eslint src/**/*.ts test/**/*.ts --format unix --fix",
+        "compile": "tsc && sh scripts/version.sh",
+        "test": "npm run compile && mocha --timeout 1000 && npm run lint && npm run schema && api-extractor run",
+        "test:only": "npm run compile && mocha",
+        "test:parallel": "npm run compile && mocha --timeout 1000 --parallel --reporter dot",
+        "coverage": "npm run compile && c8 mocha && c8 report --reporter=html",
+        "lexer_performance": "tsc && curl -o lexer_performance.abap https://raw.githubusercontent.com/abapGit/build/main/zabapgit_standalone.prog.abap && node build/adhoc/lexer_performance.js",
+        "parser_performance": "tsc && curl -o lexer_performance.abap https://raw.githubusercontent.com/abapGit/build/main/zabapgit_standalone.prog.abap && node build/adhoc/parser_performance.js",
+        "schema": "node scripts/schema.js > scripts/schema.ts && ts-json-schema-generator --tsconfig tsconfig_schema.json --jsDoc extended --path scripts/schema.ts > scripts/schema.json && node scripts/schema_post.js",
+        "publish:minor": "npm --no-git-tag-version version minor && rm -rf build && npm install && npm run test && npm publish --access public",
+        "publish:patch": "npm --no-git-tag-version version patch && rm -rf build && npm install && npm run test && npm publish --access public"
+    },
+    "mocha": {
+        "recursive": true,
+        "reporter": "progress",
+        "spec": "build/test/**/*.js",
+        "require": "source-map-support/register"
+    },
+    "c8": {
+        "include": [
+            "build/src/**/*.js"
+        ]
+    },
+    "repository": {
+        "type": "git",
+        "url": "git+https://github.com/abaplint/abaplint.git"
+    },
+    "engines": {
+        "node": ">=12.0.0"
+    },
+    "keywords": [
+        "ABAP",
+        "lint"
+    ],
+    "author": "Lars Hvam Petersen",
+    "license": "MIT",
+    "bugs": {
+        "url": "https://github.com/abaplint/abaplint/issues"
+    },
+    "homepage": "https://abaplint.org",
+    "devDependencies": {
+        "@microsoft/api-extractor": "^7.33.7",
+        "@types/chai": "^4.3.4",
+        "@types/mocha": "^10.0.1",
+        "@types/node": "^18.11.18",
+        "chai": "^4.3.7",
+        "eslint": "^8.30.0",
+        "mocha": "^10.2.0",
+        "c8": "^7.12.0",
+        "source-map-support": "^0.5.21",
+        "ts-json-schema-generator": "^1.2.0",
+        "typescript": "^4.9.4"
+    },
+    "dependencies": {
+        "fast-xml-parser": "^4.0.12",
+        "json5": "^2.2.2",
+        "vscode-languageserver-types": "^3.17.2"
+    }
+}