@abaplint/core 2.94.12 → 2.94.13

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (3) hide show
  1. package/build/src/registry.js +1 -1
  2. package/build/src/rules/cyclic_oo.js +8 -5
  3. package/package.json +2 -2
package/build/src/registry.js CHANGED
@@ -63,7 +63,7 @@ class Registry {
63
63
  }
64
64
  static abaplintVersion() {
65
65
  // magic, see build script "version.sh"
66
- return "2.94.12";
66
+ return "2.94.13";
67
67
  }
68
68
  getDDICReferences() {
69
69
  return this.references;
package/build/src/rules/cyclic_oo.js CHANGED
@@ -34,7 +34,9 @@ class CyclicOO {
34
34
  shortDescription: `Finds cyclic OO references`,
35
35
  extendedInformation: `Runs for global INTF + CLAS objects
36
36
 
37
- Objects must be without syntax errors for this rule to take effect`,
37
+ Objects must be without syntax errors for this rule to take effect
38
+
39
+ References in testclass includes are ignored`,
38
40
  };
39
41
  }
40
42
  getConfig() {
@@ -101,7 +103,7 @@ Objects must be without syntax errors for this rule to take effect`,
101
103
  previous[obj.getName()] = true;
102
104
  const path = this.findCycle(obj.getName(), obj.getName(), previous);
103
105
  if (path) {
104
- const message = "Cyclic definition/usage: " + path;
106
+ const message = "Cyclic definition/usage: " + obj.getName() + " -> " + path;
105
107
  return [issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.conf.severity)];
106
108
  }
107
109
  return [];
@@ -113,13 +115,13 @@ Objects must be without syntax errors for this rule to take effect`,
113
115
  }
114
116
  for (const e of this.edges[current]) {
115
117
  if (e === source) {
116
- return Object.keys(previous).join(" -> ") + " -> " + source;
118
+ return e;
117
119
  }
118
120
  if (previous[e] === undefined) { // dont revisit vertices
119
121
  previous[e] = true;
120
122
  const found = this.findCycle(source, e, previous);
121
123
  if (found) {
122
- return found;
124
+ return e + " -> " + found;
123
125
  }
124
126
  }
125
127
  }
@@ -134,7 +136,8 @@ Objects must be without syntax errors for this rule to take effect`,
134
136
  continue;
135
137
  }
136
138
  if (this.conf.skipTestclasses === true
137
- && r.position.getFilename().includes(".testclasses.abap")) {
139
+ && (r.position.getFilename().includes(".testclasses.")
140
+ || r.resolved.getFilename().includes(".testclasses."))) {
138
141
  continue;
139
142
  }
140
143
  if (r.referenceType === _reference_1.ReferenceType.ObjectOrientedReference
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@abaplint/core",
3
- "version": "2.94.12",
3
+ "version": "2.94.13",
4
4
  "description": "abaplint - Core API",
5
5
  "main": "build/src/index.js",
6
6
  "typings": "build/abaplint.d.ts",
@@ -52,7 +52,7 @@
52
52
  "@types/mocha": "^10.0.1",
53
53
  "@types/node": "^18.11.18",
54
54
  "chai": "^4.3.7",
55
- "eslint": "^8.30.0",
55
+ "eslint": "^8.31.0",
56
56
  "mocha": "^10.2.0",
57
57
  "c8": "^7.12.0",
58
58
  "source-map-support": "^0.5.21",