@abaplint/core 2.94.11 → 2.94.13

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.94.11";
+        return "2.94.13";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/cyclic_oo.js

@@ -15,8 +15,10 @@ class CyclicOOConf extends _basic_rule_config_1.BasicRuleConfig {
          * @uniqueItems true
         */
         this.skip = [];
-        /** Skips shared memory enabled classes*/
+        /** Skips shared memory enabled classes */
         this.skipSharedMemory = true;
+        /** Skip testclass inclues */
+        this.skipTestclasses = true;
     }
 }
 exports.CyclicOOConf = CyclicOOConf;
@@ -32,7 +34,9 @@ class CyclicOO {
             shortDescription: `Finds cyclic OO references`,
             extendedInformation: `Runs for global INTF + CLAS objects
 
-Objects must be without syntax errors for this rule to take effect`,
+Objects must be without syntax errors for this rule to take effect
+
+References in testclass includes are ignored`,
         };
     }
     getConfig() {
@@ -99,7 +103,7 @@ Objects must be without syntax errors for this rule to take effect`,
         previous[obj.getName()] = true;
         const path = this.findCycle(obj.getName(), obj.getName(), previous);
         if (path) {
-            const message = "Cyclic definition/usage: " + path;
+            const message = "Cyclic definition/usage: " + obj.getName() + " -> " + path;
             return [issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.conf.severity)];
         }
         return [];
@@ -111,13 +115,13 @@ Objects must be without syntax errors for this rule to take effect`,
         }
         for (const e of this.edges[current]) {
             if (e === source) {
-                return Object.keys(previous).join(" -> ") + " -> " + source;
+                return e;
             }
             if (previous[e] === undefined) { // dont revisit vertices
                 previous[e] = true;
                 const found = this.findCycle(source, e, previous);
                 if (found) {
-                    return found;
+                    return e + " -> " + found;
                 }
             }
         }
@@ -131,6 +135,11 @@ Objects must be without syntax errors for this rule to take effect`,
                 || r.resolved.getFilename() === _builtin_1.BuiltIn.filename) {
                 continue;
             }
+            if (this.conf.skipTestclasses === true
+                && (r.position.getFilename().includes(".testclasses.")
+                    || r.resolved.getFilename().includes(".testclasses."))) {
+                continue;
+            }
             if (r.referenceType === _reference_1.ReferenceType.ObjectOrientedReference
                 && ((_a = r.extra) === null || _a === void 0 ? void 0 : _a.ooName)) {
                 if (this.edges[from] === undefined) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.94.11",
+    "version": "2.94.13",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -52,7 +52,7 @@
         "@types/mocha": "^10.0.1",
         "@types/node": "^18.11.18",
         "chai": "^4.3.7",
-        "eslint": "^8.30.0",
+        "eslint": "^8.31.0",
         "mocha": "^10.2.0",
         "c8": "^7.12.0",
         "source-map-support": "^0.5.21",