@abaplint/core 2.93.8 → 2.93.11
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -6
- package/adhoc/lexer_performance.ts +16 -16
- package/build/src/abap/2_statements/expressions/for.js +1 -1
- package/build/src/abap/5_syntax/statements/sort.js +32 -2
- package/build/src/abap/flow/flow_graph.js +7 -7
- package/build/src/lsp/help.js +7 -7
- package/build/src/registry.js +1 -1
- package/build/src/rules/7bit_ascii.js +2 -2
- package/build/src/rules/abapdoc.js +1 -1
- package/build/src/rules/align_parameters.js +39 -39
- package/build/src/rules/ambiguous_statement.js +5 -5
- package/build/src/rules/avoid_use.js +8 -8
- package/build/src/rules/begin_end_names.js +4 -4
- package/build/src/rules/begin_single_include.js +12 -12
- package/build/src/rules/call_transaction_authority_check.js +3 -3
- package/build/src/rules/cds_comment_style.js +4 -4
- package/build/src/rules/cds_legacy_view.js +4 -4
- package/build/src/rules/chain_mainly_declarations.js +4 -4
- package/build/src/rules/change_if_to_case.js +6 -6
- package/build/src/rules/check_abstract.js +2 -2
- package/build/src/rules/check_comments.js +4 -4
- package/build/src/rules/check_include.js +3 -3
- package/build/src/rules/check_subrc.js +8 -8
- package/build/src/rules/classic_exceptions_overlap.js +8 -8
- package/build/src/rules/commented_code.js +1 -1
- package/build/src/rules/constructor_visibility_public.js +4 -4
- package/build/src/rules/contains_tab.js +2 -2
- package/build/src/rules/dangerous_statement.js +1 -1
- package/build/src/rules/definitions_top.js +2 -2
- package/build/src/rules/downport.js +82 -82
- package/build/src/rules/exit_or_check.js +3 -3
- package/build/src/rules/exporting.js +1 -1
- package/build/src/rules/forbidden_identifier.js +1 -1
- package/build/src/rules/forbidden_void_type.js +2 -2
- package/build/src/rules/functional_writing.js +17 -17
- package/build/src/rules/global_class.js +8 -8
- package/build/src/rules/identical_conditions.js +2 -2
- package/build/src/rules/identical_contents.js +14 -14
- package/build/src/rules/identical_descriptions.js +4 -4
- package/build/src/rules/if_in_if.js +7 -7
- package/build/src/rules/implement_methods.js +3 -3
- package/build/src/rules/in_statement_indentation.js +11 -11
- package/build/src/rules/intf_referencing_clas.js +3 -3
- package/build/src/rules/line_break_style.js +2 -2
- package/build/src/rules/line_length.js +1 -1
- package/build/src/rules/line_only_punc.js +1 -1
- package/build/src/rules/local_variable_names.js +2 -2
- package/build/src/rules/many_parentheses.js +10 -10
- package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
- package/build/src/rules/max_one_statement.js +5 -5
- package/build/src/rules/method_overwrites_builtin.js +2 -2
- package/build/src/rules/nesting.js +1 -1
- package/build/src/rules/no_chained_assignment.js +1 -1
- package/build/src/rules/no_external_form_calls.js +2 -2
- package/build/src/rules/no_inline_in_optional_branches.js +11 -11
- package/build/src/rules/no_public_attributes.js +1 -1
- package/build/src/rules/no_yoda_conditions.js +4 -4
- package/build/src/rules/nrob_consistency.js +2 -2
- package/build/src/rules/obsolete_statement.js +42 -42
- package/build/src/rules/omit_parameter_name.js +3 -3
- package/build/src/rules/omit_receiving.js +13 -13
- package/build/src/rules/parser_702_chaining.js +2 -2
- package/build/src/rules/parser_error.js +2 -2
- package/build/src/rules/parser_missing_space.js +1 -1
- package/build/src/rules/prefer_inline.js +16 -16
- package/build/src/rules/prefer_is_not.js +7 -7
- package/build/src/rules/prefer_raise_exception_new.js +3 -3
- package/build/src/rules/prefer_returning_to_exporting.js +1 -1
- package/build/src/rules/prefer_xsdbool.js +2 -2
- package/build/src/rules/remove_descriptions.js +4 -4
- package/build/src/rules/rfc_error_handling.js +9 -9
- package/build/src/rules/select_add_order_by.js +5 -5
- package/build/src/rules/select_performance.js +5 -5
- package/build/src/rules/sicf_consistency.js +2 -2
- package/build/src/rules/space_before_dot.js +2 -2
- package/build/src/rules/start_at_tab.js +1 -1
- package/build/src/rules/sy_modification.js +4 -4
- package/build/src/rules/tabl_enhancement_category.js +2 -2
- package/build/src/rules/unnecessary_pragma.js +22 -22
- package/build/src/rules/unused_methods.js +9 -9
- package/build/src/rules/unused_variables.js +4 -6
- package/build/src/rules/use_bool_expression.js +8 -8
- package/build/src/rules/use_line_exists.js +6 -6
- package/build/src/rules/use_new.js +4 -4
- package/build/src/rules/when_others_last.js +6 -6
- package/package.json +66 -66
|
@@ -38,36 +38,36 @@ class Downport {
|
|
|
38
38
|
key: "downport",
|
|
39
39
|
title: "Downport statement",
|
|
40
40
|
shortDescription: `Experimental downport functionality`,
|
|
41
|
-
extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
|
|
42
|
-
a higher level language version. If successful, various rules are applied to downport the statement.
|
|
43
|
-
Target downport version is always v702, thus rule is only enabled if target version is v702.
|
|
44
|
-
|
|
45
|
-
Current rules:
|
|
46
|
-
* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
|
|
47
|
-
* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
|
|
48
|
-
* FIELD-SYMBOL() definitions are outlined
|
|
49
|
-
* CONV is outlined
|
|
50
|
-
* COND is outlined
|
|
51
|
-
* REDUCE is outlined
|
|
52
|
-
* SWITCH is outlined
|
|
53
|
-
* APPEND expression is outlined
|
|
54
|
-
* INSERT expression is outlined
|
|
55
|
-
* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
|
|
56
|
-
* CAST changed to ?=
|
|
57
|
-
* LOOP AT method_call( ) is outlined
|
|
58
|
-
* VALUE # with structure fields
|
|
59
|
-
* VALUE # with internal table lines
|
|
60
|
-
* Table Expressions are outlined
|
|
61
|
-
* SELECT INTO @DATA definitions are outlined
|
|
62
|
-
* Some occurrences of string template formatting option ALPHA changed to function module call
|
|
63
|
-
* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
|
|
64
|
-
* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
|
|
65
|
-
* RAISE EXCEPTION ... MESSAGE
|
|
66
|
-
* Moving with +=, -=, /=, *=, &&= is expanded
|
|
67
|
-
* line_exists and line_index is downported to READ TABLE
|
|
68
|
-
* ENUMs, but does not nessesarily give the correct type and value
|
|
69
|
-
* MESSAGE with non simple source
|
|
70
|
-
|
|
41
|
+
extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
|
|
42
|
+
a higher level language version. If successful, various rules are applied to downport the statement.
|
|
43
|
+
Target downport version is always v702, thus rule is only enabled if target version is v702.
|
|
44
|
+
|
|
45
|
+
Current rules:
|
|
46
|
+
* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
|
|
47
|
+
* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
|
|
48
|
+
* FIELD-SYMBOL() definitions are outlined
|
|
49
|
+
* CONV is outlined
|
|
50
|
+
* COND is outlined
|
|
51
|
+
* REDUCE is outlined
|
|
52
|
+
* SWITCH is outlined
|
|
53
|
+
* APPEND expression is outlined
|
|
54
|
+
* INSERT expression is outlined
|
|
55
|
+
* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
|
|
56
|
+
* CAST changed to ?=
|
|
57
|
+
* LOOP AT method_call( ) is outlined
|
|
58
|
+
* VALUE # with structure fields
|
|
59
|
+
* VALUE # with internal table lines
|
|
60
|
+
* Table Expressions are outlined
|
|
61
|
+
* SELECT INTO @DATA definitions are outlined
|
|
62
|
+
* Some occurrences of string template formatting option ALPHA changed to function module call
|
|
63
|
+
* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
|
|
64
|
+
* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
|
|
65
|
+
* RAISE EXCEPTION ... MESSAGE
|
|
66
|
+
* Moving with +=, -=, /=, *=, &&= is expanded
|
|
67
|
+
* line_exists and line_index is downported to READ TABLE
|
|
68
|
+
* ENUMs, but does not nessesarily give the correct type and value
|
|
69
|
+
* MESSAGE with non simple source
|
|
70
|
+
|
|
71
71
|
Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
|
|
72
72
|
tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
|
|
73
73
|
};
|
|
@@ -468,10 +468,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
|
|
|
468
468
|
const fieldName = f.concatTokens();
|
|
469
469
|
fieldDefinition += indentation + " " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
|
|
470
470
|
}
|
|
471
|
-
fieldDefinition = `DATA: BEGIN OF ${name},
|
|
471
|
+
fieldDefinition = `DATA: BEGIN OF ${name},
|
|
472
472
|
${fieldDefinition}${indentation} END OF ${name}.`;
|
|
473
473
|
}
|
|
474
|
-
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
|
|
474
|
+
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
|
|
475
475
|
${indentation}`);
|
|
476
476
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
|
|
477
477
|
const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
@@ -515,12 +515,12 @@ ${indentation}`);
|
|
|
515
515
|
}
|
|
516
516
|
const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
517
517
|
const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
|
|
518
|
-
let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
|
|
519
|
-
${fieldDefinitions}${indentation} END OF ${uniqueName}.
|
|
520
|
-
${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
|
|
518
|
+
let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
|
|
519
|
+
${fieldDefinitions}${indentation} END OF ${uniqueName}.
|
|
520
|
+
${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
|
|
521
521
|
${indentation}`);
|
|
522
522
|
if (fieldDefinitions === "") {
|
|
523
|
-
fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
|
|
523
|
+
fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
|
|
524
524
|
${indentation}`);
|
|
525
525
|
}
|
|
526
526
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
|
|
@@ -565,7 +565,7 @@ ${indentation}`);
|
|
|
565
565
|
const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
566
566
|
const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
|
|
567
567
|
const firstToken = high.getFirstToken();
|
|
568
|
-
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
|
|
568
|
+
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
|
|
569
569
|
${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
|
|
570
570
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
|
|
571
571
|
const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
@@ -587,7 +587,7 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
|
|
|
587
587
|
const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
588
588
|
const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
|
|
589
589
|
const firstToken = high.getFirstToken();
|
|
590
|
-
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
|
|
590
|
+
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
|
|
591
591
|
${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
|
|
592
592
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
|
|
593
593
|
const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
@@ -629,14 +629,14 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
|
|
|
629
629
|
const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
|
|
630
630
|
const firstToken = high.getFirstToken();
|
|
631
631
|
// note that the tabix restore should be done before throwing the exception
|
|
632
|
-
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
|
|
633
|
-
${indentation}DATA ${tabixBackup} LIKE sy-tabix.
|
|
634
|
-
${indentation}${tabixBackup} = sy-tabix.
|
|
635
|
-
${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
|
|
636
|
-
${indentation}sy-tabix = ${tabixBackup}.
|
|
637
|
-
${indentation}IF sy-subrc <> 0.
|
|
638
|
-
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
639
|
-
${indentation}ENDIF.
|
|
632
|
+
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
|
|
633
|
+
${indentation}DATA ${tabixBackup} LIKE sy-tabix.
|
|
634
|
+
${indentation}${tabixBackup} = sy-tabix.
|
|
635
|
+
${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
|
|
636
|
+
${indentation}sy-tabix = ${tabixBackup}.
|
|
637
|
+
${indentation}IF sy-subrc <> 0.
|
|
638
|
+
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
639
|
+
${indentation}ENDIF.
|
|
640
640
|
${indentation}`);
|
|
641
641
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
|
|
642
642
|
const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
@@ -690,7 +690,7 @@ ${indentation}`);
|
|
|
690
690
|
const className = classNames[0].concatTokens();
|
|
691
691
|
const targetName = (_b = target.findFirstExpression(Expressions.TargetField)) === null || _b === void 0 ? void 0 : _b.concatTokens();
|
|
692
692
|
const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
693
|
-
const code = ` DATA ${targetName} TYPE REF TO ${className}.
|
|
693
|
+
const code = ` DATA ${targetName} TYPE REF TO ${className}.
|
|
694
694
|
${indentation}CATCH ${className} INTO ${targetName}.`;
|
|
695
695
|
const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), code);
|
|
696
696
|
return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
|
|
@@ -813,11 +813,11 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
|
|
|
813
813
|
const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
814
814
|
const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
815
815
|
const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
816
|
-
const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
|
|
817
|
-
${indentation}${uniqueName1}-msgid = ${id === null || id === void 0 ? void 0 : id.toUpperCase()}.
|
|
818
|
-
${indentation}${uniqueName1}-msgno = ${number}.
|
|
819
|
-
${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
|
|
820
|
-
${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
|
|
816
|
+
const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
|
|
817
|
+
${indentation}${uniqueName1}-msgid = ${id === null || id === void 0 ? void 0 : id.toUpperCase()}.
|
|
818
|
+
${indentation}${uniqueName1}-msgno = ${number}.
|
|
819
|
+
${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
|
|
820
|
+
${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
|
|
821
821
|
${indentation}RAISE EXCEPTION ${uniqueName2}.`;
|
|
822
822
|
const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
|
|
823
823
|
return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
|
|
@@ -934,15 +934,15 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
|
|
|
934
934
|
}
|
|
935
935
|
const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
936
936
|
const uniqueFS = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
937
|
-
code += ` items LIKE ${loopSourceName},
|
|
938
|
-
END OF ${groupTargetName}type.
|
|
939
|
-
DATA ${groupTargetName}tab TYPE STANDARD TABLE OF ${groupTargetName}type WITH DEFAULT KEY.
|
|
940
|
-
DATA ${uniqueName} LIKE LINE OF ${groupTargetName}tab.
|
|
941
|
-
LOOP AT ${loopSourceName} ${(_g = high.findFirstExpression(Expressions.LoopTarget)) === null || _g === void 0 ? void 0 : _g.concatTokens()}.
|
|
942
|
-
READ TABLE ${groupTargetName}tab ASSIGNING FIELD-SYMBOL(<${uniqueFS}>) WITH KEY ${condition}.
|
|
943
|
-
IF sy-subrc = 0.
|
|
944
|
-
<${uniqueFS}>-${groupCountName} = <${uniqueFS}>-${groupCountName} + 1.
|
|
945
|
-
INSERT ${loopTargetName}->* INTO TABLE <${uniqueFS}>-items.
|
|
937
|
+
code += ` items LIKE ${loopSourceName},
|
|
938
|
+
END OF ${groupTargetName}type.
|
|
939
|
+
DATA ${groupTargetName}tab TYPE STANDARD TABLE OF ${groupTargetName}type WITH DEFAULT KEY.
|
|
940
|
+
DATA ${uniqueName} LIKE LINE OF ${groupTargetName}tab.
|
|
941
|
+
LOOP AT ${loopSourceName} ${(_g = high.findFirstExpression(Expressions.LoopTarget)) === null || _g === void 0 ? void 0 : _g.concatTokens()}.
|
|
942
|
+
READ TABLE ${groupTargetName}tab ASSIGNING FIELD-SYMBOL(<${uniqueFS}>) WITH KEY ${condition}.
|
|
943
|
+
IF sy-subrc = 0.
|
|
944
|
+
<${uniqueFS}>-${groupCountName} = <${uniqueFS}>-${groupCountName} + 1.
|
|
945
|
+
INSERT ${loopTargetName}->* INTO TABLE <${uniqueFS}>-items.
|
|
946
946
|
ELSE.\n`;
|
|
947
947
|
code += ` CLEAR ${uniqueName}.\n`;
|
|
948
948
|
for (const c of group.findAllExpressions(Expressions.LoopGroupByComponent)) {
|
|
@@ -950,8 +950,8 @@ ELSE.\n`;
|
|
|
950
950
|
}
|
|
951
951
|
code += ` INSERT ${loopTargetName}->* INTO TABLE ${uniqueName}-items.\n`;
|
|
952
952
|
code += ` INSERT ${uniqueName} INTO TABLE ${groupTargetName}tab.\n`;
|
|
953
|
-
code += `ENDIF.
|
|
954
|
-
ENDLOOP.
|
|
953
|
+
code += `ENDIF.
|
|
954
|
+
ENDLOOP.
|
|
955
955
|
LOOP AT ${groupTargetName}tab ${groupTarget}.`;
|
|
956
956
|
let fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), code);
|
|
957
957
|
for (const l of ((_h = highFile.getStructure()) === null || _h === void 0 ? void 0 : _h.findAllStructures(Structures.Loop)) || []) {
|
|
@@ -1085,7 +1085,7 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
|
|
|
1085
1085
|
const enumName = (_b = high.findExpressionAfterToken("ENUM")) === null || _b === void 0 ? void 0 : _b.concatTokens();
|
|
1086
1086
|
const structureName = (_c = high.findExpressionAfterToken("STRUCTURE")) === null || _c === void 0 ? void 0 : _c.concatTokens();
|
|
1087
1087
|
// all ENUMS are char like?
|
|
1088
|
-
let code = `TYPES ${enumName} TYPE string.
|
|
1088
|
+
let code = `TYPES ${enumName} TYPE string.
|
|
1089
1089
|
CONSTANTS: BEGIN OF ${structureName},\n`;
|
|
1090
1090
|
let count = 1;
|
|
1091
1091
|
for (const e of enumStructure.findDirectStatements(Statements.TypeEnum).concat(enumStructure.findDirectStatements(Statements.Type))) {
|
|
@@ -1129,14 +1129,14 @@ CONSTANTS: BEGIN OF ${structureName},\n`;
|
|
|
1129
1129
|
const tabixBackup = this.uniqueName(low.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
1130
1130
|
const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
|
|
1131
1131
|
// restore tabix before exeption
|
|
1132
|
-
const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
|
|
1133
|
-
${indentation}DATA ${tabixBackup} LIKE sy-tabix.
|
|
1134
|
-
${indentation}${tabixBackup} = sy-tabix.
|
|
1135
|
-
${indentation}READ TABLE ${tName} ${condition}ASSIGNING ${uniqueName}.
|
|
1136
|
-
${indentation}sy-tabix = ${tabixBackup}.
|
|
1137
|
-
${indentation}IF sy-subrc <> 0.
|
|
1138
|
-
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
1139
|
-
${indentation}ENDIF.
|
|
1132
|
+
const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
|
|
1133
|
+
${indentation}DATA ${tabixBackup} LIKE sy-tabix.
|
|
1134
|
+
${indentation}${tabixBackup} = sy-tabix.
|
|
1135
|
+
${indentation}READ TABLE ${tName} ${condition}ASSIGNING ${uniqueName}.
|
|
1136
|
+
${indentation}sy-tabix = ${tabixBackup}.
|
|
1137
|
+
${indentation}IF sy-subrc <> 0.
|
|
1138
|
+
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
1139
|
+
${indentation}ENDIF.
|
|
1140
1140
|
${indentation}${uniqueName}`;
|
|
1141
1141
|
const start = target.getFirstToken().getStart();
|
|
1142
1142
|
const end = (_a = tableExpression.findDirectTokenByText("]")) === null || _a === void 0 ? void 0 : _a.getEnd();
|
|
@@ -1237,11 +1237,11 @@ ${indentation}${uniqueName}`;
|
|
|
1237
1237
|
const topTarget = (_c = high.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
|
|
1238
1238
|
const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
1239
1239
|
if (top === false) {
|
|
1240
|
-
const code = `DATA ${uniqueName} TYPE string.
|
|
1241
|
-
${indentation}CALL FUNCTION '${functionName}'
|
|
1242
|
-
${indentation} EXPORTING
|
|
1243
|
-
${indentation} input = ${source}
|
|
1244
|
-
${indentation} IMPORTING
|
|
1240
|
+
const code = `DATA ${uniqueName} TYPE string.
|
|
1241
|
+
${indentation}CALL FUNCTION '${functionName}'
|
|
1242
|
+
${indentation} EXPORTING
|
|
1243
|
+
${indentation} input = ${source}
|
|
1244
|
+
${indentation} IMPORTING
|
|
1245
1245
|
${indentation} output = ${uniqueName}.\n`;
|
|
1246
1246
|
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
|
|
1247
1247
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, child.getFirstToken().getStart(), child.getLastToken().getEnd(), uniqueName);
|
|
@@ -1249,10 +1249,10 @@ ${indentation} output = ${uniqueName}.\n`;
|
|
|
1249
1249
|
return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
|
|
1250
1250
|
}
|
|
1251
1251
|
else {
|
|
1252
|
-
const code = `CALL FUNCTION '${functionName}'
|
|
1253
|
-
${indentation} EXPORTING
|
|
1254
|
-
${indentation} input = ${source}
|
|
1255
|
-
${indentation} IMPORTING
|
|
1252
|
+
const code = `CALL FUNCTION '${functionName}'
|
|
1253
|
+
${indentation} EXPORTING
|
|
1254
|
+
${indentation} input = ${source}
|
|
1255
|
+
${indentation} IMPORTING
|
|
1256
1256
|
${indentation} output = ${topTarget}.`;
|
|
1257
1257
|
const fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), code);
|
|
1258
1258
|
return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
|
|
@@ -1291,7 +1291,7 @@ ${indentation} output = ${topTarget}.`;
|
|
|
1291
1291
|
if (sourceName === undefined) {
|
|
1292
1292
|
return undefined;
|
|
1293
1293
|
}
|
|
1294
|
-
const concat = node.concatTokens();
|
|
1294
|
+
const concat = node.concatTokens().toUpperCase();
|
|
1295
1295
|
if (concat.includes(" REFERENCE INTO ")) {
|
|
1296
1296
|
return undefined;
|
|
1297
1297
|
}
|
|
@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
|
|
|
24
24
|
return {
|
|
25
25
|
key: "exit_or_check",
|
|
26
26
|
title: "Find EXIT or CHECK outside loops",
|
|
27
|
-
shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
|
|
27
|
+
shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
|
|
28
28
|
Use RETURN to leave procesing blocks instead.`,
|
|
29
|
-
extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
|
|
30
|
-
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
|
|
29
|
+
extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
|
|
30
|
+
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
|
|
31
31
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
|
|
33
33
|
};
|
|
@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
|
|
|
22
22
|
shortDescription: `Detects EXPORTING statements which can be omitted.`,
|
|
23
23
|
badExample: `call_method( EXPORTING foo = bar ).`,
|
|
24
24
|
goodExample: `call_method( foo = bar ).`,
|
|
25
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
|
|
25
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
|
|
26
26
|
https://docs.abapopenchecks.org/checks/30/`,
|
|
27
27
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
28
28
|
};
|
|
@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
|
|
|
26
26
|
key: "forbidden_identifier",
|
|
27
27
|
title: "Forbidden Identifier",
|
|
28
28
|
shortDescription: `Forbid use of specified identifiers, list of regex.`,
|
|
29
|
-
extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
|
|
29
|
+
extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
|
|
30
30
|
https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
|
|
31
31
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
32
32
|
};
|
|
@@ -28,8 +28,8 @@ class ForbiddenVoidType {
|
|
|
28
28
|
key: "forbidden_void_type",
|
|
29
29
|
title: "Forbidden Void Types",
|
|
30
30
|
shortDescription: `Avoid usage of specified void types.`,
|
|
31
|
-
extendedInformation: `Inspiration:
|
|
32
|
-
BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
|
|
31
|
+
extendedInformation: `Inspiration:
|
|
32
|
+
BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
|
|
33
33
|
DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
|
|
34
34
|
};
|
|
35
35
|
}
|
|
@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
|
|
|
28
28
|
key: "functional_writing",
|
|
29
29
|
title: "Use functional writing",
|
|
30
30
|
shortDescription: `Detects usage of call method when functional style calls can be used.`,
|
|
31
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
|
|
31
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
|
|
32
32
|
https://docs.abapopenchecks.org/checks/07/`,
|
|
33
33
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
34
|
-
badExample: `CALL METHOD zcl_class=>method( ).
|
|
35
|
-
CALL METHOD cl_abap_typedescr=>describe_by_name
|
|
36
|
-
EXPORTING
|
|
37
|
-
p_name = 'NAME'
|
|
38
|
-
RECEIVING
|
|
39
|
-
p_descr_ref = lr_typedescr
|
|
40
|
-
EXCEPTIONS
|
|
41
|
-
type_not_found = 1
|
|
34
|
+
badExample: `CALL METHOD zcl_class=>method( ).
|
|
35
|
+
CALL METHOD cl_abap_typedescr=>describe_by_name
|
|
36
|
+
EXPORTING
|
|
37
|
+
p_name = 'NAME'
|
|
38
|
+
RECEIVING
|
|
39
|
+
p_descr_ref = lr_typedescr
|
|
40
|
+
EXCEPTIONS
|
|
41
|
+
type_not_found = 1
|
|
42
42
|
OTHERS = 2.`,
|
|
43
|
-
goodExample: `zcl_class=>method( ).
|
|
44
|
-
cl_abap_typedescr=>describe_by_name(
|
|
45
|
-
EXPORTING
|
|
46
|
-
p_name = 'NAME'
|
|
47
|
-
RECEIVING
|
|
48
|
-
p_descr_ref = lr_typedescr
|
|
49
|
-
EXCEPTIONS
|
|
50
|
-
type_not_found = 1
|
|
43
|
+
goodExample: `zcl_class=>method( ).
|
|
44
|
+
cl_abap_typedescr=>describe_by_name(
|
|
45
|
+
EXPORTING
|
|
46
|
+
p_name = 'NAME'
|
|
47
|
+
RECEIVING
|
|
48
|
+
p_descr_ref = lr_typedescr
|
|
49
|
+
EXCEPTIONS
|
|
50
|
+
type_not_found = 1
|
|
51
51
|
OTHERS = 2 ).`,
|
|
52
52
|
};
|
|
53
53
|
}
|
|
@@ -19,14 +19,14 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
|
|
|
19
19
|
key: "global_class",
|
|
20
20
|
title: "Global class checks",
|
|
21
21
|
shortDescription: `Checks related to global classes`,
|
|
22
|
-
extendedInformation: `* global classes must be in own files
|
|
23
|
-
|
|
24
|
-
* file names must match class name
|
|
25
|
-
|
|
26
|
-
* file names must match interface name
|
|
27
|
-
|
|
28
|
-
* global classes must be global definitions
|
|
29
|
-
|
|
22
|
+
extendedInformation: `* global classes must be in own files
|
|
23
|
+
|
|
24
|
+
* file names must match class name
|
|
25
|
+
|
|
26
|
+
* file names must match interface name
|
|
27
|
+
|
|
28
|
+
* global classes must be global definitions
|
|
29
|
+
|
|
30
30
|
* global interfaces must be global definitions`,
|
|
31
31
|
tags: [_irule_1.RuleTag.Syntax],
|
|
32
32
|
};
|
|
@@ -33,8 +33,8 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
|
|
|
33
33
|
return {
|
|
34
34
|
key: "identical_conditions",
|
|
35
35
|
title: "Identical conditions",
|
|
36
|
-
shortDescription: `Find identical conditions in IF + CASE + WHILE etc
|
|
37
|
-
|
|
36
|
+
shortDescription: `Find identical conditions in IF + CASE + WHILE etc
|
|
37
|
+
|
|
38
38
|
Prerequsites: code is pretty printed with identical cAsE`,
|
|
39
39
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
40
40
|
};
|
|
@@ -20,23 +20,23 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
|
|
|
20
20
|
key: "identical_contents",
|
|
21
21
|
title: "Identical contents",
|
|
22
22
|
shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
|
|
23
|
-
extendedInformation: `
|
|
24
|
-
Prerequsites: code is pretty printed with identical cAsE
|
|
25
|
-
|
|
23
|
+
extendedInformation: `
|
|
24
|
+
Prerequsites: code is pretty printed with identical cAsE
|
|
25
|
+
|
|
26
26
|
Chained statments are ignored`,
|
|
27
27
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
28
|
-
badExample: `IF foo = bar.
|
|
29
|
-
WRITE 'bar'.
|
|
30
|
-
WRITE 'world'.
|
|
31
|
-
ELSE.
|
|
32
|
-
WRITE 'foo'.
|
|
33
|
-
WRITE 'world'.
|
|
28
|
+
badExample: `IF foo = bar.
|
|
29
|
+
WRITE 'bar'.
|
|
30
|
+
WRITE 'world'.
|
|
31
|
+
ELSE.
|
|
32
|
+
WRITE 'foo'.
|
|
33
|
+
WRITE 'world'.
|
|
34
34
|
ENDIF.`,
|
|
35
|
-
goodExample: `IF foo = bar.
|
|
36
|
-
WRITE 'bar'.
|
|
37
|
-
ELSE.
|
|
38
|
-
WRITE 'foo'.
|
|
39
|
-
ENDIF.
|
|
35
|
+
goodExample: `IF foo = bar.
|
|
36
|
+
WRITE 'bar'.
|
|
37
|
+
ELSE.
|
|
38
|
+
WRITE 'foo'.
|
|
39
|
+
ENDIF.
|
|
40
40
|
WRITE 'world'.`,
|
|
41
41
|
};
|
|
42
42
|
}
|
|
@@ -16,10 +16,10 @@ class IdenticalDescriptions {
|
|
|
16
16
|
key: "identical_descriptions",
|
|
17
17
|
title: "Identical descriptions",
|
|
18
18
|
shortDescription: `Searches for objects with the same type and same description`,
|
|
19
|
-
extendedInformation: `Case insensitive
|
|
20
|
-
|
|
21
|
-
Only checks the master language descriptions
|
|
22
|
-
|
|
19
|
+
extendedInformation: `Case insensitive
|
|
20
|
+
|
|
21
|
+
Only checks the master language descriptions
|
|
22
|
+
|
|
23
23
|
Works for: INTF, CLAS, DOMA, DTEL, FUNC in same FUGR`,
|
|
24
24
|
tags: [],
|
|
25
25
|
};
|
|
@@ -19,15 +19,15 @@ class IfInIf extends _abap_rule_1.ABAPRule {
|
|
|
19
19
|
key: "if_in_if",
|
|
20
20
|
title: "IF in IF",
|
|
21
21
|
shortDescription: `Detects nested ifs which can be refactored to a single condition using AND.`,
|
|
22
|
-
extendedInformation: `https://docs.abapopenchecks.org/checks/01/
|
|
22
|
+
extendedInformation: `https://docs.abapopenchecks.org/checks/01/
|
|
23
23
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low`,
|
|
24
|
-
badExample: `IF condition1.
|
|
25
|
-
IF condition2.
|
|
26
|
-
...
|
|
27
|
-
ENDIF.
|
|
24
|
+
badExample: `IF condition1.
|
|
25
|
+
IF condition2.
|
|
26
|
+
...
|
|
27
|
+
ENDIF.
|
|
28
28
|
ENDIF.`,
|
|
29
|
-
goodExample: `IF ( condition1 ) AND ( condition2 ).
|
|
30
|
-
...
|
|
29
|
+
goodExample: `IF ( condition1 ) AND ( condition2 ).
|
|
30
|
+
...
|
|
31
31
|
ENDIF.`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
33
33
|
};
|
|
@@ -102,9 +102,9 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
|
|
|
102
102
|
for (const i of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.ClassImplementation)) || []) {
|
|
103
103
|
const name = (_b = i.findFirstExpression(Expressions.ClassName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase();
|
|
104
104
|
if (name === impl.identifier.getName().toUpperCase()) {
|
|
105
|
-
return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
|
|
106
|
-
METHOD ${methodName.toLowerCase()}.
|
|
107
|
-
RETURN. " todo, implement method
|
|
105
|
+
return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
|
|
106
|
+
METHOD ${methodName.toLowerCase()}.
|
|
107
|
+
RETURN. " todo, implement method
|
|
108
108
|
ENDMETHOD.`);
|
|
109
109
|
}
|
|
110
110
|
}
|
|
@@ -31,19 +31,19 @@ class InStatementIndentation extends _abap_rule_1.ABAPRule {
|
|
|
31
31
|
key: "in_statement_indentation",
|
|
32
32
|
title: "In-statement indentation",
|
|
33
33
|
shortDescription: "Checks alignment within statements which span multiple lines.",
|
|
34
|
-
extendedInformation: `Lines following the first line should be indented once (2 spaces).
|
|
35
|
-
|
|
36
|
-
For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
|
|
34
|
+
extendedInformation: `Lines following the first line should be indented once (2 spaces).
|
|
35
|
+
|
|
36
|
+
For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
|
|
37
37
|
to distinguish them better from code within the block.`,
|
|
38
|
-
badExample: `IF 1 = 1
|
|
39
|
-
AND 2 = 2.
|
|
40
|
-
WRITE 'hello' &&
|
|
41
|
-
'world'.
|
|
38
|
+
badExample: `IF 1 = 1
|
|
39
|
+
AND 2 = 2.
|
|
40
|
+
WRITE 'hello' &&
|
|
41
|
+
'world'.
|
|
42
42
|
ENDIF.`,
|
|
43
|
-
goodExample: `IF 1 = 1
|
|
44
|
-
AND 2 = 2.
|
|
45
|
-
WRITE 'hello' &&
|
|
46
|
-
'world'.
|
|
43
|
+
goodExample: `IF 1 = 1
|
|
44
|
+
AND 2 = 2.
|
|
45
|
+
WRITE 'hello' &&
|
|
46
|
+
'world'.
|
|
47
47
|
ENDIF.`,
|
|
48
48
|
tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
49
49
|
};
|
|
@@ -26,9 +26,9 @@ class IntfReferencingClas {
|
|
|
26
26
|
key: "intf_referencing_clas",
|
|
27
27
|
title: "INTF referencing CLAS",
|
|
28
28
|
shortDescription: `Interface contains references to class`,
|
|
29
|
-
extendedInformation: `Only global interfaces are checked.
|
|
30
|
-
Only first level references are checked.
|
|
31
|
-
Exception class references are ignored.
|
|
29
|
+
extendedInformation: `Only global interfaces are checked.
|
|
30
|
+
Only first level references are checked.
|
|
31
|
+
Exception class references are ignored.
|
|
32
32
|
Void references are ignored.`,
|
|
33
33
|
};
|
|
34
34
|
}
|
|
@@ -15,8 +15,8 @@ class LineBreakStyle {
|
|
|
15
15
|
return {
|
|
16
16
|
key: "line_break_style",
|
|
17
17
|
title: "Makes sure line breaks are consistent in the ABAP code",
|
|
18
|
-
shortDescription: `Enforces LF as newlines in ABAP files
|
|
19
|
-
|
|
18
|
+
shortDescription: `Enforces LF as newlines in ABAP files
|
|
19
|
+
|
|
20
20
|
abapGit does not work with CRLF`,
|
|
21
21
|
tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
|
|
22
22
|
};
|
|
@@ -23,7 +23,7 @@ class LineLength extends _abap_rule_1.ABAPRule {
|
|
|
23
23
|
key: "line_length",
|
|
24
24
|
title: "Line length",
|
|
25
25
|
shortDescription: `Detects lines exceeding the provided maximum length.`,
|
|
26
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
|
|
26
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
|
|
27
27
|
https://docs.abapopenchecks.org/checks/04/`,
|
|
28
28
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
29
29
|
};
|
|
@@ -27,7 +27,7 @@ class LineOnlyPunc extends _abap_rule_1.ABAPRule {
|
|
|
27
27
|
key: "line_only_punc",
|
|
28
28
|
title: "Line containing only punctuation",
|
|
29
29
|
shortDescription: `Detects lines containing only punctuation.`,
|
|
30
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
|
|
30
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
|
|
31
31
|
https://docs.abapopenchecks.org/checks/16/`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
33
33
|
badExample: "zcl_class=>method(\n).",
|
|
@@ -30,8 +30,8 @@ class LocalVariableNames extends _abap_rule_1.ABAPRule {
|
|
|
30
30
|
return {
|
|
31
31
|
key: "local_variable_names",
|
|
32
32
|
title: "Local variable naming conventions",
|
|
33
|
-
shortDescription: `
|
|
34
|
-
Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
|
|
33
|
+
shortDescription: `
|
|
34
|
+
Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
|
|
35
35
|
Regexes are case-insensitive.`,
|
|
36
36
|
tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
|
|
37
37
|
};
|
|
@@ -23,17 +23,17 @@ class ManyParentheses extends _abap_rule_1.ABAPRule {
|
|
|
23
23
|
title: "Too many parentheses",
|
|
24
24
|
shortDescription: `Searches for expressions where extra parentheses can safely be removed`,
|
|
25
25
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
|
|
26
|
-
badExample: `
|
|
27
|
-
IF ( destination IS INITIAL ).
|
|
28
|
-
ENDIF.
|
|
29
|
-
IF foo = boo AND ( bar = lar AND moo = loo ).
|
|
30
|
-
ENDIF.
|
|
26
|
+
badExample: `
|
|
27
|
+
IF ( destination IS INITIAL ).
|
|
28
|
+
ENDIF.
|
|
29
|
+
IF foo = boo AND ( bar = lar AND moo = loo ).
|
|
30
|
+
ENDIF.
|
|
31
31
|
`,
|
|
32
|
-
goodExample: `
|
|
33
|
-
IF destination IS INITIAL.
|
|
34
|
-
ENDIF.
|
|
35
|
-
IF foo = boo AND bar = lar AND moo = loo.
|
|
36
|
-
ENDIF.
|
|
32
|
+
goodExample: `
|
|
33
|
+
IF destination IS INITIAL.
|
|
34
|
+
ENDIF.
|
|
35
|
+
IF foo = boo AND bar = lar AND moo = loo.
|
|
36
|
+
ENDIF.
|
|
37
37
|
`,
|
|
38
38
|
};
|
|
39
39
|
}
|
|
@@ -21,14 +21,14 @@ class MaxOneMethodParameterPerLine extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
title: "Max one method parameter definition per line",
|
|
22
22
|
shortDescription: `Keep max one method parameter description per line`,
|
|
23
23
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace],
|
|
24
|
-
badExample: `
|
|
25
|
-
METHODS apps_scope_token
|
|
26
|
-
IMPORTING
|
|
24
|
+
badExample: `
|
|
25
|
+
METHODS apps_scope_token
|
|
26
|
+
IMPORTING
|
|
27
27
|
body TYPE bodyapps_scope_token client_id TYPE str.`,
|
|
28
|
-
goodExample: `
|
|
29
|
-
METHODS apps_scope_token
|
|
30
|
-
IMPORTING
|
|
31
|
-
body TYPE bodyapps_scope_token
|
|
28
|
+
goodExample: `
|
|
29
|
+
METHODS apps_scope_token
|
|
30
|
+
IMPORTING
|
|
31
|
+
body TYPE bodyapps_scope_token
|
|
32
32
|
client_id TYPE str.`,
|
|
33
33
|
};
|
|
34
34
|
}
|