@abaplint/core 2.93.70 → 2.93.72

package/build/abaplint.d.ts

@@ -1941,6 +1941,7 @@ declare namespace Expressions {
         InlineFS,
         Integer,
         InterfaceName,
+        KernelId,
         Language,
         Length,
         Let,
@@ -3578,6 +3579,10 @@ declare interface ITypeDefinitions {
     getByName(name: string): TypedIdentifier | undefined;
 }
 
+declare class KernelId extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class Language extends Expression {
     getRunnable(): IStatementRunnable;
 }
@@ -3900,6 +3905,7 @@ declare class MethodParameters_2 implements IMethodParameters {
     getExceptions(): string[];
     getParameterDefault(parameter: string): ExpressionNode;
     private parse;
+    private workaroundRAP;
     private add;
 }
 

package/build/src/abap/2_statements/expressions/index.js

@@ -98,6 +98,7 @@ __exportStar(require("./inlinedata"), exports);
 __exportStar(require("./inlinefs"), exports);
 __exportStar(require("./integer"), exports);
 __exportStar(require("./interface_name"), exports);
+__exportStar(require("./kernel_id"), exports);
 __exportStar(require("./language"), exports);
 __exportStar(require("./length"), exports);
 __exportStar(require("./let"), exports);

package/build/src/abap/2_statements/expressions/kernel_id.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.KernelId = void 0;
+const combi_1 = require("../combi");
+const source_1 = require("./source");
+class KernelId extends combi_1.Expression {
+    getRunnable() {
+        const field = (0, combi_1.seq)("ID", source_1.Source, "FIELD", source_1.Source);
+        return field;
+    }
+}
+exports.KernelId = KernelId;
+//# sourceMappingURL=kernel_id.js.map

package/build/src/abap/2_statements/statements/call_kernel.js

@@ -6,8 +6,7 @@ const expressions_1 = require("../expressions");
 const version_1 = require("../../../version");
 class CallKernel {
     getMatcher() {
-        const field = (0, combi_1.seq)("ID", expressions_1.Source, "FIELD", expressions_1.Source);
-        const ret = (0, combi_1.seq)("CALL", (0, combi_1.altPrio)(expressions_1.Constant, expressions_1.Field), (0, combi_1.starPrio)(field));
+        const ret = (0, combi_1.seq)("CALL", (0, combi_1.altPrio)(expressions_1.Constant, expressions_1.Field), (0, combi_1.starPrio)(expressions_1.KernelId));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
 }

package/build/src/abap/2_statements/statements/method_def.js

@@ -17,7 +17,7 @@ class MethodDef {
         const link = (0, combi_1.seq)("LINK", expressions_1.MethodParamName);
         const full = (0, combi_1.seq)("FULL", expressions_1.MethodParamName);
         const modify = (0, combi_1.alt)((0, combi_1.seq)("FOR ACTION", expressions_1.TypeName, result), (0, combi_1.seq)("FOR CREATE", (0, combi_1.alt)(expressions_1.TypeName, expressions_1.EntityAssociation)), (0, combi_1.seq)("FOR DELETE", expressions_1.TypeName), (0, combi_1.seq)("FOR UPDATE", expressions_1.TypeName));
-        const behavior = (0, combi_1.altPrio)((0, combi_1.seq)("VALIDATE ON SAVE IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, modify), (0, combi_1.seq)("READ IMPORTING", expressions_1.MethodParamName, "FOR READ", (0, combi_1.alt)(expressions_1.TypeName, expressions_1.EntityAssociation), (0, combi_1.optPrio)(full), result, (0, combi_1.optPrio)(link)), (0, combi_1.seq)("FEATURES IMPORTING", expressions_1.MethodParamName, "REQUEST", expressions_1.NamespaceSimpleName, "FOR", expressions_1.NamespaceSimpleName, result), (0, combi_1.seq)("DETERMINE", (0, combi_1.alt)("ON MODIFY", "ON SAVE"), "IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName));
+        const behavior = (0, combi_1.altPrio)((0, combi_1.seq)("VALIDATE ON SAVE IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, modify), (0, combi_1.seq)("READ IMPORTING", expressions_1.MethodParamName, "FOR READ", (0, combi_1.alt)(expressions_1.TypeName, expressions_1.EntityAssociation), (0, combi_1.optPrio)(full), result, (0, combi_1.optPrio)(link)), (0, combi_1.seq)("FEATURES IMPORTING", expressions_1.MethodParamName, "REQUEST", expressions_1.NamespaceSimpleName, "FOR", expressions_1.NamespaceSimpleName, result), (0, combi_1.seq)("BEHAVIOR IMPORTING", expressions_1.MethodParamName, "FOR CREATE", expressions_1.TypeName, expressions_1.MethodParamName, "FOR UPDATE", expressions_1.TypeName, expressions_1.MethodParamName, "FOR DELETE", expressions_1.TypeName), (0, combi_1.seq)("BEHAVIOR IMPORTING", expressions_1.MethodParamName, "FOR READ", expressions_1.TypeName, result), (0, combi_1.seq)("BEHAVIOR IMPORTING", expressions_1.MethodParamName, "FOR LOCK", expressions_1.TypeName), (0, combi_1.seq)("DETERMINE", (0, combi_1.alt)("ON MODIFY", "ON SAVE"), "IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName));
         // todo, this is only from version something
         const amdp = (0, combi_1.seq)("AMDP OPTIONS CDS SESSION CLIENT CURRENT", (0, combi_1.optPrio)(expressions_1.MethodDefImporting), (0, combi_1.optPrio)(expressions_1.MethodDefExporting), (0, combi_1.optPrio)(expressions_1.MethodDefRaising));
         const ret = (0, combi_1.seq)((0, combi_1.altPrio)("CLASS-METHODS", "METHODS"), expressions_1.MethodName, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.optPrio)(expressions_1.Abstract), expressions_1.EventHandler), parameters, testing, (0, combi_1.seq)("FOR", (0, combi_1.alt)(tableFunction, ddl, behavior)), amdp, "NOT AT END OF MODE", (0, combi_1.optPrio)(expressions_1.Redefinition)));

package/build/src/abap/5_syntax/basic_types.js

@@ -556,9 +556,9 @@ class BasicTypes {
             if (foo instanceof basic_1.ObjectReferenceType) {
                 const typeName = subs[0];
                 const id = foo.getIdentifier();
-                const type = id instanceof types_1.ClassDefinition ? "CLAS" : "INTF";
-                this.scope.addReference(expr.getFirstToken(), id, _reference_1.ReferenceType.ObjectOrientedReference, this.filename, { ooType: type, ooName: id.getName() });
                 if (id instanceof types_1.ClassDefinition || id instanceof types_1.InterfaceDefinition) {
+                    const type = id instanceof types_1.ClassDefinition ? "CLAS" : "INTF";
+                    this.scope.addReference(expr.getFirstToken(), id, _reference_1.ReferenceType.ObjectOrientedReference, this.filename, { ooType: type, ooName: id.getName() });
                     const byName = new _object_oriented_1.ObjectOriented(this.scope).searchTypeName(id, typeName);
                     foundType = byName === null || byName === void 0 ? void 0 : byName.getType();
                     if (byName === undefined || foundType === undefined) {
@@ -566,6 +566,15 @@ class BasicTypes {
                     }
                     this.scope.addReference(expr.getTokens()[2], byName, _reference_1.ReferenceType.TypeReference, this.filename);
                 }
+                else {
+                    return new Types.UnknownType("Not a object reference, " + className + ", " + id.constructor.name);
+                }
+            }
+            else if (foo === undefined) {
+                return new Types.UnknownType(className + " not found in scope");
+            }
+            else {
+                return new Types.UnknownType("Not a object reference, " + className);
             }
         }
         else {

package/build/src/abap/5_syntax/global_definitions/find_global_definitions.js

@@ -75,6 +75,11 @@ class FindGlobalDefinitions {
                 count = count + this.count(p.getType());
             }
         }
+        for (const e of def.getEvents() || []) {
+            for (const p of e.getParameters()) {
+                count = count + this.count(p.getType());
+            }
+        }
         return count;
     }
     count(type) {

package/build/src/abap/5_syntax/statements/call_kernel.js

@@ -0,0 +1,14 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CallKernel = void 0;
+const Expressions = require("../../2_statements/expressions");
+const source_1 = require("../expressions/source");
+class CallKernel {
+    runSyntax(node, scope, filename) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
+            new source_1.Source().runSyntax(s, scope, filename);
+        }
+    }
+}
+exports.CallKernel = CallKernel;
+//# sourceMappingURL=call_kernel.js.map

package/build/src/abap/5_syntax/statements/modify_database.js

@@ -12,7 +12,14 @@ class ModifyDatabase {
         }
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
-            new database_table_1.DatabaseTable().runSyntax(dbtab, scope, filename);
+            try {
+                new database_table_1.DatabaseTable().runSyntax(dbtab, scope, filename);
+            }
+            catch (e) {
+                if (scope.findVariable(dbtab.concatTokens()) === undefined) {
+                    throw e;
+                }
+            }
         }
         for (const s of node.findAllExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);

package/build/src/abap/5_syntax/syntax.js

@@ -114,6 +114,7 @@ const transfer_1 = require("./statements/transfer");
 const modify_database_1 = require("./statements/modify_database");
 const truncate_dataset_1 = require("./statements/truncate_dataset");
 const call_badi_1 = require("./statements/call_badi");
+const call_kernel_1 = require("./statements/call_kernel");
 const pack_1 = require("./statements/pack");
 const unpack_1 = require("./statements/unpack");
 const format_1 = require("./statements/format");
@@ -256,6 +257,7 @@ if (Object.keys(map).length === 0) {
     addToMap(new read_entities_1.ReadEntities());
     addToMap(new modify_entities_1.ModifyEntities());
     addToMap(new commit_entities_1.CommitEntities());
+    addToMap(new call_kernel_1.CallKernel());
 }
 // -----------------------------------
 class SyntaxLogic {

package/build/src/abap/types/method_parameters.js

@@ -147,21 +147,6 @@ class MethodParameters {
                 }
             }
         }
-        // RAP parameters, temporary fix
-        let rapName = node.findExpressionAfterToken("IMPORTING");
-        if (rapName) {
-            const token = rapName.getFirstToken();
-            this.importing.push(new _typed_identifier_1.TypedIdentifier(token, filename, new basic_1.VoidType("RapMethodParameter"), ["importing" /* IdentifierMeta.MethodImporting */]));
-            if (node.concatTokens().toUpperCase().includes(" FOR VALIDATE ON SAVE")) {
-                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "failed"), filename, new basic_1.VoidType("RapMethodParameter"), ["exporting" /* IdentifierMeta.MethodExporting */]));
-                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "reported"), filename, new basic_1.VoidType("RapMethodParameter"), ["exporting" /* IdentifierMeta.MethodExporting */]));
-            }
-        }
-        rapName = node.findExpressionAfterToken("RESULT");
-        if (rapName) {
-            const token = rapName.getFirstToken();
-            this.importing.push(new _typed_identifier_1.TypedIdentifier(token, filename, new basic_1.VoidType("RapMethodParameter"), ["exporting" /* IdentifierMeta.MethodExporting */]));
-        }
         const exporting = node.findFirstExpression(Expressions.MethodDefExporting);
         if (exporting) {
             this.add(this.exporting, exporting, scope, ["exporting" /* IdentifierMeta.MethodExporting */]);
@@ -174,6 +159,44 @@ class MethodParameters {
         if (returning) {
             this.returning = new method_def_returning_1.MethodDefReturning().runSyntax(returning, scope, this.filename, ["returning" /* IdentifierMeta.MethodReturning */]);
         }
+        this.workaroundRAP(node, scope, filename);
+    }
+    workaroundRAP(node, scope, filename) {
+        const resultName = node.findExpressionAfterToken("RESULT");
+        const isRap = node.findExpressionAfterToken("IMPORTING");
+        if (isRap) {
+            for (const foo of node.findDirectExpressions(Expressions.MethodParamName)) {
+                if (foo === resultName) {
+                    continue;
+                }
+                this.importing.push(new _typed_identifier_1.TypedIdentifier(foo.getFirstToken(), filename, new basic_1.VoidType("RapMethodParameter"), ["importing" /* IdentifierMeta.MethodImporting */]));
+            }
+            if (node.concatTokens().toUpperCase().includes(" FOR VALIDATE ")
+                || node.concatTokens().toUpperCase().includes(" FOR BEHAVIOR ")
+                || node.concatTokens().toUpperCase().includes(" FOR MODIFY ")) {
+                const token = isRap.getFirstToken();
+                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "failed"), filename, new basic_1.VoidType("RapMethodParameter"), ["exporting" /* IdentifierMeta.MethodExporting */]));
+                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "mapped"), filename, new basic_1.VoidType("RapMethodParameter"), ["exporting" /* IdentifierMeta.MethodExporting */]));
+                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "reported"), filename, new basic_1.VoidType("RapMethodParameter"), ["exporting" /* IdentifierMeta.MethodExporting */]));
+            }
+        }
+        if (resultName) {
+            const token = resultName.getFirstToken();
+            this.importing.push(new _typed_identifier_1.TypedIdentifier(token, filename, new basic_1.VoidType("RapMethodParameter"), ["exporting" /* IdentifierMeta.MethodExporting */]));
+        }
+        // its some kind of magic
+        if (scope.getName().toUpperCase() === "CL_ABAP_BEHAVIOR_SAVER") {
+            const tempChanging = this.changing.map(c => new _typed_identifier_1.TypedIdentifier(c.getToken(), filename, new basic_1.VoidType("RapMethodParameter"), c.getMeta()));
+            while (this.changing.length > 0) {
+                this.changing.shift();
+            }
+            this.changing.push(...tempChanging);
+            const tempImporting = this.importing.map(c => new _typed_identifier_1.TypedIdentifier(c.getToken(), filename, new basic_1.VoidType("RapMethodParameter"), c.getMeta()));
+            while (this.importing.length > 0) {
+                this.importing.shift();
+            }
+            this.importing.push(...tempImporting);
+        }
     }
     add(target, source, scope, meta) {
         var _a;

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.93.70";
+        return "2.93.72";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/align_parameters.js

@@ -105,7 +105,7 @@ DATA(sdf) = VALUE type(
         for (const p of candidate.parameters) {
             if (p.eq.getCol() !== expectedEqualsColumn) {
                 const message = "Align parameters to column " + expectedEqualsColumn;
-                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key);
+                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key, this.getConfig().severity);
             }
         }
         return undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.93.70",
+    "version": "2.93.72",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",