@abaplint/core 2.93.56 → 2.93.58

package/build/abaplint.d.ts

@@ -2821,6 +2821,8 @@ declare interface IFunctionModuleParameter {
     name: string;
     direction: FunctionModuleParameterDirection;
     type: string | undefined;
+    optional: boolean;
+    defaultValue: string | undefined;
 }
 
 declare interface IGlobalConfig {

package/build/src/abap/5_syntax/_procedural.js

@@ -114,7 +114,7 @@ class Procedural {
                     found = c.getType();
                 }
             }
-            if (found instanceof basic_1.UnknownType && param.type) {
+            if ((found instanceof basic_1.UnknownType || found instanceof basic_1.VoidType) && param.type) {
                 const f = ddic.lookupBuiltinType(param.type);
                 if (f) {
                     found = f;

package/build/src/abap/types/function_module_definition.js

@@ -39,6 +39,8 @@ class FunctionModuleDefinition {
                     name: param.PARAMETER,
                     direction: FunctionModuleParameterDirection.importing,
                     type: param.TYP || param.DBFIELD,
+                    optional: param.OPTIONAL === "X",
+                    defaultValue: param.DEFAULT,
                 });
             }
         }
@@ -51,6 +53,8 @@ class FunctionModuleDefinition {
                     name: param.PARAMETER,
                     direction: FunctionModuleParameterDirection.changing,
                     type: param.TYP || param.DBFIELD,
+                    optional: param.OPTIONAL === "X",
+                    defaultValue: param.DEFAULT,
                 });
             }
         }
@@ -63,6 +67,8 @@ class FunctionModuleDefinition {
                     name: param.PARAMETER,
                     direction: FunctionModuleParameterDirection.exporting,
                     type: param.TYP || param.DBFIELD,
+                    optional: true,
+                    defaultValue: undefined,
                 });
             }
         }
@@ -76,6 +82,8 @@ class FunctionModuleDefinition {
                     direction: FunctionModuleParameterDirection.tables,
                     // table types are stored in TYP
                     type: param.DBSTRUCT || param.TYP,
+                    optional: param.OPTIONAL === "X",
+                    defaultValue: undefined,
                 });
             }
         }

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.93.56";
+        return "2.93.58";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/avoid_use.js

@@ -12,6 +12,8 @@ const edit_helper_1 = require("../edit_helper");
 class AvoidUseConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
+        /** Do not emit quick fix suggestion */
+        this.skipQuickFix = false;
         /** Detects DEFINE (macro definitions) */
         this.define = true;
         /** Detects statics */
@@ -73,7 +75,7 @@ TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md
                 const children = statementNode.getChildren();
                 if (children.length === 6 && children[3].getFirstToken().getStr().toUpperCase() === "LINES") {
                     message = "DESCRIBE LINES, use lines() instead";
-                    fix = this.getDescribeLinesFix(file, statementNode);
+                    fix = this.conf.skipQuickFix === true ? undefined : this.getDescribeLinesFix(file, statementNode);
                 }
             }
             else if (this.conf.statics && statement instanceof Statements.StaticBegin) {
@@ -91,7 +93,7 @@ TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md
             }
             else if (this.conf.break && statement instanceof Statements.Break) {
                 message = "BREAK/BREAK-POINT";
-                fix = edit_helper_1.EditHelper.deleteStatement(file, statementNode);
+                fix = this.conf.skipQuickFix === true ? undefined : edit_helper_1.EditHelper.deleteStatement(file, statementNode);
             }
             if (message) {
                 issues.push(issue_1.Issue.atStatement(file, statementNode, this.getDescription(message), this.getMetadata().key, this.conf.severity, fix));

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.93.56",
+    "version": "2.93.58",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -49,7 +49,7 @@
         "@microsoft/api-extractor": "^7.33.5",
         "@types/chai": "^4.3.3",
         "@types/mocha": "^10.0.0",
-        "@types/node": "^18.11.7",
+        "@types/node": "^18.11.8",
         "chai": "^4.3.6",
         "eslint": "^8.26.0",
         "mocha": "^10.1.0",