@abaplint/core 2.93.55 → 2.93.57

package/build/abaplint.d.ts

@@ -1758,6 +1758,10 @@ declare class EnhancementSpot extends AbstractObject {
     private parseXML;
 }
 
+declare class EntityAssociation extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class EventBinding extends AbstractObject {
     getType(): string;
     getAllowedNaming(): {
@@ -1853,7 +1857,6 @@ declare namespace Expressions {
         Cast,
         ClassFinal,
         ClassFriends,
-        SimpleTarget,
         ClassGlobal_2 as ClassGlobal,
         ClassName,
         Color,
@@ -1885,6 +1888,7 @@ declare namespace Expressions {
         Dereference,
         Destination,
         Dynamic,
+        EntityAssociation,
         EventHandler,
         ExceptionName,
         FieldAll,
@@ -1980,6 +1984,7 @@ declare namespace Expressions {
         SimpleSource2,
         SimpleSource3,
         SimpleSource4,
+        SimpleTarget,
         SourceFieldSymbol,
         SourceField,
         Source,

package/build/src/abap/2_statements/expressions/entity_association.js

@@ -0,0 +1,11 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.EntityAssociation = void 0;
+const combi_1 = require("../combi");
+class EntityAssociation extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.regex)(/^[\w]+\\_[\w]+$/);
+    }
+}
+exports.EntityAssociation = EntityAssociation;
+//# sourceMappingURL=entity_association.js.map

package/build/src/abap/2_statements/expressions/index.js

@@ -30,7 +30,6 @@ __exportStar(require("./call_transformation_parameters"), exports);
 __exportStar(require("./cast"), exports);
 __exportStar(require("./class_final"), exports);
 __exportStar(require("./class_friends"), exports);
-__exportStar(require("./simple_target"), exports);
 __exportStar(require("./class_global"), exports);
 __exportStar(require("./class_name"), exports);
 __exportStar(require("./color"), exports);
@@ -62,6 +61,8 @@ __exportStar(require("./definition_name"), exports);
 __exportStar(require("./dereference"), exports);
 __exportStar(require("./destination"), exports);
 __exportStar(require("./dynamic"), exports);
+__exportStar(require("./entity_association"), exports);
+__exportStar(require("./entity_association"), exports);
 __exportStar(require("./event_handler"), exports);
 __exportStar(require("./exception_name"), exports);
 __exportStar(require("./field_all"), exports);
@@ -157,6 +158,7 @@ __exportStar(require("./simple_source1"), exports);
 __exportStar(require("./simple_source2"), exports);
 __exportStar(require("./simple_source3"), exports);
 __exportStar(require("./simple_source4"), exports);
+__exportStar(require("./simple_target"), exports);
 __exportStar(require("./source_field_symbol"), exports);
 __exportStar(require("./source_field"), exports);
 __exportStar(require("./source"), exports);

package/build/src/abap/2_statements/expressions/source.js

@@ -21,7 +21,7 @@ class Source extends combi_1.Expression {
         const paren = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), Source, rparen);
         const after = (0, combi_1.seq)((0, combi_1.altPrio)("&", "&&", _1.ArithOperator), Source);
         const bool = (0, combi_1.seq)((0, combi_1.altPrio)((0, combi_1.ver)(version_1.Version.v702, (0, combi_1.regex)(/^BOOLC$/i)), (0, combi_1.ver)(version_1.Version.v740sp08, (0, combi_1.regex)(/^XSDBOOL$/i))), (0, combi_1.tok)(tokens_1.ParenLeftW), _1.Cond, ")");
-        const prefix = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WDashW), (0, combi_1.tok)(tokens_1.WPlus), (0, combi_1.tok)(tokens_1.WPlusW), "BIT-NOT");
+        const prefix = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WPlus), "BIT-NOT");
         const old = (0, combi_1.seq)((0, combi_1.optPrio)(prefix), (0, combi_1.altPrio)(_1.Constant, _1.StringTemplate, text_element_1.TextElement, bool, method, (0, combi_1.seq)(_1.FieldChain, (0, combi_1.optPrio)(dereference_1.Dereference)), paren), (0, combi_1.optPrio)(after));
         const corr = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)("CORRESPONDING", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), _1.CorrespondingBody, rparen, (0, combi_1.optPrio)(after)));
         const conv = (0, combi_1.ver)(version_1.Version.v740sp02, (0, combi_1.seq)("CONV", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), _1.ConvBody, rparenNoSpace, (0, combi_1.optPrio)(after)));
@@ -32,7 +32,8 @@ class Source extends combi_1.Expression {
         const exact = (0, combi_1.ver)(version_1.Version.v740sp02, (0, combi_1.seq)("EXACT", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), Source, rparen, (0, combi_1.optPrio)(after)));
         const filter = (0, combi_1.ver)(version_1.Version.v740sp08, (0, combi_1.seq)("FILTER", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), _1.FilterBody, rparen));
         const reduce = (0, combi_1.ver)(version_1.Version.v740sp08, (0, combi_1.seq)("REDUCE", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), _1.ReduceBody, rparen, (0, combi_1.optPrio)(after)));
-        const ret = (0, combi_1.altPrio)(filter, reff, corr, conv, value, cond, exact, swit, reduce, old);
+        const prefix1 = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WDashW), (0, combi_1.tok)(tokens_1.WPlusW));
+        const ret = (0, combi_1.seq)((0, combi_1.starPrio)(prefix1), (0, combi_1.altPrio)(filter, reff, corr, conv, value, cond, exact, swit, reduce, old));
         return ret;
     }
 }

package/build/src/abap/2_statements/expressions/sql_aggregation.js

@@ -8,7 +8,7 @@ const dynamic_1 = require("./dynamic");
 const sql_arithmetics_1 = require("./sql_arithmetics");
 class SQLAggregation extends combi_1.Expression {
     getRunnable() {
-        const f = (0, combi_1.altPrio)(sql_arithmetics_1.SQLArithmetics, dynamic_1.Dynamic);
+        const f = (0, combi_1.altPrio)(sql_arithmetics_1.SQLArithmetics, dynamic_1.Dynamic, _1.SQLFunction);
         const fparen = (0, combi_1.seq)("(", _1.Field, ")");
         const count = (0, combi_1.seq)("COUNT", (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenLeft), (0, combi_1.tok)(tokens_1.ParenLeftW)), (0, combi_1.optPrio)("DISTINCT"), (0, combi_1.altPrio)("*", _1.Field, fparen), ")");
         const max = (0, combi_1.seq)("MAX", (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenLeft), (0, combi_1.tok)(tokens_1.ParenLeftW)), f, ")");

package/build/src/abap/2_statements/expressions/sql_function.js

@@ -10,12 +10,13 @@ const sql_alias_field_1 = require("./sql_alias_field");
 const sql_field_name_1 = require("./sql_field_name");
 const simple_source3_1 = require("./simple_source3");
 const source_1 = require("./source");
+const sql_aggregation_1 = require("./sql_aggregation");
 class SQLFunction extends combi_1.Expression {
     getRunnable() {
         const paren = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), source_1.Source, (0, combi_1.tok)(tokens_1.WParenRightW));
         const at = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), (0, combi_1.alt)(simple_source3_1.SimpleSource3, paren)));
-        const param = (0, combi_1.alt)(sql_field_name_1.SQLFieldName, sql_alias_field_1.SQLAliasField, SQLFunction, constant_1.Constant, at);
-        const castTypes = (0, combi_1.altPrio)((0, combi_1.seq)("CHAR", (0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)), "FLTP");
+        const param = (0, combi_1.alt)(sql_field_name_1.SQLFieldName, sql_alias_field_1.SQLAliasField, SQLFunction, constant_1.Constant, sql_aggregation_1.SQLAggregation, at);
+        const castTypes = (0, combi_1.altPrio)((0, combi_1.seq)("CHAR", (0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)), (0, combi_1.seq)("DEC", (0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, ",", integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)), "FLTP");
         const abs = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)("abs", (0, combi_1.tok)(tokens_1.ParenLeftW), param, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const cast = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)("cast", (0, combi_1.tok)(tokens_1.ParenLeftW), param, "AS", castTypes, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const ceil = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)("ceil", (0, combi_1.tok)(tokens_1.ParenLeftW), param, (0, combi_1.tok)(tokens_1.WParenRightW)));

package/build/src/abap/2_statements/expressions/sql_in.js

@@ -8,7 +8,8 @@ const version_1 = require("../../../version");
 class SQLIn extends combi_1.Expression {
     getRunnable() {
         const val = new _1.SQLSource();
-        const listOld = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeft), val, (0, combi_1.starPrio)((0, combi_1.seq)(",", val)), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenRight), (0, combi_1.tok)(tokens_1.ParenRightW), (0, combi_1.tok)(tokens_1.WParenRightW)));
+        const short = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.At), _1.SimpleSource3);
+        const listOld = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeft), (0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v740sp05, short), val), (0, combi_1.starPrio)((0, combi_1.seq)(",", val)), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenRight), (0, combi_1.tok)(tokens_1.ParenRightW), (0, combi_1.tok)(tokens_1.WParenRightW)));
         const listNew = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), val, (0, combi_1.starPrio)((0, combi_1.seq)(",", val)), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRight), (0, combi_1.tok)(tokens_1.WParenRightW)));
         const list = (0, combi_1.alt)(listOld, (0, combi_1.ver)(version_1.Version.v740sp02, listNew)); // version is a guess, https://github.com/abaplint/abaplint/issues/2530
         const subSelect = (0, combi_1.seq)("(", _1.Select, ")");

package/build/src/abap/2_statements/statements/method_def.js

@@ -13,7 +13,10 @@ class MethodDef {
         const tableFunction = (0, combi_1.seq)("TABLE FUNCTION", (0, combi_1.regex)(/^\w+?$/));
         // todo, this is only from version something
         const ddl = "DDL OBJECT OPTIONS CDS SESSION CLIENT REQUIRED";
-        const behavior = (0, combi_1.altPrio)((0, combi_1.seq)("VALIDATE ON SAVE IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR ACTION", expressions_1.TypeName, "RESULT", expressions_1.MethodParamName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR CREATE", expressions_1.TypeName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR DELETE", expressions_1.TypeName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR UPDATE", expressions_1.TypeName), (0, combi_1.seq)("READ IMPORTING", expressions_1.MethodParamName, "FOR READ", expressions_1.TypeName, "RESULT", expressions_1.MethodParamName), (0, combi_1.seq)("FEATURES IMPORTING", expressions_1.MethodParamName, "REQUEST", expressions_1.NamespaceSimpleName, "FOR", expressions_1.NamespaceSimpleName, "RESULT", expressions_1.MethodParamName), (0, combi_1.seq)("DETERMINE ON MODIFY IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("DETERMINE ON SAVE IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName));
+        const result = (0, combi_1.seq)("RESULT", expressions_1.MethodParamName);
+        const link = (0, combi_1.seq)("LINK", expressions_1.MethodParamName);
+        const full = (0, combi_1.seq)("FULL", expressions_1.MethodParamName);
+        const behavior = (0, combi_1.altPrio)((0, combi_1.seq)("VALIDATE ON SAVE IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR ACTION", expressions_1.TypeName, result), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR CREATE", (0, combi_1.alt)(expressions_1.TypeName, expressions_1.EntityAssociation)), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR DELETE", expressions_1.TypeName), (0, combi_1.seq)("MODIFY IMPORTING", expressions_1.MethodParamName, "FOR UPDATE", expressions_1.TypeName), (0, combi_1.seq)("READ IMPORTING", expressions_1.MethodParamName, "FOR READ", (0, combi_1.alt)(expressions_1.TypeName, expressions_1.EntityAssociation), (0, combi_1.optPrio)(full), result, (0, combi_1.optPrio)(link)), (0, combi_1.seq)("FEATURES IMPORTING", expressions_1.MethodParamName, "REQUEST", expressions_1.NamespaceSimpleName, "FOR", expressions_1.NamespaceSimpleName, result), (0, combi_1.seq)("DETERMINE ON MODIFY IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("DETERMINE ON SAVE IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName));
         // todo, this is only from version something
         const amdp = (0, combi_1.seq)("AMDP OPTIONS CDS SESSION CLIENT CURRENT", (0, combi_1.optPrio)(expressions_1.MethodDefImporting), (0, combi_1.optPrio)(expressions_1.MethodDefExporting), (0, combi_1.optPrio)(expressions_1.MethodDefRaising));
         const ret = (0, combi_1.seq)((0, combi_1.altPrio)("CLASS-METHODS", "METHODS"), expressions_1.MethodName, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.optPrio)(expressions_1.Abstract), expressions_1.EventHandler), parameters, testing, (0, combi_1.seq)("FOR", (0, combi_1.alt)(tableFunction, ddl, behavior)), amdp, "NOT AT END OF MODE", (0, combi_1.optPrio)(expressions_1.Redefinition)));

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.93.55";
+        return "2.93.57";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/avoid_use.js

@@ -12,6 +12,8 @@ const edit_helper_1 = require("../edit_helper");
 class AvoidUseConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
+        /** Do not emit quick fix suggestion */
+        this.skipQuickFix = false;
         /** Detects DEFINE (macro definitions) */
         this.define = true;
         /** Detects statics */
@@ -73,7 +75,7 @@ TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md
                 const children = statementNode.getChildren();
                 if (children.length === 6 && children[3].getFirstToken().getStr().toUpperCase() === "LINES") {
                     message = "DESCRIBE LINES, use lines() instead";
-                    fix = this.getDescribeLinesFix(file, statementNode);
+                    fix = this.conf.skipQuickFix === true ? undefined : this.getDescribeLinesFix(file, statementNode);
                 }
             }
             else if (this.conf.statics && statement instanceof Statements.StaticBegin) {
@@ -91,7 +93,7 @@ TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md
             }
             else if (this.conf.break && statement instanceof Statements.Break) {
                 message = "BREAK/BREAK-POINT";
-                fix = edit_helper_1.EditHelper.deleteStatement(file, statementNode);
+                fix = this.conf.skipQuickFix === true ? undefined : edit_helper_1.EditHelper.deleteStatement(file, statementNode);
             }
             if (message) {
                 issues.push(issue_1.Issue.atStatement(file, statementNode, this.getDescription(message), this.getMetadata().key, this.conf.severity, fix));

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.93.55",
+    "version": "2.93.57",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",