@abaplint/core 2.93.30 → 2.93.32

package/build/src/abap/5_syntax/expressions/for.js

@@ -11,14 +11,19 @@ const cond_1 = require("./cond");
 const basic_1 = require("../../types/basic");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const _reference_1 = require("../_reference");
+const let_1 = require("./let");
 class For {
     runSyntax(node, scope, filename) {
         var _a;
         let scoped = false;
         const inlineLoop = node.findDirectExpressions(Expressions.InlineLoopDefinition);
-        const inlineField = node.findAllExpressions(Expressions.InlineFieldDefinition);
+        const inlineField = node.findDirectExpressions(Expressions.InlineFieldDefinition);
         const groupsToken = (_a = node.findExpressionAfterToken("GROUPS")) === null || _a === void 0 ? void 0 : _a.getFirstToken();
-        const addScope = inlineLoop.length > 0 || inlineField.length > 0 || groupsToken !== undefined;
+        const lett = node.findDirectExpression(Expressions.Let);
+        const addScope = inlineLoop.length > 0
+            || inlineField.length > 0
+            || lett !== undefined
+            || groupsToken !== undefined;
         if (addScope) {
             // this scope is popped in parent expressions
             scope.push(_scope_type_1.ScopeType.For, "FOR", node.getFirstToken().getStart(), filename);
@@ -45,6 +50,9 @@ class For {
         for (const s of node.findDirectExpressions(Expressions.Cond)) {
             new cond_1.Cond().runSyntax(s, scope, filename);
         }
+        if (lett) {
+            new let_1.Let().runSyntax(lett, scope, filename, true);
+        }
         return scoped;
     }
 }

package/build/src/abap/5_syntax/expressions/inline_loop_definition.js

@@ -28,7 +28,12 @@ class InlineLoopDefinition {
             else if (sourceType instanceof basic_1.UnknownType) {
                 throw new Error("Unknown type, " + sourceType.getError());
             }
-            if (rowType === undefined) {
+            if (rowType === undefined
+                && node.concatTokens().toUpperCase().includes(" IN GROUP ")
+                && sourceType !== undefined) {
+                rowType = sourceType;
+            }
+            else if (rowType === undefined) {
                 throw new Error("InlineLoopDefinition, not a table type");
             }
             const identifier = new _typed_identifier_1.TypedIdentifier(target.getFirstToken(), filename, rowType, ["inline" /* IdentifierMeta.InlineDefinition */]);

package/build/src/abap/5_syntax/expressions/let.js

@@ -5,11 +5,13 @@ const Expressions = require("../../2_statements/expressions");
 const inline_field_definition_1 = require("./inline_field_definition");
 const _scope_type_1 = require("../_scope_type");
 class Let {
-    runSyntax(node, scope, filename) {
+    runSyntax(node, scope, filename, skipScope = false) {
         if (node === undefined) {
             return false;
         }
-        scope.push(_scope_type_1.ScopeType.Let, "LET", node.getFirstToken().getStart(), filename);
+        if (skipScope !== true) {
+            scope.push(_scope_type_1.ScopeType.Let, "LET", node.getFirstToken().getStart(), filename);
+        }
         for (const f of node.findDirectExpressions(Expressions.InlineFieldDefinition)) {
             new inline_field_definition_1.InlineFieldDefinition().runSyntax(f, scope, filename);
         }

package/build/src/abap/5_syntax/statements/get_reference.js

@@ -4,13 +4,19 @@ exports.GetReference = void 0;
 const Expressions = require("../../2_statements/expressions");
 const source_1 = require("../expressions/source");
 const target_1 = require("../expressions/target");
+const inline_data_1 = require("../expressions/inline_data");
+const basic_1 = require("../../types/basic");
 class GetReference {
     runSyntax(node, scope, filename) {
-        for (const s of node.findDirectExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+        const s = node.findDirectExpression(Expressions.Source);
+        const type = new source_1.Source().runSyntax(s, scope, filename);
+        const target = node.findDirectExpression(Expressions.Target);
+        const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
+        if (inline) {
+            new inline_data_1.InlineData().runSyntax(inline, scope, filename, type ? new basic_1.DataReference(type) : undefined);
         }
-        for (const t of node.findDirectExpressions(Expressions.Target)) {
-            new target_1.Target().runSyntax(t, scope, filename);
+        else if (target) {
+            new target_1.Target().runSyntax(target, scope, filename);
         }
     }
 }

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.93.30";
+        return "2.93.32";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -1228,11 +1228,11 @@ CONSTANTS: BEGIN OF ${structureName},\n`;
         if (index === undefined) {
             return undefined;
         }
-        let uniqueName = this.uniqueName(low.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        let uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         uniqueName = `<${uniqueName}>`;
         const tName = target.concatTokens().split("[")[0];
         const condition = this.tableCondition(tableExpression);
-        const tabixBackup = this.uniqueName(low.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const tabixBackup = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
         // restore tabix before exeption
         const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.93.30",
+    "version": "2.93.32",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,7 +48,7 @@
     "devDependencies": {
         "@microsoft/api-extractor": "^7.31.2",
         "@types/chai": "^4.3.3",
-        "@types/mocha": "^9.1.1",
+        "@types/mocha": "^10.0.0",
         "@types/node": "^18.7.23",
         "chai": "^4.3.6",
         "eslint": "^8.24.0",
@@ -56,7 +56,7 @@
         "c8": "^7.12.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^1.1.1",
-        "typescript": "^4.8.3"
+        "typescript": "^4.8.4"
     },
     "dependencies": {
         "fast-xml-parser": "^4.0.10",