@abaplint/core 2.93.13 → 2.93.15

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.93.13";
+        return "2.93.15";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/cyclic_oo.js

@@ -30,7 +30,9 @@ class CyclicOO {
             key: "cyclic_oo",
             title: "Cyclic OO",
             shortDescription: `Finds cyclic OO references`,
-            extendedInformation: `Runs for global INTF + CLAS objects`,
+            extendedInformation: `Runs for global INTF + CLAS objects
+
+Objects must be without syntax errors for this rule to take effect`,
         };
     }
     getConfig() {
@@ -47,6 +49,9 @@ class CyclicOO {
         this.reg = reg;
         this.edges = {};
         for (const obj of this.reg.getObjectsByType("CLAS")) {
+            if (this.reg.isDependency(obj)) {
+                continue;
+            }
             const name = obj.getName().toUpperCase();
             if (!(obj instanceof objects_1.Class)) {
                 continue;
@@ -57,9 +62,16 @@ class CyclicOO {
             else if (this.conf.skipSharedMemory === true && ((_a = obj.getClassDefinition()) === null || _a === void 0 ? void 0 : _a.isSharedMemory) === true) {
                 continue;
             }
-            this.buildEdges(name, new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
+            const run = new syntax_1.SyntaxLogic(this.reg, obj).run();
+            if (run.issues.length > 0) {
+                continue;
+            }
+            this.buildEdges(name, run.spaghetti.getTop());
         }
         for (const obj of this.reg.getObjectsByType("INTF")) {
+            if (this.reg.isDependency(obj)) {
+                continue;
+            }
             const name = obj.getName().toUpperCase();
             if (!(obj instanceof _abap_object_1.ABAPObject)) {
                 continue;
@@ -67,7 +79,11 @@ class CyclicOO {
             else if (this.conf.skip.indexOf(name) >= 0) {
                 continue;
             }
-            this.buildEdges(name, new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
+            const run = new syntax_1.SyntaxLogic(this.reg, obj).run();
+            if (run.issues.length > 0) {
+                continue;
+            }
+            this.buildEdges(name, run.spaghetti.getTop());
         }
         return this;
     }
@@ -79,7 +95,9 @@ class CyclicOO {
         if (id === undefined) {
             return [];
         }
-        const path = this.findCycle(obj.getName(), obj.getName(), [obj.getName()]);
+        const previous = {};
+        previous[obj.getName()] = true;
+        const path = this.findCycle(obj.getName(), obj.getName(), previous);
         if (path) {
             const message = "Cyclic definition/usage: " + path;
             return [issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.conf.severity)];
@@ -93,10 +111,11 @@ class CyclicOO {
         }
         for (const e of this.edges[current]) {
             if (e === source) {
-                return previous.join(" -> ") + " -> " + source;
+                return Object.keys(previous).join(" -> ") + " -> " + source;
             }
-            if (previous.indexOf(e) < 0) { // dont revisit vertices
-                const found = this.findCycle(source, e, previous.concat([e]));
+            if (previous[e] === undefined) { // dont revisit vertices
+                previous[e] = true;
+                const found = this.findCycle(source, e, previous);
                 if (found) {
                     return found;
                 }

package/build/src/rules/downport.js

@@ -1317,7 +1317,7 @@ ${indentation}    output = ${topTarget}.`;
         return undefined;
     }
     outlineFor(forLoop, indentation, lowFile, highSyntax) {
-        var _a, _b, _c, _d, _e, _f, _g, _h;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k;
         let body = "";
         let end = "";
         const loopSource = (_a = forLoop.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens();
@@ -1357,8 +1357,12 @@ ${indentation}    output = ${topTarget}.`;
             end += indentation + "ENDWHILE";
         }
         else if (loopTargetField !== undefined) {
+            let from = (_h = forLoop.findExpressionAfterToken("FROM")) === null || _h === void 0 ? void 0 : _h.concatTokens();
+            from = from ? " FROM " + from : "";
+            let to = (_j = forLoop.findExpressionAfterToken("TO")) === null || _j === void 0 ? void 0 : _j.concatTokens();
+            to = to ? " TO " + to : "";
             // todo, also backup sy-index / sy-tabix here?
-            body += indentation + `LOOP AT ${loopSource} INTO DATA(${loopTargetField})${cond}.\n`;
+            body += indentation + `LOOP AT ${loopSource} INTO DATA(${loopTargetField})${from}${to}${cond}.\n`;
             if (indexInto) {
                 body += indentation + "  DATA(" + indexInto + ") = sy-tabix.\n";
             }
@@ -1366,7 +1370,7 @@ ${indentation}    output = ${topTarget}.`;
         }
         else if (loopTargetField === undefined) {
             // todo, also backup sy-index / sy-tabix here?
-            const loopTargetFieldSymbol = (_h = forLoop.findFirstExpression(Expressions.TargetFieldSymbol)) === null || _h === void 0 ? void 0 : _h.concatTokens();
+            const loopTargetFieldSymbol = (_k = forLoop.findFirstExpression(Expressions.TargetFieldSymbol)) === null || _k === void 0 ? void 0 : _k.concatTokens();
             body += indentation + `LOOP AT ${loopSource} ASSIGNING FIELD-SYMBOL(${loopTargetFieldSymbol})${cond}.\n`;
             if (indexInto) {
                 body += indentation + "  DATA(" + indexInto + ") = sy-tabix.\n";

package/build/src/rules/line_length.js

@@ -38,20 +38,18 @@ https://docs.abapopenchecks.org/checks/04/`,
         const issues = [];
         // maximum line length in abap files
         const maxLineLength = 255;
-        file.getRawRows().forEach((row, rowIndex) => {
-            row = row.replace("\r", "");
-            let message = "";
+        const array = file.getRawRows();
+        for (let rowIndex = 0; rowIndex < array.length; rowIndex++) {
+            const row = array[rowIndex].replace("\r", "");
             if (row.length > maxLineLength) {
-                message = `Maximum allowed line length of ${maxLineLength} exceeded, currently  ${row.length}`;
+                const message = `Maximum allowed line length of ${maxLineLength} exceeded, currently  ${row.length}`;
+                issues.push(issue_1.Issue.atRow(file, rowIndex + 1, message, this.getMetadata().key, this.conf.severity));
             }
             else if (row.length > this.conf.length) {
-                message = `Reduce line length to max ${this.conf.length}, currently ${row.length}`;
+                const message = `Reduce line length to max ${this.conf.length}, currently ${row.length}`;
+                issues.push(issue_1.Issue.atRow(file, rowIndex + 1, message, this.getMetadata().key, this.conf.severity));
             }
-            else {
-                return;
-            }
-            issues.push(issue_1.Issue.atRow(file, rowIndex + 1, message, this.getMetadata().key, this.conf.severity));
-        });
+        }
         return issues;
     }
 }

package/build/src/rules/prefer_inline.js

@@ -29,7 +29,7 @@ Activates if language version is v740sp02 or above.
 
 Variables must be local(METHOD or FORM).
 
-No generic or void typed variables.
+No generic or void typed variables. No syntax errors.
 
 First position used must be a full/pure write.
 
@@ -65,7 +65,11 @@ DATA(percentage) = CONV decfloat34( comment_number / abs_statement_number ) * 10
         else if (!(obj instanceof _abap_object_1.ABAPObject)) {
             return [];
         }
-        const scopes = this.findScopeCandidates(new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
+        const run = new syntax_1.SyntaxLogic(this.reg, obj).run();
+        if (run.issues.length > 0) {
+            return [];
+        }
+        const scopes = this.findScopeCandidates(run.spaghetti.getTop());
         const ret = [];
         for (const s of scopes) {
             ret.push(...this.analyzeScope(s, obj));

package/build/src/rules/prefix_is_current_class.js

@@ -30,7 +30,7 @@ class PrefixIsCurrentClass extends _abap_rule_1.ABAPRule {
             title: "Prefix is current class",
             shortDescription: `Reports errors if the current class or interface references itself with "current_class=>"`,
             // eslint-disable-next-line max-len
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-attribute-or-method`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };
     }

package/build/src/rules/remove_descriptions.js

@@ -103,12 +103,17 @@ Consider using ABAP Doc for documentation.`,
         if (desc === undefined) {
             return [];
         }
+        const reported = {}; // there might be multiple translations
         const ret = [];
         for (const d of (0, xml_utils_1.xmlToArray)(desc.SEOCOMPOTX)) {
             const message = "Remove description for " + d.CMPNAME;
+            if (reported[d.CMPNAME] !== undefined) {
+                continue;
+            }
             const position = new position_1.Position(1, 1);
             const issue = issue_1.Issue.atPosition(file, position, message, this.getMetadata().key, this.conf.severity);
             ret.push(issue);
+            reported[d.CMPNAME] = true;
         }
         return ret;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.93.13",
+    "version": "2.93.15",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -46,10 +46,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.30.0",
+        "@microsoft/api-extractor": "^7.31.0",
         "@types/chai": "^4.3.3",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^18.7.16",
+        "@types/node": "^18.7.18",
         "chai": "^4.3.6",
         "eslint": "^8.23.1",
         "mocha": "^10.0.0",
@@ -59,7 +59,7 @@
         "typescript": "^4.8.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.0.9",
+        "fast-xml-parser": "^4.0.10",
         "json5": "^2.2.1",
         "vscode-languageserver-types": "^3.17.2"
     }