@abaplint/core 2.93.13 → 2.93.14

package/build/src/registry.js

@@ -63,7 +63,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.93.13";
+        return "2.93.14";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/cyclic_oo.js

@@ -30,7 +30,9 @@ class CyclicOO {
             key: "cyclic_oo",
             title: "Cyclic OO",
             shortDescription: `Finds cyclic OO references`,
-            extendedInformation: `Runs for global INTF + CLAS objects`,
+            extendedInformation: `Runs for global INTF + CLAS objects
+
+Objects must be without syntax errors for this rule to take effect`,
         };
     }
     getConfig() {
@@ -47,6 +49,9 @@ class CyclicOO {
         this.reg = reg;
         this.edges = {};
         for (const obj of this.reg.getObjectsByType("CLAS")) {
+            if (this.reg.isDependency(obj)) {
+                continue;
+            }
             const name = obj.getName().toUpperCase();
             if (!(obj instanceof objects_1.Class)) {
                 continue;
@@ -57,9 +62,16 @@ class CyclicOO {
             else if (this.conf.skipSharedMemory === true && ((_a = obj.getClassDefinition()) === null || _a === void 0 ? void 0 : _a.isSharedMemory) === true) {
                 continue;
             }
-            this.buildEdges(name, new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
+            const run = new syntax_1.SyntaxLogic(this.reg, obj).run();
+            if (run.issues.length > 0) {
+                continue;
+            }
+            this.buildEdges(name, run.spaghetti.getTop());
         }
         for (const obj of this.reg.getObjectsByType("INTF")) {
+            if (this.reg.isDependency(obj)) {
+                continue;
+            }
             const name = obj.getName().toUpperCase();
             if (!(obj instanceof _abap_object_1.ABAPObject)) {
                 continue;
@@ -67,7 +79,11 @@ class CyclicOO {
             else if (this.conf.skip.indexOf(name) >= 0) {
                 continue;
             }
-            this.buildEdges(name, new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
+            const run = new syntax_1.SyntaxLogic(this.reg, obj).run();
+            if (run.issues.length > 0) {
+                continue;
+            }
+            this.buildEdges(name, run.spaghetti.getTop());
         }
         return this;
     }
@@ -79,7 +95,9 @@ class CyclicOO {
         if (id === undefined) {
             return [];
         }
-        const path = this.findCycle(obj.getName(), obj.getName(), [obj.getName()]);
+        const previous = {};
+        previous[obj.getName()] = true;
+        const path = this.findCycle(obj.getName(), obj.getName(), previous);
         if (path) {
             const message = "Cyclic definition/usage: " + path;
             return [issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.conf.severity)];
@@ -93,10 +111,11 @@ class CyclicOO {
         }
         for (const e of this.edges[current]) {
             if (e === source) {
-                return previous.join(" -> ") + " -> " + source;
+                return Object.keys(previous).join(" -> ") + " -> " + source;
             }
-            if (previous.indexOf(e) < 0) { // dont revisit vertices
-                const found = this.findCycle(source, e, previous.concat([e]));
+            if (previous[e] === undefined) { // dont revisit vertices
+                previous[e] = true;
+                const found = this.findCycle(source, e, previous);
                 if (found) {
                     return found;
                 }

package/build/src/rules/remove_descriptions.js

@@ -103,12 +103,17 @@ Consider using ABAP Doc for documentation.`,
         if (desc === undefined) {
             return [];
         }
+        const reported = {}; // there might be multiple translations
         const ret = [];
         for (const d of (0, xml_utils_1.xmlToArray)(desc.SEOCOMPOTX)) {
             const message = "Remove description for " + d.CMPNAME;
+            if (reported[d.CMPNAME] !== undefined) {
+                continue;
+            }
             const position = new position_1.Position(1, 1);
             const issue = issue_1.Issue.atPosition(file, position, message, this.getMetadata().key, this.conf.severity);
             ret.push(issue);
+            reported[d.CMPNAME] = true;
         }
         return ret;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.93.13",
+    "version": "2.93.14",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -46,10 +46,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.30.0",
+        "@microsoft/api-extractor": "^7.31.0",
         "@types/chai": "^4.3.3",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^18.7.16",
+        "@types/node": "^18.7.17",
         "chai": "^4.3.6",
         "eslint": "^8.23.1",
         "mocha": "^10.0.0",