@abaplint/core 2.92.2 → 2.93.2

package/build/src/rules/downport.js

@@ -83,10 +83,19 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         const version = this.lowReg.getConfig().getVersion();
         if (version === version_1.Version.v702 || version === version_1.Version.OpenABAP) {
             this.initHighReg();
-            this.graph = new include_graph_1.IncludeGraph(reg);
         }
         return this;
     }
+    listMainForInclude(filename) {
+        if (filename === undefined) {
+            return [];
+        }
+        // only initialize this.graph if needed
+        if (this.graph === undefined) {
+            this.graph = new include_graph_1.IncludeGraph(this.lowReg);
+        }
+        return this.graph.listMainForInclude(filename);
+    }
     run(lowObj) {
         var _a;
         const ret = [];
@@ -105,7 +114,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         let highSyntaxObj = highObj;
         // for includes do the syntax check via a main program
         if (lowObj instanceof objects_1.Program && lowObj.isInclude()) {
-            const mains = this.graph.listMainForInclude((_a = lowObj.getMainABAPFile()) === null || _a === void 0 ? void 0 : _a.getFilename());
+            const mains = this.listMainForInclude((_a = lowObj.getMainABAPFile()) === null || _a === void 0 ? void 0 : _a.getFilename());
             if (mains.length <= 0) {
                 return [];
             }
@@ -115,8 +124,8 @@ Only one transformation is applied to a statement at a time, so multiple steps m
             }
             highSyntaxObj = this.highReg.findObjectForFile(f);
         }
-        const highSyntax = new syntax_1.SyntaxLogic(this.highReg, highSyntaxObj).run();
         for (const lowFile of lowObj.getABAPFiles()) {
+            let highSyntax = undefined;
             const highFile = highObj.getABAPFileByName(lowFile.getFilename());
             if (highFile === undefined) {
                 continue;
@@ -137,6 +146,9 @@ Only one transformation is applied to a statement at a time, so multiple steps m
                 const high = highStatements[i];
                 if ((low.get() instanceof _statement_1.Unknown && !(high.get() instanceof _statement_1.Unknown))
                     || high.findFirstExpression(Expressions.InlineData)) {
+                    if (highSyntax === undefined) {
+                        highSyntax = new syntax_1.SyntaxLogic(this.highReg, highSyntaxObj).run();
+                    }
                     const issue = this.checkStatement(low, high, lowFile, highSyntax, highFile);
                     if (issue) {
                         ret.push(issue);
@@ -185,23 +197,23 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
-        found = this.emptyKey(high, lowFile);
+        found = this.emptyKey(low, high, lowFile);
         if (found) {
             return found;
         }
-        found = this.stringTemplateAlpha(high, lowFile, highSyntax);
+        found = this.stringTemplateAlpha(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.moveWithOperator(high, lowFile);
+        found = this.moveWithOperator(low, high, lowFile);
         if (found) {
             return found;
         }
-        found = this.moveWithSimpleValue(high, lowFile);
+        found = this.moveWithSimpleValue(low, high, lowFile);
         if (found) {
             return found;
         }
-        found = this.assignWithTable(high, lowFile);
+        found = this.assignWithTable(low, high, lowFile);
         if (found) {
             return found;
         }
@@ -209,7 +221,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
-        found = this.downportRef(high, lowFile, highSyntax);
+        found = this.downportRef(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
@@ -233,7 +245,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
-        found = this.outlineLoopInput(high, lowFile, highSyntax);
+        found = this.outlineLoopInput(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
@@ -241,27 +253,27 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
-        found = this.outlineValue(high, lowFile, highSyntax);
+        found = this.outlineValue(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.outlineReduce(high, lowFile, highSyntax);
+        found = this.outlineReduce(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.outlineSwitch(high, lowFile, highSyntax);
+        found = this.outlineSwitch(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.outlineCast(high, lowFile, highSyntax);
+        found = this.outlineCast(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.outlineConv(high, lowFile, highSyntax);
+        found = this.outlineConv(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.outlineCond(high, lowFile, highSyntax);
+        found = this.outlineCond(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
@@ -277,11 +289,11 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
-        found = this.outlineFS(high, lowFile, highSyntax);
+        found = this.outlineFS(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.newToCreateObject(high, lowFile, highSyntax);
+        found = this.newToCreateObject(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
@@ -301,11 +313,11 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
-        found = this.replaceMethodConditional(high, lowFile, highSyntax);
+        found = this.replaceMethodConditional(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
-        found = this.replaceTableExpression(high, lowFile, highSyntax);
+        found = this.replaceTableExpression(low, high, lowFile, highSyntax);
         if (found) {
             return found;
         }
@@ -403,8 +415,11 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         }
         return undefined;
     }
-    downportSelectSingleInline(_low, high, lowFile, _highSyntax) {
+    downportSelectSingleInline(low, high, lowFile, _highSyntax) {
         var _a, _b, _c, _d;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
         const targets = ((_a = high.findFirstExpression(Expressions.SQLIntoStructure)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.SQLTarget)) || [];
         if (targets.length !== 1) {
             return undefined;
@@ -462,8 +477,11 @@ ${indentation}`);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, inlineData.getFirstToken(), "Outline SELECT @DATA", this.getMetadata().key, this.conf.severity, fix);
     }
-    downportSelectTableInline(_low, high, lowFile, highSyntax) {
+    downportSelectTableInline(low, high, lowFile, highSyntax) {
         var _a, _b, _c;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
         const targets = ((_a = high.findFirstExpression(Expressions.SQLIntoTable)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.SQLTarget)) || [];
         if (targets.length !== 1) {
             return undefined;
@@ -577,13 +595,16 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
         }
         return undefined;
     }
-    replaceTableExpression(node, lowFile, highSyntax) {
-        for (const fieldChain of node.findAllExpressionsRecursive(Expressions.FieldChain)) {
+    replaceTableExpression(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const fieldChain of high.findAllExpressionsRecursive(Expressions.FieldChain)) {
             const tableExpression = fieldChain.findDirectExpression(Expressions.TableExpression);
             if (tableExpression === undefined) {
                 continue;
             }
-            const concat = node.concatTokens().toUpperCase();
+            const concat = high.concatTokens().toUpperCase();
             if (concat.includes(" LINE_EXISTS( ") || concat.includes(" LINE_INDEX( ")) {
                 // note: line_exists() must be replaced before handling table expressions
                 continue;
@@ -603,10 +624,10 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
                 continue;
             }
             const condition = this.tableCondition(tableExpression);
-            const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
-            const tabixBackup = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
-            const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-            const firstToken = node.getFirstToken();
+            const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const tabixBackup = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+            const firstToken = high.getFirstToken();
             // note that the tabix restore should be done before throwing the exception
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
 ${indentation}DATA ${tabixBackup} LIKE sy-tabix.
@@ -619,7 +640,7 @@ ${indentation}ENDIF.
 ${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
-            return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline table expression", this.getMetadata().key, this.conf.severity, fix);
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Outline table expression", this.getMetadata().key, this.conf.severity, fix);
         }
         return undefined;
     }
@@ -801,7 +822,10 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
         return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
     }
-    emptyKey(node, lowFile) {
+    emptyKey(low, node, lowFile) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
         for (let i of node.findAllExpressions(Expressions.TypeTable)) {
             const key = i.findDirectExpression(Expressions.TypeTableKey);
             if (key === undefined) {
@@ -950,7 +974,10 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
         }
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, LOOP GROUP", this.getMetadata().key, this.conf.severity, fix);
     }
-    downportRef(high, lowFile, highSyntax) {
+    downportRef(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
         let found = undefined;
         for (const s of high.findAllExpressionsRecursive(Expressions.Source)) {
             if (s.getFirstToken().getStr().toUpperCase() === "REF"
@@ -968,8 +995,11 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, REF", this.getMetadata().key, this.conf.severity, fix);
     }
-    assignWithTable(high, lowFile) {
+    assignWithTable(low, high, lowFile) {
         var _a, _b;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
         if (!(high.get() instanceof Statements.Assign)) {
             return undefined;
         }
@@ -1004,7 +1034,10 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), code);
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, ASSIGN table expr", this.getMetadata().key, this.conf.severity, fix);
     }
-    moveWithSimpleValue(high, lowFile) {
+    moveWithSimpleValue(low, high, lowFile) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
         if (!(high.get() instanceof Statements.Move)
             || high.getChildren().length !== 4) {
             return undefined;
@@ -1069,8 +1102,11 @@ CONSTANTS: BEGIN OF ${structureName},\n`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, start, end, code);
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport ENUM", this.getMetadata().key, this.conf.severity, fix);
     }
-    moveWithTableTarget(node, high, lowFile, highSyntax) {
+    moveWithTableTarget(low, high, lowFile, highSyntax) {
         var _a;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
         if (!(high.get() instanceof Statements.Move)) {
             return undefined;
         }
@@ -1086,11 +1122,11 @@ CONSTANTS: BEGIN OF ${structureName},\n`;
         if (index === undefined) {
             return undefined;
         }
-        let uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        let uniqueName = this.uniqueName(low.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         uniqueName = `<${uniqueName}>`;
         const tName = target.concatTokens().split("[")[0];
         const condition = this.tableCondition(tableExpression);
-        const tabixBackup = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const tabixBackup = this.uniqueName(low.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
         // restore tabix before exeption
         const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
@@ -1110,9 +1146,12 @@ ${indentation}${uniqueName}`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, start, end, code);
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, move with table target", this.getMetadata().key, this.conf.severity, fix);
     }
-    moveWithOperator(high, lowFile) {
+    moveWithOperator(low, high, lowFile) {
         var _a, _b, _c;
-        if (!(high.get() instanceof Statements.Move)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Move)) {
             return undefined;
         }
         const children = high.getChildren();
@@ -1153,12 +1192,15 @@ ${indentation}${uniqueName}`;
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Expand operator", this.getMetadata().key, this.conf.severity, fix);
     }
     // must be very simple string templates, like "|{ ls_line-no ALPHA = IN }|"
-    stringTemplateAlpha(node, lowFile, highSyntax) {
+    stringTemplateAlpha(low, high, lowFile, highSyntax) {
         var _a, _b, _c;
-        if (!(node.get() instanceof Statements.Move)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Move)) {
             return undefined;
         }
-        const topSource = node.findDirectExpression(Expressions.Source);
+        const topSource = high.findDirectExpression(Expressions.Source);
         if (topSource === undefined || topSource.getChildren().length !== 1) {
             return undefined;
         }
@@ -1190,10 +1232,10 @@ ${indentation}${uniqueName}`;
             default:
                 return undefined;
         }
-        const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+        const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
         const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
-        const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
-        const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const topTarget = (_c = high.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+        const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         if (top === false) {
             const code = `DATA ${uniqueName} TYPE string.
 ${indentation}CALL FUNCTION '${functionName}'
@@ -1201,10 +1243,10 @@ ${indentation}  EXPORTING
 ${indentation}    input  = ${source}
 ${indentation}  IMPORTING
 ${indentation}    output = ${uniqueName}.\n`;
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, child.getFirstToken().getStart(), child.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
-            return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
         }
         else {
             const code = `CALL FUNCTION '${functionName}'
@@ -1212,29 +1254,32 @@ ${indentation}  EXPORTING
 ${indentation}    input  = ${source}
 ${indentation}  IMPORTING
 ${indentation}    output = ${topTarget}.`;
-            const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
-            return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
+            const fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), code);
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
         }
     }
-    outlineLoopInput(node, lowFile, highSyntax) {
-        if (!(node.get() instanceof Statements.Loop)) {
+    outlineLoopInput(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Loop)) {
             return undefined;
         }
-        else if (node.findDirectExpression(Expressions.SimpleSource2)) {
+        else if (high.findDirectExpression(Expressions.SimpleSource2)) {
             return undefined;
         }
         // the first Source must be outlined
-        const s = node.findDirectExpression(Expressions.Source);
+        const s = high.findDirectExpression(Expressions.Source);
         if (s === undefined) {
             return undefined;
         }
-        const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const code = `DATA(${uniqueName}) = ${s.concatTokens()}.\n` +
-            " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);
+            " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, s.getFirstToken().getStart(), s.getLastToken().getEnd(), uniqueName);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
-        return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline LOOP input", this.getMetadata().key, this.conf.severity, fix);
+        return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Outline LOOP input", this.getMetadata().key, this.conf.severity, fix);
     }
     outlineLoopTarget(node, lowFile, _highSyntax) {
         var _a, _b, _c, _d, _e, _f, _g;
@@ -1323,19 +1368,22 @@ ${indentation}    output = ${topTarget}.`;
         }
         return { body, end };
     }
-    outlineSwitch(node, lowFile, highSyntax) {
+    outlineSwitch(low, high, lowFile, highSyntax) {
         var _a, _b, _c, _d;
-        for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const i of high.findAllExpressionsRecursive(Expressions.Source)) {
             const firstToken = i.getFirstToken();
             if (firstToken.getStr().toUpperCase() !== "SWITCH") {
                 continue;
             }
             let type = this.findType(i, lowFile, highSyntax);
             if (type === undefined) {
-                if (node.get() instanceof Statements.Move
-                    && node.findDirectExpression(Expressions.Source) === i
-                    && ((_a = node.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.TargetField)) !== undefined) {
-                    type = "LIKE " + ((_b = node.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
+                if (high.get() instanceof Statements.Move
+                    && high.findDirectExpression(Expressions.Source) === i
+                    && ((_a = high.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.TargetField)) !== undefined) {
+                    type = "LIKE " + ((_b = high.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
                 }
                 if (type === undefined) {
                     continue;
@@ -1345,7 +1393,7 @@ ${indentation}    output = ${topTarget}.`;
                 type = "TYPE " + type;
             }
             const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
-            const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             let body = "";
             let name = "";
             const switchBody = i.findDirectExpression(Expressions.SwitchBody);
@@ -1387,16 +1435,19 @@ ${indentation}    output = ${topTarget}.`;
                 }
             }
             body += "\n" + indentation + "ENDCASE.\n" + indentation;
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), body);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), body);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, firstToken.getStart(), i.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, firstToken, "Downport SWITCH", this.getMetadata().key, this.conf.severity, fix);
         }
         return undefined;
     }
-    outlineReduce(node, lowFile, highSyntax) {
+    outlineReduce(low, high, lowFile, highSyntax) {
         var _a, _b;
-        for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const i of high.findAllExpressionsRecursive(Expressions.Source)) {
             const firstToken = i.getFirstToken();
             if (firstToken.getStr().toUpperCase() !== "REDUCE") {
                 continue;
@@ -1406,7 +1457,7 @@ ${indentation}    output = ${topTarget}.`;
                 continue;
             }
             const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
-            const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             let body = "";
             let name = "";
             const reduceBody = i.findDirectExpression(Expressions.ReduceBody);
@@ -1462,16 +1513,19 @@ ${indentation}    output = ${topTarget}.`;
             const abap = `DATA ${uniqueName} TYPE ${type}.\n` +
                 body +
                 indentation;
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, firstToken.getStart(), i.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, firstToken, "Downport REDUCE", this.getMetadata().key, this.conf.severity, fix);
         }
         return undefined;
     }
-    outlineValue(node, lowFile, highSyntax) {
+    outlineValue(low, high, lowFile, highSyntax) {
         var _a, _b, _c;
-        const allSources = node.findAllExpressionsRecursive(Expressions.Source);
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        const allSources = high.findAllExpressionsRecursive(Expressions.Source);
         for (const s of allSources) {
             const firstToken = s.getFirstToken();
             if (firstToken.getStr().toUpperCase() !== "VALUE") {
@@ -1479,8 +1533,8 @@ ${indentation}    output = ${topTarget}.`;
             }
             let type = this.findType(s, lowFile, highSyntax);
             if (type === undefined) {
-                if (node.get() instanceof Statements.Move && node.findDirectExpression(Expressions.Source) === s) {
-                    type = "LIKE " + ((_a = node.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens());
+                if (high.get() instanceof Statements.Move && high.findDirectExpression(Expressions.Source) === s) {
+                    type = "LIKE " + ((_a = high.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens());
                 }
                 if (type === undefined) {
                     continue;
@@ -1491,7 +1545,7 @@ ${indentation}    output = ${topTarget}.`;
             }
             const valueBody = s.findDirectExpression(Expressions.ValueBody);
             const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
-            let indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            let indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             let body = "";
             const base = valueBody === null || valueBody === void 0 ? void 0 : valueBody.findExpressionAfterToken("BASE");
             if (base) {
@@ -1598,7 +1652,7 @@ ${indentation}    output = ${topTarget}.`;
                 indentation + `CLEAR ${uniqueName}.\n` + // might be called inside a loop
                 body +
                 indentation;
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, firstToken.getStart(), s.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, firstToken, "Downport VALUE", this.getMetadata().key, this.conf.severity, fix);
@@ -1670,17 +1724,20 @@ ${indentation}    output = ${topTarget}.`;
             return (_a = inferred.getType().getQualifiedName()) === null || _a === void 0 ? void 0 : _a.toLowerCase();
         }
     }
-    outlineFS(node, lowFile, highSyntax) {
+    outlineFS(low, high, lowFile, highSyntax) {
         var _a, _b;
-        for (const i of node.findAllExpressionsRecursive(Expressions.InlineFS)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const i of high.findAllExpressionsRecursive(Expressions.InlineFS)) {
             const nameToken = (_a = i.findDirectExpression(Expressions.TargetFieldSymbol)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
             if (nameToken === undefined) {
                 continue;
             }
             const name = nameToken.getStr();
             let type = "";
-            if (node.concatTokens().toUpperCase().startsWith("APPEND INITIAL LINE TO ")) {
-                type = "LIKE LINE OF " + ((_b = node.findFirstExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
+            if (high.concatTokens().toUpperCase().startsWith("APPEND INITIAL LINE TO ")) {
+                type = "LIKE LINE OF " + ((_b = high.findFirstExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
             }
             else {
                 const spag = highSyntax.spaghetti.lookupPosition(nameToken.getStart(), lowFile.getFilename());
@@ -1698,8 +1755,8 @@ ${indentation}    output = ${topTarget}.`;
                 type += found.getType().getQualifiedName() ? found.getType().getQualifiedName().toLowerCase() : found.getType().toABAP();
             }
             const code = `FIELD-SYMBOLS ${name} ${type}.\n` +
-                " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);
+                " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, i.getFirstToken().getStart(), i.getLastToken().getEnd(), name);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, i.getFirstToken(), "Outline FIELD-SYMBOL", this.getMetadata().key, this.conf.severity, fix);
@@ -1707,6 +1764,7 @@ ${indentation}    output = ${topTarget}.`;
         return undefined;
     }
     outlineData(node, lowFile, highSyntax) {
+        // hmm, no guard here, as DATA(SDF) is valid in 702
         var _a, _b;
         for (const i of node.findAllExpressionsRecursive(Expressions.InlineData)) {
             const nameToken = (_a = i.findDirectExpression(Expressions.TargetField)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
@@ -1738,9 +1796,12 @@ ${indentation}    output = ${topTarget}.`;
         }
         return undefined;
     }
-    outlineCond(node, lowFile, highSyntax) {
+    outlineCond(low, high, lowFile, highSyntax) {
         var _a, _b;
-        for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const i of high.findAllExpressionsRecursive(Expressions.Source)) {
             if (i.getFirstToken().getStr().toUpperCase() !== "COND") {
                 continue;
             }
@@ -1751,10 +1812,10 @@ ${indentation}    output = ${topTarget}.`;
             const uniqueName = this.uniqueName(i.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             let type = this.findType(i, lowFile, highSyntax);
             if (type === undefined) {
-                if (node.get() instanceof Statements.Move
-                    && node.findDirectExpression(Expressions.Source) === i
-                    && ((_a = node.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.TargetField)) !== undefined) {
-                    type = "LIKE " + ((_b = node.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
+                if (high.get() instanceof Statements.Move
+                    && high.findDirectExpression(Expressions.Source) === i
+                    && ((_a = high.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.TargetField)) !== undefined) {
+                    type = "LIKE " + ((_b = high.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
                 }
                 if (type === undefined) {
                     continue;
@@ -1763,10 +1824,10 @@ ${indentation}    output = ${topTarget}.`;
             else {
                 type = "TYPE " + type;
             }
-            const indent = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            const indent = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             const bodyCode = this.buildCondBody(body, uniqueName, indent, lowFile, highSyntax);
             const abap = `DATA ${uniqueName} ${type}.\n` + bodyCode;
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, i.getFirstToken().getStart(), i.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, i.getFirstToken(), "Downport COND", this.getMetadata().key, this.conf.severity, fix);
@@ -1822,9 +1883,12 @@ ${indentation}    output = ${topTarget}.`;
         code += indent;
         return code;
     }
-    outlineConv(node, lowFile, highSyntax) {
+    outlineConv(low, high, lowFile, highSyntax) {
         var _a;
-        for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const i of high.findAllExpressionsRecursive(Expressions.Source)) {
             if (i.getFirstToken().getStr().toUpperCase() !== "CONV") {
                 continue;
             }
@@ -1838,11 +1902,11 @@ ${indentation}    output = ${topTarget}.`;
             }
             const uniqueName = this.uniqueName(i.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const type = this.findType(i, lowFile, highSyntax);
-            const indent = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            const indent = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             const abap = `DATA ${uniqueName} TYPE ${type}.\n` +
                 indent + `${uniqueName} = ${body}.\n` +
                 indent;
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, i.getFirstToken().getStart(), end.getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, i.getFirstToken(), "Downport CONV", this.getMetadata().key, this.conf.severity, fix);
@@ -1850,17 +1914,20 @@ ${indentation}    output = ${topTarget}.`;
         return undefined;
     }
     // "CAST" to "?="
-    outlineCast(node, lowFile, highSyntax) {
+    outlineCast(low, high, lowFile, highSyntax) {
         var _a;
-        for (const i of node.findAllExpressionsRecursive(Expressions.Cast)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const i of high.findAllExpressionsRecursive(Expressions.Cast)) {
             const uniqueName = this.uniqueName(i.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const type = this.findType(i, lowFile, highSyntax, true);
             const body = (_a = i.findDirectExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens();
             const abap = `DATA ${uniqueName} TYPE ${type}.\n` +
-                " ".repeat(node.getFirstToken().getStart().getCol() - 1) +
+                " ".repeat(high.getFirstToken().getStart().getCol() - 1) +
                 `${uniqueName} ?= ${body}.\n` +
-                " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
+                " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, i.getFirstToken().getStart(), i.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, i.getFirstToken(), "Downport CAST", this.getMetadata().key, this.conf.severity, fix);
@@ -1904,14 +1971,17 @@ ${indentation}    output = ${topTarget}.`;
         }
         return undefined;
     }
-    replaceMethodConditional(node, lowFile, highSyntax) {
-        for (const c of node.findAllExpressionsRecursive(Expressions.Compare)) {
+    replaceMethodConditional(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const c of high.findAllExpressionsRecursive(Expressions.Compare)) {
             const chain = c.findDirectExpression(Expressions.MethodCallChain);
             if (chain === undefined) {
                 continue;
             }
             let predicate = false;
-            const spag = highSyntax.spaghetti.lookupPosition(node.getFirstToken().getStart(), lowFile.getFilename());
+            const spag = highSyntax.spaghetti.lookupPosition(high.getFirstToken().getStart(), lowFile.getFilename());
             for (const r of (spag === null || spag === void 0 ? void 0 : spag.getData().references) || []) {
                 if (r.referenceType === _reference_1.ReferenceType.BuiltinMethodReference &&
                     new _builtin_1.BuiltIn().isPredicate(chain.getFirstToken().getStr().toUpperCase())) {
@@ -2032,13 +2102,16 @@ ${indentation}    output = ${topTarget}.`;
         }
         return undefined;
     }
-    newToCreateObject(node, lowFile, highSyntax) {
-        const source = node.findDirectExpression(Expressions.Source);
+    newToCreateObject(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        const source = high.findDirectExpression(Expressions.Source);
         let fix = undefined;
-        if (node.get() instanceof Statements.Move
+        if (high.get() instanceof Statements.Move
             && source
             && source.getFirstToken().getStr().toUpperCase() === "NEW") {
-            const target = node.findDirectExpression(Expressions.Target);
+            const target = high.findDirectExpression(Expressions.Target);
             const found = source === null || source === void 0 ? void 0 : source.findFirstExpression(Expressions.NewObject);
             // must be at top level of the source for quickfix to work(todo: handle more scenarios)
             if (target
@@ -2047,12 +2120,12 @@ ${indentation}    output = ${topTarget}.`;
                 && target.findDirectExpression(Expressions.InlineData) === undefined) {
                 const abap = this.newParameters(found, target.concatTokens(), highSyntax, lowFile);
                 if (abap !== undefined) {
-                    fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), abap);
+                    fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), abap);
                 }
             }
         }
-        if (fix === undefined && node.findAllExpressions(Expressions.NewObject)) {
-            const found = node.findFirstExpression(Expressions.NewObject);
+        if (fix === undefined && high.findAllExpressions(Expressions.NewObject)) {
+            const found = high.findFirstExpression(Expressions.NewObject);
             if (found === undefined) {
                 return undefined;
             }
@@ -2062,16 +2135,16 @@ ${indentation}    output = ${topTarget}.`;
                 return undefined;
             }
             const type = this.findType(found, lowFile, highSyntax);
-            const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             const data = `DATA ${name} TYPE REF TO ${type}.\n` +
                 indentation + abap + "\n" +
                 indentation;
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), data);
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), data);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, found.getFirstToken().getStart(), found.getLastToken().getEnd(), name);
             fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         }
         if (fix) {
-            return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Use CREATE OBJECT instead of NEW", this.getMetadata().key, this.conf.severity, fix);
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Use CREATE OBJECT instead of NEW", this.getMetadata().key, this.conf.severity, fix);
         }
         else {
             return undefined;