@abaplint/core 2.91.9 → 2.91.12

package/build/src/rules/unknown_types.js

@@ -99,7 +99,7 @@ class UnknownTypes {
             }
         }
         for (const v of nodeData.idefs) {
-            const found = this.checkMethodParameters(v);
+            const found = this.checkParameters(v);
             if (found) {
                 const message = "Contains unknown, " + found.found;
                 ret.push(issue_1.Issue.atIdentifier(found.id, message, this.getMetadata().key, this.conf.severity));
@@ -107,7 +107,7 @@ class UnknownTypes {
         }
         for (const name in nodeData.cdefs) {
             const v = nodeData.cdefs[name];
-            const found = this.checkMethodParameters(v);
+            const found = this.checkParameters(v);
             if (found) {
                 const message = "Contains unknown, " + found.found;
                 ret.push(issue_1.Issue.atIdentifier(found.id, message, this.getMetadata().key, this.conf.severity));
@@ -118,7 +118,7 @@ class UnknownTypes {
         }
         return ret;
     }
-    checkMethodParameters(idef) {
+    checkParameters(idef) {
         var _a;
         for (const m of ((_a = idef.getMethodDefinitions()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
             for (const p of m.getParameters().getAll()) {
@@ -128,6 +128,14 @@ class UnknownTypes {
                 }
             }
         }
+        for (const e of idef.getEvents() || []) {
+            for (const p of e.getParameters()) {
+                const found = this.containsUnknown(p.getType());
+                if (found) {
+                    return { id: p, found };
+                }
+            }
+        }
         return undefined;
     }
     containsUnknown(type) {

package/build/src/rules/unnecessary_pragma.js

@@ -21,31 +21,31 @@ class UnnecessaryPragma extends _abap_rule_1.ABAPRule {
             key: "unnecessary_pragma",
             title: "Unnecessary Pragma",
             shortDescription: `Finds pragmas which can be removed`,
-            extendedInformation: `* NO_HANDLER with handler
-
-* NEEDED without definition
-
-* NO_TEXT without texts
-
+            extendedInformation: `* NO_HANDLER with handler
+
+* NEEDED without definition
+
+* NO_TEXT without texts
+
 * SUBRC_OK where sy-subrc is checked`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception ##NO_HANDLER.
-    RETURN. " it has a handler
-ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.
-SELECT SINGLE * FROM tadir INTO @DATA(sdfs) ##SUBRC_OK.
-IF sy-subrc <> 0.
+            badExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception ##NO_HANDLER.
+    RETURN. " it has a handler
+ENDTRY.
+MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs) ##SUBRC_OK.
+IF sy-subrc <> 0.
 ENDIF.`,
-            goodExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception.
-    RETURN.
-ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message.
-SELECT SINGLE * FROM tadir INTO @DATA(sdfs).
-IF sy-subrc <> 0.
+            goodExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception.
+    RETURN.
+ENDTRY.
+MESSAGE w125(zbar) WITH c_foo INTO message.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs).
+IF sy-subrc <> 0.
 ENDIF.`,
         };
     }

package/build/src/rules/unused_methods.js

@@ -55,15 +55,15 @@ class UnusedMethods {
             key: "unused_methods",
             title: "Unused methods",
             shortDescription: `Checks for unused methods`,
-            extendedInformation: `Checks private and protected methods.
-
-Skips:
-* methods FOR TESTING
-* methods SETUP + TEARDOWN + CLASS_SETUP + CLASS_TEARDOWN in testclasses
-* class_constructor + constructor methods
-* event handlers
-* methods that are redefined
-* INCLUDEs
+            extendedInformation: `Checks private and protected methods.
+
+Skips:
+* methods FOR TESTING
+* methods SETUP + TEARDOWN + CLASS_SETUP + CLASS_TEARDOWN in testclasses
+* class_constructor + constructor methods
+* event handlers
+* methods that are redefined
+* INCLUDEs
 `,
             tags: [],
             pragma: "##CALLED",

package/build/src/rules/unused_variables.js

@@ -64,12 +64,12 @@ class UnusedVariables {
             key: "unused_variables",
             title: "Unused variables",
             shortDescription: `Checks for unused variables and constants`,
-            extendedInformation: `WARNING: slow
-
-Skips event parameters.
-
-Note that this currently does not work if the source code uses macros.
-
+            extendedInformation: `WARNING: slow
+
+Skips event parameters.
+
+Note that this currently does not work if the source code uses macros.
+
 Unused variables are not reported if the object contains syntax errors. Errors found in INCLUDES are reported for the main program.`,
             tags: [_irule_1.RuleTag.Quickfix],
             pragma: "##NEEDED",

package/build/src/rules/use_bool_expression.js

@@ -27,15 +27,15 @@ class UseBoolExpression extends _abap_rule_1.ABAPRule {
             shortDescription: `Use boolean expression, xsdbool from 740sp08 and up, boolc from 702 and up`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-xsdbool-to-set-boolean-variables`,
             tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `IF line IS INITIAL.
-  has_entries = abap_false.
-ELSE.
-  has_entries = abap_true.
-ENDIF.
-
+            badExample: `IF line IS INITIAL.
+  has_entries = abap_false.
+ELSE.
+  has_entries = abap_true.
+ENDIF.
+
 DATA(fsdf) = COND #( WHEN foo <> bar THEN abap_true ELSE abap_false ).`,
-            goodExample: `DATA(has_entries) = xsdbool( line IS NOT INITIAL ).
-
+            goodExample: `DATA(has_entries) = xsdbool( line IS NOT INITIAL ).
+
 DATA(fsdf) = xsdbool( foo <> bar ).`,
         };
     }

package/build/src/rules/use_line_exists.js

@@ -22,15 +22,15 @@ class UseLineExists extends _abap_rule_1.ABAPRule {
             key: "use_line_exists",
             title: "Use line_exists",
             shortDescription: `Use line_exists, from 740sp02 and up`,
-            extendedInformation: `
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-line_exists-to-read-table-or-loop-at
-
+            extendedInformation: `
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-line_exists-to-read-table-or-loop-at
+
 Not reported if the READ TABLE statement contains BINARY SEARCH.`,
             tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
-            badExample: `READ TABLE my_table TRANSPORTING NO FIELDS WITH KEY key = 'A'.
-IF sy-subrc = 0.
+            badExample: `READ TABLE my_table TRANSPORTING NO FIELDS WITH KEY key = 'A'.
+IF sy-subrc = 0.
 ENDIF.`,
-            goodExample: `IF line_exists( my_table[ key = 'A' ] ).
+            goodExample: `IF line_exists( my_table[ key = 'A' ] ).
 ENDIF.`,
         };
     }

package/build/src/rules/use_new.js

@@ -23,10 +23,10 @@ class UseNew extends _abap_rule_1.ABAPRule {
             key: "use_new",
             title: "Use NEW",
             shortDescription: `Checks for deprecated CREATE OBJECT statements.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-new-to-create-object
-
-If the target variable is referenced in the CREATE OBJECT statement, no errors are issued
-
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-new-to-create-object
+
+If the target variable is referenced in the CREATE OBJECT statement, no errors are issued
+
 Applicable from v740sp02 and up`,
             badExample: `CREATE OBJECT ref.`,
             goodExample: `ref = NEW #( ).`,

package/build/src/rules/when_others_last.js

@@ -21,13 +21,13 @@ class WhenOthersLast extends _abap_rule_1.ABAPRule {
             title: "WHEN OTHERS last",
             shortDescription: `Checks that WHEN OTHERS is placed the last within a CASE statement.`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `CASE bar.
-  WHEN OTHERS.
-  WHEN 2.
+            badExample: `CASE bar.
+  WHEN OTHERS.
+  WHEN 2.
 ENDCASE.`,
-            goodExample: `CASE bar.
-  WHEN 2.
-  WHEN OTHERS.
+            goodExample: `CASE bar.
+  WHEN 2.
+  WHEN OTHERS.
 ENDCASE.`,
         };
     }

package/build/src/rules/xml_consistency.js

@@ -65,8 +65,7 @@ class XMLConsistency {
             else if (name !== obj.getName().toUpperCase()) {
                 issues.push(issue_1.Issue.atRow(file, 1, "Name in XML does not match object", this.getMetadata().key, this.conf.severity));
             }
-            else if (obj.getDefinition() === undefined
-                || ((_b = obj.getDefinition()) === null || _b === void 0 ? void 0 : _b.getName().toUpperCase()) !== name.toUpperCase()) {
+            else if (obj.getDefinition() !== undefined && ((_b = obj.getDefinition()) === null || _b === void 0 ? void 0 : _b.getName().toUpperCase()) !== name.toUpperCase()) {
                 issues.push(issue_1.Issue.atRow(file, 1, "Interface matching XML name not found in ABAP file", this.getMetadata().key, this.conf.severity));
             }
         }

package/package.json

@@ -1,65 +1,65 @@
-{
-    "name": "@abaplint/core",
-    "version": "2.91.9",
-    "description": "abaplint - Core API",
-    "main": "build/src/index.js",
-    "typings": "build/abaplint.d.ts",
-    "scripts": {
-        "lint": "eslint src/**/*.ts test/**/*.ts --format unix",
-        "lint:fix": "eslint src/**/*.ts test/**/*.ts --format unix --fix",
-        "compile": "tsc && sh scripts/version.sh",
-        "test": "npm run compile && mocha --timeout 1000 && npm run lint && npm run schema && api-extractor run",
-        "test:only": "npm run compile && mocha",
-        "test:parallel": "npm run compile && mocha --timeout 1000 --parallel --reporter dot",
-        "coverage": "npm run compile && c8 mocha && c8 report --reporter=html",
-        "schema": "node scripts/schema.js > scripts/schema.ts && ts-json-schema-generator --tsconfig tsconfig_schema.json --jsDoc extended --path scripts/schema.ts > scripts/schema.json && node scripts/schema_post.js",
-        "publish:minor": "npm --no-git-tag-version version minor && rm -rf build && npm install && npm run test && npm publish --access public",
-        "publish:patch": "npm --no-git-tag-version version patch && rm -rf build && npm install && npm run test && npm publish --access public"
-    },
-    "mocha": {
-        "recursive": true,
-        "reporter": "progress",
-        "spec": "build/test/**/*.js",
-        "require": "source-map-support/register"
-    },
-    "c8": {
-        "include": [
-            "build/src/**/*.js"
-        ]
-    },
-    "repository": {
-        "type": "git",
-        "url": "git+https://github.com/abaplint/abaplint.git"
-    },
-    "engines": {
-        "node": ">=12.0.0"
-    },
-    "keywords": [
-        "ABAP",
-        "lint"
-    ],
-    "author": "Lars Hvam Petersen",
-    "license": "MIT",
-    "bugs": {
-        "url": "https://github.com/abaplint/abaplint/issues"
-    },
-    "homepage": "https://abaplint.org",
-    "devDependencies": {
-        "@microsoft/api-extractor": "^7.28.4",
-        "@types/chai": "^4.3.1",
-        "@types/mocha": "^9.1.1",
-        "@types/node": "^18.0.3",
-        "chai": "^4.3.6",
-        "eslint": "^8.19.0",
-        "mocha": "^10.0.0",
-        "c8": "^7.11.3",
-        "source-map-support": "^0.5.21",
-        "ts-json-schema-generator": "^1.0.0",
-        "typescript": "^4.7.4"
-    },
-    "dependencies": {
-        "fast-xml-parser": "^4.0.9",
-        "json5": "^2.2.1",
-        "vscode-languageserver-types": "^3.17.1"
-    }
-}
+{
+    "name": "@abaplint/core",
+    "version": "2.91.12",
+    "description": "abaplint - Core API",
+    "main": "build/src/index.js",
+    "typings": "build/abaplint.d.ts",
+    "scripts": {
+        "lint": "eslint src/**/*.ts test/**/*.ts --format unix",
+        "lint:fix": "eslint src/**/*.ts test/**/*.ts --format unix --fix",
+        "compile": "tsc && sh scripts/version.sh",
+        "test": "npm run compile && mocha --timeout 1000 && npm run lint && npm run schema && api-extractor run",
+        "test:only": "npm run compile && mocha",
+        "test:parallel": "npm run compile && mocha --timeout 1000 --parallel --reporter dot",
+        "coverage": "npm run compile && c8 mocha && c8 report --reporter=html",
+        "schema": "node scripts/schema.js > scripts/schema.ts && ts-json-schema-generator --tsconfig tsconfig_schema.json --jsDoc extended --path scripts/schema.ts > scripts/schema.json && node scripts/schema_post.js",
+        "publish:minor": "npm --no-git-tag-version version minor && rm -rf build && npm install && npm run test && npm publish --access public",
+        "publish:patch": "npm --no-git-tag-version version patch && rm -rf build && npm install && npm run test && npm publish --access public"
+    },
+    "mocha": {
+        "recursive": true,
+        "reporter": "progress",
+        "spec": "build/test/**/*.js",
+        "require": "source-map-support/register"
+    },
+    "c8": {
+        "include": [
+            "build/src/**/*.js"
+        ]
+    },
+    "repository": {
+        "type": "git",
+        "url": "git+https://github.com/abaplint/abaplint.git"
+    },
+    "engines": {
+        "node": ">=12.0.0"
+    },
+    "keywords": [
+        "ABAP",
+        "lint"
+    ],
+    "author": "Lars Hvam Petersen",
+    "license": "MIT",
+    "bugs": {
+        "url": "https://github.com/abaplint/abaplint/issues"
+    },
+    "homepage": "https://abaplint.org",
+    "devDependencies": {
+        "@microsoft/api-extractor": "^7.28.6",
+        "@types/chai": "^4.3.1",
+        "@types/mocha": "^9.1.1",
+        "@types/node": "^18.0.6",
+        "chai": "^4.3.6",
+        "eslint": "^8.20.0",
+        "mocha": "^10.0.0",
+        "c8": "^7.12.0",
+        "source-map-support": "^0.5.21",
+        "ts-json-schema-generator": "^1.0.0",
+        "typescript": "^4.7.4"
+    },
+    "dependencies": {
+        "fast-xml-parser": "^4.0.9",
+        "json5": "^2.2.1",
+        "vscode-languageserver-types": "^3.17.2"
+    }
+}