@abaplint/core 2.91.38 → 2.92.1

package/build/abaplint.d.ts

@@ -2782,9 +2782,12 @@ declare interface IFunctionModuleParameter {
 declare interface IGlobalConfig {
     /** input files, glob format */
     files: string;
+    skipGeneratedBOPFInterfaces?: boolean;
+    skipGeneratedFunctionGroups?: boolean;
     skipGeneratedGatewayClasses?: boolean;
     skipGeneratedPersistentClasses?: boolean;
-    skipGeneratedFunctionGroups?: boolean;
+    skipGeneratedProxyClasses?: boolean;
+    skipGeneratedProxyInterfaces?: boolean;
     /** Clone and parse dependencies specified in .apack-manifest.xml if it is present */
     useApackDependencies?: boolean;
     /** Do not report any issues for includes without main programs */
@@ -3222,6 +3225,7 @@ export declare interface IRegistry {
     parseAsync(input?: IRunInput): Promise<IRegistry>;
     addDependencies(files: readonly IFile[]): IRegistry;
     addDependency(file: IFile): IRegistry;
+    removeDependency(obj: IObject): void;
     isDependency(obj: IObject): boolean;
     isFileDependency(filename: string): boolean;
     findIssues(input?: IRunInput): readonly Issue[];
@@ -4465,7 +4469,6 @@ declare class RefreshControl implements IStatement {
 export declare class Registry implements IRegistry {
     private readonly objects;
     private readonly objectsByType;
-    /** object containing filenames of dependencies */
     private readonly dependencies;
     private readonly references;
     private conf;
@@ -4486,9 +4489,11 @@ export declare class Registry implements IRegistry {
     addFile(file: IFile): IRegistry;
     updateFile(file: IFile): IRegistry;
     removeFile(file: IFile): IRegistry;
+    private _addFiles;
     addFiles(files: readonly IFile[]): IRegistry;
     addDependencies(files: readonly IFile[]): IRegistry;
     addDependency(file: IFile): IRegistry;
+    removeDependency(obj: IObject): void;
     isDependency(obj: IObject): boolean;
     isFileDependency(filename: string): boolean;
     findObjectForFile(file: IFile): IObject | undefined;

package/build/src/abap/2_statements/expressions/sql_target.js

@@ -7,7 +7,8 @@ const tokens_1 = require("../../1_lexer/tokens");
 const _1 = require(".");
 class SQLTarget extends combi_1.Expression {
     getRunnable() {
-        const at = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WAt), (0, combi_1.tok)(tokens_1.At)), _1.Target));
+        const n = (0, combi_1.ver)(version_1.Version.v754, "NEW");
+        const at = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.opt)(n), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WAt), (0, combi_1.tok)(tokens_1.At)), _1.Target));
         return (0, combi_1.altPrio)(at, _1.Target);
     }
 }

package/build/src/abap/5_syntax/_procedural.js

@@ -87,7 +87,8 @@ class Procedural {
             else {
                 found = ddic.lookup(param.type).type;
             }
-            if (param.direction === types_1.FunctionModuleParameterDirection.tables) {
+            if (param.direction === types_1.FunctionModuleParameterDirection.tables
+                && !(found instanceof basic_1.TableType)) {
                 found = new basic_1.TableType(found, { withHeader: true });
             }
             if (found instanceof basic_1.UnknownType && ((_a = param.type) === null || _a === void 0 ? void 0 : _a.includes("-"))) {

package/build/src/abap/types/function_module_definition.js

@@ -74,7 +74,8 @@ class FunctionModuleDefinition {
                 this.parameters.push({
                     name: param.PARAMETER,
                     direction: FunctionModuleParameterDirection.tables,
-                    type: param.DBSTRUCT,
+                    // table types are stored in TYP
+                    type: param.DBSTRUCT || param.TYP,
                 });
             }
         }

package/build/src/config.js

@@ -42,14 +42,19 @@ class Config {
         if (ver) {
             version = ver;
         }
+        // defaults: dont skip anything, report everything. The user can decide to skip stuff
+        // its difficult to debug errors not being reported
         const config = {
             global: {
                 files: "/src/**/*.*",
                 exclude: [],
                 noIssues: [],
-                skipGeneratedGatewayClasses: true,
-                skipGeneratedPersistentClasses: true,
-                skipGeneratedFunctionGroups: true,
+                skipGeneratedBOPFInterfaces: false,
+                skipGeneratedFunctionGroups: false,
+                skipGeneratedGatewayClasses: false,
+                skipGeneratedPersistentClasses: false,
+                skipGeneratedProxyClasses: false,
+                skipGeneratedProxyInterfaces: false,
                 useApackDependencies: false,
                 skipIncludesWithoutMain: false,
             },

package/build/src/objects/data_element.js

@@ -34,7 +34,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
     parseType(reg) {
         const references = [];
         let lookup = undefined;
-        if (this.parsedXML === undefined || this.parsedXML === {}) {
+        if (this.parsedXML === undefined) {
             lookup = { type: new Types.UnknownType("Data Element " + this.getName() + ", parser error") };
         }
         else {

package/build/src/objects/table_type.js

@@ -32,7 +32,7 @@ class TableType extends _abstract_object_1.AbstractObject {
         const ddic = new ddic_1.DDIC(reg);
         const references = [];
         let type;
-        if (this.parsedXML === undefined || this.parsedXML === {}) {
+        if (this.parsedXML === undefined) {
             type = new Types.UnknownType("Table Type, parser error", this.getName());
         }
         else if (this.parsedXML.rowkind === "S") {

package/build/src/registry.js

@@ -60,7 +60,6 @@ class Registry {
     constructor(conf) {
         this.objects = {};
         this.objectsByType = {};
-        /** object containing filenames of dependencies */
         this.dependencies = {};
         this.issues = [];
         this.conf = conf ? conf : config_1.Config.getDefault();
@@ -68,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.91.38";
+        return "2.92.1";
     }
     getDDICReferences() {
         return this.references;
@@ -143,6 +142,7 @@ class Registry {
         return this;
     }
     inErrorNamespace(name) {
+        // todo: performance? cache regexp?
         const reg = new RegExp(this.getConfig().getSyntaxSetttings().errorNamespace, "i");
         return reg.test(name);
     }
@@ -163,7 +163,7 @@ class Registry {
         }
         return this;
     }
-    addFiles(files) {
+    _addFiles(files, dependency) {
         var _a;
         const globalExclude = ((_a = this.conf.getGlobal().exclude) !== null && _a !== void 0 ? _a : [])
             .map(pattern => new RegExp(pattern, "i"));
@@ -173,28 +173,60 @@ class Registry {
             if (isNotAbapgitFile || excludeHelper_1.ExcludeHelper.isExcluded(filename, globalExclude)) {
                 continue;
             }
-            const found = this.findOrCreate(f.getObjectName(), f.getObjectType());
+            let found = this.findOrCreate(f.getObjectName(), f.getObjectType());
+            if (dependency === false && found && this.isDependency(found)) {
+                this.removeDependency(found);
+                found = this.findOrCreate(f.getObjectName(), f.getObjectType());
+            }
             found.addFile(f);
         }
         return this;
     }
+    addFiles(files) {
+        this._addFiles(files, false);
+        return this;
+    }
     addDependencies(files) {
         for (const f of files) {
-            this.dependencies[f.getFilename().toUpperCase()] = true;
+            this.addDependency(f);
         }
-        return this.addFiles(files);
+        return this;
     }
     addDependency(file) {
-        this.dependencies[file.getFilename().toUpperCase()] = true;
-        this.addFile(file);
+        var _a;
+        const type = (_a = file.getObjectType()) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+        if (type === undefined) {
+            return this;
+        }
+        const name = file.getObjectName().toUpperCase();
+        if (this.dependencies[type] === undefined) {
+            this.dependencies[type] = {};
+        }
+        this.dependencies[type][name] = true;
+        this._addFiles([file], true);
         return this;
     }
+    removeDependency(obj) {
+        var _a;
+        (_a = this.dependencies[obj.getType()]) === null || _a === void 0 ? true : delete _a[obj.getName()];
+        this.removeObject(obj);
+    }
     isDependency(obj) {
-        const filename = obj.getFiles()[0].getFilename().toUpperCase();
-        return this.dependencies[filename] === true;
+        var _a;
+        return ((_a = this.dependencies[obj.getType()]) === null || _a === void 0 ? void 0 : _a[obj.getName()]) === true;
     }
     isFileDependency(filename) {
-        return this.dependencies[filename.toUpperCase()] === true;
+        var _a, _b;
+        const f = this.getFileByName(filename);
+        if (f === undefined) {
+            return false;
+        }
+        const type = (_a = f.getObjectType()) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+        if (type === undefined) {
+            return false;
+        }
+        const name = f.getObjectName().toUpperCase();
+        return ((_b = this.dependencies[type]) === null || _b === void 0 ? void 0 : _b[name]) === true;
     }
     // assumption: the file is already in the registry
     findObjectForFile(file) {

package/build/src/skip_logic.js

@@ -10,7 +10,7 @@ class SkipLogic {
     }
     skip(obj) {
         const global = this.reg.getConfig().getGlobal();
-        if (global.skipGeneratedGatewayClasses
+        if (global.skipGeneratedGatewayClasses === true
             && obj instanceof objects_1.Class
             && this.isGeneratedGatewayClass(obj)) {
             return true;
@@ -24,23 +24,29 @@ class SkipLogic {
                 return true;
             }
         }
-        else if (global.skipGeneratedPersistentClasses
+        else if (global.skipGeneratedPersistentClasses === true
             && obj instanceof objects_1.Class
             && this.isGeneratedPersistentClass(obj)) {
             return true;
         }
-        else if (global.skipGeneratedFunctionGroups
+        else if (global.skipGeneratedFunctionGroups === true
             && obj instanceof objects_1.FunctionGroup
             && this.isGeneratedFunctionGroup(obj)) {
             return true;
         }
-        else if (obj instanceof objects_1.Class && this.isGeneratedProxyClass(obj)) {
+        else if (global.skipGeneratedProxyClasses === true
+            && obj instanceof objects_1.Class
+            && this.isGeneratedProxyClass(obj)) {
             return true;
         }
-        else if (obj instanceof objects_1.Interface && this.isGeneratedProxyInterface(obj)) {
+        else if (global.skipGeneratedProxyInterfaces === true
+            && obj instanceof objects_1.Interface
+            && this.isGeneratedProxyInterface(obj)) {
             return true;
         }
-        else if (obj instanceof objects_1.Interface && this.isGeneratedBOPFInterface(obj)) {
+        else if (global.skipGeneratedBOPFInterfaces === true
+            && obj instanceof objects_1.Interface
+            && this.isGeneratedBOPFInterface(obj)) {
             return true;
         }
         return false;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.91.38",
+    "version": "2.92.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,14 +48,14 @@
         "@microsoft/api-extractor": "^7.29.5",
         "@types/chai": "^4.3.3",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^18.7.12",
+        "@types/node": "^18.7.13",
         "chai": "^4.3.6",
         "eslint": "^8.22.0",
         "mocha": "^10.0.0",
         "c8": "^7.12.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^1.0.0",
-        "typescript": "^4.7.4"
+        "typescript": "^4.8.2"
     },
     "dependencies": {
         "fast-xml-parser": "^4.0.9",