@abaplint/core 2.91.27 → 2.91.30

package/build/abaplint.d.ts

@@ -209,6 +209,10 @@ declare class AssignmentServiceToAuthorizationGroup extends AbstractObject {
     getDescription(): string | undefined;
 }
 
+declare class AssignSource extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class AssociationName extends Expression {
     getRunnable(): IStatementRunnable;
 }
@@ -1799,6 +1803,7 @@ declare namespace Expressions {
         Cast,
         ClassFinal,
         ClassFriends,
+        AssignSource,
         ClassGlobal_2 as ClassGlobal,
         ClassName,
         Color,

package/build/src/abap/2_statements/expressions/assign_source.js

@@ -0,0 +1,19 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.AssignSource = void 0;
+const combi_1 = require("../combi");
+const tokens_1 = require("../../1_lexer/tokens");
+const source_1 = require("./source");
+const dynamic_1 = require("./dynamic");
+const field_1 = require("./field");
+class AssignSource extends combi_1.Expression {
+    getRunnable() {
+        const component = (0, combi_1.seq)("COMPONENT", source_1.Source, "OF STRUCTURE", source_1.Source);
+        const tableField = (0, combi_1.seq)("TABLE FIELD", (0, combi_1.alt)(source_1.Source, dynamic_1.Dynamic));
+        const arrow = (0, combi_1.alt)((0, combi_1.tok)(tokens_1.InstanceArrow), (0, combi_1.tok)(tokens_1.StaticArrow));
+        const source = (0, combi_1.alt)((0, combi_1.seq)(source_1.Source, (0, combi_1.opt)((0, combi_1.seq)(arrow, dynamic_1.Dynamic))), component, tableField, (0, combi_1.seq)(dynamic_1.Dynamic, (0, combi_1.opt)((0, combi_1.seq)(arrow, (0, combi_1.alt)(field_1.Field, dynamic_1.Dynamic)))));
+        return source;
+    }
+}
+exports.AssignSource = AssignSource;
+//# sourceMappingURL=assign_source.js.map

package/build/src/abap/2_statements/expressions/index.js

@@ -29,6 +29,7 @@ __exportStar(require("./call_transformation_parameters"), exports);
 __exportStar(require("./cast"), exports);
 __exportStar(require("./class_final"), exports);
 __exportStar(require("./class_friends"), exports);
+__exportStar(require("./assign_source"), exports);
 __exportStar(require("./class_global"), exports);
 __exportStar(require("./class_name"), exports);
 __exportStar(require("./color"), exports);

package/build/src/abap/2_statements/statements/assign.js

@@ -2,14 +2,9 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Assign = void 0;
 const combi_1 = require("../combi");
-const tokens_1 = require("../../1_lexer/tokens");
 const expressions_1 = require("../expressions");
 class Assign {
     getMatcher() {
-        const component = (0, combi_1.seq)("COMPONENT", expressions_1.Source, "OF STRUCTURE", expressions_1.Source);
-        const tableField = (0, combi_1.seq)("TABLE FIELD", (0, combi_1.alt)(expressions_1.Source, expressions_1.Dynamic));
-        const arrow = (0, combi_1.alt)((0, combi_1.tok)(tokens_1.InstanceArrow), (0, combi_1.tok)(tokens_1.StaticArrow));
-        const source = (0, combi_1.alt)((0, combi_1.seq)(expressions_1.Source, (0, combi_1.opt)((0, combi_1.seq)(arrow, expressions_1.Dynamic))), component, tableField, (0, combi_1.seq)(expressions_1.Dynamic, (0, combi_1.opt)((0, combi_1.seq)(arrow, (0, combi_1.alt)(expressions_1.Field, expressions_1.Dynamic)))));
         const type = (0, combi_1.seq)("TYPE", (0, combi_1.alt)(expressions_1.Dynamic, expressions_1.TypeName));
         const like = (0, combi_1.seq)("LIKE", (0, combi_1.alt)(expressions_1.Dynamic, expressions_1.Source));
         const handle = (0, combi_1.seq)("TYPE HANDLE", expressions_1.Source);
@@ -17,7 +12,7 @@ class Assign {
         const decimals = (0, combi_1.seq)("DECIMALS", expressions_1.Source);
         const casting = (0, combi_1.seq)("CASTING", (0, combi_1.opt)((0, combi_1.alt)(like, handle, (0, combi_1.per)(type, decimals))));
         const obsoleteType = (0, combi_1.seq)("TYPE", expressions_1.Source, (0, combi_1.optPrio)(decimals));
-        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), source, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType)), (0, combi_1.opt)(range));
+        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), expressions_1.AssignSource, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType)), (0, combi_1.opt)(range));
         return ret;
     }
 }

package/build/src/abap/5_syntax/expressions/type_table.js

@@ -6,6 +6,7 @@ const basic_types_1 = require("../basic_types");
 const Expressions = require("../../2_statements/expressions");
 const basic_1 = require("../../types/basic");
 const _scope_type_1 = require("../_scope_type");
+const type_table_key_1 = require("./type_table_key");
 class TypeTable {
     runSyntax(node, scope, filename, qualifiedNamePrefix) {
         // todo, input is currently the statement, but should be the expression?
@@ -25,10 +26,16 @@ class TypeTable {
                 qualifiedName = scope.getName() + "=>" + qualifiedName;
             }
         }
-        const type = new basic_types_1.BasicTypes(filename, scope).parseTable(node, qualifiedName);
+        let type = new basic_types_1.BasicTypes(filename, scope).parseTable(node, qualifiedName);
         if (type === undefined) {
             return new _typed_identifier_1.TypedIdentifier(name, filename, new basic_1.UnknownType("TableType, fallback"));
         }
+        for (const tt of node.findAllExpressions(Expressions.TypeTableKey)) {
+            const error = new type_table_key_1.TypeTableKey().runSyntax(tt, type);
+            if (error) {
+                type = error;
+            }
+        }
         return new _typed_identifier_1.TypedIdentifier(name, filename, type);
     }
 }

package/build/src/abap/5_syntax/expressions/type_table_key.js

@@ -0,0 +1,25 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.TypeTableKey = void 0;
+const Expressions = require("../../2_statements/expressions");
+const basic_1 = require("../../types/basic");
+class TypeTableKey {
+    runSyntax(node, type) {
+        if (type instanceof basic_1.TableType) {
+            const rowType = type.getRowType();
+            if (rowType instanceof basic_1.StructureType) {
+                for (const c of node.findAllExpressions(Expressions.FieldSub)) {
+                    const concat = c.concatTokens();
+                    if (concat.includes("-") === false // todo, properly check sub fields
+                        && rowType.getComponentByName(concat) === undefined
+                        && concat.toUpperCase() !== "TABLE_LINE") {
+                        return new basic_1.UnknownType(`Field ${concat} not part of structure`);
+                    }
+                }
+            }
+        }
+        return undefined;
+    }
+}
+exports.TypeTableKey = TypeTableKey;
+//# sourceMappingURL=type_table_key.js.map

package/build/src/abap/5_syntax/statements/assign.js

@@ -8,13 +8,14 @@ const dynamic_1 = require("../expressions/dynamic");
 const basic_1 = require("../../types/basic");
 class Assign {
     runSyntax(node, scope, filename) {
-        const sources = node.findDirectExpressions(Expressions.Source);
+        var _a, _b;
+        const sources = node.findAllExpressions(Expressions.Source);
         const firstSource = sources[0];
         let sourceType = new source_1.Source().runSyntax(firstSource, scope, filename);
-        if (sourceType === undefined || node.findDirectExpression(Expressions.Dynamic)) {
+        if (sourceType === undefined || ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Dynamic))) {
             sourceType = new basic_1.VoidType("DynamicAssign");
         }
-        for (const d of node.findAllExpressions(Expressions.Dynamic)) {
+        for (const d of ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.Dynamic)) || []) {
             new dynamic_1.Dynamic().runSyntax(d, scope, filename);
         }
         const target = node.findDirectExpression(Expressions.FSTarget);

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.91.27";
+        return "2.91.30";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -201,6 +201,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.assignWithTable(high, lowFile);
+        if (found) {
+            return found;
+        }
         found = this.downportRefSimple(high, lowFile);
         if (found) {
             return found;
@@ -916,6 +920,7 @@ IF sy-subrc = 0.
   <${uniqueFS}>-${groupCountName} = <${uniqueFS}>-${groupCountName} + 1.
   INSERT ${loopTargetName}->* INTO TABLE <${uniqueFS}>-items.
 ELSE.\n`;
+        code += `  CLEAR ${uniqueName}.\n`;
         for (const c of group.findAllExpressions(Expressions.LoopGroupByComponent)) {
             code += `  ${uniqueName}-${c.concatTokens().replace("GROUP SIZE", "1")}.\n`;
         }
@@ -963,6 +968,30 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, REF", this.getMetadata().key, this.conf.severity, fix);
     }
+    assignWithTable(high, lowFile) {
+        var _a, _b;
+        if (!(high.get() instanceof Statements.Assign)
+            || high.getChildren().length !== 5) {
+            return undefined;
+        }
+        const fieldChain = (_b = (_a = high.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.FieldChain);
+        if ((fieldChain === null || fieldChain === void 0 ? void 0 : fieldChain.getChildren().length) !== 2) {
+            return undefined;
+        }
+        const tableExpression = fieldChain === null || fieldChain === void 0 ? void 0 : fieldChain.getChildren()[1];
+        if (!(tableExpression.get() instanceof Expressions.TableExpression)
+            || !(tableExpression instanceof nodes_1.ExpressionNode)) {
+            return undefined;
+        }
+        const index = tableExpression.findDirectExpression(Expressions.Source);
+        if (index === undefined) {
+            return undefined;
+        }
+        const fsTarget = high.findDirectExpression(Expressions.FSTarget);
+        const code = `READ TABLE ${fieldChain === null || fieldChain === void 0 ? void 0 : fieldChain.getChildren()[0].concatTokens()} INDEX ${index.concatTokens()} ASSIGNING ${fsTarget === null || fsTarget === void 0 ? void 0 : fsTarget.concatTokens()}.`;
+        const fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), code);
+        return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, ASSIGN table expr", this.getMetadata().key, this.conf.severity, fix);
+    }
     moveWithSimpleValue(high, lowFile) {
         if (!(high.get() instanceof Statements.Move)
             || high.getChildren().length !== 4) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.91.27",
+    "version": "2.91.30",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -45,10 +45,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.29.0",
-        "@types/chai": "^4.3.1",
+        "@microsoft/api-extractor": "^7.29.2",
+        "@types/chai": "^4.3.3",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^18.6.4",
+        "@types/node": "^18.7.2",
         "chai": "^4.3.6",
         "eslint": "^8.21.0",
         "mocha": "^10.0.0",