@abaplint/core 2.91.21 → 2.91.24

package/build/abaplint.d.ts

@@ -1705,6 +1705,15 @@ declare class EnhancementSpot extends AbstractObject {
     private parseXML;
 }
 
+declare class EventBinding extends AbstractObject {
+    getType(): string;
+    getAllowedNaming(): {
+        maxLength: number;
+        allowNamespace: boolean;
+    };
+    getDescription(): string | undefined;
+}
+
 declare class EventHandler extends Expression {
     getRunnable(): IStatementRunnable;
 }
@@ -1924,6 +1933,7 @@ declare namespace Expressions {
         SQLCompareOperator,
         SQLCompare,
         SQLCond,
+        SQLField,
         SQLFieldListLoop,
         SQLFieldList,
         SQLFieldName,
@@ -3957,6 +3967,7 @@ declare namespace Objects {
         EnhancementImplementation,
         IBadiDefinition,
         EnhancementSpot,
+        EventBinding,
         ExtensionIndex,
         FieldCatalog,
         FormObjectForm,
@@ -4928,6 +4939,10 @@ declare class SQLCond extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare class SQLField extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class SQLFieldList extends Expression {
     getRunnable(): IStatementRunnable;
 }

package/build/src/abap/2_statements/expressions/index.js

@@ -163,6 +163,7 @@ __exportStar(require("./sql_client"), exports);
 __exportStar(require("./sql_compare_operator"), exports);
 __exportStar(require("./sql_compare"), exports);
 __exportStar(require("./sql_cond"), exports);
+__exportStar(require("./sql_field"), exports);
 __exportStar(require("./sql_field_list_loop"), exports);
 __exportStar(require("./sql_field_list"), exports);
 __exportStar(require("./sql_field_name"), exports);

package/build/src/abap/2_statements/expressions/perform_changing.js

@@ -2,10 +2,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PerformChanging = void 0;
 const combi_1 = require("../combi");
-const source_1 = require("./source");
+const target_1 = require("./target");
 class PerformChanging extends combi_1.Expression {
     getRunnable() {
-        const changing = (0, combi_1.seq)("CHANGING", (0, combi_1.plus)(source_1.Source));
+        const changing = (0, combi_1.seq)("CHANGING", (0, combi_1.plus)(target_1.Target));
         return changing;
     }
 }

package/build/src/abap/2_statements/expressions/sql_field.js

@@ -0,0 +1,22 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SQLField = void 0;
+const combi_1 = require("../combi");
+const _1 = require(".");
+const version_1 = require("../../../version");
+const tokens_1 = require("../../1_lexer/tokens");
+const sql_function_1 = require("./sql_function");
+const simple_field_chain_1 = require("./simple_field_chain");
+const sql_path_1 = require("./sql_path");
+class SQLField extends combi_1.Expression {
+    getRunnable() {
+        const abap = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), simple_field_chain_1.SimpleFieldChain));
+        const as = (0, combi_1.seq)("AS", _1.SQLAsName);
+        const field = (0, combi_1.altPrio)(_1.SQLAggregation, _1.SQLCase, sql_function_1.SQLFunction, sql_path_1.SQLPath, _1.SQLFieldName, abap, _1.Constant);
+        const sub = (0, combi_1.plusPrio)((0, combi_1.seq)((0, combi_1.altPrio)("+", "-", "*", "/", "&&"), (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.WParenLeftW)), field, (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.WParenRightW))));
+        const arith = (0, combi_1.ver)(version_1.Version.v740sp05, sub);
+        return (0, combi_1.seq)(field, (0, combi_1.optPrio)(arith), (0, combi_1.optPrio)(as));
+    }
+}
+exports.SQLField = SQLField;
+//# sourceMappingURL=sql_field.js.map

package/build/src/abap/2_statements/expressions/sql_field_list.js

@@ -4,19 +4,10 @@ exports.SQLFieldList = void 0;
 const combi_1 = require("../combi");
 const _1 = require(".");
 const version_1 = require("../../../version");
-const tokens_1 = require("../../1_lexer/tokens");
-const sql_function_1 = require("./sql_function");
-const simple_field_chain_1 = require("./simple_field_chain");
-const sql_path_1 = require("./sql_path");
 class SQLFieldList extends combi_1.Expression {
     getRunnable() {
         const comma = (0, combi_1.optPrio)((0, combi_1.ver)(version_1.Version.v740sp05, ","));
-        const abap = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), simple_field_chain_1.SimpleFieldChain));
-        const as = (0, combi_1.seq)("AS", _1.SQLAsName);
-        const field = (0, combi_1.altPrio)(_1.SQLAggregation, _1.SQLCase, sql_function_1.SQLFunction, sql_path_1.SQLPath, _1.SQLFieldName, abap, _1.Constant);
-        const sub = (0, combi_1.plusPrio)((0, combi_1.seq)((0, combi_1.altPrio)("+", "-", "*", "/", "&&"), (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.WParenLeftW)), field, (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.WParenRightW))));
-        const arith = (0, combi_1.ver)(version_1.Version.v740sp05, sub);
-        return (0, combi_1.altPrio)("*", _1.Dynamic, (0, combi_1.plusPrio)((0, combi_1.seq)(field, (0, combi_1.optPrio)(arith), (0, combi_1.optPrio)(as), comma)));
+        return (0, combi_1.altPrio)("*", _1.Dynamic, (0, combi_1.plusPrio)((0, combi_1.seq)(_1.SQLField, comma)));
     }
 }
 exports.SQLFieldList = SQLFieldList;

package/build/src/abap/2_statements/expressions/sql_field_list_loop.js

@@ -4,14 +4,13 @@ exports.SQLFieldListLoop = void 0;
 const combi_1 = require("../combi");
 const _1 = require(".");
 const version_1 = require("../../../version");
-const sql_function_1 = require("./sql_function");
 const sql_path_1 = require("./sql_path");
 // loop must include one field from the database table
 class SQLFieldListLoop extends combi_1.Expression {
     getRunnable() {
         const comma = (0, combi_1.opt)((0, combi_1.ver)(version_1.Version.v740sp05, ","));
         const as = (0, combi_1.seq)("AS", _1.SQLAsName);
-        const someField = (0, combi_1.seq)((0, combi_1.alt)(_1.SQLFieldName, sql_path_1.SQLPath, _1.SQLAggregation, sql_function_1.SQLFunction, _1.SQLCase), (0, combi_1.optPrio)(as), comma);
+        const someField = (0, combi_1.seq)(_1.SQLField, comma);
         const fieldList = (0, combi_1.seq)((0, combi_1.star)(someField), (0, combi_1.alt)(_1.SQLFieldName, sql_path_1.SQLPath), (0, combi_1.optPrio)(as), comma, (0, combi_1.star)(someField));
         const fields = (0, combi_1.alt)("*", _1.Dynamic, fieldList);
         return fields;

package/build/src/abap/5_syntax/statements/perform.js

@@ -5,6 +5,7 @@ const Expressions = require("../../2_statements/expressions");
 const Statements = require("../../2_statements/statements");
 const _reference_1 = require("../_reference");
 const source_1 = require("../expressions/source");
+const target_1 = require("../expressions/target");
 class Perform {
     runSyntax(node, scope, filename) {
         if (!(node.get() instanceof Statements.Perform)) {
@@ -13,8 +14,8 @@ class Perform {
         ////////////////////////////
         // check parameters are defined
         for (const c of node.findDirectExpressions(Expressions.PerformChanging)) {
-            for (const s of c.findDirectExpressions(Expressions.Source)) {
-                new source_1.Source().runSyntax(s, scope, filename);
+            for (const s of c.findDirectExpressions(Expressions.Target)) {
+                new target_1.Target().runSyntax(s, scope, filename);
             }
         }
         for (const t of node.findDirectExpressions(Expressions.PerformTables)) {

package/build/src/objects/event_binding.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.EventBinding = void 0;
+const _abstract_object_1 = require("./_abstract_object");
+class EventBinding extends _abstract_object_1.AbstractObject {
+    getType() {
+        return "EVTB";
+    }
+    getAllowedNaming() {
+        return {
+            maxLength: 40,
+            allowNamespace: true,
+        };
+    }
+    getDescription() {
+        // todo
+        return undefined;
+    }
+}
+exports.EventBinding = EventBinding;
+//# sourceMappingURL=event_binding.js.map

package/build/src/objects/index.js

@@ -51,6 +51,7 @@ __exportStar(require("./ecatt_test_data_container"), exports);
 __exportStar(require("./ecatt_test_script"), exports);
 __exportStar(require("./enhancement_implementation"), exports);
 __exportStar(require("./enhancement_spot"), exports);
+__exportStar(require("./event_binding"), exports);
 __exportStar(require("./extension_index"), exports);
 __exportStar(require("./field_catalog"), exports);
 __exportStar(require("./form_object_form"), exports);

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.91.21";
+        return "2.91.24";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -340,8 +340,9 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         const candidates = [high.findAllExpressionsRecursive(Expressions.SQLTarget),
             high.findAllExpressionsRecursive(Expressions.SQLSource),
             high.findAllExpressionsRecursive(Expressions.SQLSourceSimple)].flat();
-        for (const c of candidates) {
-            if (c.getFirstToken() instanceof tokens_1.WAt) {
+        for (const c of candidates.reverse()) {
+            if (c.getFirstToken() instanceof tokens_1.WAt
+                || c.getFirstToken() instanceof tokens_1.At) {
                 addFix(c.getFirstToken());
             }
         }
@@ -353,7 +354,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
             }
         }
         if (fix !== undefined) {
-            return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, remove \" and ,", this.getMetadata().key, this.conf.severity, fix);
+            return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, remove @ and ,", this.getMetadata().key, this.conf.severity, fix);
         }
         for (const c of high.findAllExpressionsRecursive(Expressions.SQLIn)) {
             const children = c.getChildren();
@@ -420,7 +421,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
             return undefined;
         }
         let fieldDefinition = "";
-        const fields = fieldList.findDirectExpressions(Expressions.SQLFieldName);
+        const fields = fieldList.findAllExpressions(Expressions.SQLFieldName);
         const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
         if (fields.length === 1) {
             fieldDefinition = `DATA ${name} TYPE ${tableName}-${fields[0].concatTokens()}.`;
@@ -476,7 +477,7 @@ ${indentation}`);
             return undefined;
         }
         let fieldDefinitions = "";
-        for (const f of fieldList.findDirectExpressions(Expressions.SQLFieldName)) {
+        for (const f of fieldList.findAllExpressions(Expressions.SQLFieldName)) {
             let fieldName = f.concatTokens();
             if (fieldName.includes("~")) {
                 const split = fieldName.split("~");

package/build/src/rules/select_add_order_by.js

@@ -60,8 +60,8 @@ If the target is a sorted/hashed table, no issue is reported`,
                     continue;
                 }
                 // skip COUNT(*)
-                const list = s.findFirstExpression(Expressions.SQLFieldList);
-                if ((list === null || list === void 0 ? void 0 : list.getChildren().length) === 1 && ((_a = list.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.SQLAggregation) {
+                const list = s.findAllExpressions(Expressions.SQLField);
+                if (list.length === 1 && ((_a = list[0].getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.SQLAggregation) {
                     continue;
                 }
                 else if (s.findFirstExpression(Expressions.SQLOrderBy)) {

package/build/src/rules/sy_modification.js

@@ -19,7 +19,9 @@ class SyModification extends _abap_rule_1.ABAPRule {
             key: "sy_modification",
             title: "Modification of SY fields",
             shortDescription: `Finds modification of sy fields`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm`,
+            extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm
+
+Changes to SY-TVAR* fields are not reported`,
             tags: [_irule_1.RuleTag.SingleFile],
             badExample: `
 sy-uname = 2.
@@ -42,6 +44,9 @@ sy = sy.`,
             const firstChild = t.getChildren()[0];
             if (firstChild.get() instanceof Expressions.TargetField
                 && firstChild.getFirstToken().getStr().toUpperCase() === "SY") {
+                if (t.concatTokens().toUpperCase().startsWith("SY-TVAR")) {
+                    continue;
+                }
                 const message = "Modification of SY field";
                 const issue = issue_1.Issue.atToken(file, firstChild.getFirstToken(), message, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.91.21",
+    "version": "2.91.24",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -45,10 +45,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.28.7",
+        "@microsoft/api-extractor": "^7.29.0",
         "@types/chai": "^4.3.1",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^18.6.3",
+        "@types/node": "^18.6.4",
         "chai": "^4.3.6",
         "eslint": "^8.21.0",
         "mocha": "^10.0.0",