@abaplint/core 2.91.16 → 2.91.19

package/build/abaplint.d.ts

@@ -1475,6 +1475,7 @@ declare class Domain extends AbstractObject {
     private parsedType;
     getType(): string;
     getDescription(): string | undefined;
+    getConversionExit(): string | undefined;
     getAllowedNaming(): {
         maxLength: number;
         allowNamespace: boolean;

package/build/src/objects/domain.js

@@ -13,6 +13,10 @@ class Domain extends _abstract_object_1.AbstractObject {
         var _a;
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.description;
     }
+    getConversionExit() {
+        var _a;
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.conversionExit;
+    }
     getAllowedNaming() {
         return {
             maxLength: 30,
@@ -62,6 +66,7 @@ class Domain extends _abstract_object_1.AbstractObject {
             description: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DDTEXT,
             datatype: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DATATYPE,
             length: dd01v === null || dd01v === void 0 ? void 0 : dd01v.LENG,
+            conversionExit: dd01v === null || dd01v === void 0 ? void 0 : dd01v.CONVEXIT,
             decimals: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DECIMALS,
             values: values,
         };

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.91.16";
+        return "2.91.19";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/definitions_top.js

@@ -52,12 +52,21 @@ https://docs.abapopenchecks.org/checks/17/`,
         if (structure === undefined) {
             return [];
         }
+        const containsUnknown = file.getStatements().some(s => s.get() instanceof _statement_1.Unknown);
+        if (containsUnknown === true) {
+            return [];
+        }
         const routines = structure.findAllStructures(Structures.Form).concat(structure.findAllStructures(Structures.Method));
         for (const r of routines) {
             // one fix per routine
             this.fixed = false;
             this.mode = DEFINITION;
             this.moveTo = (_a = r.getFirstStatement()) === null || _a === void 0 ? void 0 : _a.getLastToken().getEnd();
+            if (this.reg.getConfig().getVersion() !== version_1.Version.v702) {
+                if (r.findFirstExpression(Expressions.InlineData)) {
+                    continue;
+                }
+            }
             const found = this.walk(r, file);
             if (found) {
                 issues.push(found);
@@ -68,11 +77,6 @@ https://docs.abapopenchecks.org/checks/17/`,
     //////////////////
     walk(r, file) {
         var _a, _b, _c, _d, _e, _f;
-        if (this.reg.getConfig().getVersion() !== version_1.Version.v702) {
-            if (r.findFirstExpression(Expressions.InlineData)) {
-                return undefined;
-            }
-        }
         let previous = undefined;
         for (const c of r.getChildren()) {
             if (c instanceof nodes_1.StatementNode && c.get() instanceof _statement_1.Comment) {

package/build/src/rules/downport.js

@@ -1342,7 +1342,7 @@ ${indentation}    output = ${topTarget}.`;
         return undefined;
     }
     outlineValue(node, lowFile, highSyntax) {
-        var _a;
+        var _a, _b, _c;
         const allSources = node.findAllExpressionsRecursive(Expressions.Source);
         for (const s of allSources) {
             const firstToken = s.getFirstToken();
@@ -1421,6 +1421,36 @@ ${indentation}    output = ${topTarget}.`;
                 }
                 previous = b;
             }
+            if (body === "" && ((_b = valueBody === null || valueBody === void 0 ? void 0 : valueBody.getLastChild()) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase()) === "OPTIONAL") {
+                const fieldChain = valueBody.findFirstExpression(Expressions.FieldChain);
+                const rowName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
+                let tableExpression = undefined;
+                let tabName = "";
+                let after = "";
+                for (const c of (fieldChain === null || fieldChain === void 0 ? void 0 : fieldChain.getChildren()) || []) {
+                    if (c.get() instanceof Expressions.TableExpression && c instanceof nodes_1.ExpressionNode) {
+                        tableExpression = c;
+                    }
+                    else if (tableExpression === undefined) {
+                        tabName += c.concatTokens();
+                    }
+                    else {
+                        after += c.concatTokens();
+                    }
+                }
+                let condition = "";
+                if ((tableExpression === null || tableExpression === void 0 ? void 0 : tableExpression.getChildren().length) === 3) {
+                    condition = "INDEX " + ((_c = tableExpression === null || tableExpression === void 0 ? void 0 : tableExpression.findDirectExpression(Expressions.Source)) === null || _c === void 0 ? void 0 : _c.concatTokens());
+                }
+                else {
+                    condition = "WITH KEY " + (tableExpression === null || tableExpression === void 0 ? void 0 : tableExpression.concatTokens().replace("[ ", "").replace(" ]", ""));
+                }
+                body +=
+                    indentation + `READ TABLE ${tabName} INTO DATA(${rowName}) ${condition}.\n` +
+                        indentation + `IF sy-subrc = 0.\n` +
+                        indentation + `  ${uniqueName} = ${rowName}${after}.\n` +
+                        indentation + `ENDIF.\n`;
+            }
             if (end !== "") {
                 indentation = indentation.substring(2);
                 body += indentation + end;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.91.16",
+    "version": "2.91.19",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -45,12 +45,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.28.6",
+        "@microsoft/api-extractor": "^7.28.7",
         "@types/chai": "^4.3.1",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^18.6.1",
+        "@types/node": "^18.6.3",
         "chai": "^4.3.6",
-        "eslint": "^8.20.0",
+        "eslint": "^8.21.0",
         "mocha": "^10.0.0",
         "c8": "^7.12.0",
         "source-map-support": "^0.5.21",