@abaplint/core 2.91.1 → 2.91.4

package/build/abaplint.d.ts

@@ -1325,6 +1325,7 @@ declare class DDIC {
     lookupDomain(name: string, parent?: string): ILookupResult;
     lookupDataElement(name: string | undefined): ILookupResult;
     lookupTableOrView(name: string | undefined): ILookupResult;
+    /** this method only looks up the object, does not parse the type */
     lookupTableOrView2(name: string | undefined): Table | DataDefinition | View | undefined;
     lookupTable(name: string | undefined): AbstractType;
     private lookupView;
@@ -2740,9 +2741,9 @@ declare interface IFunctionModuleParameter {
 declare interface IGlobalConfig {
     /** input files, glob format */
     files: string;
-    skipGeneratedGatewayClasses: boolean;
-    skipGeneratedPersistentClasses: boolean;
-    skipGeneratedFunctionGroups: boolean;
+    skipGeneratedGatewayClasses?: boolean;
+    skipGeneratedPersistentClasses?: boolean;
+    skipGeneratedFunctionGroups?: boolean;
     /** Clone and parse dependencies specified in .apack-manifest.xml if it is present */
     useApackDependencies?: boolean;
     /** Do not report any issues for includes without main programs */

package/build/src/ddic.js

@@ -227,6 +227,7 @@ class DDIC {
         }
         return this.lookupView(name);
     }
+    /** this method only looks up the object, does not parse the type */
     lookupTableOrView2(name) {
         var _a;
         if (name === undefined) {

package/build/src/objects/table.js

@@ -209,9 +209,9 @@ class Table extends _abstract_object_1.AbstractObject {
                 });
             }
             if (field.CHECKTABLE) {
-                const lookup = ddic.lookupTableOrView(field.CHECKTABLE);
-                if (lookup.object) {
-                    references.push({ object: lookup.object });
+                const lookup = ddic.lookupTableOrView2(field.CHECKTABLE);
+                if (lookup) {
+                    references.push({ object: lookup });
                 }
             }
         }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.91.1";
+        return "2.91.4";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/select_performance.js

@@ -36,6 +36,11 @@ class SelectPerformance {
 
 SELECT *: not reported if using INTO/APPENDING CORRESPONDING FIELDS OF`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Performance],
+            badExample: `SELECT field1, field2 FROM table
+    INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.
+ENDSELECT.`,
+            goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS
+  INTO TABLE @DATA(table) ORDER BY field3 DESCENDING`,
         };
     }
     initialize(reg) {

package/build/src/rules/selection_screen_naming.js

@@ -15,6 +15,8 @@ class SelectionScreenNamingConf extends _naming_rule_config_1.NamingRuleConfig {
         this.parameter = "^P_.+$";
         /** The pattern for selection-screen select-options */
         this.selectOption = "^S_.+$";
+        /** The pattern for selection-screen screen elements */
+        this.screenElement = "^SC_.+$";
     }
 }
 exports.SelectionScreenNamingConf = SelectionScreenNamingConf;
@@ -49,15 +51,20 @@ class SelectionScreenNaming extends _abap_rule_1.ABAPRule {
         }
         let parameterCheckDisabled = false;
         let selectOptionDisabled = false;
+        let screenElementDisabled = false;
         if (this.conf.parameter === undefined || this.conf.parameter.length === 0) {
             parameterCheckDisabled = true;
         }
         if (this.conf.selectOption === undefined || this.conf.selectOption.length === 0) {
             selectOptionDisabled = true;
         }
+        if (this.conf.screenElement === undefined || this.conf.screenElement.length === 0) {
+            screenElementDisabled = true;
+        }
         for (const stat of file.getStatements()) {
             if ((stat.get() instanceof statements_1.Parameter && !parameterCheckDisabled)
-                || (stat.get() instanceof statements_1.SelectOption && !selectOptionDisabled)) {
+                || (stat.get() instanceof statements_1.SelectOption && !selectOptionDisabled)
+                || (stat.get() instanceof statements_1.SelectionScreen && !screenElementDisabled)) {
                 const fieldNode = this.getFieldForStatementNode(stat);
                 const regex = new RegExp(this.getPatternForStatement(stat.get()), "i");
                 if (fieldNode && name_validator_1.NameValidator.violatesRule(fieldNode.getFirstToken().getStr(), regex, this.conf)) {
@@ -75,6 +82,9 @@ class SelectionScreenNaming extends _abap_rule_1.ABAPRule {
         else if (statement instanceof statements_1.SelectOption) {
             pattern = this.conf.selectOption;
         }
+        else if (statement instanceof statements_1.SelectionScreen) {
+            pattern = this.conf.screenElement;
+        }
         return pattern;
     }
     getFieldForStatementNode(statNode) {
@@ -84,6 +94,9 @@ class SelectionScreenNaming extends _abap_rule_1.ABAPRule {
         else if (statNode.get() instanceof statements_1.SelectOption) {
             return statNode.findFirstExpression(expressions_1.FieldSub);
         }
+        else if (statNode.get() instanceof statements_1.SelectionScreen) {
+            return statNode.findFirstExpression(expressions_1.InlineField);
+        }
         else {
             return undefined;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.91.1",
+    "version": "2.91.4",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -45,10 +45,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.24.2",
+        "@microsoft/api-extractor": "^7.25.0",
         "@types/chai": "^4.3.1",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^17.0.39",
+        "@types/node": "^18.0.0",
         "chai": "^4.3.6",
         "eslint": "^8.17.0",
         "mocha": "^10.0.0",