@abaplint/core 2.90.9 → 2.90.10

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (108) hide show
  1. package/README.md +6 -6
  2. package/build/abaplint.d.ts +15 -0
  3. package/build/src/abap/2_statements/expressions/association_name.js +11 -0
  4. package/build/src/abap/2_statements/expressions/index.js +1 -0
  5. package/build/src/abap/2_statements/statements/commit_entities.js +1 -1
  6. package/build/src/abap/2_statements/statements/delete_internal.js +3 -2
  7. package/build/src/abap/2_statements/statements/get_permissions.js +14 -0
  8. package/build/src/abap/2_statements/statements/index.js +2 -0
  9. package/build/src/abap/2_statements/statements/modify_entities.js +3 -1
  10. package/build/src/abap/2_statements/statements/read_entities.js +1 -1
  11. package/build/src/abap/2_statements/statements/set_locks.js +14 -0
  12. package/build/src/abap/3_structures/structures/normal.js +1 -1
  13. package/build/src/abap/5_syntax/_builtin.js +5 -5
  14. package/build/src/abap/5_syntax/expressions/form_param.js +4 -4
  15. package/build/src/abap/5_syntax/expressions/inline_data.js +2 -2
  16. package/build/src/abap/5_syntax/expressions/inline_field_definition.js +1 -1
  17. package/build/src/abap/5_syntax/expressions/inline_fs.js +2 -2
  18. package/build/src/abap/5_syntax/expressions/inline_loop_definition.js +2 -2
  19. package/build/src/abap/5_syntax/statements/catch.js +3 -3
  20. package/build/src/abap/5_syntax/statements/class_data.js +1 -1
  21. package/build/src/abap/5_syntax/statements/constant.js +1 -1
  22. package/build/src/abap/5_syntax/statements/selection_screen.js +2 -2
  23. package/build/src/abap/5_syntax/structures/class_data.js +1 -1
  24. package/build/src/abap/5_syntax/structures/constants.js +1 -1
  25. package/build/src/abap/5_syntax/structures/type_enum.js +2 -2
  26. package/build/src/abap/flow/flow_graph.js +7 -7
  27. package/build/src/abap/types/class_constant.js +1 -1
  28. package/build/src/abap/types/form_definition.js +2 -2
  29. package/build/src/abap/types/method_parameters.js +11 -11
  30. package/build/src/lsp/_lookup.js +1 -1
  31. package/build/src/lsp/help.js +7 -7
  32. package/build/src/registry.js +1 -1
  33. package/build/src/rules/7bit_ascii.js +2 -2
  34. package/build/src/rules/abapdoc.js +1 -1
  35. package/build/src/rules/align_parameters.js +33 -33
  36. package/build/src/rules/ambiguous_statement.js +5 -5
  37. package/build/src/rules/avoid_use.js +8 -8
  38. package/build/src/rules/begin_end_names.js +4 -4
  39. package/build/src/rules/begin_single_include.js +12 -12
  40. package/build/src/rules/call_transaction_authority_check.js +3 -3
  41. package/build/src/rules/chain_mainly_declarations.js +4 -4
  42. package/build/src/rules/check_abstract.js +2 -2
  43. package/build/src/rules/check_comments.js +4 -4
  44. package/build/src/rules/check_include.js +3 -3
  45. package/build/src/rules/check_subrc.js +8 -8
  46. package/build/src/rules/classic_exceptions_overlap.js +8 -8
  47. package/build/src/rules/commented_code.js +1 -1
  48. package/build/src/rules/constructor_visibility_public.js +4 -4
  49. package/build/src/rules/contains_tab.js +2 -2
  50. package/build/src/rules/dangerous_statement.js +1 -1
  51. package/build/src/rules/downport.js +65 -65
  52. package/build/src/rules/exit_or_check.js +4 -3
  53. package/build/src/rules/exporting.js +1 -1
  54. package/build/src/rules/forbidden_identifier.js +1 -1
  55. package/build/src/rules/forbidden_void_type.js +2 -2
  56. package/build/src/rules/functional_writing.js +17 -17
  57. package/build/src/rules/global_class.js +8 -8
  58. package/build/src/rules/identical_conditions.js +2 -2
  59. package/build/src/rules/identical_contents.js +14 -14
  60. package/build/src/rules/identical_descriptions.js +4 -4
  61. package/build/src/rules/if_in_if.js +7 -7
  62. package/build/src/rules/implement_methods.js +3 -3
  63. package/build/src/rules/in_statement_indentation.js +11 -11
  64. package/build/src/rules/intf_referencing_clas.js +3 -3
  65. package/build/src/rules/line_break_style.js +2 -2
  66. package/build/src/rules/line_length.js +1 -1
  67. package/build/src/rules/line_only_punc.js +1 -1
  68. package/build/src/rules/local_variable_names.js +2 -2
  69. package/build/src/rules/many_parentheses.js +10 -10
  70. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  71. package/build/src/rules/max_one_statement.js +3 -3
  72. package/build/src/rules/method_overwrites_builtin.js +2 -2
  73. package/build/src/rules/nesting.js +1 -1
  74. package/build/src/rules/no_chained_assignment.js +1 -1
  75. package/build/src/rules/no_external_form_calls.js +2 -2
  76. package/build/src/rules/no_inline_in_optional_branches.js +11 -11
  77. package/build/src/rules/no_public_attributes.js +1 -1
  78. package/build/src/rules/no_yoda_conditions.js +4 -4
  79. package/build/src/rules/nrob_consistency.js +2 -2
  80. package/build/src/rules/obsolete_statement.js +40 -40
  81. package/build/src/rules/omit_parameter_name.js +8 -6
  82. package/build/src/rules/omit_receiving.js +13 -13
  83. package/build/src/rules/parser_702_chaining.js +2 -2
  84. package/build/src/rules/parser_error.js +2 -2
  85. package/build/src/rules/parser_missing_space.js +1 -1
  86. package/build/src/rules/prefer_inline.js +18 -18
  87. package/build/src/rules/prefer_is_not.js +7 -7
  88. package/build/src/rules/prefer_raise_exception_new.js +3 -3
  89. package/build/src/rules/prefer_returning_to_exporting.js +1 -1
  90. package/build/src/rules/prefer_xsdbool.js +2 -2
  91. package/build/src/rules/remove_descriptions.js +4 -4
  92. package/build/src/rules/rfc_error_handling.js +9 -9
  93. package/build/src/rules/select_add_order_by.js +5 -5
  94. package/build/src/rules/select_performance.js +2 -2
  95. package/build/src/rules/sicf_consistency.js +2 -2
  96. package/build/src/rules/slow_parameter_passing.js +1 -1
  97. package/build/src/rules/space_before_dot.js +2 -2
  98. package/build/src/rules/start_at_tab.js +1 -1
  99. package/build/src/rules/sy_modification.js +2 -2
  100. package/build/src/rules/tabl_enhancement_category.js +2 -2
  101. package/build/src/rules/unnecessary_pragma.js +14 -14
  102. package/build/src/rules/unused_methods.js +9 -9
  103. package/build/src/rules/unused_variables.js +9 -9
  104. package/build/src/rules/use_bool_expression.js +8 -8
  105. package/build/src/rules/use_line_exists.js +6 -6
  106. package/build/src/rules/use_new.js +4 -4
  107. package/build/src/rules/when_others_last.js +6 -6
  108. package/package.json +65 -65
@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
28
28
  key: "functional_writing",
29
29
  title: "Use functional writing",
30
30
  shortDescription: `Detects usage of call method when functional style calls can be used.`,
31
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
31
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
32
32
  https://docs.abapopenchecks.org/checks/07/`,
33
33
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
34
- badExample: `CALL METHOD zcl_class=>method( ).
35
- CALL METHOD cl_abap_typedescr=>describe_by_name
36
- EXPORTING
37
- p_name = 'NAME'
38
- RECEIVING
39
- p_descr_ref = lr_typedescr
40
- EXCEPTIONS
41
- type_not_found = 1
34
+ badExample: `CALL METHOD zcl_class=>method( ).
35
+ CALL METHOD cl_abap_typedescr=>describe_by_name
36
+ EXPORTING
37
+ p_name = 'NAME'
38
+ RECEIVING
39
+ p_descr_ref = lr_typedescr
40
+ EXCEPTIONS
41
+ type_not_found = 1
42
42
  OTHERS = 2.`,
43
- goodExample: `zcl_class=>method( ).
44
- cl_abap_typedescr=>describe_by_name(
45
- EXPORTING
46
- p_name = 'NAME'
47
- RECEIVING
48
- p_descr_ref = lr_typedescr
49
- EXCEPTIONS
50
- type_not_found = 1
43
+ goodExample: `zcl_class=>method( ).
44
+ cl_abap_typedescr=>describe_by_name(
45
+ EXPORTING
46
+ p_name = 'NAME'
47
+ RECEIVING
48
+ p_descr_ref = lr_typedescr
49
+ EXCEPTIONS
50
+ type_not_found = 1
51
51
  OTHERS = 2 ).`,
52
52
  };
53
53
  }
@@ -19,14 +19,14 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
19
19
  key: "global_class",
20
20
  title: "Global class checks",
21
21
  shortDescription: `Checks related to global classes`,
22
- extendedInformation: `* global classes must be in own files
23
-
24
- * file names must match class name
25
-
26
- * file names must match interface name
27
-
28
- * global classes must be global definitions
29
-
22
+ extendedInformation: `* global classes must be in own files
23
+
24
+ * file names must match class name
25
+
26
+ * file names must match interface name
27
+
28
+ * global classes must be global definitions
29
+
30
30
  * global interfaces must be global definitions`,
31
31
  tags: [_irule_1.RuleTag.Syntax],
32
32
  };
@@ -33,8 +33,8 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
33
33
  return {
34
34
  key: "identical_conditions",
35
35
  title: "Identical conditions",
36
- shortDescription: `Find identical conditions in IF + CASE + WHILE etc
37
-
36
+ shortDescription: `Find identical conditions in IF + CASE + WHILE etc
37
+
38
38
  Prerequsites: code is pretty printed with identical cAsE`,
39
39
  tags: [_irule_1.RuleTag.SingleFile],
40
40
  };
@@ -20,23 +20,23 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
20
20
  key: "identical_contents",
21
21
  title: "Identical contents",
22
22
  shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
23
- extendedInformation: `
24
- Prerequsites: code is pretty printed with identical cAsE
25
-
23
+ extendedInformation: `
24
+ Prerequsites: code is pretty printed with identical cAsE
25
+
26
26
  Chained statments are ignored`,
27
27
  tags: [_irule_1.RuleTag.SingleFile],
28
- badExample: `IF foo = bar.
29
- WRITE 'bar'.
30
- WRITE 'world'.
31
- ELSE.
32
- WRITE 'foo'.
33
- WRITE 'world'.
28
+ badExample: `IF foo = bar.
29
+ WRITE 'bar'.
30
+ WRITE 'world'.
31
+ ELSE.
32
+ WRITE 'foo'.
33
+ WRITE 'world'.
34
34
  ENDIF.`,
35
- goodExample: `IF foo = bar.
36
- WRITE 'bar'.
37
- ELSE.
38
- WRITE 'foo'.
39
- ENDIF.
35
+ goodExample: `IF foo = bar.
36
+ WRITE 'bar'.
37
+ ELSE.
38
+ WRITE 'foo'.
39
+ ENDIF.
40
40
  WRITE 'world'.`,
41
41
  };
42
42
  }
@@ -16,10 +16,10 @@ class IdenticalDescriptions {
16
16
  key: "identical_descriptions",
17
17
  title: "Identical descriptions",
18
18
  shortDescription: `Searches for objects with the same type and same description`,
19
- extendedInformation: `Case insensitive
20
-
21
- Only checks the master language descriptions
22
-
19
+ extendedInformation: `Case insensitive
20
+
21
+ Only checks the master language descriptions
22
+
23
23
  Works for: INTF, CLAS, DOMA, DTEL, FUNC in same FUGR`,
24
24
  tags: [],
25
25
  };
@@ -19,15 +19,15 @@ class IfInIf extends _abap_rule_1.ABAPRule {
19
19
  key: "if_in_if",
20
20
  title: "IF in IF",
21
21
  shortDescription: `Detects nested ifs which can be refactored to a single condition using AND.`,
22
- extendedInformation: `https://docs.abapopenchecks.org/checks/01/
22
+ extendedInformation: `https://docs.abapopenchecks.org/checks/01/
23
23
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low`,
24
- badExample: `IF condition1.
25
- IF condition2.
26
- ...
27
- ENDIF.
24
+ badExample: `IF condition1.
25
+ IF condition2.
26
+ ...
27
+ ENDIF.
28
28
  ENDIF.`,
29
- goodExample: `IF ( condition1 ) AND ( condition2 ).
30
- ...
29
+ goodExample: `IF ( condition1 ) AND ( condition2 ).
30
+ ...
31
31
  ENDIF.`,
32
32
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
33
33
  };
@@ -102,9 +102,9 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
102
102
  for (const i of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.ClassImplementation)) || []) {
103
103
  const name = (_b = i.findFirstExpression(Expressions.ClassName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase();
104
104
  if (name === impl.identifier.getName().toUpperCase()) {
105
- return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
106
- METHOD ${methodName.toLowerCase()}.
107
- RETURN. " todo, implement method
105
+ return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
106
+ METHOD ${methodName.toLowerCase()}.
107
+ RETURN. " todo, implement method
108
108
  ENDMETHOD.`);
109
109
  }
110
110
  }
@@ -31,19 +31,19 @@ class InStatementIndentation extends _abap_rule_1.ABAPRule {
31
31
  key: "in_statement_indentation",
32
32
  title: "In-statement indentation",
33
33
  shortDescription: "Checks alignment within statements which span multiple lines.",
34
- extendedInformation: `Lines following the first line should be indented once (2 spaces).
35
-
36
- For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
34
+ extendedInformation: `Lines following the first line should be indented once (2 spaces).
35
+
36
+ For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
37
37
  to distinguish them better from code within the block.`,
38
- badExample: `IF 1 = 1
39
- AND 2 = 2.
40
- WRITE 'hello' &&
41
- 'world'.
38
+ badExample: `IF 1 = 1
39
+ AND 2 = 2.
40
+ WRITE 'hello' &&
41
+ 'world'.
42
42
  ENDIF.`,
43
- goodExample: `IF 1 = 1
44
- AND 2 = 2.
45
- WRITE 'hello' &&
46
- 'world'.
43
+ goodExample: `IF 1 = 1
44
+ AND 2 = 2.
45
+ WRITE 'hello' &&
46
+ 'world'.
47
47
  ENDIF.`,
48
48
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
49
49
  };
@@ -26,9 +26,9 @@ class IntfReferencingClas {
26
26
  key: "intf_referencing_clas",
27
27
  title: "INTF referencing CLAS",
28
28
  shortDescription: `Interface contains references to class`,
29
- extendedInformation: `Only global interfaces are checked.
30
- Only first level references are checked.
31
- Exception class references are ignored.
29
+ extendedInformation: `Only global interfaces are checked.
30
+ Only first level references are checked.
31
+ Exception class references are ignored.
32
32
  Void references are ignored.`,
33
33
  };
34
34
  }
@@ -15,8 +15,8 @@ class LineBreakStyle {
15
15
  return {
16
16
  key: "line_break_style",
17
17
  title: "Makes sure line breaks are consistent in the ABAP code",
18
- shortDescription: `Enforces LF as newlines in ABAP files
19
-
18
+ shortDescription: `Enforces LF as newlines in ABAP files
19
+
20
20
  abapGit does not work with CRLF`,
21
21
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
22
22
  };
@@ -23,7 +23,7 @@ class LineLength extends _abap_rule_1.ABAPRule {
23
23
  key: "line_length",
24
24
  title: "Line length",
25
25
  shortDescription: `Detects lines exceeding the provided maximum length.`,
26
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
26
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
27
27
  https://docs.abapopenchecks.org/checks/04/`,
28
28
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
29
29
  };
@@ -27,7 +27,7 @@ class LineOnlyPunc extends _abap_rule_1.ABAPRule {
27
27
  key: "line_only_punc",
28
28
  title: "Line containing only punctuation",
29
29
  shortDescription: `Detects lines containing only punctuation.`,
30
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
30
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
31
31
  https://docs.abapopenchecks.org/checks/16/`,
32
32
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
33
33
  badExample: "zcl_class=>method(\n).",
@@ -30,8 +30,8 @@ class LocalVariableNames extends _abap_rule_1.ABAPRule {
30
30
  return {
31
31
  key: "local_variable_names",
32
32
  title: "Local variable naming conventions",
33
- shortDescription: `
34
- Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
33
+ shortDescription: `
34
+ Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
35
35
  Regexes are case-insensitive.`,
36
36
  tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
37
37
  };
@@ -23,17 +23,17 @@ class ManyParentheses extends _abap_rule_1.ABAPRule {
23
23
  title: "Too many parentheses",
24
24
  shortDescription: `Searches for expressions where extra parentheses can safely be removed`,
25
25
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
26
- badExample: `
27
- IF ( destination IS INITIAL ).
28
- ENDIF.
29
- IF foo = boo AND ( bar = lar AND moo = loo ).
30
- ENDIF.
26
+ badExample: `
27
+ IF ( destination IS INITIAL ).
28
+ ENDIF.
29
+ IF foo = boo AND ( bar = lar AND moo = loo ).
30
+ ENDIF.
31
31
  `,
32
- goodExample: `
33
- IF destination IS INITIAL.
34
- ENDIF.
35
- IF foo = boo AND bar = lar AND moo = loo.
36
- ENDIF.
32
+ goodExample: `
33
+ IF destination IS INITIAL.
34
+ ENDIF.
35
+ IF foo = boo AND bar = lar AND moo = loo.
36
+ ENDIF.
37
37
  `,
38
38
  };
39
39
  }
@@ -21,14 +21,14 @@ class MaxOneMethodParameterPerLine extends _abap_rule_1.ABAPRule {
21
21
  title: "Max one method parameter definition per line",
22
22
  shortDescription: `Keep max one method parameter description per line`,
23
23
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace],
24
- badExample: `
25
- METHODS apps_scope_token
26
- IMPORTING
24
+ badExample: `
25
+ METHODS apps_scope_token
26
+ IMPORTING
27
27
  body TYPE bodyapps_scope_token client_id TYPE str.`,
28
- goodExample: `
29
- METHODS apps_scope_token
30
- IMPORTING
31
- body TYPE bodyapps_scope_token
28
+ goodExample: `
29
+ METHODS apps_scope_token
30
+ IMPORTING
31
+ body TYPE bodyapps_scope_token
32
32
  client_id TYPE str.`,
33
33
  };
34
34
  }
@@ -21,9 +21,9 @@ class MaxOneStatement extends _abap_rule_1.ABAPRule {
21
21
  key: "max_one_statement",
22
22
  title: "Max one statement per line",
23
23
  shortDescription: `Checks that each line contains only a single statement.`,
24
- extendedInformation: `Does not report empty statements, use rule empty_statement for detecting empty statements.
25
-
26
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#no-more-than-one-statement-per-line
24
+ extendedInformation: `Does not report empty statements, use rule empty_statement for detecting empty statements.
25
+
26
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#no-more-than-one-statement-per-line
27
27
  https://docs.abapopenchecks.org/checks/11/`,
28
28
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
29
29
  badExample: `WRITE foo. WRITE bar.`,
@@ -19,8 +19,8 @@ class MethodOverwritesBuiltIn extends _abap_rule_1.ABAPRule {
19
19
  key: "method_overwrites_builtin",
20
20
  title: "Method name overwrites builtin function",
21
21
  shortDescription: `Checks Method names that overwrite builtin SAP functions`,
22
- extendedInformation: `https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abenbuilt_in_functions_overview.htm
23
-
22
+ extendedInformation: `https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abenbuilt_in_functions_overview.htm
23
+
24
24
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obscuring-built-in-functions`,
25
25
  tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
26
26
  };
@@ -24,7 +24,7 @@ class Nesting extends _abap_rule_1.ABAPRule {
24
24
  key: "nesting",
25
25
  title: "Check nesting depth",
26
26
  shortDescription: `Checks for methods exceeding a maximum nesting depth`,
27
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low
27
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low
28
28
  https://docs.abapopenchecks.org/checks/74/`,
29
29
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
30
30
  };
@@ -23,7 +23,7 @@ class NoChainedAssignment extends _abap_rule_1.ABAPRule {
23
23
  extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-chain-assignments`,
24
24
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
25
25
  badExample: `var1 = var2 = var3.`,
26
- goodExample: `var2 = var3.
26
+ goodExample: `var2 = var3.
27
27
  var1 = var2.`,
28
28
  };
29
29
  }
@@ -20,8 +20,8 @@ class NoExternalFormCalls extends _abap_rule_1.ABAPRule {
20
20
  key: "no_external_form_calls",
21
21
  title: "No external FORM calls",
22
22
  shortDescription: `Detect external form calls`,
23
- badExample: `PERFORM foo IN PROGRAM bar.
24
-
23
+ badExample: `PERFORM foo IN PROGRAM bar.
24
+
25
25
  PERFORM foo(bar).`,
26
26
  tags: [_irule_1.RuleTag.SingleFile],
27
27
  };
@@ -21,17 +21,17 @@ class NoInlineInOptionalBranches extends _abap_rule_1.ABAPRule {
21
21
  key: "no_inline_in_optional_branches",
22
22
  title: "Don't declare inline in optional branches",
23
23
  shortDescription: `Don't declare inline in optional branches`,
24
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-declare-inline-in-optional-branches
25
-
26
- Considered optional branches:
27
- * inside IF/ELSEIF/ELSE
28
- * inside LOOP
29
- * inside WHILE
30
- * inside CASE/WHEN, CASE TYPE OF
31
- * inside DO
32
- * inside SELECT loops
33
-
34
- Not considered optional branches:
24
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-declare-inline-in-optional-branches
25
+
26
+ Considered optional branches:
27
+ * inside IF/ELSEIF/ELSE
28
+ * inside LOOP
29
+ * inside WHILE
30
+ * inside CASE/WHEN, CASE TYPE OF
31
+ * inside DO
32
+ * inside SELECT loops
33
+
34
+ Not considered optional branches:
35
35
  * TRY/CATCH/CLEANUP`,
36
36
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
37
37
  };
@@ -27,7 +27,7 @@ class NoPublicAttributes extends _abap_rule_1.ABAPRule {
27
27
  return {
28
28
  key: "no_public_attributes",
29
29
  title: "No public attributes",
30
- shortDescription: `Checks that classes and interfaces don't contain any public attributes.
30
+ shortDescription: `Checks that classes and interfaces don't contain any public attributes.
31
31
  Exceptions are excluded from this rule.`,
32
32
  extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#members-private-by-default-protected-only-if-needed`,
33
33
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
@@ -24,13 +24,13 @@ class NoYodaConditions extends _abap_rule_1.ABAPRule {
24
24
  key: "no_yoda_conditions",
25
25
  title: "No Yoda conditions",
26
26
  shortDescription: `Finds Yoda conditions and reports issues`,
27
- extendedInformation: `https://en.wikipedia.org/wiki/Yoda_conditions
28
-
27
+ extendedInformation: `https://en.wikipedia.org/wiki/Yoda_conditions
28
+
29
29
  Conditions with operators CP, NP, CS, NS, CA, NA, CO, CN are ignored`,
30
30
  tags: [_irule_1.RuleTag.SingleFile],
31
- badExample: `IF 0 <> sy-subrc.
31
+ badExample: `IF 0 <> sy-subrc.
32
32
  ENDIF.`,
33
- goodExample: `IF sy-subrc <> 0.
33
+ goodExample: `IF sy-subrc <> 0.
34
34
  ENDIF.`,
35
35
  };
36
36
  }
@@ -17,8 +17,8 @@ class NROBConsistency {
17
17
  key: "nrob_consistency",
18
18
  title: "Number range consistency",
19
19
  shortDescription: `Consistency checks for number ranges`,
20
- extendedInformation: `Issue reported if percentage warning is over 50%
21
-
20
+ extendedInformation: `Issue reported if percentage warning is over 50%
21
+
22
22
  Issue reported if the referenced domain is not found(taking error namespace into account)`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
24
  };
@@ -79,46 +79,46 @@ class ObsoleteStatement extends _abap_rule_1.ABAPRule {
79
79
  title: "Obsolete statements",
80
80
  shortDescription: `Checks for usages of certain obsolete statements`,
81
81
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
82
- extendedInformation: `
83
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-language-constructs
84
-
85
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obsolete-language-elements
86
-
87
- SET EXTENDED CHECK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapset_extended_check.htm
88
-
89
- IS REQUESTED: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenlogexp_requested.htm
90
-
91
- WITH HEADER LINE: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapdata_header_line.htm
92
-
93
- FIELD-SYMBOLS STRUCTURE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapfield-symbols_obsolete_typing.htm
94
-
95
- TYPE-POOLS: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
96
-
97
- LOAD addition: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
98
-
99
- COMMUICATION: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapcommunication.htm
100
-
101
- OCCURS: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapdata_occurs.htm
102
-
103
- PARAMETER: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapparameter.htm
104
-
105
- RANGES: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapranges.htm
106
-
107
- PACK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abappack.htm
108
-
109
- MOVE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapmove_obs.htm
110
-
111
- SELECT without INTO: https://help.sap.com/doc/abapdocu_731_index_htm/7.31/en-US/abapselect_obsolete.htm
112
- SELECT COUNT(*) is considered okay
113
-
114
- FREE MEMORY: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abapfree_mem_id_obsolete.htm
115
-
116
- SORT BY FS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapsort_itab_obsolete.htm
117
-
118
- CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapcall_transformation_objects.htm
119
-
120
- POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm
121
-
82
+ extendedInformation: `
83
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-language-constructs
84
+
85
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obsolete-language-elements
86
+
87
+ SET EXTENDED CHECK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapset_extended_check.htm
88
+
89
+ IS REQUESTED: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenlogexp_requested.htm
90
+
91
+ WITH HEADER LINE: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapdata_header_line.htm
92
+
93
+ FIELD-SYMBOLS STRUCTURE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapfield-symbols_obsolete_typing.htm
94
+
95
+ TYPE-POOLS: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
96
+
97
+ LOAD addition: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
98
+
99
+ COMMUICATION: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapcommunication.htm
100
+
101
+ OCCURS: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapdata_occurs.htm
102
+
103
+ PARAMETER: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapparameter.htm
104
+
105
+ RANGES: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapranges.htm
106
+
107
+ PACK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abappack.htm
108
+
109
+ MOVE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapmove_obs.htm
110
+
111
+ SELECT without INTO: https://help.sap.com/doc/abapdocu_731_index_htm/7.31/en-US/abapselect_obsolete.htm
112
+ SELECT COUNT(*) is considered okay
113
+
114
+ FREE MEMORY: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abapfree_mem_id_obsolete.htm
115
+
116
+ SORT BY FS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapsort_itab_obsolete.htm
117
+
118
+ CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapcall_transformation_objects.htm
119
+
120
+ POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm
121
+
122
122
  OCCURENCES: check for OCCURENCES vs OCCURRENCES`,
123
123
  };
124
124
  }
@@ -22,9 +22,9 @@ class OmitParameterName {
22
22
  key: "omit_parameter_name",
23
23
  title: "Omit parameter name",
24
24
  shortDescription: `Omit the parameter name in single parameter calls`,
25
- extendedInformation: `
26
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-parameter-name-in-single-parameter-calls
27
-
25
+ extendedInformation: `
26
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-parameter-name-in-single-parameter-calls
27
+
28
28
  EXPORTING must already be omitted for this rule to take effect, https://rules.abaplint.org/exporting/`,
29
29
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
30
30
  badExample: `method( param = 2 ).`,
@@ -81,12 +81,14 @@ EXPORTING must already be omitted for this rule to take effect, https://rules.ab
81
81
  const p = (_a = parameters[0].findDirectExpression(Expressions.ParameterName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
82
82
  if ((p === null || p === void 0 ? void 0 : p.getStr().toUpperCase()) === i.toUpperCase()) {
83
83
  const message = "Omit default parameter name \"" + i + "\"";
84
- let fix = undefined;
85
84
  const end = (_b = parameters[0].findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStart();
86
85
  if (end) {
87
- fix = edit_helper_1.EditHelper.deleteRange(file, p.getStart(), end);
86
+ const fix = edit_helper_1.EditHelper.deleteRange(file, p.getStart(), end);
87
+ issues.push(issue_1.Issue.atRange(file, p.getStart(), end, message, this.getMetadata().key, this.getConfig().severity, fix));
88
+ }
89
+ else {
90
+ issues.push(issue_1.Issue.atToken(file, name.getFirstToken(), message, this.getMetadata().key, this.getConfig().severity));
88
91
  }
89
- issues.push(issue_1.Issue.atToken(file, name.getFirstToken(), message, this.getMetadata().key, this.getConfig().severity, fix));
90
92
  }
91
93
  }
92
94
  }
@@ -21,20 +21,20 @@ class OmitReceiving extends _abap_rule_1.ABAPRule {
21
21
  shortDescription: `Omit RECEIVING`,
22
22
  extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-receiving`,
23
23
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
24
- badExample: `
25
- upload_pack(
26
- EXPORTING
27
- io_client = lo_client
28
- iv_url = iv_url
29
- iv_deepen_level = iv_deepen_level
30
- it_hashes = lt_hashes
31
- RECEIVING
24
+ badExample: `
25
+ upload_pack(
26
+ EXPORTING
27
+ io_client = lo_client
28
+ iv_url = iv_url
29
+ iv_deepen_level = iv_deepen_level
30
+ it_hashes = lt_hashes
31
+ RECEIVING
32
32
  rt_objects = et_objects ).`,
33
- goodExample: `
34
- et_objects = upload_pack(
35
- io_client = lo_client
36
- iv_url = iv_url
37
- iv_deepen_level = iv_deepen_level
33
+ goodExample: `
34
+ et_objects = upload_pack(
35
+ io_client = lo_client
36
+ iv_url = iv_url
37
+ iv_deepen_level = iv_deepen_level
38
38
  it_hashes = lt_hashes ).`,
39
39
  };
40
40
  }
@@ -19,8 +19,8 @@ class Parser702Chaining extends _abap_rule_1.ABAPRule {
19
19
  return {
20
20
  key: "parser_702_chaining",
21
21
  title: "Parser Error, bad chanining on 702",
22
- shortDescription: `ABAP on 702 does not allow for method chaining with IMPORTING/EXPORTING/CHANGING keywords,
23
- this rule finds these and reports errors.
22
+ shortDescription: `ABAP on 702 does not allow for method chaining with IMPORTING/EXPORTING/CHANGING keywords,
23
+ this rule finds these and reports errors.
24
24
  Only active on target version 702 and below.`,
25
25
  tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.SingleFile],
26
26
  };
@@ -20,8 +20,8 @@ class ParserError extends _abap_rule_1.ABAPRule {
20
20
  return {
21
21
  key: "parser_error",
22
22
  title: "Parser error",
23
- shortDescription: `Checks for syntax not recognized by abaplint.
24
-
23
+ shortDescription: `Checks for syntax not recognized by abaplint.
24
+
25
25
  See recognized syntax at https://syntax.abaplint.org`,
26
26
  tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.SingleFile],
27
27
  };