@abaplint/core 2.90.5 → 2.90.9

package/README.md

@@ -1,7 +1,7 @@
-# @abaplint/core
-
-[abaplint](https://abaplint.org/) core library
-
-Exposes functionality like the parser and rules, which can be used in other projects.
-
+# @abaplint/core
+
+[abaplint](https://abaplint.org/) core library
+
+Exposes functionality like the parser and rules, which can be used in other projects.
+
 For more information see https://github.com/abaplint/abaplint

package/build/abaplint.d.ts

@@ -1,5 +1,4 @@
 import * as LServer from 'vscode-languageserver-types';
-import * as SemanticProtocol from 'vscode-languageserver-protocol/lib/common/protocol.semanticTokens';
 import { WorkspaceEdit } from 'vscode-languageserver-types';
 
 export declare class ABAPFile extends AbstractFile {
@@ -3447,8 +3446,8 @@ export declare class LanguageServer {
     documentHighlight(_params: ITextDocumentPositionParams): LServer.DocumentHighlight[];
     implementation(params: ITextDocumentPositionParams): LServer.Location[];
     references(params: ITextDocumentPositionParams): LServer.Location[];
-    static semanticTokensLegend(): SemanticProtocol.SemanticTokensLegend;
-    semanticTokensRange(range: ITextDocumentRange): SemanticProtocol.SemanticTokens;
+    static semanticTokensLegend(): LServer.SemanticTokensLegend;
+    semanticTokensRange(range: ITextDocumentRange): LServer.SemanticTokens;
     help(textDocument: LServer.TextDocumentIdentifier, position: LServer.Position): string;
     listDefinitionPositions(textDocument: LServer.TextDocumentIdentifier): LServer.Range[];
     listReadPositions(textDocument: LServer.TextDocumentIdentifier): LServer.Range[];

package/build/src/abap/1_lexer/lexer.js

@@ -69,6 +69,12 @@ class Stream {
     nextNextChar() {
         return this.raw.substr(this.offset + 1, 2);
     }
+    getRaw() {
+        return this.raw;
+    }
+    getOffset() {
+        return this.offset;
+    }
 }
 class Lexer {
     static run(file, virtual) {
@@ -84,10 +90,7 @@ class Lexer {
             const col = this.stream.getCol();
             const row = this.stream.getRow();
             let whiteBefore = false;
-            let prev = this.stream.prevChar();
-            if (s.length === 2) {
-                prev = this.stream.prevPrevChar().substr(0, 1);
-            }
+            const prev = this.stream.getRaw().substr(this.stream.getOffset() - s.length, 1);
             if (prev === " " || prev === "\n" || prev === "\t" || prev === ":") {
                 whiteBefore = true;
             }
@@ -113,13 +116,13 @@ class Lexer {
                 if (first === "|" && last === "|") {
                     tok = new Tokens.StringTemplate(pos, s);
                 }
-                else if (first === "|" && last === "{") {
+                else if (first === "|" && last === "{" && whiteAfter === true) {
                     tok = new Tokens.StringTemplateBegin(pos, s);
                 }
-                else if (first === "}" && last === "|") {
+                else if (first === "}" && last === "|" && whiteBefore === true) {
                     tok = new Tokens.StringTemplateEnd(pos, s);
                 }
-                else if (first === "}" && last === "{") {
+                else if (first === "}" && last === "{" && whiteAfter === true && whiteBefore === true) {
                     tok = new Tokens.StringTemplateMiddle(pos, s);
                 }
                 else {

package/build/src/abap/2_statements/expressions/method_param_name.js

@@ -4,7 +4,7 @@ exports.MethodParamName = void 0;
 const combi_1 = require("../combi");
 class MethodParamName extends combi_1.Expression {
     getRunnable() {
-        const field = (0, combi_1.regex)(/^!?(\/\w+\/)?\w+$/);
+        const field = (0, combi_1.regex)(/^!?\w*(\/\w+\/)?\w+$/);
         return field;
     }
 }

package/build/src/abap/flow/flow_graph.js

@@ -72,13 +72,13 @@ class FlowGraph {
         this.label = label;
     }
     toDigraph() {
-        return `digraph G {
-labelloc="t";
-label="${this.label}";
-graph [fontname = "helvetica"];
-node [fontname = "helvetica", shape="box"];
-edge [fontname = "helvetica"];
-${this.toTextEdges()}
+        return `digraph G {
+labelloc="t";
+label="${this.label}";
+graph [fontname = "helvetica"];
+node [fontname = "helvetica", shape="box"];
+edge [fontname = "helvetica"];
+${this.toTextEdges()}
 }`;
     }
     listSources(node) {

package/build/src/lsp/help.js

@@ -19,13 +19,13 @@ class Help {
     /////////////////////////////////////////////////
     static dumpABAP(file, reg, textDocument, position) {
         let content = "";
-        content = `
-    <a href="#_tokens" rel="no-refresh">Tokens</a> |
-    <a href="#_statements" rel="no-refresh">Statements</a> |
-    <a href="#_structure" rel="no-refresh">Structure</a> |
-    <a href="#_files" rel="no-refresh">Files</a> |
-    <a href="#_info" rel="no-refresh">Info Dump</a>
-    <hr>
+        content = `
+    <a href="#_tokens" rel="no-refresh">Tokens</a> |
+    <a href="#_statements" rel="no-refresh">Statements</a> |
+    <a href="#_structure" rel="no-refresh">Structure</a> |
+    <a href="#_files" rel="no-refresh">Files</a> |
+    <a href="#_info" rel="no-refresh">Info Dump</a>
+    <hr>
     ` +
             "<tt>" + textDocument.uri + " (" +
             (position.line + 1) + ", " +

package/build/src/lsp/semantic.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SemanticHighlighting = void 0;
-const SemanticProtocol = require("vscode-languageserver-protocol/lib/common/protocol.semanticTokens");
+const LServer = require("vscode-languageserver-types");
 const position_1 = require("../position");
 const tokens_1 = require("../abap/1_lexer/tokens");
 const nodes_1 = require("../abap/nodes");
@@ -30,7 +30,7 @@ class SemanticHighlighting {
             SemanticHighlighting.tokenTypes.push(SOURCE_ABAP);
             SemanticHighlighting.tokenTypeMap[BLOCK_ABAP] = SemanticHighlighting.tokenTypes.length;
             SemanticHighlighting.tokenTypes.push(BLOCK_ABAP);
-            for (const t in SemanticProtocol.SemanticTokenTypes) {
+            for (const t in LServer.SemanticTokenTypes) {
                 SemanticHighlighting.tokenTypeMap[t] = SemanticHighlighting.tokenTypes.length;
                 SemanticHighlighting.tokenTypes.push(t);
             }
@@ -58,7 +58,7 @@ class SemanticHighlighting {
             const statementInstance = s.get();
             for (const t of s.getTokenNodes()) {
                 const tokenInstance = t.get();
-                let tokenType = SemanticProtocol.SemanticTokenTypes.keyword;
+                let tokenType = LServer.SemanticTokenTypes.keyword;
                 if (tokenInstance instanceof tokens_1.Punctuation) {
                     tokenType = SOURCE_ABAP;
                 }
@@ -81,10 +81,10 @@ class SemanticHighlighting {
                     || tokenInstance instanceof tokens_1.StringTemplateBegin
                     || tokenInstance instanceof tokens_1.StringTemplateEnd
                     || tokenInstance instanceof tokens_1.StringTemplateMiddle) {
-                    tokenType = SemanticProtocol.SemanticTokenTypes.string;
+                    tokenType = LServer.SemanticTokenTypes.string;
                 }
                 else if (tokenInstance instanceof tokens_1.Comment) {
-                    tokenType = SemanticProtocol.SemanticTokenTypes.comment;
+                    tokenType = LServer.SemanticTokenTypes.comment;
                 }
                 else if (t instanceof nodes_1.TokenNodeRegex) {
                     tokenType = SOURCE_ABAP;

package/build/src/objects/table.js

@@ -155,6 +155,27 @@ class Table extends _abstract_object_1.AbstractObject {
                         type: new basic_1.GenericObjectReferenceType()
                     });
                 }
+                else if (field.REFTYPE === "S") {
+                    const lookup = ddic.lookupTableOrView(field.ROLLNAME);
+                    components.push({ name: field.FIELDNAME, type: new basic_1.DataReference(lookup.type) });
+                    if (lookup.object) {
+                        references.push({ object: lookup.object });
+                    }
+                }
+                else if (field.REFTYPE === "L") {
+                    const lookup = ddic.lookupTableType(field.ROLLNAME);
+                    components.push({ name: field.FIELDNAME, type: new basic_1.DataReference(lookup.type) });
+                    if (lookup.object) {
+                        references.push({ object: lookup.object });
+                    }
+                }
+                else if (field.REFTYPE === "E") {
+                    const lookup = ddic.lookupDataElement(field.ROLLNAME);
+                    components.push({ name: field.FIELDNAME, type: new basic_1.DataReference(lookup.type) });
+                    if (lookup.object) {
+                        references.push({ object: lookup.object });
+                    }
+                }
                 else {
                     const lookup = ddic.lookupObject(field.ROLLNAME);
                     components.push({ name: field.FIELDNAME, type: lookup.type });
@@ -245,6 +266,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 DECIMALS: field.DECIMALS,
                 KEYFLAG: field.KEYFLAG,
                 GROUPNAME: field.GROUPNAME,
+                REFTYPE: field.REFTYPE,
             });
         }
     }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.90.5";
+        return "2.90.9";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/7bit_ascii.js

@@ -17,8 +17,8 @@ class SevenBitAscii {
             key: "7bit_ascii",
             title: "Check for 7bit ascii",
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
-            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
-
+            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
+
 Checkes files with extension ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/abapdoc.js

@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
         return {
             key: "abapdoc",
             title: "Check abapdoc",
-            shortDescription: `Various checks regarding abapdoc.
+            shortDescription: `Various checks regarding abapdoc.
 Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/align_parameters.js

@@ -20,42 +20,42 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
             key: "align_parameters",
             title: "Align Parameters",
             shortDescription: `Checks for vertially aligned parameters`,
-            extendedInformation: `Checks:
-* function module calls
-* method calls
-* VALUE constructors
-* NEW constructors
-* RAISE EXCEPTION statements
-* CREATE OBJECT statements
-* RAISE EVENT statements
-
-https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
-
-Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
-
+            extendedInformation: `Checks:
+* function module calls
+* method calls
+* VALUE constructors
+* NEW constructors
+* RAISE EXCEPTION statements
+* CREATE OBJECT statements
+* RAISE EVENT statements
+
+https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+
+Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
+
 Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
-            badExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo = 2
-    parameter = 3.
-
-foobar( moo = 1
-  param = 1 ).
-
-foo = VALUE #(
-    foo = bar
+            badExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo = 2
+    parameter = 3.
+
+foobar( moo = 1
+  param = 1 ).
+
+foo = VALUE #(
+    foo = bar
         moo = 2 ).`,
-            goodExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo       = 2
-    parameter = 3.
-
-foobar( moo   = 1
-        param = 1 ).
-
-foo = VALUE #(
-    foo = bar
+            goodExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo       = 2
+    parameter = 3.
+
+foobar( moo   = 1
+        param = 1 ).
+
+foo = VALUE #(
+    foo = bar
     moo = 2 ).`,
         };
     }

package/build/src/rules/ambiguous_statement.js

@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
         return {
             key: "ambiguous_statement",
             title: "Check for ambigious statements",
-            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
-Add "TABLE" keyword or "@" for escaping SQL variables
-
+            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
+Add "TABLE" keyword or "@" for escaping SQL variables
+
 Only works if the target version is 740sp05 or above`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DELETE foo FROM bar.
+            badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
-            goodExample: `DELETE foo FROM @bar.
+            goodExample: `DELETE foo FROM @bar.
 MODIFY TABLE foo FROM bar.`,
         };
     }

package/build/src/rules/avoid_use.js

@@ -37,14 +37,14 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
-
-Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
-STATICS: use CLASS-DATA instead
-
-DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
-
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+
+Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
+STATICS: use CLASS-DATA instead
+
+DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
+
 TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/begin_end_names.js

@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
             title: "Check BEGIN END names",
             shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            badExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF structure_not_the_same.`,
-            goodExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            goodExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF stru.`,
         };
     }

package/build/src/rules/begin_single_include.js

@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
             title: "BEGIN contains single INCLUDE",
             shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TYPES: BEGIN OF dummy1.
-  INCLUDE TYPE dselc.
-TYPES: END OF dummy1.
-
-DATA BEGIN OF foo.
-INCLUDE STRUCTURE syst.
-DATA END OF foo.
-
-STATICS BEGIN OF bar.
-INCLUDE STRUCTURE syst.
+            badExample: `TYPES: BEGIN OF dummy1.
+  INCLUDE TYPE dselc.
+TYPES: END OF dummy1.
+
+DATA BEGIN OF foo.
+INCLUDE STRUCTURE syst.
+DATA END OF foo.
+
+STATICS BEGIN OF bar.
+INCLUDE STRUCTURE syst.
 STATICS END OF bar.`,
-            goodExample: `DATA BEGIN OF foo.
-INCLUDE STRUCTURE dselc.
+            goodExample: `DATA BEGIN OF foo.
+INCLUDE STRUCTURE dselc.
 DATA END OF foo.`,
         };
     }

package/build/src/rules/call_transaction_authority_check.js

@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
             extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
             badExample: `CALL TRANSACTION 'FOO'.`,
-            goodExample: `TRY.
-    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
-  CATCH cx_sy_authorization_error.
+            goodExample: `TRY.
+    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
+  CATCH cx_sy_authorization_error.
 ENDTRY.`,
         };
     }

package/build/src/rules/chain_mainly_declarations.js

@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
             key: "chain_mainly_declarations",
             title: "Chain mainly declarations",
             shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/23/
-
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/23/
+
+https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
 `,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `CALL METHOD: bar.`,

package/build/src/rules/check_abstract.js

@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
         return {
             key: "check_abstract",
             title: "Check abstract methods and classes",
-            shortDescription: `Checks abstract methods and classes:
-- class defined as abstract and final,
+            shortDescription: `Checks abstract methods and classes:
+- class defined as abstract and final,
 - non-abstract class contains abstract methods`,
             extendedInformation: `If a class defines only constants, use an interface instead`,
             tags: [_irule_1.RuleTag.SingleFile],

package/build/src/rules/check_comments.js

@@ -27,11 +27,11 @@ class CheckComments extends _abap_rule_1.ABAPRule {
         return {
             key: "check_comments",
             title: "Check Comments",
-            shortDescription: `
+            shortDescription: `
 Various checks for comment usage.`,
-            extendedInformation: `
-* End of line comments. Comments starting with "#EC" or "##" are ignored
-
+            extendedInformation: `
+* End of line comments. Comments starting with "#EC" or "##" are ignored
+
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/check_include.js

@@ -17,9 +17,9 @@ class CheckInclude {
             key: "check_include",
             title: "Check INCLUDEs",
             shortDescription: `Checks INCLUDE statements`,
-            extendedInformation: `
-* Reports unused includes
-* Errors if the includes are not found
+            extendedInformation: `
+* Reports unused includes
+* Errors if the includes are not found
 * Error if including a main program`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/check_subrc.js

@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
             key: "check_subrc",
             title: "Check sy-subrc",
             shortDescription: `Check sy-subrc`,
-            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
-
-If sy-dbcnt is checked after database statements, it is considered okay.
-
-"SELECT SINGLE @abap_true FROM " is considered as an existence check
-
-If IS ASSIGNED is checked after assigning, it is considered okay.
-
+            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
+
+If sy-dbcnt is checked after database statements, it is considered okay.
+
+"SELECT SINGLE @abap_true FROM " is considered as an existence check
+
+If IS ASSIGNED is checked after assigning, it is considered okay.
+
 FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             tags: [_irule_1.RuleTag.SingleFile],
             pseudoComment: "EC CI_SUBRC",

package/build/src/rules/classic_exceptions_overlap.js

@@ -21,15 +21,15 @@ class ClassicExceptionsOverlap extends _abap_rule_1.ABAPRule {
             shortDescription: `Find overlapping classic exceptions`,
             extendedInformation: `When debugging its typically good to know exactly which exception is caught`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `  EXCEPTIONS
-    system_failure        = 1 MESSAGE lv_message
-    communication_failure = 1 MESSAGE lv_message
-    resource_failure      = 1
+            badExample: `  EXCEPTIONS
+    system_failure        = 1 MESSAGE lv_message
+    communication_failure = 1 MESSAGE lv_message
+    resource_failure      = 1
     OTHERS                = 1.`,
-            goodExample: `  EXCEPTIONS
-    system_failure        = 1 MESSAGE lv_message
-    communication_failure = 2 MESSAGE lv_message
-    resource_failure      = 3
+            goodExample: `  EXCEPTIONS
+    system_failure        = 1 MESSAGE lv_message
+    communication_failure = 2 MESSAGE lv_message
+    resource_failure      = 3
     OTHERS                = 4.`,
         };
     }

package/build/src/rules/commented_code.js

@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
             key: "commented_code",
             title: "Find commented code",
             shortDescription: `Detects usage of commented out code.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
 https://docs.abapopenchecks.org/checks/14/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/constructor_visibility_public.js

@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
             key: "constructor_visibility_public",
             title: "Check constructor visibility is public",
             shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
-            extendedInformation: `
-This only applies to global classes.
-
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
+            extendedInformation: `
+This only applies to global classes.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/contains_tab.js

@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
             key: "contains_tab",
             title: "Code contains tab",
             shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/09/
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/09/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/dangerous_statement.js

@@ -24,7 +24,7 @@ class DangerousStatementConf extends _basic_rule_config_1.BasicRuleConfig {
         this.deleteReport = true;
         this.deleteTextpool = true;
         this.deleteDynpro = true;
-        this.importDynpro = true;
+        this.exportDynpro = true;
         /** Finds instances of dynamic SQL: SELECT, UPDATE, DELETE, INSERT, MODIFY */
         this.dynamicSQL = true;
     }
@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
             key: "dangerous_statement",
             title: "Dangerous statement",
             shortDescription: `Detects potentially dangerous statements`,
-            extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
+            extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
 dynamic SQL can potentially create SQL injection problems`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
         };
@@ -89,8 +89,8 @@ dynamic SQL can potentially create SQL injection problems`,
             else if (this.conf.deleteDynpro && statement instanceof Statements.DeleteDynpro) {
                 message = "DELETE DYNPRO";
             }
-            else if (this.conf.importDynpro && statement instanceof Statements.ImportDynpro) {
-                message = "IMPORT DYNPRO";
+            else if (this.conf.exportDynpro && statement instanceof Statements.ExportDynpro) {
+                message = "EXPORT DYNPRO";
             }
             if (message) {
                 issues.push(issue_1.Issue.atStatement(file, statementNode, this.getDescription(message), this.getMetadata().key, this.conf.severity));
@@ -112,7 +112,8 @@ dynamic SQL can potentially create SQL injection problems`,
             || statement instanceof Statements.InsertDatabase
             || statement instanceof Statements.ModifyDatabase
             || statement instanceof Statements.DeleteDatabase) {
-            if (statementNode.findFirstExpression(Expressions.Dynamic)) {
+            const dyn = statementNode.findFirstExpression(Expressions.Dynamic);
+            if (dyn && dyn.findDirectExpression(Expressions.Constant) === undefined) {
                 return "Dynamic SQL";
             }
         }