@abaplint/core 2.90.11 → 2.91.1

package/build/abaplint.d.ts

@@ -1262,6 +1262,7 @@ declare class DataDefinition extends AbstractObject {
     findSourceFile(): IFile | undefined;
     hasParserError(): boolean | undefined;
     parse(): IParseResult;
+    getTree(): ExpressionNode | undefined;
     private findSQLViewName;
     private findFieldNames;
     private findSourcesAndRelations;

package/build/src/abap/5_syntax/_type_utils.js

@@ -22,6 +22,7 @@ class TypeUtils {
         else if (type instanceof basic_1.StringType
             || type instanceof basic_1.AnyType
             || type instanceof basic_1.CharacterType
+            || type instanceof basic_1.SimpleType
             || type instanceof basic_1.CLikeType
             || type instanceof basic_1.DateType
             || type instanceof basic_1.CSequenceType
@@ -55,6 +56,7 @@ class TypeUtils {
             || type instanceof basic_1.UnknownType
             || type instanceof basic_1.NumericType
             || type instanceof basic_1.IntegerType
+            || type instanceof basic_1.SimpleType
             || type instanceof basic_1.FloatType
             || type instanceof basic_1.FloatingPointType
             || type instanceof basic_1.DecFloatType

package/build/src/cds/expressions/cds_with_parameters.js

@@ -6,7 +6,7 @@ const combi_1 = require("../../abap/2_statements/combi");
 class CDSWithParameters extends combi_1.Expression {
     getRunnable() {
         const param = (0, combi_1.seq)(_1.CDSName, ":", _1.CDSType);
-        return (0, combi_1.seq)("wITH PARAMETERS", param, (0, combi_1.star)((0, combi_1.seq)(",", param)));
+        return (0, combi_1.seq)("WITH PARAMETERS", param, (0, combi_1.star)((0, combi_1.seq)(",", param)));
     }
 }
 exports.CDSWithParameters = CDSWithParameters;

package/build/src/objects/data_definition.js

@@ -85,6 +85,10 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
         this.dirty = false;
         return { updated: true, runtime: Date.now() - start };
     }
+    getTree() {
+        var _a;
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.tree;
+    }
     //////////
     findSQLViewName() {
         var _a;

package/build/src/objects/table.js

@@ -208,6 +208,12 @@ class Table extends _abstract_object_1.AbstractObject {
                     type: new Types.UnknownType("Table " + this.getName() + ", unknown component type \"" + comptype + "\"")
                 });
             }
+            if (field.CHECKTABLE) {
+                const lookup = ddic.lookupTableOrView(field.CHECKTABLE);
+                if (lookup.object) {
+                    references.push({ object: lookup.object });
+                }
+            }
         }
         if (components.length === 0) {
             return new Types.UnknownType("Table/Structure " + this.getName() + " does not contain any components");
@@ -266,6 +272,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 DECIMALS: field.DECIMALS,
                 KEYFLAG: field.KEYFLAG,
                 GROUPNAME: field.GROUPNAME,
+                CHECKTABLE: field.CHECKTABLE,
                 REFTYPE: field.REFTYPE,
             });
         }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.90.11";
+        return "2.91.1";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/cds_legacy_view.js

@@ -0,0 +1,63 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSLegacyView = exports.CDSLegacyViewConf = void 0;
+const issue_1 = require("../issue");
+const _irule_1 = require("./_irule");
+const version_1 = require("../version");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const objects_1 = require("../objects");
+class CDSLegacyViewConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.CDSLegacyViewConf = CDSLegacyViewConf;
+class CDSLegacyView {
+    constructor() {
+        this.conf = new CDSLegacyViewConf();
+    }
+    getMetadata() {
+        return {
+            key: "cds_legacy_view",
+            title: "CDS Legacy View",
+            shortDescription: `Identify CDS Legacy Views`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `https://blogs.sap.com/2021/10/16/a-new-generation-of-cds-views-how-to-migrate-your-cds-views-to-cds-view-entities/
+
+v755 and up`,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(o) {
+        const issues = [];
+        if (this.reg.getConfig().getVersion() < version_1.Version.v755
+            && this.reg.getConfig().getVersion() !== version_1.Version.Cloud) {
+            return [];
+        }
+        if (o.getType() !== "DDLS") {
+            return [];
+        }
+        if (o instanceof objects_1.DataDefinition) {
+            const tree = o.getTree();
+            if (tree === undefined) {
+                return []; // parser error
+            }
+            if (tree.findDirectTokenByText("ENTITY") === undefined) {
+                const file = o.findSourceFile();
+                if (file) {
+                    issues.push(issue_1.Issue.atRow(file, 1, "CDS Legacy View", this.getMetadata().key, this.getConfig().severity));
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.CDSLegacyView = CDSLegacyView;
+//# sourceMappingURL=cds_legacy_view.js.map

package/build/src/rules/cds_parser_error.js

@@ -18,7 +18,7 @@ class CDSParserError {
             title: "CDS Parser Error",
             shortDescription: `CDS parsing, experimental`,
             extendedInformation: ``,
-            tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Experimental],
+            tags: [_irule_1.RuleTag.Syntax],
         };
     }
     getConfig() {
@@ -36,7 +36,7 @@ class CDSParserError {
             const hasError = o.hasParserError();
             const file = o.findSourceFile();
             if (hasError === true && file) {
-                issues.push(issue_1.Issue.atRow(file, 1, "CDS Parser error", this.getMetadata().key));
+                issues.push(issue_1.Issue.atRow(file, 1, "CDS Parser error", this.getMetadata().key, this.getConfig().severity));
             }
         }
         return issues;

package/build/src/rules/downport.js

@@ -1252,14 +1252,6 @@ ${indentation}    output = ${topTarget}.`;
                 body += indentation + uniqueName + " = " + base.concatTokens() + ".\n";
             }
             let end = "";
-            /*
-                  for (const forLoop of valueBody?.findDirectExpressions(Expressions.For) || []) {
-                    const outlineFor = this.outlineFor(forLoop, indentation, lowFile, highSyntax);
-                    body += outlineFor.body;
-                    end = outlineFor.end + `.\n` + end;
-                    indentation += "  ";
-                  }
-            */
             let structureName = uniqueName;
             let added = false;
             let skip = false;
@@ -1284,6 +1276,9 @@ ${indentation}    output = ${topTarget}.`;
                     indentation += "  ";
                 }
                 else if (b.get() instanceof Expressions.Source) {
+                    if ((valueBody === null || valueBody === void 0 ? void 0 : valueBody.getChildren().length) === 1) {
+                        body += indentation + uniqueName + " = " + b.concatTokens() + `.\n`;
+                    }
                     structureName = b.concatTokens();
                     if (base && (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectTokenByText("(")) === undefined) {
                         structureName = uniqueName;

package/build/src/rules/index.js

@@ -25,6 +25,7 @@ __exportStar(require("./begin_end_names"), exports);
 __exportStar(require("./begin_single_include"), exports);
 __exportStar(require("./call_transaction_authority_check"), exports);
 __exportStar(require("./cds_parser_error"), exports);
+__exportStar(require("./cds_legacy_view"), exports);
 __exportStar(require("./chain_mainly_declarations"), exports);
 __exportStar(require("./check_abstract"), exports);
 __exportStar(require("./check_comments"), exports);
@@ -36,6 +37,7 @@ __exportStar(require("./check_syntax"), exports);
 __exportStar(require("./classic_exceptions_overlap"), exports);
 __exportStar(require("./check_text_elements"), exports);
 __exportStar(require("./check_transformation_exists"), exports);
+__exportStar(require("./superfluous_value"), exports);
 __exportStar(require("./class_attribute_names"), exports);
 __exportStar(require("./cloud_types"), exports);
 __exportStar(require("./colon_missing_space"), exports);

package/build/src/rules/superfluous_value.js

@@ -0,0 +1,73 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SuperfluousValue = exports.SuperfluousValueConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const Expressions = require("../abap/2_statements/expressions");
+const Statements = require("../abap/2_statements/statements");
+const _irule_1 = require("./_irule");
+const version_1 = require("../version");
+class SuperfluousValueConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.SuperfluousValueConf = SuperfluousValueConf;
+class SuperfluousValue extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new SuperfluousValueConf();
+    }
+    getMetadata() {
+        return {
+            key: "superfluous_value",
+            title: "Superfluous VALUE",
+            shortDescription: `Find superfluous VALUE expressions`,
+            extendedInformation: `Left hand side is inline, VALUE is inferred, value body is simple, from v740sp02 and up`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `DATA(message_entry) = VALUE #( message_table[ msgno = msgno ] ).`,
+            goodExample: `DATA(message_entry) = message_table[ msgno = msgno ].`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        var _a, _b;
+        const output = [];
+        if (this.reg.getConfig().getVersion() < version_1.Version.v740sp02
+            && this.reg.getConfig().getVersion() !== version_1.Version.Cloud) {
+            return [];
+        }
+        const struc = file.getStructure();
+        if (struc === undefined) {
+            return []; // syntax error
+        }
+        for (const m of struc.findAllStatements(Statements.Move)) {
+            if (((_a = m.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.InlineData)) === undefined) {
+                continue;
+            }
+            const source = m.findDirectExpression(Expressions.Source);
+            if (source === undefined) {
+                continue;
+            }
+            const type = (_b = source.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+            if (type !== "#") {
+                continue;
+            }
+            const body = source.findDirectExpression(Expressions.ValueBody);
+            if (body === undefined) {
+                continue;
+            }
+            if (body.getChildren().length === 1) {
+                const message = "Superfluous VALUE expression";
+                const issue = issue_1.Issue.atStatement(file, m, message, this.getMetadata().key, this.conf.severity);
+                output.push(issue);
+            }
+        }
+        return output;
+    }
+}
+exports.SuperfluousValue = SuperfluousValue;
+//# sourceMappingURL=superfluous_value.js.map

package/build/src/rules/unnecessary_pragma.js

@@ -25,20 +25,28 @@ class UnnecessaryPragma extends _abap_rule_1.ABAPRule {
 
 * NEEDED without definition
 
-* NO_TEXT without texts`,
+* NO_TEXT without texts
+
+* SUBRC_OK where sy-subrc is checked`,
             tags: [_irule_1.RuleTag.SingleFile],
             badExample: `TRY.
     ...
   CATCH zcx_abapgit_exception ##NO_HANDLER.
     RETURN. " it has a handler
 ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.`,
+MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs) ##SUBRC_OK.
+IF sy-subrc <> 0.
+ENDIF.`,
             goodExample: `TRY.
     ...
   CATCH zcx_abapgit_exception.
     RETURN.
 ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message.`,
+MESSAGE w125(zbar) WITH c_foo INTO message.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs).
+IF sy-subrc <> 0.
+ENDIF.`,
         };
     }
     getConfig() {
@@ -53,6 +61,7 @@ MESSAGE w125(zbar) WITH c_foo INTO message.`,
         const statements = file.getStatements();
         for (let i = 0; i < statements.length; i++) {
             const statement = statements[i];
+            const nextStatement = statements[i + 1];
             if (statement.get() instanceof Statements.EndTry) {
                 noHandler = false;
             }
@@ -70,6 +79,7 @@ MESSAGE w125(zbar) WITH c_foo INTO message.`,
             }
             issues.push(...this.checkText(statement, file));
             issues.push(...this.checkNeeded(statement, file));
+            issues.push(...this.checkSubrc(statement, nextStatement, file));
         }
         return issues;
     }
@@ -85,6 +95,18 @@ MESSAGE w125(zbar) WITH c_foo INTO message.`,
         }
         return [];
     }
+    checkSubrc(statement, next, file) {
+        const p = statement.getPragmas().find(t => t.getStr().toUpperCase() === "##SUBRC_OK");
+        if (p === undefined) {
+            return [];
+        }
+        const concat = next.concatTokens().toUpperCase();
+        if (concat.includes(" SY-SUBRC")) {
+            const message = "SUBRC_OK can be removed as sy-subrc is checked";
+            return [issue_1.Issue.atToken(file, p, message, this.getMetadata().key, this.getConfig().severity)];
+        }
+        return [];
+    }
     checkNeeded(statement, file) {
         const p = statement.getPragmas().find(t => t.getStr().toUpperCase() === "##NEEDED");
         if (p === undefined) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.90.11",
+    "version": "2.91.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",