@abaplint/core 2.90.10 → 2.91.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (88) hide show
  1. package/README.md +6 -6
  2. package/build/abaplint.d.ts +3 -0
  3. package/build/src/abap/5_syntax/_builtin.js +16 -0
  4. package/build/src/abap/flow/flow_graph.js +7 -7
  5. package/build/src/cds/expressions/cds_with_parameters.js +1 -1
  6. package/build/src/lsp/help.js +7 -7
  7. package/build/src/objects/data_definition.js +4 -0
  8. package/build/src/objects/table.js +7 -0
  9. package/build/src/registry.js +1 -1
  10. package/build/src/rules/7bit_ascii.js +2 -2
  11. package/build/src/rules/abapdoc.js +1 -1
  12. package/build/src/rules/align_parameters.js +33 -33
  13. package/build/src/rules/ambiguous_statement.js +5 -5
  14. package/build/src/rules/avoid_use.js +8 -8
  15. package/build/src/rules/begin_end_names.js +4 -4
  16. package/build/src/rules/begin_single_include.js +12 -12
  17. package/build/src/rules/call_transaction_authority_check.js +3 -3
  18. package/build/src/rules/cds_legacy_view.js +63 -0
  19. package/build/src/rules/cds_parser_error.js +2 -2
  20. package/build/src/rules/chain_mainly_declarations.js +4 -4
  21. package/build/src/rules/check_abstract.js +2 -2
  22. package/build/src/rules/check_comments.js +4 -4
  23. package/build/src/rules/check_include.js +3 -3
  24. package/build/src/rules/check_subrc.js +8 -8
  25. package/build/src/rules/classic_exceptions_overlap.js +8 -8
  26. package/build/src/rules/commented_code.js +1 -1
  27. package/build/src/rules/constructor_visibility_public.js +4 -4
  28. package/build/src/rules/contains_tab.js +2 -2
  29. package/build/src/rules/dangerous_statement.js +1 -1
  30. package/build/src/rules/downport.js +85 -75
  31. package/build/src/rules/exit_or_check.js +3 -3
  32. package/build/src/rules/exporting.js +1 -1
  33. package/build/src/rules/forbidden_identifier.js +1 -1
  34. package/build/src/rules/forbidden_void_type.js +2 -2
  35. package/build/src/rules/functional_writing.js +17 -17
  36. package/build/src/rules/global_class.js +8 -8
  37. package/build/src/rules/identical_conditions.js +2 -2
  38. package/build/src/rules/identical_contents.js +14 -14
  39. package/build/src/rules/identical_descriptions.js +4 -4
  40. package/build/src/rules/if_in_if.js +7 -7
  41. package/build/src/rules/implement_methods.js +3 -3
  42. package/build/src/rules/in_statement_indentation.js +11 -11
  43. package/build/src/rules/index.js +2 -0
  44. package/build/src/rules/intf_referencing_clas.js +3 -3
  45. package/build/src/rules/line_break_style.js +2 -2
  46. package/build/src/rules/line_length.js +1 -1
  47. package/build/src/rules/line_only_punc.js +1 -1
  48. package/build/src/rules/local_variable_names.js +2 -2
  49. package/build/src/rules/many_parentheses.js +10 -10
  50. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  51. package/build/src/rules/max_one_statement.js +3 -3
  52. package/build/src/rules/method_overwrites_builtin.js +2 -2
  53. package/build/src/rules/nesting.js +1 -1
  54. package/build/src/rules/no_chained_assignment.js +1 -1
  55. package/build/src/rules/no_external_form_calls.js +2 -2
  56. package/build/src/rules/no_inline_in_optional_branches.js +11 -11
  57. package/build/src/rules/no_public_attributes.js +1 -1
  58. package/build/src/rules/no_yoda_conditions.js +4 -4
  59. package/build/src/rules/nrob_consistency.js +2 -2
  60. package/build/src/rules/obsolete_statement.js +40 -40
  61. package/build/src/rules/omit_parameter_name.js +3 -3
  62. package/build/src/rules/omit_receiving.js +13 -13
  63. package/build/src/rules/parser_702_chaining.js +2 -2
  64. package/build/src/rules/parser_error.js +2 -2
  65. package/build/src/rules/parser_missing_space.js +1 -1
  66. package/build/src/rules/prefer_inline.js +16 -16
  67. package/build/src/rules/prefer_is_not.js +7 -7
  68. package/build/src/rules/prefer_raise_exception_new.js +3 -3
  69. package/build/src/rules/prefer_returning_to_exporting.js +1 -1
  70. package/build/src/rules/prefer_xsdbool.js +2 -2
  71. package/build/src/rules/remove_descriptions.js +4 -4
  72. package/build/src/rules/rfc_error_handling.js +9 -9
  73. package/build/src/rules/select_add_order_by.js +5 -5
  74. package/build/src/rules/select_performance.js +2 -2
  75. package/build/src/rules/sicf_consistency.js +2 -2
  76. package/build/src/rules/space_before_dot.js +2 -2
  77. package/build/src/rules/start_at_tab.js +1 -1
  78. package/build/src/rules/superfluous_value.js +73 -0
  79. package/build/src/rules/sy_modification.js +2 -2
  80. package/build/src/rules/tabl_enhancement_category.js +2 -2
  81. package/build/src/rules/unnecessary_pragma.js +39 -17
  82. package/build/src/rules/unused_methods.js +9 -9
  83. package/build/src/rules/unused_variables.js +6 -6
  84. package/build/src/rules/use_bool_expression.js +8 -8
  85. package/build/src/rules/use_line_exists.js +6 -6
  86. package/build/src/rules/use_new.js +4 -4
  87. package/build/src/rules/when_others_last.js +6 -6
  88. package/package.json +65 -65
package/README.md CHANGED
@@ -1,7 +1,7 @@
1
- # @abaplint/core
2
-
3
- [abaplint](https://abaplint.org/) core library
4
-
5
- Exposes functionality like the parser and rules, which can be used in other projects.
6
-
1
+ # @abaplint/core
2
+
3
+ [abaplint](https://abaplint.org/) core library
4
+
5
+ Exposes functionality like the parser and rules, which can be used in other projects.
6
+
7
7
  For more information see https://github.com/abaplint/abaplint
@@ -414,6 +414,7 @@ export declare class BuiltIn {
414
414
  private row;
415
415
  private buildDefinition;
416
416
  searchBuiltin(name: string | undefined): IMethodDefinition | undefined;
417
+ isPredicate(name: string | undefined): boolean | undefined;
417
418
  getTypes(): TypedIdentifier[];
418
419
  get(extras: string[]): TypedIdentifier[];
419
420
  private buildSY;
@@ -1261,6 +1262,7 @@ declare class DataDefinition extends AbstractObject {
1261
1262
  findSourceFile(): IFile | undefined;
1262
1263
  hasParserError(): boolean | undefined;
1263
1264
  parse(): IParseResult;
1265
+ getTree(): ExpressionNode | undefined;
1264
1266
  private findSQLViewName;
1265
1267
  private findFieldNames;
1266
1268
  private findSourcesAndRelations;
@@ -2543,6 +2545,7 @@ declare interface IBuiltinMethod {
2543
2545
  [key: string]: AbstractType;
2544
2546
  };
2545
2547
  version?: Version;
2548
+ predicate?: boolean;
2546
2549
  return: AbstractType;
2547
2550
  }
2548
2551
 
@@ -103,6 +103,17 @@ class BuiltIn {
103
103
  }
104
104
  return this.buildDefinition(BuiltIn.methods[index], index);
105
105
  }
106
+ isPredicate(name) {
107
+ if (name === undefined) {
108
+ return undefined;
109
+ }
110
+ // todo, optimize, use hash map
111
+ const index = BuiltIn.methods.findIndex(a => a.name === name.toUpperCase());
112
+ if (index < 0) {
113
+ return undefined;
114
+ }
115
+ return BuiltIn.methods[index].predicate;
116
+ }
106
117
  getTypes() {
107
118
  const ret = this.buildSY();
108
119
  const id = new tokens_1.Identifier(new position_1.Position(1, 1), "abap_bool");
@@ -415,6 +426,7 @@ BuiltIn.methods = [
415
426
  "occ": new basic_1.IntegerType(),
416
427
  },
417
428
  return: new basic_1.CharacterType(1),
429
+ predicate: true,
418
430
  version: version_1.Version.v702,
419
431
  },
420
432
  {
@@ -430,6 +442,7 @@ BuiltIn.methods = [
430
442
  "len": new basic_1.IntegerType(),
431
443
  "occ": new basic_1.IntegerType(),
432
444
  },
445
+ predicate: true,
433
446
  return: new basic_1.CharacterType(1), version: version_1.Version.v702,
434
447
  },
435
448
  {
@@ -446,6 +459,7 @@ BuiltIn.methods = [
446
459
  "occ": new basic_1.IntegerType(),
447
460
  },
448
461
  return: new basic_1.CharacterType(1),
462
+ predicate: true,
449
463
  version: version_1.Version.v702,
450
464
  },
451
465
  {
@@ -656,6 +670,7 @@ BuiltIn.methods = [
656
670
  "val": new basic_1.AnyType(),
657
671
  },
658
672
  return: new basic_1.CharacterType(1),
673
+ predicate: true,
659
674
  version: version_1.Version.v740sp02,
660
675
  },
661
676
  {
@@ -713,6 +728,7 @@ BuiltIn.methods = [
713
728
  "len": new basic_1.IntegerType(),
714
729
  },
715
730
  return: new basic_1.CharacterType(1),
731
+ predicate: true,
716
732
  version: version_1.Version.v702,
717
733
  },
718
734
  {
@@ -72,13 +72,13 @@ class FlowGraph {
72
72
  this.label = label;
73
73
  }
74
74
  toDigraph() {
75
- return `digraph G {
76
- labelloc="t";
77
- label="${this.label}";
78
- graph [fontname = "helvetica"];
79
- node [fontname = "helvetica", shape="box"];
80
- edge [fontname = "helvetica"];
81
- ${this.toTextEdges()}
75
+ return `digraph G {
76
+ labelloc="t";
77
+ label="${this.label}";
78
+ graph [fontname = "helvetica"];
79
+ node [fontname = "helvetica", shape="box"];
80
+ edge [fontname = "helvetica"];
81
+ ${this.toTextEdges()}
82
82
  }`;
83
83
  }
84
84
  listSources(node) {
@@ -6,7 +6,7 @@ const combi_1 = require("../../abap/2_statements/combi");
6
6
  class CDSWithParameters extends combi_1.Expression {
7
7
  getRunnable() {
8
8
  const param = (0, combi_1.seq)(_1.CDSName, ":", _1.CDSType);
9
- return (0, combi_1.seq)("wITH PARAMETERS", param, (0, combi_1.star)((0, combi_1.seq)(",", param)));
9
+ return (0, combi_1.seq)("WITH PARAMETERS", param, (0, combi_1.star)((0, combi_1.seq)(",", param)));
10
10
  }
11
11
  }
12
12
  exports.CDSWithParameters = CDSWithParameters;
@@ -19,13 +19,13 @@ class Help {
19
19
  /////////////////////////////////////////////////
20
20
  static dumpABAP(file, reg, textDocument, position) {
21
21
  let content = "";
22
- content = `
23
- <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
- <a href="#_statements" rel="no-refresh">Statements</a> |
25
- <a href="#_structure" rel="no-refresh">Structure</a> |
26
- <a href="#_files" rel="no-refresh">Files</a> |
27
- <a href="#_info" rel="no-refresh">Info Dump</a>
28
- <hr>
22
+ content = `
23
+ <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
+ <a href="#_statements" rel="no-refresh">Statements</a> |
25
+ <a href="#_structure" rel="no-refresh">Structure</a> |
26
+ <a href="#_files" rel="no-refresh">Files</a> |
27
+ <a href="#_info" rel="no-refresh">Info Dump</a>
28
+ <hr>
29
29
  ` +
30
30
  "<tt>" + textDocument.uri + " (" +
31
31
  (position.line + 1) + ", " +
@@ -85,6 +85,10 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
85
85
  this.dirty = false;
86
86
  return { updated: true, runtime: Date.now() - start };
87
87
  }
88
+ getTree() {
89
+ var _a;
90
+ return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.tree;
91
+ }
88
92
  //////////
89
93
  findSQLViewName() {
90
94
  var _a;
@@ -208,6 +208,12 @@ class Table extends _abstract_object_1.AbstractObject {
208
208
  type: new Types.UnknownType("Table " + this.getName() + ", unknown component type \"" + comptype + "\"")
209
209
  });
210
210
  }
211
+ if (field.CHECKTABLE) {
212
+ const lookup = ddic.lookupTableOrView(field.CHECKTABLE);
213
+ if (lookup.object) {
214
+ references.push({ object: lookup.object });
215
+ }
216
+ }
211
217
  }
212
218
  if (components.length === 0) {
213
219
  return new Types.UnknownType("Table/Structure " + this.getName() + " does not contain any components");
@@ -266,6 +272,7 @@ class Table extends _abstract_object_1.AbstractObject {
266
272
  DECIMALS: field.DECIMALS,
267
273
  KEYFLAG: field.KEYFLAG,
268
274
  GROUPNAME: field.GROUPNAME,
275
+ CHECKTABLE: field.CHECKTABLE,
269
276
  REFTYPE: field.REFTYPE,
270
277
  });
271
278
  }
@@ -68,7 +68,7 @@ class Registry {
68
68
  }
69
69
  static abaplintVersion() {
70
70
  // magic, see build script "version.sh"
71
- return "2.90.10";
71
+ return "2.91.0";
72
72
  }
73
73
  getDDICReferences() {
74
74
  return this.references;
@@ -17,8 +17,8 @@ class SevenBitAscii {
17
17
  key: "7bit_ascii",
18
18
  title: "Check for 7bit ascii",
19
19
  shortDescription: `Only allow characters from the 7bit ASCII set.`,
20
- extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
-
20
+ extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
+
22
22
  Checkes files with extension ".abap" and ".asddls"`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
24
  };
@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "abapdoc",
25
25
  title: "Check abapdoc",
26
- shortDescription: `Various checks regarding abapdoc.
26
+ shortDescription: `Various checks regarding abapdoc.
27
27
  Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
28
28
  tags: [_irule_1.RuleTag.SingleFile],
29
29
  };
@@ -20,42 +20,42 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
20
20
  key: "align_parameters",
21
21
  title: "Align Parameters",
22
22
  shortDescription: `Checks for vertially aligned parameters`,
23
- extendedInformation: `Checks:
24
- * function module calls
25
- * method calls
26
- * VALUE constructors
27
- * NEW constructors
28
- * RAISE EXCEPTION statements
29
- * CREATE OBJECT statements
30
- * RAISE EVENT statements
31
-
32
- https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
-
34
- Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
-
23
+ extendedInformation: `Checks:
24
+ * function module calls
25
+ * method calls
26
+ * VALUE constructors
27
+ * NEW constructors
28
+ * RAISE EXCEPTION statements
29
+ * CREATE OBJECT statements
30
+ * RAISE EVENT statements
31
+
32
+ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
+
34
+ Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
+
36
36
  Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
37
37
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
38
- badExample: `CALL FUNCTION 'FOOBAR'
39
- EXPORTING
40
- foo = 2
41
- parameter = 3.
42
-
43
- foobar( moo = 1
44
- param = 1 ).
45
-
46
- foo = VALUE #(
47
- foo = bar
38
+ badExample: `CALL FUNCTION 'FOOBAR'
39
+ EXPORTING
40
+ foo = 2
41
+ parameter = 3.
42
+
43
+ foobar( moo = 1
44
+ param = 1 ).
45
+
46
+ foo = VALUE #(
47
+ foo = bar
48
48
  moo = 2 ).`,
49
- goodExample: `CALL FUNCTION 'FOOBAR'
50
- EXPORTING
51
- foo = 2
52
- parameter = 3.
53
-
54
- foobar( moo = 1
55
- param = 1 ).
56
-
57
- foo = VALUE #(
58
- foo = bar
49
+ goodExample: `CALL FUNCTION 'FOOBAR'
50
+ EXPORTING
51
+ foo = 2
52
+ parameter = 3.
53
+
54
+ foobar( moo = 1
55
+ param = 1 ).
56
+
57
+ foo = VALUE #(
58
+ foo = bar
59
59
  moo = 2 ).`,
60
60
  };
61
61
  }
@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
20
20
  return {
21
21
  key: "ambiguous_statement",
22
22
  title: "Check for ambigious statements",
23
- shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
- Add "TABLE" keyword or "@" for escaping SQL variables
25
-
23
+ shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
+ Add "TABLE" keyword or "@" for escaping SQL variables
25
+
26
26
  Only works if the target version is 740sp05 or above`,
27
27
  tags: [_irule_1.RuleTag.SingleFile],
28
- badExample: `DELETE foo FROM bar.
28
+ badExample: `DELETE foo FROM bar.
29
29
  MODIFY foo FROM bar.`,
30
- goodExample: `DELETE foo FROM @bar.
30
+ goodExample: `DELETE foo FROM @bar.
31
31
  MODIFY TABLE foo FROM bar.`,
32
32
  };
33
33
  }
@@ -37,14 +37,14 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
37
37
  key: "avoid_use",
38
38
  title: "Avoid use of certain statements",
39
39
  shortDescription: `Detects usage of certain statements.`,
40
- extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
41
-
42
- Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
43
-
44
- STATICS: use CLASS-DATA instead
45
-
46
- DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
47
-
40
+ extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
41
+
42
+ Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
43
+
44
+ STATICS: use CLASS-DATA instead
45
+
46
+ DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
47
+
48
48
  TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround`,
49
49
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
50
50
  };
@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
23
23
  title: "Check BEGIN END names",
24
24
  shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
25
25
  tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
26
- badExample: `DATA: BEGIN OF stru,
27
- field TYPE i,
26
+ badExample: `DATA: BEGIN OF stru,
27
+ field TYPE i,
28
28
  END OF structure_not_the_same.`,
29
- goodExample: `DATA: BEGIN OF stru,
30
- field TYPE i,
29
+ goodExample: `DATA: BEGIN OF stru,
30
+ field TYPE i,
31
31
  END OF stru.`,
32
32
  };
33
33
  }
@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
21
21
  title: "BEGIN contains single INCLUDE",
22
22
  shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TYPES: BEGIN OF dummy1.
25
- INCLUDE TYPE dselc.
26
- TYPES: END OF dummy1.
27
-
28
- DATA BEGIN OF foo.
29
- INCLUDE STRUCTURE syst.
30
- DATA END OF foo.
31
-
32
- STATICS BEGIN OF bar.
33
- INCLUDE STRUCTURE syst.
24
+ badExample: `TYPES: BEGIN OF dummy1.
25
+ INCLUDE TYPE dselc.
26
+ TYPES: END OF dummy1.
27
+
28
+ DATA BEGIN OF foo.
29
+ INCLUDE STRUCTURE syst.
30
+ DATA END OF foo.
31
+
32
+ STATICS BEGIN OF bar.
33
+ INCLUDE STRUCTURE syst.
34
34
  STATICS END OF bar.`,
35
- goodExample: `DATA BEGIN OF foo.
36
- INCLUDE STRUCTURE dselc.
35
+ goodExample: `DATA BEGIN OF foo.
36
+ INCLUDE STRUCTURE dselc.
37
37
  DATA END OF foo.`,
38
38
  };
39
39
  }
@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
24
24
  extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
25
25
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
26
26
  badExample: `CALL TRANSACTION 'FOO'.`,
27
- goodExample: `TRY.
28
- CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
- CATCH cx_sy_authorization_error.
27
+ goodExample: `TRY.
28
+ CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
+ CATCH cx_sy_authorization_error.
30
30
  ENDTRY.`,
31
31
  };
32
32
  }
@@ -0,0 +1,63 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ exports.CDSLegacyView = exports.CDSLegacyViewConf = void 0;
4
+ const issue_1 = require("../issue");
5
+ const _irule_1 = require("./_irule");
6
+ const version_1 = require("../version");
7
+ const _basic_rule_config_1 = require("./_basic_rule_config");
8
+ const objects_1 = require("../objects");
9
+ class CDSLegacyViewConf extends _basic_rule_config_1.BasicRuleConfig {
10
+ }
11
+ exports.CDSLegacyViewConf = CDSLegacyViewConf;
12
+ class CDSLegacyView {
13
+ constructor() {
14
+ this.conf = new CDSLegacyViewConf();
15
+ }
16
+ getMetadata() {
17
+ return {
18
+ key: "cds_legacy_view",
19
+ title: "CDS Legacy View",
20
+ shortDescription: `Identify CDS Legacy Views`,
21
+ // eslint-disable-next-line max-len
22
+ extendedInformation: `https://blogs.sap.com/2021/10/16/a-new-generation-of-cds-views-how-to-migrate-your-cds-views-to-cds-view-entities/
23
+
24
+ v755 and up`,
25
+ tags: [_irule_1.RuleTag.SingleFile],
26
+ };
27
+ }
28
+ getConfig() {
29
+ return this.conf;
30
+ }
31
+ setConfig(conf) {
32
+ this.conf = conf;
33
+ }
34
+ initialize(reg) {
35
+ this.reg = reg;
36
+ return this;
37
+ }
38
+ run(o) {
39
+ const issues = [];
40
+ if (this.reg.getConfig().getVersion() < version_1.Version.v755
41
+ && this.reg.getConfig().getVersion() !== version_1.Version.Cloud) {
42
+ return [];
43
+ }
44
+ if (o.getType() !== "DDLS") {
45
+ return [];
46
+ }
47
+ if (o instanceof objects_1.DataDefinition) {
48
+ const tree = o.getTree();
49
+ if (tree === undefined) {
50
+ return []; // parser error
51
+ }
52
+ if (tree.findDirectTokenByText("ENTITY") === undefined) {
53
+ const file = o.findSourceFile();
54
+ if (file) {
55
+ issues.push(issue_1.Issue.atRow(file, 1, "CDS Legacy View", this.getMetadata().key, this.getConfig().severity));
56
+ }
57
+ }
58
+ }
59
+ return issues;
60
+ }
61
+ }
62
+ exports.CDSLegacyView = CDSLegacyView;
63
+ //# sourceMappingURL=cds_legacy_view.js.map
@@ -18,7 +18,7 @@ class CDSParserError {
18
18
  title: "CDS Parser Error",
19
19
  shortDescription: `CDS parsing, experimental`,
20
20
  extendedInformation: ``,
21
- tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Experimental],
21
+ tags: [_irule_1.RuleTag.Syntax],
22
22
  };
23
23
  }
24
24
  getConfig() {
@@ -36,7 +36,7 @@ class CDSParserError {
36
36
  const hasError = o.hasParserError();
37
37
  const file = o.findSourceFile();
38
38
  if (hasError === true && file) {
39
- issues.push(issue_1.Issue.atRow(file, 1, "CDS Parser error", this.getMetadata().key));
39
+ issues.push(issue_1.Issue.atRow(file, 1, "CDS Parser error", this.getMetadata().key, this.getConfig().severity));
40
40
  }
41
41
  }
42
42
  return issues;
@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
45
45
  key: "chain_mainly_declarations",
46
46
  title: "Chain mainly declarations",
47
47
  shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
48
- extendedInformation: `
49
- https://docs.abapopenchecks.org/checks/23/
50
-
51
- https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
48
+ extendedInformation: `
49
+ https://docs.abapopenchecks.org/checks/23/
50
+
51
+ https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
52
52
  `,
53
53
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
54
54
  badExample: `CALL METHOD: bar.`,
@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "check_abstract",
25
25
  title: "Check abstract methods and classes",
26
- shortDescription: `Checks abstract methods and classes:
27
- - class defined as abstract and final,
26
+ shortDescription: `Checks abstract methods and classes:
27
+ - class defined as abstract and final,
28
28
  - non-abstract class contains abstract methods`,
29
29
  extendedInformation: `If a class defines only constants, use an interface instead`,
30
30
  tags: [_irule_1.RuleTag.SingleFile],
@@ -27,11 +27,11 @@ class CheckComments extends _abap_rule_1.ABAPRule {
27
27
  return {
28
28
  key: "check_comments",
29
29
  title: "Check Comments",
30
- shortDescription: `
30
+ shortDescription: `
31
31
  Various checks for comment usage.`,
32
- extendedInformation: `
33
- * End of line comments. Comments starting with "#EC" or "##" are ignored
34
-
32
+ extendedInformation: `
33
+ * End of line comments. Comments starting with "#EC" or "##" are ignored
34
+
35
35
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
36
36
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
37
37
  };
@@ -17,9 +17,9 @@ class CheckInclude {
17
17
  key: "check_include",
18
18
  title: "Check INCLUDEs",
19
19
  shortDescription: `Checks INCLUDE statements`,
20
- extendedInformation: `
21
- * Reports unused includes
22
- * Errors if the includes are not found
20
+ extendedInformation: `
21
+ * Reports unused includes
22
+ * Errors if the includes are not found
23
23
  * Error if including a main program`,
24
24
  tags: [_irule_1.RuleTag.Syntax],
25
25
  };
@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
34
34
  key: "check_subrc",
35
35
  title: "Check sy-subrc",
36
36
  shortDescription: `Check sy-subrc`,
37
- extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
-
39
- If sy-dbcnt is checked after database statements, it is considered okay.
40
-
41
- "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
-
43
- If IS ASSIGNED is checked after assigning, it is considered okay.
44
-
37
+ extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
+
39
+ If sy-dbcnt is checked after database statements, it is considered okay.
40
+
41
+ "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
+
43
+ If IS ASSIGNED is checked after assigning, it is considered okay.
44
+
45
45
  FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
46
46
  tags: [_irule_1.RuleTag.SingleFile],
47
47
  pseudoComment: "EC CI_SUBRC",
@@ -21,15 +21,15 @@ class ClassicExceptionsOverlap extends _abap_rule_1.ABAPRule {
21
21
  shortDescription: `Find overlapping classic exceptions`,
22
22
  extendedInformation: `When debugging its typically good to know exactly which exception is caught`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: ` EXCEPTIONS
25
- system_failure = 1 MESSAGE lv_message
26
- communication_failure = 1 MESSAGE lv_message
27
- resource_failure = 1
24
+ badExample: ` EXCEPTIONS
25
+ system_failure = 1 MESSAGE lv_message
26
+ communication_failure = 1 MESSAGE lv_message
27
+ resource_failure = 1
28
28
  OTHERS = 1.`,
29
- goodExample: ` EXCEPTIONS
30
- system_failure = 1 MESSAGE lv_message
31
- communication_failure = 2 MESSAGE lv_message
32
- resource_failure = 3
29
+ goodExample: ` EXCEPTIONS
30
+ system_failure = 1 MESSAGE lv_message
31
+ communication_failure = 2 MESSAGE lv_message
32
+ resource_failure = 3
33
33
  OTHERS = 4.`,
34
34
  };
35
35
  }
@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
30
30
  key: "commented_code",
31
31
  title: "Find commented code",
32
32
  shortDescription: `Detects usage of commented out code.`,
33
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
33
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
34
34
  https://docs.abapopenchecks.org/checks/14/`,
35
35
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
36
36
  };
@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
18
18
  key: "constructor_visibility_public",
19
19
  title: "Check constructor visibility is public",
20
20
  shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
21
- extendedInformation: `
22
- This only applies to global classes.
23
-
24
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
21
+ extendedInformation: `
22
+ This only applies to global classes.
23
+
24
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
25
25
  https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
26
26
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
27
27
  };
@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
25
25
  key: "contains_tab",
26
26
  title: "Code contains tab",
27
27
  shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
28
- extendedInformation: `
29
- https://docs.abapopenchecks.org/checks/09/
28
+ extendedInformation: `
29
+ https://docs.abapopenchecks.org/checks/09/
30
30
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
31
31
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
32
32
  };
@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
40
40
  key: "dangerous_statement",
41
41
  title: "Dangerous statement",
42
42
  shortDescription: `Detects potentially dangerous statements`,
43
- extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
43
+ extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
44
44
  dynamic SQL can potentially create SQL injection problems`,
45
45
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
46
46
  };