@abaplint/core 2.90.10 → 2.90.11

package/README.md

@@ -1,7 +1,7 @@
-# @abaplint/core
-
-[abaplint](https://abaplint.org/) core library
-
-Exposes functionality like the parser and rules, which can be used in other projects.
-
+# @abaplint/core
+
+[abaplint](https://abaplint.org/) core library
+
+Exposes functionality like the parser and rules, which can be used in other projects.
+
 For more information see https://github.com/abaplint/abaplint

package/build/abaplint.d.ts

@@ -414,6 +414,7 @@ export declare class BuiltIn {
     private row;
     private buildDefinition;
     searchBuiltin(name: string | undefined): IMethodDefinition | undefined;
+    isPredicate(name: string | undefined): boolean | undefined;
     getTypes(): TypedIdentifier[];
     get(extras: string[]): TypedIdentifier[];
     private buildSY;
@@ -2543,6 +2544,7 @@ declare interface IBuiltinMethod {
         [key: string]: AbstractType;
     };
     version?: Version;
+    predicate?: boolean;
     return: AbstractType;
 }
 

package/build/src/abap/5_syntax/_builtin.js

@@ -103,6 +103,17 @@ class BuiltIn {
         }
         return this.buildDefinition(BuiltIn.methods[index], index);
     }
+    isPredicate(name) {
+        if (name === undefined) {
+            return undefined;
+        }
+        // todo, optimize, use hash map
+        const index = BuiltIn.methods.findIndex(a => a.name === name.toUpperCase());
+        if (index < 0) {
+            return undefined;
+        }
+        return BuiltIn.methods[index].predicate;
+    }
     getTypes() {
         const ret = this.buildSY();
         const id = new tokens_1.Identifier(new position_1.Position(1, 1), "abap_bool");
@@ -415,6 +426,7 @@ BuiltIn.methods = [
             "occ": new basic_1.IntegerType(),
         },
         return: new basic_1.CharacterType(1),
+        predicate: true,
         version: version_1.Version.v702,
     },
     {
@@ -430,6 +442,7 @@ BuiltIn.methods = [
             "len": new basic_1.IntegerType(),
             "occ": new basic_1.IntegerType(),
         },
+        predicate: true,
         return: new basic_1.CharacterType(1), version: version_1.Version.v702,
     },
     {
@@ -446,6 +459,7 @@ BuiltIn.methods = [
             "occ": new basic_1.IntegerType(),
         },
         return: new basic_1.CharacterType(1),
+        predicate: true,
         version: version_1.Version.v702,
     },
     {
@@ -656,6 +670,7 @@ BuiltIn.methods = [
             "val": new basic_1.AnyType(),
         },
         return: new basic_1.CharacterType(1),
+        predicate: true,
         version: version_1.Version.v740sp02,
     },
     {
@@ -713,6 +728,7 @@ BuiltIn.methods = [
             "len": new basic_1.IntegerType(),
         },
         return: new basic_1.CharacterType(1),
+        predicate: true,
         version: version_1.Version.v702,
     },
     {

package/build/src/abap/flow/flow_graph.js

@@ -72,13 +72,13 @@ class FlowGraph {
         this.label = label;
     }
     toDigraph() {
-        return `digraph G {
-labelloc="t";
-label="${this.label}";
-graph [fontname = "helvetica"];
-node [fontname = "helvetica", shape="box"];
-edge [fontname = "helvetica"];
-${this.toTextEdges()}
+        return `digraph G {
+labelloc="t";
+label="${this.label}";
+graph [fontname = "helvetica"];
+node [fontname = "helvetica", shape="box"];
+edge [fontname = "helvetica"];
+${this.toTextEdges()}
 }`;
     }
     listSources(node) {

package/build/src/lsp/help.js

@@ -19,13 +19,13 @@ class Help {
     /////////////////////////////////////////////////
     static dumpABAP(file, reg, textDocument, position) {
         let content = "";
-        content = `
-    <a href="#_tokens" rel="no-refresh">Tokens</a> |
-    <a href="#_statements" rel="no-refresh">Statements</a> |
-    <a href="#_structure" rel="no-refresh">Structure</a> |
-    <a href="#_files" rel="no-refresh">Files</a> |
-    <a href="#_info" rel="no-refresh">Info Dump</a>
-    <hr>
+        content = `
+    <a href="#_tokens" rel="no-refresh">Tokens</a> |
+    <a href="#_statements" rel="no-refresh">Statements</a> |
+    <a href="#_structure" rel="no-refresh">Structure</a> |
+    <a href="#_files" rel="no-refresh">Files</a> |
+    <a href="#_info" rel="no-refresh">Info Dump</a>
+    <hr>
     ` +
             "<tt>" + textDocument.uri + " (" +
             (position.line + 1) + ", " +

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.90.10";
+        return "2.90.11";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/7bit_ascii.js

@@ -17,8 +17,8 @@ class SevenBitAscii {
             key: "7bit_ascii",
             title: "Check for 7bit ascii",
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
-            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
-
+            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
+
 Checkes files with extension ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/abapdoc.js

@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
         return {
             key: "abapdoc",
             title: "Check abapdoc",
-            shortDescription: `Various checks regarding abapdoc.
+            shortDescription: `Various checks regarding abapdoc.
 Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/align_parameters.js

@@ -20,42 +20,42 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
             key: "align_parameters",
             title: "Align Parameters",
             shortDescription: `Checks for vertially aligned parameters`,
-            extendedInformation: `Checks:
-* function module calls
-* method calls
-* VALUE constructors
-* NEW constructors
-* RAISE EXCEPTION statements
-* CREATE OBJECT statements
-* RAISE EVENT statements
-
-https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
-
-Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
-
+            extendedInformation: `Checks:
+* function module calls
+* method calls
+* VALUE constructors
+* NEW constructors
+* RAISE EXCEPTION statements
+* CREATE OBJECT statements
+* RAISE EVENT statements
+
+https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+
+Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
+
 Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
-            badExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo = 2
-    parameter = 3.
-
-foobar( moo = 1
-  param = 1 ).
-
-foo = VALUE #(
-    foo = bar
+            badExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo = 2
+    parameter = 3.
+
+foobar( moo = 1
+  param = 1 ).
+
+foo = VALUE #(
+    foo = bar
         moo = 2 ).`,
-            goodExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo       = 2
-    parameter = 3.
-
-foobar( moo   = 1
-        param = 1 ).
-
-foo = VALUE #(
-    foo = bar
+            goodExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo       = 2
+    parameter = 3.
+
+foobar( moo   = 1
+        param = 1 ).
+
+foo = VALUE #(
+    foo = bar
     moo = 2 ).`,
         };
     }

package/build/src/rules/ambiguous_statement.js

@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
         return {
             key: "ambiguous_statement",
             title: "Check for ambigious statements",
-            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
-Add "TABLE" keyword or "@" for escaping SQL variables
-
+            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
+Add "TABLE" keyword or "@" for escaping SQL variables
+
 Only works if the target version is 740sp05 or above`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DELETE foo FROM bar.
+            badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
-            goodExample: `DELETE foo FROM @bar.
+            goodExample: `DELETE foo FROM @bar.
 MODIFY TABLE foo FROM bar.`,
         };
     }

package/build/src/rules/avoid_use.js

@@ -37,14 +37,14 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
-
-Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
-STATICS: use CLASS-DATA instead
-
-DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
-
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+
+Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
+STATICS: use CLASS-DATA instead
+
+DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
+
 TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/begin_end_names.js

@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
             title: "Check BEGIN END names",
             shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            badExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF structure_not_the_same.`,
-            goodExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            goodExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF stru.`,
         };
     }

package/build/src/rules/begin_single_include.js

@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
             title: "BEGIN contains single INCLUDE",
             shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TYPES: BEGIN OF dummy1.
-  INCLUDE TYPE dselc.
-TYPES: END OF dummy1.
-
-DATA BEGIN OF foo.
-INCLUDE STRUCTURE syst.
-DATA END OF foo.
-
-STATICS BEGIN OF bar.
-INCLUDE STRUCTURE syst.
+            badExample: `TYPES: BEGIN OF dummy1.
+  INCLUDE TYPE dselc.
+TYPES: END OF dummy1.
+
+DATA BEGIN OF foo.
+INCLUDE STRUCTURE syst.
+DATA END OF foo.
+
+STATICS BEGIN OF bar.
+INCLUDE STRUCTURE syst.
 STATICS END OF bar.`,
-            goodExample: `DATA BEGIN OF foo.
-INCLUDE STRUCTURE dselc.
+            goodExample: `DATA BEGIN OF foo.
+INCLUDE STRUCTURE dselc.
 DATA END OF foo.`,
         };
     }

package/build/src/rules/call_transaction_authority_check.js

@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
             extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
             badExample: `CALL TRANSACTION 'FOO'.`,
-            goodExample: `TRY.
-    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
-  CATCH cx_sy_authorization_error.
+            goodExample: `TRY.
+    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
+  CATCH cx_sy_authorization_error.
 ENDTRY.`,
         };
     }

package/build/src/rules/chain_mainly_declarations.js

@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
             key: "chain_mainly_declarations",
             title: "Chain mainly declarations",
             shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/23/
-
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/23/
+
+https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
 `,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `CALL METHOD: bar.`,

package/build/src/rules/check_abstract.js

@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
         return {
             key: "check_abstract",
             title: "Check abstract methods and classes",
-            shortDescription: `Checks abstract methods and classes:
-- class defined as abstract and final,
+            shortDescription: `Checks abstract methods and classes:
+- class defined as abstract and final,
 - non-abstract class contains abstract methods`,
             extendedInformation: `If a class defines only constants, use an interface instead`,
             tags: [_irule_1.RuleTag.SingleFile],

package/build/src/rules/check_comments.js

@@ -27,11 +27,11 @@ class CheckComments extends _abap_rule_1.ABAPRule {
         return {
             key: "check_comments",
             title: "Check Comments",
-            shortDescription: `
+            shortDescription: `
 Various checks for comment usage.`,
-            extendedInformation: `
-* End of line comments. Comments starting with "#EC" or "##" are ignored
-
+            extendedInformation: `
+* End of line comments. Comments starting with "#EC" or "##" are ignored
+
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/check_include.js

@@ -17,9 +17,9 @@ class CheckInclude {
             key: "check_include",
             title: "Check INCLUDEs",
             shortDescription: `Checks INCLUDE statements`,
-            extendedInformation: `
-* Reports unused includes
-* Errors if the includes are not found
+            extendedInformation: `
+* Reports unused includes
+* Errors if the includes are not found
 * Error if including a main program`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/check_subrc.js

@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
             key: "check_subrc",
             title: "Check sy-subrc",
             shortDescription: `Check sy-subrc`,
-            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
-
-If sy-dbcnt is checked after database statements, it is considered okay.
-
-"SELECT SINGLE @abap_true FROM " is considered as an existence check
-
-If IS ASSIGNED is checked after assigning, it is considered okay.
-
+            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
+
+If sy-dbcnt is checked after database statements, it is considered okay.
+
+"SELECT SINGLE @abap_true FROM " is considered as an existence check
+
+If IS ASSIGNED is checked after assigning, it is considered okay.
+
 FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             tags: [_irule_1.RuleTag.SingleFile],
             pseudoComment: "EC CI_SUBRC",

package/build/src/rules/classic_exceptions_overlap.js

@@ -21,15 +21,15 @@ class ClassicExceptionsOverlap extends _abap_rule_1.ABAPRule {
             shortDescription: `Find overlapping classic exceptions`,
             extendedInformation: `When debugging its typically good to know exactly which exception is caught`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `  EXCEPTIONS
-    system_failure        = 1 MESSAGE lv_message
-    communication_failure = 1 MESSAGE lv_message
-    resource_failure      = 1
+            badExample: `  EXCEPTIONS
+    system_failure        = 1 MESSAGE lv_message
+    communication_failure = 1 MESSAGE lv_message
+    resource_failure      = 1
     OTHERS                = 1.`,
-            goodExample: `  EXCEPTIONS
-    system_failure        = 1 MESSAGE lv_message
-    communication_failure = 2 MESSAGE lv_message
-    resource_failure      = 3
+            goodExample: `  EXCEPTIONS
+    system_failure        = 1 MESSAGE lv_message
+    communication_failure = 2 MESSAGE lv_message
+    resource_failure      = 3
     OTHERS                = 4.`,
         };
     }

package/build/src/rules/commented_code.js

@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
             key: "commented_code",
             title: "Find commented code",
             shortDescription: `Detects usage of commented out code.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
 https://docs.abapopenchecks.org/checks/14/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/constructor_visibility_public.js

@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
             key: "constructor_visibility_public",
             title: "Check constructor visibility is public",
             shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
-            extendedInformation: `
-This only applies to global classes.
-
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
+            extendedInformation: `
+This only applies to global classes.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/contains_tab.js

@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
             key: "contains_tab",
             title: "Code contains tab",
             shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/09/
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/09/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/dangerous_statement.js

@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
             key: "dangerous_statement",
             title: "Dangerous statement",
             shortDescription: `Detects potentially dangerous statements`,
-            extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
+            extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
 dynamic SQL can potentially create SQL injection problems`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
         };