@abaplint/core 2.90.0 → 2.90.3

package/build/src/abap/2_statements/expressions/sql_compare.js

@@ -8,7 +8,9 @@ const version_1 = require("../../../version");
 class SQLCompare extends combi_1.Expression {
     getRunnable() {
         const val = new _1.SQLSource();
-        const list = (0, combi_1.seq)((0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenLeft), (0, combi_1.tok)(tokens_1.WParenLeftW)), val, (0, combi_1.starPrio)((0, combi_1.seq)(",", val)), ")");
+        const listOld = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeft), val, (0, combi_1.starPrio)((0, combi_1.seq)(",", val)), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenRight), (0, combi_1.tok)(tokens_1.ParenRightW), (0, combi_1.tok)(tokens_1.WParenRightW)));
+        const listNew = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), val, (0, combi_1.starPrio)((0, combi_1.seq)(",", val)), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRight), (0, combi_1.tok)(tokens_1.WParenRightW)));
+        const list = (0, combi_1.alt)(listOld, (0, combi_1.ver)(version_1.Version.v740sp02, listNew)); // version is a guess, https://github.com/abaplint/abaplint/issues/2530
         const subSelect = (0, combi_1.seq)("(", _1.Select, ")");
         const inn = (0, combi_1.seq)("IN", (0, combi_1.altPrio)(_1.SQLSource, list, subSelect));
         const between = (0, combi_1.seq)("BETWEEN", _1.SQLSource, "AND", _1.SQLSource);

package/build/src/abap/2_statements/statements/insert_internal.js

@@ -17,7 +17,7 @@ class InsertInternal {
         const fromTo = (0, combi_1.seq)((0, combi_1.opt)(from), (0, combi_1.opt)(to));
         const foo = (0, combi_1.per)(into, ref, index, assigning);
         const lines = (0, combi_1.seq)("LINES OF", target, (0, combi_1.opt)(fromTo));
-        const src = (0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source), expressions_1.SimpleSource1);
+        const src = (0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source), expressions_1.SimpleSource4);
         const tab = (0, combi_1.seq)("TABLE", expressions_1.Source);
         const ret = (0, combi_1.seq)("INSERT", (0, combi_1.altPrio)(tab, (0, combi_1.seq)((0, combi_1.altPrio)(initial, lines, src), foo)));
         return ret;

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.90.0";
+        return "2.90.3";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/double_space.js

@@ -114,7 +114,9 @@ class DoubleSpace extends _abap_rule_1.ABAPRule {
                 const issueStartPos = new position_1.Position(prev.getRow(), prev.getCol() + 2);
                 const issueEndPos = new position_1.Position(t.getRow(), t.getCol());
                 const fix = edit_helper_1.EditHelper.deleteRange(file, issueStartPos, issueEndPos);
-                issues.push(issue_1.Issue.atRange(file, issueStartPos, issueEndPos, this.getMessage(), this.getMetadata().key, this.conf.severity, fix));
+                if (this.pragmaInRange(s.getPragmas(), issueStartPos, issueEndPos) === false) {
+                    issues.push(issue_1.Issue.atRange(file, issueStartPos, issueEndPos, this.getMessage(), this.getMetadata().key, this.conf.severity, fix));
+                }
             }
             if (this.getConfig().endParen === true
                 && prev.getRow() === t.getRow()
@@ -124,12 +126,23 @@ class DoubleSpace extends _abap_rule_1.ABAPRule {
                 const issueStartPos = new position_1.Position(prev.getEnd().getRow(), prev.getEnd().getCol() + 1);
                 const issueEndPos = new position_1.Position(t.getRow(), t.getCol());
                 const fix = edit_helper_1.EditHelper.deleteRange(file, issueStartPos, issueEndPos);
-                issues.push(issue_1.Issue.atRange(file, issueStartPos, issueEndPos, this.getMessage(), this.getMetadata().key, this.conf.severity, fix));
+                if (this.pragmaInRange(s.getPragmas(), issueStartPos, issueEndPos) === false) {
+                    issues.push(issue_1.Issue.atRange(file, issueStartPos, issueEndPos, this.getMessage(), this.getMetadata().key, this.conf.severity, fix));
+                }
             }
             prev = t;
         }
         return issues;
     }
+    pragmaInRange(pragmas, start, end) {
+        let ret = false;
+        for (const p of pragmas) {
+            if (p.getStart().isBetween(start, end)) {
+                ret = true;
+            }
+        }
+        return ret;
+    }
     checkKeywords(s, file) {
         const issues = [];
         let prev = undefined;

package/build/src/rules/downport.js

@@ -49,6 +49,7 @@ Current rules:
 * REDUCE is outlined
 * SWITCH is outlined
 * APPEND expression is outlined
+* INSERT expression is outlined
 * EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
 * CAST changed to ?=
 * LOOP AT method_call( ) is outlined
@@ -286,6 +287,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.replaceInsertExpression(high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.downportMessage(high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -507,6 +512,28 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
         }
         return undefined;
     }
+    replaceInsertExpression(high, lowFile, highSyntax) {
+        if (!(high.get() instanceof Statements.InsertInternal)) {
+            return undefined;
+        }
+        const children = high.getChildren();
+        if (children[1].get() instanceof Expressions.Source) {
+            const source = children[1];
+            const target = high.findDirectExpression(Expressions.Target);
+            if (target === undefined) {
+                return undefined;
+            }
+            const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+            const firstToken = high.getFirstToken();
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
+${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
+            const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
+            const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Outline INSERT source expression", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
     replaceTableExpression(node, lowFile, highSyntax) {
         for (const fieldChain of node.findAllExpressionsRecursive(Expressions.FieldChain)) {
             const tableExpression = fieldChain.findDirectExpression(Expressions.TableExpression);
@@ -1224,12 +1251,14 @@ ${indentation}    output = ${topTarget}.`;
                 body += indentation + uniqueName + " = " + base.concatTokens() + ".\n";
             }
             let end = "";
-            for (const forLoop of (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectExpressions(Expressions.For)) || []) {
-                const outlineFor = this.outlineFor(forLoop, indentation, lowFile, highSyntax);
-                body += outlineFor.body;
-                end = outlineFor.end + `.\n` + end;
-                indentation += "  ";
-            }
+            /*
+                  for (const forLoop of valueBody?.findDirectExpressions(Expressions.For) || []) {
+                    const outlineFor = this.outlineFor(forLoop, indentation, lowFile, highSyntax);
+                    body += outlineFor.body;
+                    end = outlineFor.end + `.\n` + end;
+                    indentation += "  ";
+                  }
+            */
             let structureName = uniqueName;
             let added = false;
             let skip = false;
@@ -1247,6 +1276,12 @@ ${indentation}    output = ${topTarget}.`;
                     }
                     body += indentation + structureName + "-" + b.concatTokens() + ".\n";
                 }
+                else if (b instanceof nodes_1.ExpressionNode && b.get() instanceof Expressions.For) {
+                    const outlineFor = this.outlineFor(b, indentation, lowFile, highSyntax);
+                    body += outlineFor.body;
+                    end = outlineFor.end + `.\n` + end;
+                    indentation += "  ";
+                }
                 else if (b.get() instanceof Expressions.Source) {
                     structureName = b.concatTokens();
                     if (base && (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectTokenByText("(")) === undefined) {
@@ -1302,6 +1337,10 @@ ${indentation}    output = ${topTarget}.`;
             }
             const found = spag.findVariable(name);
             if (found === undefined) {
+                const source = f.findFirstExpression(Expressions.Source);
+                if (source) {
+                    ret += indentation + "DATA(" + name + `) = ${source.concatTokens()}.\n`;
+                }
                 continue;
             }
             const type = found.getType().getQualifiedName() ? (_a = found.getType().getQualifiedName()) === null || _a === void 0 ? void 0 : _a.toLowerCase() : found.getType().toABAP();

package/build/src/rules/function_module_recommendations.js

@@ -12,28 +12,29 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
         /** Tuple of Function Module Name to be replaced, the recommended alternative and
          * the version from which the recommendation is valid.*/
         this.recommendations = [
-            { name: "SUBST_GET_FILE_LIST", replace: "see note 1686357" },
-            { name: "ROUND", replace: "use built in function: round()" },
-            { name: "SO_NEW_DOCUMENT_ATT_SEND_API1", replace: "use CL_BCS" },
+            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
-            { name: "SCMS_STRING_TO_XSTRING", replace: "use CL_BINARY_CONVERT" },
-            { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
-            { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
+            { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
             { name: "GUI_DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "GUI_UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
-            { name: "WS_FILENAME_GET", replace: "use CL_GUI_FRONTEND_SERVICES" },
-            { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
-            { name: "SAPGUI_PROGRESS_INDICATOR", replace: "use CL_PROGRESS_INDICATOR" },
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
-            { name: "SSFC_BASE64_DECODE", replace: "use class CL_HTTP_UTILITY methods" },
-            { name: "SSFC_BASE64_ENCODE", replace: "use class CL_HTTP_UTILITY methods" },
-            { name: "SCMS_BASE64_DECODE_STR", replace: "use class CL_HTTP_UTILITY methods" },
-            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
-            { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
-            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
-            { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
+            { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
+            { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
+            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
+            { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
+            { name: "ROUND", replace: "use built in function: round()" },
+            { name: "SAPGUI_PROGRESS_INDICATOR", replace: "use CL_PROGRESS_INDICATOR" },
+            { name: "SCMS_BASE64_DECODE_STR", replace: "use class CL_HTTP_UTILITY methods" },
+            { name: "SCMS_STRING_TO_XSTRING", replace: "use CL_BINARY_CONVERT" },
+            { name: "SO_NEW_DOCUMENT_ATT_SEND_API1", replace: "use CL_BCS" },
+            { name: "SSFC_BASE64_DECODE", replace: "use class CL_HTTP_UTILITY methods" },
+            { name: "SSFC_BASE64_ENCODE", replace: "use class CL_HTTP_UTILITY methods" },
+            { name: "SUBST_GET_FILE_LIST", replace: "see note 1686357" },
+            { name: "WS_FILENAME_GET", replace: "use CL_GUI_FRONTEND_SERVICES" },
         ];
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.90.0",
+    "version": "2.90.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -45,12 +45,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.23.1",
+        "@microsoft/api-extractor": "^7.23.2",
         "@types/chai": "^4.3.1",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^17.0.31",
+        "@types/node": "^17.0.32",
         "chai": "^4.3.6",
-        "eslint": "^8.14.0",
+        "eslint": "^8.15.0",
         "mocha": "^10.0.0",
         "c8": "^7.11.2",
         "source-map-support": "^0.5.21",
@@ -60,7 +60,7 @@
     "dependencies": {
         "fast-xml-parser": "^4.0.7",
         "json5": "^2.2.1",
-        "vscode-languageserver-protocol": "^3.16.0",
-        "vscode-languageserver-types": "^3.16.0"
+        "vscode-languageserver-protocol": "=3.16.0",
+        "vscode-languageserver-types": "=3.16.0"
     }
 }