@abaplint/core 2.89.2 → 2.89.5

package/build/src/rules/downport.js

@@ -1,13 +1,14 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Downport = exports.DownportConf = void 0;
+const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
+const Structures = require("../abap/3_structures/structures");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const issue_1 = require("../issue");
 const _irule_1 = require("./_irule");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
 const nodes_1 = require("../abap/nodes");
-const Statements = require("../abap/2_statements/statements");
-const Expressions = require("../abap/2_statements/expressions");
 const edit_helper_1 = require("../edit_helper");
 const position_1 = require("../position");
 const _abap_object_1 = require("../objects/_abap_object");
@@ -35,33 +36,34 @@ class Downport {
             key: "downport",
             title: "Downport statement",
             shortDescription: `Experimental downport functionality`,
-            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
-a higher level language version. If successful, various rules are applied to downport the statement.
-Target downport version is always v702, thus rule is only enabled if target version is v702.
-
-Current rules:
-* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
-* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
-* FIELD-SYMBOL() definitions are outlined
-* CONV is outlined
-* COND is outlined
-* REDUCE is outlined
-* SWITCH is outlined
-* APPEND expression is outlined
-* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
-* CAST changed to ?=
-* LOOP AT method_call( ) is outlined
-* VALUE # with structure fields
-* VALUE # with internal table lines
-* Table Expressions are outlined
-* SELECT INTO @DATA definitions are outlined
-* Some occurrences of string template formatting option ALPHA changed to function module call
-* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
-* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
-* RAISE EXCEPTION ... MESSAGE
-* Moving with +=, -=, /=, *=, &&= is expanded
-* line_exists and line_index is downported to READ TABLE
-
+            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
+a higher level language version. If successful, various rules are applied to downport the statement.
+Target downport version is always v702, thus rule is only enabled if target version is v702.
+
+Current rules:
+* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
+* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
+* FIELD-SYMBOL() definitions are outlined
+* CONV is outlined
+* COND is outlined
+* REDUCE is outlined
+* SWITCH is outlined
+* APPEND expression is outlined
+* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
+* CAST changed to ?=
+* LOOP AT method_call( ) is outlined
+* VALUE # with structure fields
+* VALUE # with internal table lines
+* Table Expressions are outlined
+* SELECT INTO @DATA definitions are outlined
+* Some occurrences of string template formatting option ALPHA changed to function module call
+* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
+* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
+* RAISE EXCEPTION ... MESSAGE
+* Moving with +=, -=, /=, *=, &&= is expanded
+* line_exists and line_index is downported to READ TABLE
+* ENUMs, but does not nessesarily give the correct type and value
+
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
         };
@@ -131,7 +133,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
                 const high = highStatements[i];
                 if ((low.get() instanceof _statement_1.Unknown && !(high.get() instanceof _statement_1.Unknown))
                     || high.findFirstExpression(Expressions.InlineData)) {
-                    const issue = this.checkStatement(low, high, lowFile, highSyntax);
+                    const issue = this.checkStatement(low, high, lowFile, highSyntax, highFile);
                     if (issue) {
                         ret.push(issue);
                     }
@@ -163,11 +165,15 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         this.highReg.parse();
     }
     /** applies one rule at a time, multiple iterations are required to transform complex statements */
-    checkStatement(low, high, lowFile, highSyntax) {
+    checkStatement(low, high, lowFile, highSyntax, highFile) {
         if (low.getFirstToken().getStart() instanceof position_1.VirtualPosition) {
             return undefined;
         }
-        let found = this.partiallyImplemented(high, lowFile);
+        let found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
+        if (found) {
+            return found;
+        }
+        found = this.partiallyImplemented(high, lowFile);
         if (found) {
             return found;
         }
@@ -394,10 +400,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
                 const fieldName = f.concatTokens();
                 fieldDefinition += indentation + "        " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
             }
-            fieldDefinition = `DATA: BEGIN OF ${name},
+            fieldDefinition = `DATA: BEGIN OF ${name},
 ${fieldDefinition}${indentation}      END OF ${name}.`;
         }
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
 ${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -438,12 +444,12 @@ ${indentation}`);
         }
         const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
-        let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
-${fieldDefinitions}${indentation}      END OF ${uniqueName}.
-${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
+        let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
+${fieldDefinitions}${indentation}      END OF ${uniqueName}.
+${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
 ${indentation}`);
         if (fieldDefinitions === "") {
-            fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
+            fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
 ${indentation}`);
         }
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
@@ -464,7 +470,7 @@ ${indentation}`);
             const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             const firstToken = high.getFirstToken();
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
 ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -503,14 +509,14 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
             const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const firstToken = node.getFirstToken();
             // note that the tabix restore should be done before throwing the exception
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
-${indentation}DATA ${tabixBackup} LIKE sy-tabix.
-${indentation}${tabixBackup} = sy-tabix.
-${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
-${indentation}sy-tabix = ${tabixBackup}.
-${indentation}IF sy-subrc <> 0.
-${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
-${indentation}ENDIF.
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
+${indentation}DATA ${tabixBackup} LIKE sy-tabix.
+${indentation}${tabixBackup} = sy-tabix.
+${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
+${indentation}sy-tabix = ${tabixBackup}.
+${indentation}IF sy-subrc <> 0.
+${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
+${indentation}ENDIF.
 ${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -564,7 +570,7 @@ ${indentation}`);
         const className = classNames[0].concatTokens();
         const targetName = (_b = target.findFirstExpression(Expressions.TargetField)) === null || _b === void 0 ? void 0 : _b.concatTokens();
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-        const code = `  DATA ${targetName} TYPE REF TO ${className}.
+        const code = `  DATA ${targetName} TYPE REF TO ${className}.
 ${indentation}CATCH ${className} INTO ${targetName}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), code);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
@@ -675,11 +681,11 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
             const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-            const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
-${indentation}${uniqueName1}-msgid = ${id}.
-${indentation}${uniqueName1}-msgno = ${number}.
-${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
-${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
+            const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
+${indentation}${uniqueName1}-msgid = ${id}.
+${indentation}${uniqueName1}-msgno = ${number}.
+${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
+${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
 ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
             const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
             return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
@@ -738,6 +744,38 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, start, end, code);
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, simple move", this.getMetadata().key, this.conf.severity, fix);
     }
+    // note, downporting ENUM does not give the correct types, but it will work in most cases?
+    downportEnum(_low, high, lowFile, _highSyntax, highFile) {
+        var _a, _b, _c, _d, _e;
+        if (!(high.get() instanceof Statements.TypeEnumBegin)) {
+            return undefined;
+        }
+        const enumStructure = (_a = highFile.getStructure()) === null || _a === void 0 ? void 0 : _a.findFirstStructure(Structures.TypeEnum);
+        if (enumStructure === undefined) {
+            return undefined;
+        }
+        if (enumStructure.getFirstStatement() !== high) {
+            return undefined;
+        }
+        const enumName = (_b = high.findExpressionAfterToken("ENUM")) === null || _b === void 0 ? void 0 : _b.concatTokens();
+        const structureName = (_c = high.findExpressionAfterToken("STRUCTURE")) === null || _c === void 0 ? void 0 : _c.concatTokens();
+        let code = `TYPES ${enumName} TYPE i.
+CONSTANTS: BEGIN OF ${structureName},\n`;
+        let count = 1;
+        for (const e of enumStructure.findDirectStatements(Statements.TypeEnum).concat(enumStructure.findDirectStatements(Statements.Type))) {
+            const name = (_d = e.findFirstExpression(Expressions.NamespaceSimpleName)) === null || _d === void 0 ? void 0 : _d.concatTokens();
+            let value = (_e = e.findFirstExpression(Expressions.Value)) === null || _e === void 0 ? void 0 : _e.concatTokens();
+            if (value === undefined) {
+                value = "VALUE " + count++;
+            }
+            code += `             ${name} TYPE ${enumName} ${value},\n`;
+        }
+        code += `           END OF ${structureName}.`;
+        const start = enumStructure.getFirstToken().getStart();
+        const end = enumStructure.getLastToken().getEnd();
+        const fix = edit_helper_1.EditHelper.replaceRange(lowFile, start, end, code);
+        return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport ENUM", this.getMetadata().key, this.conf.severity, fix);
+    }
     moveWithTableTarget(node, high, lowFile, highSyntax) {
         var _a;
         if (!(high.get() instanceof Statements.Move)) {
@@ -762,14 +800,14 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
         const tabixBackup = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
         // restore tabix before exeption
-        const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
-${indentation}DATA ${tabixBackup} LIKE sy-tabix.
-${indentation}${tabixBackup} = sy-tabix.
-${indentation}READ TABLE ${tName} ${condition}ASSIGNING ${uniqueName}.
-${indentation}sy-tabix = ${tabixBackup}.
-${indentation}IF sy-subrc <> 0.
-${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
-${indentation}ENDIF.
+        const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
+${indentation}DATA ${tabixBackup} LIKE sy-tabix.
+${indentation}${tabixBackup} = sy-tabix.
+${indentation}READ TABLE ${tName} ${condition}ASSIGNING ${uniqueName}.
+${indentation}sy-tabix = ${tabixBackup}.
+${indentation}IF sy-subrc <> 0.
+${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
+${indentation}ENDIF.
 ${indentation}${uniqueName}`;
         const start = target.getFirstToken().getStart();
         const end = (_a = tableExpression.findDirectTokenByText("]")) === null || _a === void 0 ? void 0 : _a.getEnd();
@@ -857,10 +895,10 @@ ${indentation}${uniqueName}`;
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
         const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
         const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
-        const code = `CALL FUNCTION '${functionName}'
-${indentation}  EXPORTING
-${indentation}    input  = ${source}
-${indentation}  IMPORTING
+        const code = `CALL FUNCTION '${functionName}'
+${indentation}  EXPORTING
+${indentation}    input  = ${source}
+${indentation}  IMPORTING
 ${indentation}    output = ${topTarget}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
@@ -1164,6 +1202,9 @@ ${indentation}    output = ${topTarget}.`;
                 }
                 else if (b.get() instanceof Expressions.Source) {
                     structureName = b.concatTokens();
+                    if (base && (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectTokenByText("(")) === undefined) {
+                        structureName = uniqueName;
+                    }
                 }
                 else if (b.get() instanceof Expressions.ValueBodyLines) {
                     body += indentation + "APPEND " + b.concatTokens() + ` TO ${uniqueName}.\n`;
@@ -1310,7 +1351,10 @@ ${indentation}    output = ${topTarget}.`;
             else if (found.getType() instanceof basic_1.VoidType && found.getType().getQualifiedName() === undefined) {
                 continue;
             }
-            const type = found.getType().getQualifiedName() ? (_b = found.getType().getQualifiedName()) === null || _b === void 0 ? void 0 : _b.toLowerCase() : found.getType().toABAP();
+            let type = found.getType().getQualifiedName() ? (_b = found.getType().getQualifiedName()) === null || _b === void 0 ? void 0 : _b.toLowerCase() : found.getType().toABAP();
+            if (found.getType() instanceof basic_1.ObjectReferenceType) {
+                type = found.getType().toABAP();
+            }
             const code = `DATA ${name} TYPE ${type}.\n` +
                 " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);

package/build/src/rules/exit_or_check.js

@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
         return {
             key: "exit_or_check",
             title: "Find EXIT or CHECK outside loops",
-            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
+            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
 Use RETURN to leave procesing blocks instead.`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
-https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };

package/build/src/rules/exporting.js

@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
             shortDescription: `Detects EXPORTING statements which can be omitted.`,
             badExample: `call_method( EXPORTING foo = bar ).`,
             goodExample: `call_method( foo = bar ).`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
 https://docs.abapopenchecks.org/checks/30/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_identifier.js

@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
             key: "forbidden_identifier",
             title: "Forbidden Identifier",
             shortDescription: `Forbid use of specified identifiers, list of regex.`,
-            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
+            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
 https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_void_type.js

@@ -28,8 +28,8 @@ class ForbiddenVoidType {
             key: "forbidden_void_type",
             title: "Forbidden Void Types",
             shortDescription: `Avoid usage of specified void types.`,
-            extendedInformation: `Inspiration:
-BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
+            extendedInformation: `Inspiration:
+BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
 DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
         };
     }

package/build/src/rules/functional_writing.js

@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
             key: "functional_writing",
             title: "Use functional writing",
             shortDescription: `Detects usage of call method when functional style calls can be used.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
 https://docs.abapopenchecks.org/checks/07/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `CALL METHOD zcl_class=>method( ).
-CALL METHOD cl_abap_typedescr=>describe_by_name
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            badExample: `CALL METHOD zcl_class=>method( ).
+CALL METHOD cl_abap_typedescr=>describe_by_name
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2.`,
-            goodExample: `zcl_class=>method( ).
-cl_abap_typedescr=>describe_by_name(
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            goodExample: `zcl_class=>method( ).
+cl_abap_typedescr=>describe_by_name(
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2 ).`,
         };
     }

package/build/src/rules/global_class.js

@@ -19,14 +19,14 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
             key: "global_class",
             title: "Global class checks",
             shortDescription: `Checks related to global classes`,
-            extendedInformation: `* global classes must be in own files
-
-* file names must match class name
-
-* file names must match interface name
-
-* global classes must be global definitions
-
+            extendedInformation: `* global classes must be in own files
+
+* file names must match class name
+
+* file names must match interface name
+
+* global classes must be global definitions
+
 * global interfaces must be global definitions`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/identical_conditions.js

@@ -33,8 +33,8 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
         return {
             key: "identical_conditions",
             title: "Identical conditions",
-            shortDescription: `Find identical conditions in IF + CASE + WHILE etc
-
+            shortDescription: `Find identical conditions in IF + CASE + WHILE etc
+
 Prerequsites: code is pretty printed with identical cAsE`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/identical_contents.js

@@ -20,23 +20,23 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
             key: "identical_contents",
             title: "Identical contents",
             shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
-            extendedInformation: `
-Prerequsites: code is pretty printed with identical cAsE
-
+            extendedInformation: `
+Prerequsites: code is pretty printed with identical cAsE
+
 Chained statments are ignored`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `IF foo = bar.
-  WRITE 'bar'.
-  WRITE 'world'.
-ELSE.
-  WRITE 'foo'.
-  WRITE 'world'.
+            badExample: `IF foo = bar.
+  WRITE 'bar'.
+  WRITE 'world'.
+ELSE.
+  WRITE 'foo'.
+  WRITE 'world'.
 ENDIF.`,
-            goodExample: `IF foo = bar.
-  WRITE 'bar'.
-ELSE.
-  WRITE 'foo'.
-ENDIF.
+            goodExample: `IF foo = bar.
+  WRITE 'bar'.
+ELSE.
+  WRITE 'foo'.
+ENDIF.
 WRITE 'world'.`,
         };
     }

package/build/src/rules/identical_descriptions.js

@@ -16,10 +16,10 @@ class IdenticalDescriptions {
             key: "identical_descriptions",
             title: "Identical descriptions",
             shortDescription: `Searches for objects with the same type and same description`,
-            extendedInformation: `Case insensitive
-
-Only checks the master language descriptions
-
+            extendedInformation: `Case insensitive
+
+Only checks the master language descriptions
+
 Works for: INTF, CLAS, DOMA, DTEL, FUNC in same FUGR`,
             tags: [],
         };

package/build/src/rules/if_in_if.js

@@ -19,15 +19,15 @@ class IfInIf extends _abap_rule_1.ABAPRule {
             key: "if_in_if",
             title: "IF in IF",
             shortDescription: `Detects nested ifs which can be refactored to a single condition using AND.`,
-            extendedInformation: `https://docs.abapopenchecks.org/checks/01/
+            extendedInformation: `https://docs.abapopenchecks.org/checks/01/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low`,
-            badExample: `IF condition1.
-  IF condition2.
-    ...
-  ENDIF.
+            badExample: `IF condition1.
+  IF condition2.
+    ...
+  ENDIF.
 ENDIF.`,
-            goodExample: `IF ( condition1 ) AND ( condition2 ).
-  ...
+            goodExample: `IF ( condition1 ) AND ( condition2 ).
+  ...
 ENDIF.`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/implement_methods.js

@@ -102,9 +102,9 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
         for (const i of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.ClassImplementation)) || []) {
             const name = (_b = i.findFirstExpression(Expressions.ClassName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase();
             if (name === impl.identifier.getName().toUpperCase()) {
-                return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
-  METHOD ${methodName.toLowerCase()}.
-    RETURN. " todo, implement method
+                return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
+  METHOD ${methodName.toLowerCase()}.
+    RETURN. " todo, implement method
   ENDMETHOD.`);
             }
         }

package/build/src/rules/in_statement_indentation.js

@@ -31,19 +31,19 @@ class InStatementIndentation extends _abap_rule_1.ABAPRule {
             key: "in_statement_indentation",
             title: "In-statement indentation",
             shortDescription: "Checks alignment within statements which span multiple lines.",
-            extendedInformation: `Lines following the first line should be indented once (2 spaces).
-      
-For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
+            extendedInformation: `Lines following the first line should be indented once (2 spaces).
+      
+For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
 to distinguish them better from code within the block.`,
-            badExample: `IF 1 = 1
-  AND 2 = 2.
-  WRITE 'hello' &&
-  'world'.
+            badExample: `IF 1 = 1
+  AND 2 = 2.
+  WRITE 'hello' &&
+  'world'.
 ENDIF.`,
-            goodExample: `IF 1 = 1
-    AND 2 = 2.
-  WRITE 'hello' &&
-    'world'.
+            goodExample: `IF 1 = 1
+    AND 2 = 2.
+  WRITE 'hello' &&
+    'world'.
 ENDIF.`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/intf_referencing_clas.js

@@ -26,9 +26,9 @@ class IntfReferencingClas {
             key: "intf_referencing_clas",
             title: "INTF referencing CLAS",
             shortDescription: `Interface contains references to class`,
-            extendedInformation: `Only global interfaces are checked.
-      Only first level references are checked.
-      Exception class references are ignored.
+            extendedInformation: `Only global interfaces are checked.
+      Only first level references are checked.
+      Exception class references are ignored.
       Void references are ignored.`,
         };
     }

package/build/src/rules/line_break_style.js

@@ -15,8 +15,8 @@ class LineBreakStyle {
         return {
             key: "line_break_style",
             title: "Makes sure line breaks are consistent in the ABAP code",
-            shortDescription: `Enforces LF as newlines in ABAP files
-
+            shortDescription: `Enforces LF as newlines in ABAP files
+
 abapGit does not work with CRLF`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/line_length.js

@@ -23,7 +23,7 @@ class LineLength extends _abap_rule_1.ABAPRule {
             key: "line_length",
             title: "Line length",
             shortDescription: `Detects lines exceeding the provided maximum length.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
 https://docs.abapopenchecks.org/checks/04/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/line_only_punc.js

@@ -27,7 +27,7 @@ class LineOnlyPunc extends _abap_rule_1.ABAPRule {
             key: "line_only_punc",
             title: "Line containing only punctuation",
             shortDescription: `Detects lines containing only punctuation.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
 https://docs.abapopenchecks.org/checks/16/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
             badExample: "zcl_class=>method(\n).",

package/build/src/rules/local_variable_names.js

@@ -30,8 +30,8 @@ class LocalVariableNames extends _abap_rule_1.ABAPRule {
         return {
             key: "local_variable_names",
             title: "Local variable naming conventions",
-            shortDescription: `
-Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
+            shortDescription: `
+Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
 Regexes are case-insensitive.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/many_parentheses.js

@@ -23,17 +23,17 @@ class ManyParentheses extends _abap_rule_1.ABAPRule {
             title: "Too many parentheses",
             shortDescription: `Searches for expressions where extra parentheses can safely be removed`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
-            badExample: `
-IF ( destination IS INITIAL ).
-ENDIF.
-IF foo = boo AND ( bar = lar AND moo = loo ).
-ENDIF.
+            badExample: `
+IF ( destination IS INITIAL ).
+ENDIF.
+IF foo = boo AND ( bar = lar AND moo = loo ).
+ENDIF.
 `,
-            goodExample: `
-IF destination IS INITIAL.
-ENDIF.
-IF foo = boo AND bar = lar AND moo = loo.
-ENDIF.
+            goodExample: `
+IF destination IS INITIAL.
+ENDIF.
+IF foo = boo AND bar = lar AND moo = loo.
+ENDIF.
 `,
         };
     }