@abaplint/core 2.89.0 → 2.89.3

package/build/src/abap/5_syntax/basic_types.js

@@ -623,7 +623,7 @@ class BasicTypes {
             const search = this.scope.existsObject(name);
             if (search.found === true && search.id) {
                 this.scope.addReference(chain.getFirstToken(), search.id, _reference_1.ReferenceType.ObjectOrientedReference, this.filename, { ooType: search.ooType, ooName: name });
-                return new Types.ObjectReferenceType(search.id);
+                return new Types.ObjectReferenceType(search.id, name);
             }
         }
         const found = this.resolveTypeName(chain);

package/build/src/abap/5_syntax/expressions/cast.js

@@ -30,12 +30,14 @@ class Cast {
                 tt = new basic_1.VoidType(typeName);
             }
             else if (found === undefined) {
+                // todo, this should be an UnknownType instead?
                 throw new Error("Type \"" + typeName + "\" not found in scope, Cast");
             }
             else {
                 tt = new basic_1.ObjectReferenceType(found);
             }
         }
+        new source_1.Source().addIfInferred(node, scope, filename, tt);
         if (new _type_utils_1.TypeUtils(scope).isCastable(sourceType, tt) === false) {
             throw new Error("Cast, incompatible types");
         }

package/build/src/abap/5_syntax/expressions/source.js

@@ -176,6 +176,13 @@ class Source {
             if (found) {
                 scope.addReference(typeToken, found, _reference_1.ReferenceType.InferredType, filename);
             }
+            else if (inferredType instanceof basic_1.ObjectReferenceType) {
+                const def = scope.findObjectDefinition(inferredType.getQualifiedName());
+                if (def) {
+                    const tid = new _typed_identifier_1.TypedIdentifier(typeToken, filename, inferredType);
+                    scope.addReference(typeToken, tid, _reference_1.ReferenceType.InferredType, filename);
+                }
+            }
             else if (inferredType instanceof basic_1.CharacterType) {
                 // character is bit special it does not have a qualified name eg "TYPE c LENGTH 6"
                 const tid = new _typed_identifier_1.TypedIdentifier(typeToken, filename, inferredType);
@@ -198,10 +205,18 @@ class Source {
             }
             return targetType;
         }
-        if (typeName !== "#") {
+        if (typeName !== "#" && typeToken) {
             const found = basic.parseType(typeExpression);
-            if (found === undefined && scope.getDDIC().inErrorNamespace(typeName) === false) {
-                return new basic_1.VoidType(typeName);
+            if (found && found instanceof unknown_type_1.UnknownType) {
+                if (scope.getDDIC().inErrorNamespace(typeName) === false) {
+                    scope.addReference(typeToken, undefined, _reference_1.ReferenceType.VoidType, filename);
+                    return new basic_1.VoidType(typeName);
+                }
+                else {
+                    const tid = new _typed_identifier_1.TypedIdentifier(typeToken, filename, found);
+                    scope.addReference(typeToken, tid, _reference_1.ReferenceType.TypeReference, filename);
+                    return found;
+                }
             }
             else if (found === undefined) {
                 throw new Error("Type \"" + typeName + "\" not found in scope, VALUE");

package/build/src/abap/5_syntax/statements/find.js

@@ -18,12 +18,12 @@ class Find {
                 { name: "OFFSET", type: new basic_1.IntegerType() },
                 { name: "LENGTH", type: new basic_1.IntegerType() },
                 { name: "SUBMATCHES", type: new basic_1.TableType(new basic_1.StringType(), { withHeader: false }) },
-            ]);
+            ], "MATCH_RESULT");
             if (node.concatTokens().toUpperCase().startsWith("FIND FIRST")) {
                 this.inline(rfound, scope, filename, type);
             }
             else {
-                this.inline(rfound, scope, filename, new basic_1.TableType(type, { withHeader: false }));
+                this.inline(rfound, scope, filename, new basic_1.TableType(type, { withHeader: false }, "MATCH_RESULT_TAB"));
             }
         }
         const ofound = node.findExpressionsAfterToken("OFFSET");

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.89.0";
+        return "2.89.3";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -1310,7 +1310,10 @@ ${indentation}    output = ${topTarget}.`;
             else if (found.getType() instanceof basic_1.VoidType && found.getType().getQualifiedName() === undefined) {
                 continue;
             }
-            const type = found.getType().getQualifiedName() ? (_b = found.getType().getQualifiedName()) === null || _b === void 0 ? void 0 : _b.toLowerCase() : found.getType().toABAP();
+            let type = found.getType().getQualifiedName() ? (_b = found.getType().getQualifiedName()) === null || _b === void 0 ? void 0 : _b.toLowerCase() : found.getType().toABAP();
+            if (found.getType() instanceof basic_1.ObjectReferenceType) {
+                type = found.getType().toABAP();
+            }
             const code = `DATA ${name} TYPE ${type}.\n` +
                 " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);

package/build/src/rules/no_inline_in_optional_branches.js

@@ -7,6 +7,7 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const Structures = require("../abap/3_structures/structures");
 const Expressions = require("../abap/2_statements/expressions");
 const _irule_1 = require("./_irule");
+const version_1 = require("../version");
 class NoInlineInOptionalBranchesConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.NoInlineInOptionalBranchesConf = NoInlineInOptionalBranchesConf;
@@ -43,6 +44,12 @@ Not considered optional branches:
     }
     runParsed(file) {
         const output = [];
+        const version = this.reg.getConfig().getVersion();
+        if (version === version_1.Version.v700
+            || version === version_1.Version.v702
+            || version === version_1.Version.OpenABAP) {
+            return [];
+        }
         const struc = file.getStructure();
         if (struc === undefined) {
             return []; // syntax error
@@ -60,7 +67,7 @@ Not considered optional branches:
             const inline = c.findFirstExpression(Expressions.InlineData);
             if (inline) {
                 const message = "Don't declare inline in optional branches";
-                const issue = issue_1.Issue.atToken(file, c.getFirstToken(), message, this.getMetadata().key, this.getConfig().severity);
+                const issue = issue_1.Issue.atToken(file, inline.getFirstToken(), message, this.getMetadata().key, this.getConfig().severity);
                 output.push(issue);
             }
         }

package/build/src/rules/unknown_types.js

@@ -10,6 +10,7 @@ const _irule_1 = require("./_irule");
 const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const _scope_type_1 = require("../abap/5_syntax/_scope_type");
 const _reference_1 = require("../abap/5_syntax/_reference");
+const basic_1 = require("../abap/types/basic");
 class UnknownTypesConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.UnknownTypesConf = UnknownTypesConf;
@@ -70,6 +71,12 @@ class UnknownTypes {
                 const message = r.extra.ooName + " unknown";
                 ret.push(issue_1.Issue.atIdentifier(r.position, message, this.getMetadata().key, this.conf.severity));
             }
+            if (r.referenceType === _reference_1.ReferenceType.TypeReference
+                && r.resolved instanceof _typed_identifier_1.TypedIdentifier
+                && r.resolved.getType() instanceof basic_1.UnknownType) {
+                const message = r.resolved.getType().getError();
+                ret.push(issue_1.Issue.atIdentifier(r.position, message, this.getMetadata().key, this.conf.severity));
+            }
         }
         if (node.getIdentifier().stype !== _scope_type_1.ScopeType.ClassImplementation) {
             const vars = nodeData.vars;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.89.0",
+    "version": "2.89.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,11 +48,11 @@
         "@microsoft/api-extractor": "^7.22.2",
         "@types/chai": "^4.3.1",
         "@types/mocha": "^9.1.0",
-        "@types/node": "^17.0.24",
+        "@types/node": "^17.0.25",
         "chai": "^4.3.6",
         "eslint": "^8.13.0",
         "mocha": "^9.2.2",
-        "c8": "^7.11.0",
+        "c8": "^7.11.2",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^1.0.0",
         "typescript": "^4.6.3"