@abaplint/core 2.88.2 → 2.88.5

package/build/src/abap/5_syntax/basic_types.js

@@ -199,7 +199,18 @@ class BasicTypes {
         if (nameExpr.countTokens() > 1) { // workaround for names with dashes
             name = new identifier_1.Identifier(name.getStart(), nameExpr.concatTokens());
         }
-        const found = this.parseType(node, this.scope.isTypePool() ? name.getStr() : undefined);
+        let qualifiedName = undefined;
+        if (this.scope.isTypePool() === true) {
+            qualifiedName = name.getStr();
+        }
+        else {
+            qualifiedName = name.getStr();
+            if (this.scope.getType() === _scope_type_1.ScopeType.ClassDefinition
+                || this.scope.getType() === _scope_type_1.ScopeType.Interface) {
+                qualifiedName = this.scope.getName() + "=>" + qualifiedName;
+            }
+        }
+        const found = this.parseType(node, qualifiedName);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name, this.filename, found);
         }
@@ -301,9 +312,9 @@ class BasicTypes {
         // fallback to old style syntax, OCCURS etc
         return this.parseType(node, name);
     }
-    parseType(node, name) {
+    parseType(node, qualifiedName) {
         var _a, _b, _c, _d, _e, _f;
-        const typename = node.findFirstExpression(Expressions.TypeName);
+        const typeName = node.findFirstExpression(Expressions.TypeName);
         let text = (_a = node.findFirstExpression(Expressions.Type)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
         if (text === undefined) {
             text = (_b = node.findFirstExpression(Expressions.TypeParam)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
@@ -369,7 +380,7 @@ class BasicTypes {
             }
             found = this.resolveLikeName(sub);
             if (found && text.includes(" OCCURS ")) {
-                found = new Types.TableType(found, { withHeader: text.includes("WITH HEADER LINE") }, name);
+                found = new Types.TableType(found, { withHeader: text.includes("WITH HEADER LINE") }, qualifiedName);
             }
         }
         else if (text.startsWith("TYPE LINE OF ")) {
@@ -392,13 +403,13 @@ class BasicTypes {
             }
         }
         else if (text.startsWith("TYPE REF TO ")) {
-            found = this.resolveTypeRef(typename);
+            found = this.resolveTypeRef(typeName);
         }
         else if (text.startsWith("TYPE")) {
-            found = this.resolveTypeName(typename, this.findLength(node), this.findDecimals(node), name);
+            found = this.resolveTypeName(typeName, this.findLength(node), this.findDecimals(node), qualifiedName);
             const concat = node.concatTokens().toUpperCase();
             if (found && concat.includes(" OCCURS ")) {
-                found = new Types.TableType(found, { withHeader: concat.includes("WITH HEADER LINE") }, name);
+                found = new Types.TableType(found, { withHeader: concat.includes("WITH HEADER LINE") }, qualifiedName);
             }
             else if (found && concat.includes("WITH HEADER LINE")) {
                 if (found instanceof Types.VoidType) {
@@ -411,7 +422,7 @@ class BasicTypes {
                     found = new Types.TableType(found.getRowType(), { withHeader: true });
                 }
             }
-            if (found === undefined && typename === undefined) {
+            if (found === undefined && typeName === undefined) {
                 let length = 1;
                 const len = node.findDirectExpression(Expressions.ConstantFieldLength);
                 if (len) {
@@ -420,9 +431,9 @@ class BasicTypes {
                         length = parseInt(int.concatTokens(), 10);
                     }
                 }
-                found = new Types.CharacterType(length, name); // fallback
+                found = new Types.CharacterType(length, qualifiedName); // fallback
                 if (concat.includes(" OCCURS ")) {
-                    found = new Types.TableType(found, { withHeader: concat.includes("WITH HEADER LINE") }, name);
+                    found = new Types.TableType(found, { withHeader: concat.includes("WITH HEADER LINE") }, qualifiedName);
                 }
             }
         }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.88.2";
+        return "2.88.5";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -499,13 +499,17 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
             }
             const condition = this.tableCondition(tableExpression);
             const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const tabixBackup = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const firstToken = node.getFirstToken();
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
+${indentation}DATA ${tabixBackup} LIKE sy-tabix.
+${indentation}${tabixBackup} = sy-tabix.
 ${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
 ${indentation}IF sy-subrc <> 0.
 ${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
 ${indentation}ENDIF.
+${indentation}sy-tabix = ${tabixBackup}.
 ${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -754,12 +758,16 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
         uniqueName = `<${uniqueName}>`;
         const tName = target.concatTokens().split("[")[0];
         const condition = this.tableCondition(tableExpression);
+        const tabixBackup = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
         const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
+${indentation}DATA ${tabixBackup} LIKE sy-tabix.
+${indentation}${tabixBackup} = sy-tabix.
 ${indentation}READ TABLE ${tName} ${condition}ASSIGNING ${uniqueName}.
 ${indentation}IF sy-subrc <> 0.
 ${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
 ${indentation}ENDIF.
+${indentation}sy-tabix = ${tabixBackup}.
 ${indentation}${uniqueName}`;
         const start = target.getFirstToken().getStart();
         const end = (_a = tableExpression.findDirectTokenByText("]")) === null || _a === void 0 ? void 0 : _a.getEnd();
@@ -924,6 +932,7 @@ ${indentation}    output = ${topTarget}.`;
             || forLoop.findDirectTokenByText("WHILE")) {
             const fieldDef = forLoop.findDirectExpression(Expressions.InlineFieldDefinition);
             const field = (_d = fieldDef === null || fieldDef === void 0 ? void 0 : fieldDef.findFirstExpression(Expressions.Field)) === null || _d === void 0 ? void 0 : _d.concatTokens();
+            const indexBackup = this.uniqueName(forLoop.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             body += indentation + "DATA " + field + " TYPE i.\n";
             const second = fieldDef === null || fieldDef === void 0 ? void 0 : fieldDef.getChildren()[2];
             if ((second === null || second === void 0 ? void 0 : second.get()) instanceof Expressions.Source) {
@@ -931,15 +940,26 @@ ${indentation}    output = ${topTarget}.`;
             }
             const not = forLoop.findDirectTokenByText("UNTIL") ? " NOT" : "";
             const cond = forLoop.findFirstExpression(Expressions.Cond);
+            body += indentation + `DATA ${indexBackup} LIKE sy-index.\n`;
+            body += indentation + `${indexBackup} = sy-index.\n`;
             body += indentation + `WHILE${not} ${cond === null || cond === void 0 ? void 0 : cond.concatTokens()}.\n`;
-            end += `  ${field} = ${field} + 1.\n`;
+            body += indentation + `  sy-index = ${indexBackup}.\n`;
+            const then = forLoop.findExpressionAfterToken("THEN");
+            if (then) {
+                end += `  ${field} = ${then.concatTokens()}.\n`;
+            }
+            else {
+                end += `  ${field} = ${field} + 1.\n`;
+            }
             end += indentation + "ENDWHILE";
         }
         else if (loopTargetField) {
+            // todo, also backup sy-index / sy-tabix here?
             body += indentation + `LOOP AT ${loopSource} INTO DATA(${loopTargetField})${cond}.\n`;
             end = "ENDLOOP";
         }
         else if (loopTargetField === undefined) {
+            // todo, also backup sy-index / sy-tabix here?
             const loopTargetFieldSymbol = (_e = forLoop.findFirstExpression(Expressions.TargetFieldSymbol)) === null || _e === void 0 ? void 0 : _e.concatTokens();
             body += indentation + `LOOP AT ${loopSource} ASSIGNING FIELD-SYMBOL(${loopTargetFieldSymbol})${cond}.\n`;
             end = "ENDLOOP";

package/build/src/rules/message_exists.js

@@ -6,6 +6,7 @@ const issue_1 = require("../issue");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const ddic_1 = require("../ddic");
+const _irule_1 = require("./_irule");
 class MessageExistsConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.MessageExistsConf = MessageExistsConf;
@@ -19,6 +20,7 @@ class MessageExistsRule extends _abap_rule_1.ABAPRule {
             key: "message_exists",
             title: "Check MESSAGE exists",
             shortDescription: `In message statements, check that the message class + id exist`,
+            tags: [_irule_1.RuleTag.Syntax],
         };
     }
     getConfig() {

package/build/src/rules/sicf_consistency.js

@@ -16,9 +16,8 @@ class SICFConsistency {
         return {
             key: "sicf_consistency",
             title: "SICF consistency",
-            shortDescription: `Checks the validity of ICF services:
-
-* Class defined in handler must exist
+            shortDescription: `Checks the validity of ICF services`,
+            extendedInformation: `* Class defined in handler must exist
 * Class must not have any syntax errors
 * Class must implement interface IF_HTTP_EXTENSION`,
         };

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.88.2",
+    "version": "2.88.5",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",