@abaplint/core 2.88.10 → 2.89.2

package/build/abaplint.d.ts

@@ -741,6 +741,7 @@ declare class Class extends ABAPObject {
     getNameFromXML(): string | undefined;
     getCategory(): string | undefined;
     getLocalsImpFile(): ABAPFile | undefined;
+    getTestclassFile(): ABAPFile | undefined;
     private parseXML;
 }
 
@@ -2652,7 +2653,8 @@ export declare const enum IdentifierMeta {
     BuiltIn = "built-in",
     DDIC = "ddic",
     Static = "static",
-    Enum = "enum"
+    Enum = "enum",
+    SelectionScreenTab = "selection_screen_tab"
 }
 
 export declare interface IDependency {

package/build/src/abap/5_syntax/expressions/source.js

@@ -198,10 +198,18 @@ class Source {
             }
             return targetType;
         }
-        if (typeName !== "#") {
+        if (typeName !== "#" && typeToken) {
             const found = basic.parseType(typeExpression);
-            if (found === undefined && scope.getDDIC().inErrorNamespace(typeName) === false) {
-                return new basic_1.VoidType(typeName);
+            if (found && found instanceof unknown_type_1.UnknownType) {
+                if (scope.getDDIC().inErrorNamespace(typeName) === false) {
+                    scope.addReference(typeToken, undefined, _reference_1.ReferenceType.VoidType, filename);
+                    return new basic_1.VoidType(typeName);
+                }
+                else {
+                    const tid = new _typed_identifier_1.TypedIdentifier(typeToken, filename, found);
+                    scope.addReference(typeToken, tid, _reference_1.ReferenceType.TypeReference, filename);
+                    return found;
+                }
             }
             else if (found === undefined) {
                 throw new Error("Type \"" + typeName + "\" not found in scope, VALUE");

package/build/src/abap/5_syntax/statements/data.js

@@ -5,8 +5,13 @@ const Expressions = require("../../2_statements/expressions");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const data_definition_1 = require("../expressions/data_definition");
 const unknown_type_1 = require("../../types/basic/unknown_type");
+const basic_types_1 = require("../basic_types");
 class Data {
     runSyntax(node, scope, filename) {
+        const val = node.findFirstExpression(Expressions.Value);
+        if (val) {
+            new basic_types_1.BasicTypes(filename, scope).findValue(node);
+        }
         const dd = node.findFirstExpression(Expressions.DataDefinition);
         if (dd) {
             return new data_definition_1.DataDefinition().runSyntax(dd, scope, filename);

package/build/src/abap/5_syntax/statements/find.js

@@ -18,12 +18,12 @@ class Find {
                 { name: "OFFSET", type: new basic_1.IntegerType() },
                 { name: "LENGTH", type: new basic_1.IntegerType() },
                 { name: "SUBMATCHES", type: new basic_1.TableType(new basic_1.StringType(), { withHeader: false }) },
-            ]);
+            ], "MATCH_RESULT");
             if (node.concatTokens().toUpperCase().startsWith("FIND FIRST")) {
                 this.inline(rfound, scope, filename, type);
             }
             else {
-                this.inline(rfound, scope, filename, new basic_1.TableType(type, { withHeader: false }));
+                this.inline(rfound, scope, filename, new basic_1.TableType(type, { withHeader: false }, "MATCH_RESULT_TAB"));
             }
         }
         const ofound = node.findExpressionsAfterToken("OFFSET");

package/build/src/abap/5_syntax/statements/selection_screen.js

@@ -18,7 +18,10 @@ class SelectionScreen {
                 { name: "DYNNR", type: new basic_1.CharacterType(4) },
                 { name: "ACTIVETAB", type: new basic_1.CharacterType(132) },
             ]);
-            scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(name, filename, type));
+            scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(name, filename, type, ["selection_screen_tab" /* SelectionScreenTab */]));
+        }
+        else if (concat.startsWith("SELECTION-SCREEN TAB")) {
+            scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(name, filename, new basic_1.CharacterType(83), ["selection_screen_tab" /* SelectionScreenTab */]));
         }
         else {
             scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(name, filename, new basic_1.CharacterType(83)));

package/build/src/objects/class.js

@@ -78,6 +78,14 @@ class Class extends _abap_object_1.ABAPObject {
         }
         return undefined;
     }
+    getTestclassFile() {
+        for (const file of this.getABAPFiles()) {
+            if (file.getFilename().endsWith(".clas.testclasses.abap")) {
+                return file;
+            }
+        }
+        return undefined;
+    }
     /////////////////////////
     parseXML() {
         if (this.parsedXML !== undefined) {

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.88.10";
+        return "2.89.2";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/check_transformation_exists.js

@@ -40,13 +40,15 @@ class CheckTransformationExists extends _abap_rule_1.ABAPRule {
         }
         for (const s of file.getStatements()) {
             if (s.get() instanceof statements_1.CallTransformation) {
-                const name = s.findFirstExpression(expressions_1.NamespaceSimpleName);
-                if (name === undefined) {
+                const nameExpression = s.findFirstExpression(expressions_1.NamespaceSimpleName);
+                if (nameExpression === undefined) {
                     continue;
                 }
-                const tok = name.getFirstToken();
-                if (this.reg.getObject("XSLT", tok.getStr()) === undefined) {
-                    const issue = issue_1.Issue.atToken(file, tok, this.getDescription(tok.getStr()), this.getMetadata().key);
+                const tok = nameExpression.getFirstToken();
+                const name = tok.getStr();
+                if (this.reg.inErrorNamespace(name) === true
+                    && this.reg.getObject("XSLT", name) === undefined) {
+                    const issue = issue_1.Issue.atToken(file, tok, this.getDescription(name), this.getMetadata().key);
                     output.push(issue);
                 }
             }

package/build/src/rules/classic_exceptions_overlap.js

@@ -0,0 +1,69 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ClassicExceptionsOverlap = exports.ClassicExceptionsOverlapConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const Expressions = require("../abap/2_statements/expressions");
+const _irule_1 = require("./_irule");
+class ClassicExceptionsOverlapConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.ClassicExceptionsOverlapConf = ClassicExceptionsOverlapConf;
+class ClassicExceptionsOverlap extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new ClassicExceptionsOverlapConf();
+    }
+    getMetadata() {
+        return {
+            key: "classic_exceptions_overlap",
+            title: "Classic exceptions overlap when catching",
+            shortDescription: `Find overlapping classic exceptions`,
+            extendedInformation: `When debugging its typically good to know exactly which exception is caught`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `  EXCEPTIONS
+    system_failure        = 1 MESSAGE lv_message
+    communication_failure = 1 MESSAGE lv_message
+    resource_failure      = 1
+    OTHERS                = 1.`,
+            goodExample: `  EXCEPTIONS
+    system_failure        = 1 MESSAGE lv_message
+    communication_failure = 2 MESSAGE lv_message
+    resource_failure      = 3
+    OTHERS                = 4.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        var _a;
+        const output = [];
+        const struc = file.getStructure();
+        if (struc === undefined) {
+            return []; // syntax error
+        }
+        for (const p of struc.findAllExpressions(Expressions.ParameterListExceptions)) {
+            const set = new Set();
+            for (const e of p.findAllExpressions(Expressions.ParameterException)) {
+                const text = (_a = e.findDirectExpression(Expressions.SimpleName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+                if (text === undefined) {
+                    continue;
+                }
+                if (set.has(text)) {
+                    const message = "Exception overlap, " + text;
+                    const issue = issue_1.Issue.atToken(file, e.getFirstToken(), message, this.getMetadata().key, this.getConfig().severity);
+                    output.push(issue);
+                    break;
+                }
+                set.add(text);
+            }
+        }
+        return output;
+    }
+}
+exports.ClassicExceptionsOverlap = ClassicExceptionsOverlap;
+//# sourceMappingURL=classic_exceptions_overlap.js.map

package/build/src/rules/definitions_top.js

@@ -122,7 +122,8 @@ class DefinitionsTop extends _abap_rule_1.ABAPRule {
         return undefined;
     }
     buildFix(file, statement, start) {
-        const concat = statement.concatTokens();
+        let concat = statement.concatTokens();
+        concat = concat.replace(/,$/, ".");
         const fix1 = edit_helper_1.EditHelper.deleteStatement(file, statement);
         const indentation = " ".repeat(statement.getFirstToken().getCol() - 1);
         const fix2 = edit_helper_1.EditHelper.insertAt(file, start.getEnd(), "\n" + indentation + concat);

package/build/src/rules/double_space.js

@@ -145,6 +145,7 @@ class DoubleSpace extends _abap_rule_1.ABAPRule {
             const upper = prev.get().getStr().toUpperCase();
             if (prev instanceof nodes_1.TokenNodeRegex
                 || upper === "("
+                || upper === ")"
                 || upper === "CHANGING"
                 || upper === "EXPORTING"
                 || upper === "OTHERS") {

package/build/src/rules/identical_form_names.js

@@ -8,6 +8,7 @@ const _abap_object_1 = require("../objects/_abap_object");
 class IdenticalFormNamesConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.IdenticalFormNamesConf = IdenticalFormNamesConf;
+// todo: deprecation candidate? this is/should be handled by the syntax check?
 class IdenticalFormNames {
     constructor() {
         this.conf = new IdenticalFormNamesConf();

package/build/src/rules/index.js

@@ -30,9 +30,9 @@ __exportStar(require("./check_abstract"), exports);
 __exportStar(require("./check_comments"), exports);
 __exportStar(require("./check_ddic"), exports);
 __exportStar(require("./check_include"), exports);
-__exportStar(require("./unnecessary_pragma"), exports);
 __exportStar(require("./check_subrc"), exports);
 __exportStar(require("./check_syntax"), exports);
+__exportStar(require("./classic_exceptions_overlap"), exports);
 __exportStar(require("./check_text_elements"), exports);
 __exportStar(require("./check_transformation_exists"), exports);
 __exportStar(require("./class_attribute_names"), exports);
@@ -80,7 +80,7 @@ __exportStar(require("./line_break_style"), exports);
 __exportStar(require("./line_length"), exports);
 __exportStar(require("./line_only_punc"), exports);
 __exportStar(require("./local_class_naming"), exports);
-__exportStar(require("./local_testclass_location"), exports);
+__exportStar(require("./local_testclass_consistency"), exports);
 __exportStar(require("./local_variable_names"), exports);
 __exportStar(require("./main_file_contents"), exports);
 __exportStar(require("./many_parentheses"), exports);
@@ -99,6 +99,7 @@ __exportStar(require("./nesting"), exports);
 __exportStar(require("./newline_between_methods"), exports);
 __exportStar(require("./no_aliases"), exports);
 __exportStar(require("./no_chained_assignment"), exports);
+__exportStar(require("./no_inline_in_optional_branches"), exports);
 __exportStar(require("./no_public_attributes"), exports);
 __exportStar(require("./no_yoda_conditions"), exports);
 __exportStar(require("./nrob_consistency"), exports);
@@ -144,6 +145,7 @@ __exportStar(require("./types_naming"), exports);
 __exportStar(require("./uncaught_exception"), exports);
 __exportStar(require("./unknown_types"), exports);
 __exportStar(require("./unnecessary_chaining"), exports);
+__exportStar(require("./unnecessary_pragma"), exports);
 __exportStar(require("./unreachable_code"), exports);
 __exportStar(require("./unsecure_fae"), exports);
 __exportStar(require("./unused_ddic"), exports);

package/build/src/rules/local_testclass_consistency.js

@@ -0,0 +1,63 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.LocalTestclassConsistency = exports.LocalTestclassConsistencyConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const objects_1 = require("../objects");
+const _irule_1 = require("./_irule");
+const version_1 = require("../version");
+class LocalTestclassConsistencyConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.LocalTestclassConsistencyConf = LocalTestclassConsistencyConf;
+class LocalTestclassConsistency extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new LocalTestclassConsistencyConf();
+    }
+    getMetadata() {
+        return {
+            key: "local_testclass_consistency",
+            title: "Local testclass consistency",
+            shortDescription: `Checks that local test classes are placed in the test include, and class unit test flag is set`,
+            tags: [_irule_1.RuleTag.Syntax],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file, obj) {
+        var _a;
+        const issues = [];
+        if (this.reg.getConfig().getVersion() === version_1.Version.v700) {
+            // 700 does not have testclass includes
+            return [];
+        }
+        if (!(obj instanceof objects_1.Class)) {
+            return [];
+        }
+        for (const c of file.getInfo().listClassDefinitions()) {
+            if (c.isLocal && c.isForTesting && !file.getFilename().includes(".testclasses.abap")) {
+                const message = "Place local testclass \"" + c.name + "\" in the testclass include";
+                const issue = issue_1.Issue.atIdentifier(c.identifier, message, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+        }
+        if (file.getFilename().includes(".testclasses.") === true
+            && obj.getTestclassFile() !== undefined
+            && ((_a = obj.getXML()) === null || _a === void 0 ? void 0 : _a.includes("<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>")) === false) {
+            const id = obj.getIdentifier();
+            if (id) {
+                const message = "Has testclass, but XML does not set <WITH_UNIT_TESTS>";
+                const issue = issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+        }
+        return issues;
+    }
+}
+exports.LocalTestclassConsistency = LocalTestclassConsistency;
+//# sourceMappingURL=local_testclass_consistency.js.map

package/build/src/rules/no_inline_in_optional_branches.js

@@ -0,0 +1,78 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoInlineInOptionalBranches = exports.NoInlineInOptionalBranchesConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const Structures = require("../abap/3_structures/structures");
+const Expressions = require("../abap/2_statements/expressions");
+const _irule_1 = require("./_irule");
+const version_1 = require("../version");
+class NoInlineInOptionalBranchesConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoInlineInOptionalBranchesConf = NoInlineInOptionalBranchesConf;
+class NoInlineInOptionalBranches extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoInlineInOptionalBranchesConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_inline_in_optional_branches",
+            title: "Don't declare inline in optional branches",
+            shortDescription: `Don't declare inline in optional branches`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-declare-inline-in-optional-branches
+
+Considered optional branches:
+* inside IF/ELSEIF/ELSE
+* inside LOOP
+* inside WHILE
+* inside CASE/WHEN, CASE TYPE OF
+* inside DO
+* inside SELECT loops
+
+Not considered optional branches:
+* TRY/CATCH/CLEANUP`,
+            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const output = [];
+        const version = this.reg.getConfig().getVersion();
+        if (version === version_1.Version.v700
+            || version === version_1.Version.v702
+            || version === version_1.Version.OpenABAP) {
+            return [];
+        }
+        const struc = file.getStructure();
+        if (struc === undefined) {
+            return []; // syntax error
+        }
+        const candidates = [
+            ...struc.findAllStructures(Structures.If),
+            ...struc.findAllStructures(Structures.Loop),
+            ...struc.findAllStructures(Structures.While),
+            ...struc.findAllStructures(Structures.Case),
+            ...struc.findAllStructures(Structures.CaseType),
+            ...struc.findAllStructures(Structures.Do),
+            ...struc.findAllStructures(Structures.Select)
+        ];
+        for (const c of candidates) {
+            const inline = c.findFirstExpression(Expressions.InlineData);
+            if (inline) {
+                const message = "Don't declare inline in optional branches";
+                const issue = issue_1.Issue.atToken(file, c.getFirstToken(), message, this.getMetadata().key, this.getConfig().severity);
+                output.push(issue);
+            }
+        }
+        return output;
+    }
+}
+exports.NoInlineInOptionalBranches = NoInlineInOptionalBranches;
+//# sourceMappingURL=no_inline_in_optional_branches.js.map

package/build/src/rules/unknown_types.js

@@ -10,6 +10,7 @@ const _irule_1 = require("./_irule");
 const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const _scope_type_1 = require("../abap/5_syntax/_scope_type");
 const _reference_1 = require("../abap/5_syntax/_reference");
+const basic_1 = require("../abap/types/basic");
 class UnknownTypesConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.UnknownTypesConf = UnknownTypesConf;
@@ -70,6 +71,12 @@ class UnknownTypes {
                 const message = r.extra.ooName + " unknown";
                 ret.push(issue_1.Issue.atIdentifier(r.position, message, this.getMetadata().key, this.conf.severity));
             }
+            if (r.referenceType === _reference_1.ReferenceType.TypeReference
+                && r.resolved instanceof _typed_identifier_1.TypedIdentifier
+                && r.resolved.getType() instanceof basic_1.UnknownType) {
+                const message = r.resolved.getType().getError();
+                ret.push(issue_1.Issue.atIdentifier(r.position, message, this.getMetadata().key, this.conf.severity));
+            }
         }
         if (node.getIdentifier().stype !== _scope_type_1.ScopeType.ClassImplementation) {
             const vars = nodeData.vars;

package/build/src/rules/unused_variables.js

@@ -156,6 +156,7 @@ Unused variables are not reported if the object contains syntax errors. Errors f
                 }
                 else if (name === "ME"
                     || name === "SUPER"
+                    || meta.includes("selection_screen_tab" /* SelectionScreenTab */)
                     || meta.includes("event_parameter" /* EventParameter */)) {
                     // todo, workaround for "me" and "super", these should somehow be typed to built-in
                     continue;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.88.10",
+    "version": "2.89.2",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,11 +48,11 @@
         "@microsoft/api-extractor": "^7.22.2",
         "@types/chai": "^4.3.1",
         "@types/mocha": "^9.1.0",
-        "@types/node": "^17.0.24",
+        "@types/node": "^17.0.25",
         "chai": "^4.3.6",
         "eslint": "^8.13.0",
         "mocha": "^9.2.2",
-        "c8": "^7.11.0",
+        "c8": "^7.11.2",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^1.0.0",
         "typescript": "^4.6.3"

package/build/src/rules/local_testclass_location.js

@@ -1,54 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.LocalTestclassLocation = exports.LocalTestclassLocationConf = void 0;
-const issue_1 = require("../issue");
-const _abap_rule_1 = require("./_abap_rule");
-const _basic_rule_config_1 = require("./_basic_rule_config");
-const objects_1 = require("../objects");
-const _irule_1 = require("./_irule");
-const version_1 = require("../version");
-class LocalTestclassLocationConf extends _basic_rule_config_1.BasicRuleConfig {
-}
-exports.LocalTestclassLocationConf = LocalTestclassLocationConf;
-class LocalTestclassLocation extends _abap_rule_1.ABAPRule {
-    constructor() {
-        super(...arguments);
-        this.conf = new LocalTestclassLocationConf();
-    }
-    getMetadata() {
-        return {
-            key: "local_testclass_location",
-            title: "Local testclass location",
-            shortDescription: `Checks that local test classes are placed in the test include.`,
-            tags: [_irule_1.RuleTag.SingleFile],
-        };
-    }
-    getDescription(className) {
-        return "Place local testclass \"" + className + "\" in the testclass include";
-    }
-    getConfig() {
-        return this.conf;
-    }
-    setConfig(conf) {
-        this.conf = conf;
-    }
-    runParsed(file, obj) {
-        const issues = [];
-        if (this.reg.getConfig().getVersion() === version_1.Version.v700) {
-            // 700 does not have testclass includes
-            return [];
-        }
-        if (!(obj instanceof objects_1.Class)) {
-            return [];
-        }
-        for (const c of file.getInfo().listClassDefinitions()) {
-            if (c.isLocal && c.isForTesting && !file.getFilename().includes(".testclasses.abap")) {
-                const issue = issue_1.Issue.atIdentifier(c.identifier, this.getDescription(c.name), this.getMetadata().key, this.conf.severity);
-                issues.push(issue);
-            }
-        }
-        return issues;
-    }
-}
-exports.LocalTestclassLocation = LocalTestclassLocation;
-//# sourceMappingURL=local_testclass_location.js.map