@abaplint/core 2.86.6 → 2.87.0

package/build/abaplint.d.ts

@@ -2646,6 +2646,7 @@ export declare const enum IdentifierMeta {
     EventParameter = "event_parameter",
     FormParameter = "form_parameter",
     ReadOnly = "read_only",
+    PassByValue = "pass_by_value",
     InlineDefinition = "inline",
     BuiltIn = "built-in",
     DDIC = "ddic",

package/build/src/abap/types/method_parameters.js

@@ -163,7 +163,14 @@ class MethodParameters {
             if (p === undefined) {
                 continue;
             }
-            target.push(new method_param_1.MethodParam().runSyntax(p, scope, this.filename, meta));
+            const extraMeta = [];
+            if (opt.concatTokens().toUpperCase().startsWith("VALUE(")) {
+                extraMeta.push("pass_by_value" /* PassByValue */);
+            }
+            else if (meta.includes("importing" /* MethodImporting */)) {
+                extraMeta.push("read_only" /* ReadOnly */);
+            }
+            target.push(new method_param_1.MethodParam().runSyntax(p, scope, this.filename, [...meta, ...extraMeta]));
             if (opt.getLastToken().getStr().toUpperCase() === "OPTIONAL") {
                 const name = target[target.length - 1].getName().toUpperCase();
                 this.optional.push(name);

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.86.6";
+        return "2.87.0";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/double_space.js

@@ -56,6 +56,7 @@ class DoubleSpace extends _abap_rule_1.ABAPRule {
                 && !(s.get() instanceof _statement_1.Unknown)
                 && !(s.get() instanceof statements_1.MethodDef)
                 && !(s.get() instanceof _statement_1.MacroCall)
+                && !(s.get() instanceof statements_1.Events)
                 && !(s.get() instanceof _statement_1.MacroContent)) {
                 issues = issues.concat(this.checkKeywords(s, file));
             }

package/build/src/rules/downport.js

@@ -515,16 +515,29 @@ ${indentation}`);
     }
     tableCondition(tableExpression) {
         let condition = "";
+        let keyName = "";
         for (const c of tableExpression.getChildren() || []) {
             if (c.getFirstToken().getStr() === "[" || c.getFirstToken().getStr() === "]") {
                 continue;
             }
             else if (c.get() instanceof Expressions.ComponentChainSimple && condition === "") {
-                condition = "WITH KEY ";
+                if (keyName === "") {
+                    condition = "WITH KEY ";
+                }
+                else {
+                    condition = "WITH TABLE KEY " + keyName + " COMPONENTS ";
+                }
             }
             else if (c.get() instanceof Expressions.Source && condition === "") {
                 condition = "INDEX ";
             }
+            else if (c instanceof nodes_1.TokenNode && c.getFirstToken().getStr().toUpperCase() === "KEY") {
+                continue;
+            }
+            else if (c.get() instanceof Expressions.SimpleName) {
+                keyName = c.concatTokens();
+                continue;
+            }
             condition += c.concatTokens() + " ";
         }
         return condition;
@@ -1143,6 +1156,7 @@ ${indentation}    output = ${topTarget}.`;
                 body += indentation + end;
             }
             const abap = `DATA ${uniqueName} ${type}.\n` +
+                indentation + `CLEAR ${uniqueName}.\n` + // might be called inside a loop
                 body +
                 indentation;
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
@@ -1311,6 +1325,7 @@ ${indentation}    output = ${topTarget}.`;
     buildCondBody(body, uniqueName, indent, lowFile, highSyntax) {
         let code = "";
         let first = true;
+        let addElse = true;
         for (const c of body.getChildren()) {
             if (c instanceof nodes_1.TokenNode) {
                 switch (c.getFirstToken().getStr().toUpperCase()) {
@@ -1328,6 +1343,7 @@ ${indentation}    output = ${topTarget}.`;
                         break;
                     case "ELSE":
                         code += indent + "ELSE.\n";
+                        addElse = false;
                         break;
                     default:
                         throw "buildCondBody, unexpected token";
@@ -1346,6 +1362,11 @@ ${indentation}    output = ${topTarget}.`;
                 throw "buildCondBody, unexpected expression, " + c.get().constructor.name;
             }
         }
+        if (addElse) {
+            // COND might be called inside a loop
+            code += indent + "ELSE.\n";
+            code += indent + `  CLEAR ${uniqueName}.\n`;
+        }
         code += indent + "ENDIF.\n";
         code += indent;
         return code;

package/build/src/rules/index.js

@@ -129,6 +129,7 @@ __exportStar(require("./selection_screen_naming"), exports);
 __exportStar(require("./sequential_blank"), exports);
 __exportStar(require("./short_case"), exports);
 __exportStar(require("./sicf_consistency"), exports);
+__exportStar(require("./slow_parameter_passing"), exports);
 __exportStar(require("./space_before_colon"), exports);
 __exportStar(require("./space_before_dot"), exports);
 __exportStar(require("./sql_escape_host_variables"), exports);

package/build/src/rules/slow_parameter_passing.js

@@ -0,0 +1,85 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SlowParameterPassing = exports.SlowParameterPassingConf = void 0;
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const issue_1 = require("../issue");
+const _irule_1 = require("./_irule");
+const _abap_object_1 = require("../objects/_abap_object");
+const syntax_1 = require("../abap/5_syntax/syntax");
+const _scope_type_1 = require("../abap/5_syntax/_scope_type");
+const _reference_1 = require("../abap/5_syntax/_reference");
+class SlowParameterPassingConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.SlowParameterPassingConf = SlowParameterPassingConf;
+class SlowParameterPassing {
+    constructor() {
+        this.conf = new SlowParameterPassingConf();
+    }
+    getMetadata() {
+        return {
+            key: "slow_parameter_passing",
+            title: "Slow Parameter Passing",
+            shortDescription: `Detects show pass by value passing for methods where parameter is not changed`,
+            tags: [_irule_1.RuleTag.Performance],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        const issues = [];
+        if (!(obj instanceof _abap_object_1.ABAPObject)) {
+            return [];
+        }
+        const top = new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop();
+        const methods = this.listMethodNodes(top);
+        for (const m of methods) {
+            const vars = m.getData().vars;
+            for (const v in vars) {
+                const id = vars[v];
+                if (id.getMeta().includes("pass_by_value" /* PassByValue */) === false) {
+                    continue;
+                }
+                const writes = this.listWritePositions(m, id);
+                if (writes.length === 0) {
+                    const message = "Parameter passed by VALUE but not changed";
+                    issues.push(issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.getConfig().severity));
+                }
+            }
+        }
+        return issues;
+    }
+    listWritePositions(node, id) {
+        var _a, _b;
+        const ret = [];
+        for (const v of node.getData().references) {
+            if (v.referenceType === _reference_1.ReferenceType.DataWriteReference
+                && ((_a = v.resolved) === null || _a === void 0 ? void 0 : _a.getFilename()) === id.getFilename()
+                && ((_b = v.resolved) === null || _b === void 0 ? void 0 : _b.getStart().equals(id.getStart()))) {
+                ret.push(v.position.getStart());
+            }
+        }
+        return ret;
+    }
+    listMethodNodes(node) {
+        const ret = [];
+        if (node.getIdentifier().stype === _scope_type_1.ScopeType.Method) {
+            ret.push(node);
+        }
+        else {
+            for (const c of node.getChildren()) {
+                ret.push(...this.listMethodNodes(c));
+            }
+        }
+        return ret;
+    }
+}
+exports.SlowParameterPassing = SlowParameterPassing;
+//# sourceMappingURL=slow_parameter_passing.js.map

package/build/src/rules/unsecure_fae.js

@@ -20,7 +20,7 @@ class UnsecureFAE {
             title: "Unsecure FAE",
             shortDescription: `Checks for unsecure FAE`,
             extendedInformation: `Issues from rule check_syntax must be fixed before this rule takes effect`,
-            tags: [_irule_1.RuleTag.Experimental],
+            tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Performance],
         };
     }
     getConfig() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.86.6",
+    "version": "2.87.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",